Issues in class-give-db-logs-meta.php (master) - Issues in master - WordImpress/Give - Measure and Improve Code Quality continuously with Scrutinizer

Issues (4296)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-give-db-logs-meta.php (6 issues)

Labels

Duplication 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Logs Meta DB class
 *
 * @package     Give
 * @subpackage  Classes/DB Log Meta
 * @copyright   Copyright (c) 2016, WordImpress
 * @license     https://opensource.org/licenses/gpl-license GNU Public License
 * @since       2.0
 */

// Exit if accessed directly.
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Class Give_DB_Log_Meta
 *
 * This class is for interacting with the log meta database table.
 *
 * @since 2.0
 */
class Give_DB_Log_Meta extends Give_DB_Meta {
	/**
	 * Meta supports.
	 *
	 * @since  2.0
	 * @access protected
	 * @var array
	 */
	protected $supports = array();

	/**
	 * Meta type
	 *
	 * @since  2.0
	 * @access protected
	 * @var bool
	 */
	protected $meta_type = 'log';

	/**
	 * Give_DB_Log_Meta constructor.
	 *
	 * @access  public
	 * @since   2.0
	 */
	public function __construct() {

		/* @var WPDB $wpdb */
		global $wpdb;

		$wpdb->logmeta     = $this->table_name = $wpdb->prefix . 'give_logmeta';
		$this->primary_key = 'meta_id';
		$this->version     = '1.0';

		$this->register_table();

		parent::__construct();
	}

	/**
	 * Get table columns and data types.
	 *
	 * @access  public
	 * @since   2.0
	 *
	 * @return  array  Columns and formats.
	 */
	public function get_columns() {
		return array(
			'meta_id'    => '%d',
			'log_id'     => '%d',
			'meta_key'   => '%s',

			'meta_value' => '%s',

		);
	}

	/**
	 * Delete all log meta
	 *
	 * @since  2.0
	 * @access public
	 *
	 * @param int $log_id
	 *
	 * @return bool
	 */
	public function delete_row( $log_id = 0 ) {

		/* @var WPDB $wpdb */
		global $wpdb;

		// Row ID must be positive integer
		$log_id = absint( $log_id );

		if ( empty( $log_id ) ) {
			return false;
		}

		if ( false === $wpdb->query( $wpdb->prepare( "DELETE FROM $this->table_name WHERE log_id = %d", $log_id ) ) ) {

			return false;
		}

		return true;
	}

	/**
	 * Check if current id is valid
	 *
	 * @since  2.0
	 * @access protected
	 *
	 * @param $ID
	 *
	 * @return bool
	 */
	protected function is_valid_post_type( $ID ) {
		return $ID && true;
	}
}


1		<?php
2		/**
3		* Logs Meta DB class
4		*
5		* @package Give
6		* @subpackage Classes/DB Log Meta
7		* @copyright Copyright (c) 2016, WordImpress
8		* @license https://opensource.org/licenses/gpl-license GNU Public License
9		* @since 2.0
10		*/
11
12		// Exit if accessed directly.
13		if ( ! defined( 'ABSPATH' ) ) {
14		exit;
15		}
16
17		/**
18		* Class Give_DB_Log_Meta
19		*
20		* This class is for interacting with the log meta database table.
21		*
22		* @since 2.0
23		*/
24		class Give_DB_Log_Meta extends Give_DB_Meta {
25		/**
26		* Meta supports.
27		*
28		* @since 2.0
29		* @access protected
30		* @var array
31		*/
32		protected $supports = array();
33
34		/**
35		* Meta type
36		*
37		* @since 2.0
38		* @access protected
39		* @var bool
40		*/
41		protected $meta_type = 'log';
42
43		/**
44		* Give_DB_Log_Meta constructor.
45		*
46		* @access public
47		* @since 2.0
48		*/
49	View Code Duplication	public function __construct() {
		0 ignored issues – show Duplication introduced 2018-02-17 00:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		/* @var WPDB $wpdb */
51		global $wpdb;
52
53		$wpdb->logmeta = $this->table_name = $wpdb->prefix . 'give_logmeta';
54		$this->primary_key = 'meta_id';
55		$this->version = '1.0';
56
57		$this->register_table();
58
59		parent::__construct();
60		}
61
62		/**
63		* Get table columns and data types.
64		*
65		* @access public
66		* @since 2.0
67		*
68		* @return array Columns and formats.
69		*/
70		public function get_columns() {
71		return array(
72		'meta_id' => '%d',
73		'log_id' => '%d',
74		'meta_key' => '%s',
		0 ignored issues – show introduced 2018-01-17 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected usage of meta_key, possible slow query. Loading history...
75		'meta_value' => '%s',
		0 ignored issues – show introduced 2018-01-17 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Detected usage of meta_value, possible slow query. Loading history...
76		);
77		}
78
79		/**
80		* Delete all log meta
81		*
82		* @since 2.0
83		* @access public
84		*
85		* @param int $log_id
86		*
87		* @return bool
88		*/
89	View Code Duplication	public function delete_row( $log_id = 0 ) {
		0 ignored issues – show Duplication introduced 2018-01-17 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90		/* @var WPDB $wpdb */
91		global $wpdb;
92
93		// Row ID must be positive integer
94		$log_id = absint( $log_id );
95
96		if ( empty( $log_id ) ) {
97		return false;
98		}
99
100		if ( false === $wpdb->query( $wpdb->prepare( "DELETE FROM $this->table_name WHERE log_id = %d", $log_id ) ) ) {
		0 ignored issues – show introduced 2018-01-17 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call is discouraged. Loading history... introduced 2018-01-17 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Usage of a direct database call without caching is prohibited. Use wp_cache_get / wp_cache_set. Loading history...
101		return false;
102		}
103
104		return true;
105		}
106
107		/**
108		* Check if current id is valid
109		*
110		* @since 2.0
111		* @access protected
112		*
113		* @param $ID
114		*
115		* @return bool
116		*/
117		protected function is_valid_post_type( $ID ) {
118		return $ID && true;
119		}
120		}
121

WordImpress / Give

Issues (4296)

Security Analysis not enabled

includes/class-give-db-logs-meta.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like