Inspection of "Merge pull request #664 from WordImpress/release/1..." - WordImpress/Give - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45b05a...b92b5a )

by Devin

created 2016-06-28 23:46 UTC

Status

Spacing +57 added lines, -57 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@  discard block
 block discarded – undo
 	 */
 	public function __construct() {
 
-		add_filter( 'give_map_meta_cap', array( $this, 'meta_caps' ), 10, 4 );
+		add_filter('give_map_meta_cap', array($this, 'meta_caps'), 10, 4);
 	}
 
 	/**
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
 	 * @return void
 	 */
 	public function add_roles() {
-		add_role( 'give_manager', __( 'Give Manager', 'give' ), array(
+		add_role('give_manager', __('Give Manager', 'give'), array(
 			'read'                   => true,
 			'edit_posts'             => true,
 			'delete_posts'           => true,
@@ -68,20 +68,20 @@  discard block
 block discarded – undo
 			'publish_posts'          => true,
 			'read_private_pages'     => true,
 			'read_private_posts'     => true
-		) );
+		));
 
-		add_role( 'give_accountant', __( 'Give Accountant', 'give' ), array(
+		add_role('give_accountant', __('Give Accountant', 'give'), array(
 		    'read'                   => true,
 		    'edit_posts'             => false,
 		    'delete_posts'           => false
-		) );
+		));
 
-		add_role( 'give_worker', __( 'Give Worker', 'give' ), array(
+		add_role('give_worker', __('Give Worker', 'give'), array(
 			'read'                   => true,
 			'edit_posts'             => false,
 			'upload_files'           => true,
 			'delete_posts'           => false
-		) );
+		));
 
 	}
 
@@ -96,38 +96,38 @@  discard block
 block discarded – undo
 	public function add_caps() {
 		global $wp_roles;
 
-		if ( class_exists('WP_Roles') ) {
-			if ( ! isset( $wp_roles ) ) {
+		if (class_exists('WP_Roles')) {
+			if ( ! isset($wp_roles)) {
 				$wp_roles = new WP_Roles();
 			}
 		}
 
-		if ( is_object( $wp_roles ) ) {
-			$wp_roles->add_cap( 'give_manager', 'view_give_reports' );
-			$wp_roles->add_cap( 'give_manager', 'view_give_sensitive_data' );
-			$wp_roles->add_cap( 'give_manager', 'export_give_reports' );
-			$wp_roles->add_cap( 'give_manager', 'manage_give_settings' );
+		if (is_object($wp_roles)) {
+			$wp_roles->add_cap('give_manager', 'view_give_reports');
+			$wp_roles->add_cap('give_manager', 'view_give_sensitive_data');
+			$wp_roles->add_cap('give_manager', 'export_give_reports');
+			$wp_roles->add_cap('give_manager', 'manage_give_settings');
 
-			$wp_roles->add_cap( 'administrator', 'view_give_reports' );
-			$wp_roles->add_cap( 'administrator', 'view_give_sensitive_data' );
-			$wp_roles->add_cap( 'administrator', 'export_give_reports' );
-			$wp_roles->add_cap( 'administrator', 'manage_give_settings' );
+			$wp_roles->add_cap('administrator', 'view_give_reports');
+			$wp_roles->add_cap('administrator', 'view_give_sensitive_data');
+			$wp_roles->add_cap('administrator', 'export_give_reports');
+			$wp_roles->add_cap('administrator', 'manage_give_settings');
 
 			// Add the main post type capabilities
 			$capabilities = $this->get_core_caps();
-			foreach ( $capabilities as $cap_group ) {
-				foreach ( $cap_group as $cap ) {
-					$wp_roles->add_cap( 'administrator', $cap );
-					$wp_roles->add_cap( 'give_manager', $cap );
-					$wp_roles->add_cap( 'give_worker', $cap );
+			foreach ($capabilities as $cap_group) {
+				foreach ($cap_group as $cap) {
+					$wp_roles->add_cap('administrator', $cap);
+					$wp_roles->add_cap('give_manager', $cap);
+					$wp_roles->add_cap('give_worker', $cap);
 				}
 			}
 
-			$wp_roles->add_cap( 'give_accountant', 'edit_give_forms' );
-			$wp_roles->add_cap( 'give_accountant', 'read_private_forms' );
-			$wp_roles->add_cap( 'give_accountant', 'view_give_reports' );
-			$wp_roles->add_cap( 'give_accountant', 'export_give_reports' );
-			$wp_roles->add_cap( 'give_accountant', 'edit_give_payments' );
+			$wp_roles->add_cap('give_accountant', 'edit_give_forms');
+			$wp_roles->add_cap('give_accountant', 'read_private_forms');
+			$wp_roles->add_cap('give_accountant', 'view_give_reports');
+			$wp_roles->add_cap('give_accountant', 'export_give_reports');
+			$wp_roles->add_cap('give_accountant', 'edit_give_payments');
 
 		}
 	}
@@ -142,10 +142,10 @@  discard block
 block discarded – undo
 	public function get_core_caps() {
 		$capabilities = array();
 
-		$capability_types = array( 'give_form', 'give_payment' );
+		$capability_types = array('give_form', 'give_payment');
 
-		foreach ( $capability_types as $capability_type ) {
-			$capabilities[ $capability_type ] = array(
+		foreach ($capability_types as $capability_type) {
+			$capabilities[$capability_type] = array(
 				// Post type
 				"edit_{$capability_type}",
 				"read_{$capability_type}",
@@ -182,22 +182,22 @@  discard block
 block discarded – undo
 	 * @since  1.0
 	 * @return array $caps
 	 */
-	public function meta_caps( $caps, $cap, $user_id, $args ) {
+	public function meta_caps($caps, $cap, $user_id, $args) {
 
-		switch( $cap ) {
+		switch ($cap) {
 
 			case 'view_give_forms_stats' :
 				
-				if( empty( $args[0] ) ) {
+				if (empty($args[0])) {
 					break;
 				}
 				
-				$form = get_post( $args[0] );
-				if ( empty( $form ) ) {
+				$form = get_post($args[0]);
+				if (empty($form)) {
 					break;
 				}
 
-				if( user_can( $user_id, 'view_give_reports' ) || $user_id == $form->post_author ) {
+				if (user_can($user_id, 'view_give_reports') || $user_id == $form->post_author) {
 					$caps = array();
 				}
 
@@ -219,41 +219,41 @@  discard block
 block discarded – undo
 		
 		global $wp_roles;
 
-		if ( class_exists( 'WP_Roles' ) ) {
-			if ( ! isset( $wp_roles ) ) {
+		if (class_exists('WP_Roles')) {
+			if ( ! isset($wp_roles)) {
 				$wp_roles = new WP_Roles();
 			}
 		}
 
-		if ( is_object( $wp_roles ) ) {
+		if (is_object($wp_roles)) {
 			/** Give Manager Capabilities */
-			$wp_roles->remove_cap( 'give_manager', 'view_give_reports' );
-			$wp_roles->remove_cap( 'give_manager', 'view_give_sensitive_data' );
-			$wp_roles->remove_cap( 'give_manager', 'export_give_reports' );
-			$wp_roles->remove_cap( 'give_manager', 'manage_give_settings' );
+			$wp_roles->remove_cap('give_manager', 'view_give_reports');
+			$wp_roles->remove_cap('give_manager', 'view_give_sensitive_data');
+			$wp_roles->remove_cap('give_manager', 'export_give_reports');
+			$wp_roles->remove_cap('give_manager', 'manage_give_settings');
 
 			/** Site Administrator Capabilities */
-			$wp_roles->remove_cap( 'administrator', 'view_give_reports' );
-			$wp_roles->remove_cap( 'administrator', 'view_give_sensitive_data' );
-			$wp_roles->remove_cap( 'administrator', 'export_give_reports' );
-			$wp_roles->remove_cap( 'administrator', 'manage_give_settings' );
+			$wp_roles->remove_cap('administrator', 'view_give_reports');
+			$wp_roles->remove_cap('administrator', 'view_give_sensitive_data');
+			$wp_roles->remove_cap('administrator', 'export_give_reports');
+			$wp_roles->remove_cap('administrator', 'manage_give_settings');
 
 			/** Remove the Main Post Type Capabilities */
 			$capabilities = $this->get_core_caps();
 
-			foreach ( $capabilities as $cap_group ) {
-				foreach ( $cap_group as $cap ) {
-					$wp_roles->remove_cap( 'give_manager', $cap );
-					$wp_roles->remove_cap( 'administrator', $cap );
-					$wp_roles->remove_cap( 'give_worker', $cap );
+			foreach ($capabilities as $cap_group) {
+				foreach ($cap_group as $cap) {
+					$wp_roles->remove_cap('give_manager', $cap);
+					$wp_roles->remove_cap('administrator', $cap);
+					$wp_roles->remove_cap('give_worker', $cap);
 				}
 			}
 
 			/** Shop Accountant Capabilities */
-			$wp_roles->remove_cap( 'give_accountant', 'edit_give_forms' );
-			$wp_roles->remove_cap( 'give_accountant', 'read_private_forms' );
-			$wp_roles->remove_cap( 'give_accountant', 'view_give_reports' );
-			$wp_roles->remove_cap( 'give_accountant', 'export_give_reports' );
+			$wp_roles->remove_cap('give_accountant', 'edit_give_forms');
+			$wp_roles->remove_cap('give_accountant', 'read_private_forms');
+			$wp_roles->remove_cap('give_accountant', 'view_give_reports');
+			$wp_roles->remove_cap('give_accountant', 'export_give_reports');
 
 		}
 	}

Please login to merge, or discard this patch.

		@@ -28,7 +28,7 @@ discard block
		block discarded – undo
28	28	*/
29	29	public function __construct() {
30	30
31		- add_filter( 'give_map_meta_cap', array( $this, 'meta_caps' ), 10, 4 );
	31	+ add_filter('give_map_meta_cap', array($this, 'meta_caps'), 10, 4);
32	32	}
33	33
34	34	/**
		@@ -39,7 +39,7 @@ discard block
		block discarded – undo
39	39	* @return void
40	40	*/
41	41	public function add_roles() {
42		- add_role( 'give_manager', __( 'Give Manager', 'give' ), array(
	42	+ add_role('give_manager', __('Give Manager', 'give'), array(
43	43	'read' => true,
44	44	'edit_posts' => true,
45	45	'delete_posts' => true,
		@@ -68,20 +68,20 @@ discard block
		block discarded – undo
68	68	'publish_posts' => true,
69	69	'read_private_pages' => true,
70	70	'read_private_posts' => true
71		- ) );
	71	+ ));
72	72
73		- add_role( 'give_accountant', __( 'Give Accountant', 'give' ), array(
	73	+ add_role('give_accountant', __('Give Accountant', 'give'), array(
74	74	'read' => true,
75	75	'edit_posts' => false,
76	76	'delete_posts' => false
77		- ) );
	77	+ ));
78	78
79		- add_role( 'give_worker', __( 'Give Worker', 'give' ), array(
	79	+ add_role('give_worker', __('Give Worker', 'give'), array(
80	80	'read' => true,
81	81	'edit_posts' => false,
82	82	'upload_files' => true,
83	83	'delete_posts' => false
84		- ) );
	84	+ ));
85	85
86	86	}
87	87
		@@ -96,38 +96,38 @@ discard block
		block discarded – undo
96	96	public function add_caps() {
97	97	global $wp_roles;
98	98
99		- if ( class_exists('WP_Roles') ) {
100		- if ( ! isset( $wp_roles ) ) {
	99	+ if (class_exists('WP_Roles')) {
	100	+ if ( ! isset($wp_roles)) {
101	101	$wp_roles = new WP_Roles();
102	102	}
103	103	}
104	104
105		- if ( is_object( $wp_roles ) ) {
106		- $wp_roles->add_cap( 'give_manager', 'view_give_reports' );
107		- $wp_roles->add_cap( 'give_manager', 'view_give_sensitive_data' );
108		- $wp_roles->add_cap( 'give_manager', 'export_give_reports' );
109		- $wp_roles->add_cap( 'give_manager', 'manage_give_settings' );
	105	+ if (is_object($wp_roles)) {
	106	+ $wp_roles->add_cap('give_manager', 'view_give_reports');
	107	+ $wp_roles->add_cap('give_manager', 'view_give_sensitive_data');
	108	+ $wp_roles->add_cap('give_manager', 'export_give_reports');
	109	+ $wp_roles->add_cap('give_manager', 'manage_give_settings');
110	110
111		- $wp_roles->add_cap( 'administrator', 'view_give_reports' );
112		- $wp_roles->add_cap( 'administrator', 'view_give_sensitive_data' );
113		- $wp_roles->add_cap( 'administrator', 'export_give_reports' );
114		- $wp_roles->add_cap( 'administrator', 'manage_give_settings' );
	111	+ $wp_roles->add_cap('administrator', 'view_give_reports');
	112	+ $wp_roles->add_cap('administrator', 'view_give_sensitive_data');
	113	+ $wp_roles->add_cap('administrator', 'export_give_reports');
	114	+ $wp_roles->add_cap('administrator', 'manage_give_settings');
115	115
116	116	// Add the main post type capabilities
117	117	$capabilities = $this->get_core_caps();
118		- foreach ( $capabilities as $cap_group ) {
119		- foreach ( $cap_group as $cap ) {
120		- $wp_roles->add_cap( 'administrator', $cap );
121		- $wp_roles->add_cap( 'give_manager', $cap );
122		- $wp_roles->add_cap( 'give_worker', $cap );
	118	+ foreach ($capabilities as $cap_group) {
	119	+ foreach ($cap_group as $cap) {
	120	+ $wp_roles->add_cap('administrator', $cap);
	121	+ $wp_roles->add_cap('give_manager', $cap);
	122	+ $wp_roles->add_cap('give_worker', $cap);
123	123	}
124	124	}
125	125
126		- $wp_roles->add_cap( 'give_accountant', 'edit_give_forms' );
127		- $wp_roles->add_cap( 'give_accountant', 'read_private_forms' );
128		- $wp_roles->add_cap( 'give_accountant', 'view_give_reports' );
129		- $wp_roles->add_cap( 'give_accountant', 'export_give_reports' );
130		- $wp_roles->add_cap( 'give_accountant', 'edit_give_payments' );
	126	+ $wp_roles->add_cap('give_accountant', 'edit_give_forms');
	127	+ $wp_roles->add_cap('give_accountant', 'read_private_forms');
	128	+ $wp_roles->add_cap('give_accountant', 'view_give_reports');
	129	+ $wp_roles->add_cap('give_accountant', 'export_give_reports');
	130	+ $wp_roles->add_cap('give_accountant', 'edit_give_payments');
131	131
132	132	}
133	133	}
		@@ -142,10 +142,10 @@ discard block
		block discarded – undo
142	142	public function get_core_caps() {
143	143	$capabilities = array();
144	144
145		- $capability_types = array( 'give_form', 'give_payment' );
	145	+ $capability_types = array('give_form', 'give_payment');
146	146
147		- foreach ( $capability_types as $capability_type ) {
148		- $capabilities[ $capability_type ] = array(
	147	+ foreach ($capability_types as $capability_type) {
	148	+ $capabilities[$capability_type] = array(
149	149	// Post type
150	150	"edit_{$capability_type}",
151	151	"read_{$capability_type}",
		@@ -182,22 +182,22 @@ discard block
		block discarded – undo
182	182	* @since 1.0
183	183	* @return array $caps
184	184	*/
185		- public function meta_caps( $caps, $cap, $user_id, $args ) {
	185	+ public function meta_caps($caps, $cap, $user_id, $args) {
186	186
187		- switch( $cap ) {
	187	+ switch ($cap) {
188	188
189	189	case 'view_give_forms_stats' :
190	190
191		- if( empty( $args[0] ) ) {
	191	+ if (empty($args[0])) {
192	192	break;
193	193	}
194	194
195		- $form = get_post( $args[0] );
196		- if ( empty( $form ) ) {
	195	+ $form = get_post($args[0]);
	196	+ if (empty($form)) {
197	197	break;
198	198	}
199	199
200		- if( user_can( $user_id, 'view_give_reports' ) \|\| $user_id == $form->post_author ) {
	200	+ if (user_can($user_id, 'view_give_reports') \|\| $user_id == $form->post_author) {
201	201	$caps = array();
202	202	}
203	203
		@@ -219,41 +219,41 @@ discard block
		block discarded – undo
219	219
220	220	global $wp_roles;
221	221
222		- if ( class_exists( 'WP_Roles' ) ) {
223		- if ( ! isset( $wp_roles ) ) {
	222	+ if (class_exists('WP_Roles')) {
	223	+ if ( ! isset($wp_roles)) {
224	224	$wp_roles = new WP_Roles();
225	225	}
226	226	}
227	227
228		- if ( is_object( $wp_roles ) ) {
	228	+ if (is_object($wp_roles)) {
229	229	/** Give Manager Capabilities */
230		- $wp_roles->remove_cap( 'give_manager', 'view_give_reports' );
231		- $wp_roles->remove_cap( 'give_manager', 'view_give_sensitive_data' );
232		- $wp_roles->remove_cap( 'give_manager', 'export_give_reports' );
233		- $wp_roles->remove_cap( 'give_manager', 'manage_give_settings' );
	230	+ $wp_roles->remove_cap('give_manager', 'view_give_reports');
	231	+ $wp_roles->remove_cap('give_manager', 'view_give_sensitive_data');
	232	+ $wp_roles->remove_cap('give_manager', 'export_give_reports');
	233	+ $wp_roles->remove_cap('give_manager', 'manage_give_settings');
234	234
235	235	/** Site Administrator Capabilities */
236		- $wp_roles->remove_cap( 'administrator', 'view_give_reports' );
237		- $wp_roles->remove_cap( 'administrator', 'view_give_sensitive_data' );
238		- $wp_roles->remove_cap( 'administrator', 'export_give_reports' );
239		- $wp_roles->remove_cap( 'administrator', 'manage_give_settings' );
	236	+ $wp_roles->remove_cap('administrator', 'view_give_reports');
	237	+ $wp_roles->remove_cap('administrator', 'view_give_sensitive_data');
	238	+ $wp_roles->remove_cap('administrator', 'export_give_reports');
	239	+ $wp_roles->remove_cap('administrator', 'manage_give_settings');
240	240
241	241	/** Remove the Main Post Type Capabilities */
242	242	$capabilities = $this->get_core_caps();
243	243
244		- foreach ( $capabilities as $cap_group ) {
245		- foreach ( $cap_group as $cap ) {
246		- $wp_roles->remove_cap( 'give_manager', $cap );
247		- $wp_roles->remove_cap( 'administrator', $cap );
248		- $wp_roles->remove_cap( 'give_worker', $cap );
	244	+ foreach ($capabilities as $cap_group) {
	245	+ foreach ($cap_group as $cap) {
	246	+ $wp_roles->remove_cap('give_manager', $cap);
	247	+ $wp_roles->remove_cap('administrator', $cap);
	248	+ $wp_roles->remove_cap('give_worker', $cap);
249	249	}
250	250	}
251	251
252	252	/** Shop Accountant Capabilities */
253		- $wp_roles->remove_cap( 'give_accountant', 'edit_give_forms' );
254		- $wp_roles->remove_cap( 'give_accountant', 'read_private_forms' );
255		- $wp_roles->remove_cap( 'give_accountant', 'view_give_reports' );
256		- $wp_roles->remove_cap( 'give_accountant', 'export_give_reports' );
	253	+ $wp_roles->remove_cap('give_accountant', 'edit_give_forms');
	254	+ $wp_roles->remove_cap('give_accountant', 'read_private_forms');
	255	+ $wp_roles->remove_cap('give_accountant', 'view_give_reports');
	256	+ $wp_roles->remove_cap('give_accountant', 'export_give_reports');
257	257
258	258	}
259	259	}

WordImpress / Give

Push — master ( 45b05a...b92b5a )

Status

Category

Spacing +57 added lines, -57 removed lines patch added patch discarded remove patch