ProxyClientFactory::getClientOptions() - Code Metrics - Inspection of "Updated README.md" - Wolnosciowiec/webproxy - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (9dd5cd)

by Blackred

created 2017-02-28 06:34 UTC

ProxyClientFactory::getClientOptions() A

↳ Parent: ProxyClientFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php declare(strict_types=1);

namespace Wolnosciowiec\WebProxy\Factory;

use GuzzleHttp\Client;
use Proxy\Adapter\Guzzle\GuzzleAdapter;
use Proxy\Proxy;
use Wolnosciowiec\WebProxy\Service\Proxy\ProxySelector;

/**
 * Creates a proxy client injecting
 * proxy server data (if available)
 * --------------------------------
 *
 * @package Wolnosciowiec\WebProxy\Factory
 */
class ProxyClientFactory
{
    /**
     * @var ProxySelector $proxySelector
     */
    private $proxySelector;

    /**
     * @var int $connectionTimeout
     */
    private $connectionTimeout = 10;

    public function __construct(ProxySelector $proxySelector, int $connectionTimeout = 10)
    {
        $this->proxySelector     = $proxySelector;
        $this->connectionTimeout = $connectionTimeout;
    }

    /**
     * @return Proxy
     */
    public function create()
    {
        return new Proxy(new GuzzleAdapter(
            new Client($this->getClientOptions())
        ));
    }

    /**
     * @return array
     */
    private function getClientOptions(): array
    {
        return array_filter([
            'proxy' => array_filter([
                'http'  => $this->proxySelector->getHTTPProxy(),
            ]),

            'connect_timeout' => $this->connectionTimeout,
            'read_timeout'    => $this->connectionTimeout,
            'timeout'         => $this->connectionTimeout,
        ]);
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Wolnosciowiec\WebProxy\Factory;
4
5			use GuzzleHttp\Client;
6			use Proxy\Adapter\Guzzle\GuzzleAdapter;
7			use Proxy\Proxy;
8			use Wolnosciowiec\WebProxy\Service\Proxy\ProxySelector;
9
10			/**
11			* Creates a proxy client injecting
12			* proxy server data (if available)
13			* --------------------------------
14			*
15			* @package Wolnosciowiec\WebProxy\Factory
16			*/
17			class ProxyClientFactory
18			{
19			/**
20			* @var ProxySelector $proxySelector
21			*/
22			private $proxySelector;
23
24			/**
25			* @var int $connectionTimeout
26			*/
27			private $connectionTimeout = 10;
28
29			public function __construct(ProxySelector $proxySelector, int $connectionTimeout = 10)
30			{
31			$this->proxySelector = $proxySelector;
32			$this->connectionTimeout = $connectionTimeout;
33			}
34
35			/**
36			* @return Proxy
37			*/
38			public function create()
39			{
40			return new Proxy(new GuzzleAdapter(
41			new Client($this->getClientOptions())
42			));
43			}
44
45			/**
46			* @return array
47			*/
48			private function getClientOptions(): array
49			{
50			return array_filter([
51			'proxy' => array_filter([
52			'http' => $this->proxySelector->getHTTPProxy(),
53			]),
54
55			'connect_timeout' => $this->connectionTimeout,
56			'read_timeout' => $this->connectionTimeout,
57			'timeout' => $this->connectionTimeout,
58			]);
59			}
60			}
61

Wolnosciowiec / webproxy

Branch — master (9dd5cd)

ProxyClientFactory::getClientOptions() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like