Wolframcheg / symfotest

src/AppBundle/Services/PassManager.php

Unused Use Statements -8 removed lines

@@ -1,23 +1,15 @@
 <?php
 namespace AppBundle\Services;
 
-use AppBundle\Entity\Comment;
 use AppBundle\Entity\ModuleUser;
 use AppBundle\Entity\PassModule;
 use AppBundle\Form\AnswerForPassType;
-use AppBundle\Form\CommentType;
 use AppBundle\Traits\GenerateOutput;
 use Faker\Provider\cs_CZ\DateTime;
-use Knp\Component\Pager\PaginatorInterface;
-use Proxies\__CG__\AppBundle\Entity\Module;
 use Symfony\Bridge\Doctrine\RegistryInterface;
 use Symfony\Component\Form\Extension\Core\Type\SubmitType;
 use Symfony\Component\Form\FormFactoryInterface;
-use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Symfony\Component\Routing\RouterInterface;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
 
 class PassManager

Spacing +5 added lines, -5 removed lines

@@ -81,7 +81,7 @@ 
         $dateEstimate = $pass->getTimeStart()
             ->modify("+{$pass->getTimePeriod()} minutes");
 
-        if($nowDate > $dateEstimate){
+        if ($nowDate > $dateEstimate) {
          //   $pass->setIsActive(false);
         //    $this->doctrine->getEntityManager()->flush();
             $this->deactivation->deactivation($pass);
@@ -137,14 +137,14 @@ 
             $firstQuestionForPass = $this->doctrine->getRepository('AppBundle:Question')
                 ->getFirstQuestionForPass($passModule->getId());
 
-            if(null === $firstQuestionForPass)
+            if (null === $firstQuestionForPass)
                 return $this->generateOutput('error', 500, 'This module does not have any questions ;(');
 
             $passModule->setCurrentQuestion($firstQuestionForPass);
             $this->doctrine->getEntityManager()->flush();
         }
 
-        if(!($passModule->getIsActive())){
+        if (!($passModule->getIsActive())) {
             return $this->generateOutput('error', 403, 'This pass is not active ;(');
         }
 
@@ -161,9 +161,9 @@ 
             'idPassModule' => $idPassModule,
             'answers' => $currentQuestion->getAnswers()->toArray()
         ]);
-        $form->add('submit', SubmitType::class, ['label' => 'Save', 'attr' => [ 'class' => 'btn btn-primary' ]]);
+        $form->add('submit', SubmitType::class, [ 'label' => 'Save', 'attr' => [ 'class' => 'btn btn-primary' ] ]);
 
-        $currentNumberQuestion = $passModule->getCountPassedQuestions()+1;
+        $currentNumberQuestion = $passModule->getCountPassedQuestions() + 1;
 
         return $this->generateOutput('ok', 200, [
             $form,

Braces +12 added lines, -8 removed lines

@@ -56,8 +56,9 @@ 
             return $this->generateOutput('error', 403, 'You do not have access to this module');
         }
 
-        if ($moduleUser->getAttempts() == $moduleUser->getModule()->getAttempts())
-            return $this->generateOutput('error', 403, 'Your attempts are exhausted');
+        if ($moduleUser->getAttempts() == $moduleUser->getModule()->getAttempts()) {
+                    return $this->generateOutput('error', 403, 'Your attempts are exhausted');
+        }
 
         $lastPass = $moduleUser->getPassModules()->last();
 
@@ -68,8 +69,9 @@ 
 
         $time_residue = $this->checkDatePass($lastPass);
 
-        if (!$time_residue)
-            $this->identPass($idModule);
+        if (!$time_residue) {
+                    $this->identPass($idModule);
+        }
 
         return $this->generateOutput('redirect_to_pass', 301, $lastPass->getId());
     }
@@ -137,8 +139,9 @@ 
             $firstQuestionForPass = $this->doctrine->getRepository('AppBundle:Question')
                 ->getFirstQuestionForPass($passModule->getId());
 
-            if(null === $firstQuestionForPass)
-                return $this->generateOutput('error', 500, 'This module does not have any questions ;(');
+            if(null === $firstQuestionForPass) {
+                            return $this->generateOutput('error', 500, 'This module does not have any questions ;(');
+            }
 
             $passModule->setCurrentQuestion($firstQuestionForPass);
             $this->doctrine->getEntityManager()->flush();
@@ -150,8 +153,9 @@ 
 
         $time_residue = $this->checkDatePass($passModule);
 
-        if (!$time_residue)
-            return $this->generateOutput('error', 403, 'This pass is overdue ;(');
+        if (!$time_residue) {
+                    return $this->generateOutput('error', 403, 'This pass is overdue ;(');
+        }
 
 
         $currentQuestion = $passModule->getCurrentQuestion();

src/AppBundle/OAuthProvider/LoginUserProvider.php

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
     {
         $em = $this->em;
         $type = $response->getResourceOwner()->getName();
-        $user = $em->getRepository('AppBundle:User')->findOneBy(['email' => $response->getEmail()]);
+        $user = $em->getRepository('AppBundle:User')->findOneBy([ 'email' => $response->getEmail() ]);
         if ($user === null) {
             $user = new User();
             $user->setEmail($response->getEmail())
@@ -89,7 +89,7 @@ 
      */
     public function loadUserByUsername($username)
     {
-        $user = $this->em->getRepository('AppBundle:User')->findOneBy(['email' => $username]);
+        $user = $this->em->getRepository('AppBundle:User')->findOneBy([ 'email' => $username ]);
         if (!$user) {
             throw new UsernameNotFoundException(sprintf("User '%s' not found.", $username));
         }

src/AppBundle/Services/CheckAnwers.php

Spacing +6 added lines, -6 removed lines

@@ -24,7 +24,7 @@ 
     {
         $em = $this->doctrine->getManager();
         $question = $em->getRepository('AppBundle:Question')
-            ->find($data['idQuestion']);
+            ->find($data[ 'idQuestion' ]);
 
         $originalAnswers = $question->getAnswers();
         $countOriginalAnswers = $question->getCountAnswers();
@@ -37,8 +37,8 @@ 
 
         foreach ($originalAnswers as $item) {
             $item->getCorrectly() ? $countAllTrueAnswers++ : null;
-            $data["answer_{$item->getId()}"] ? $countAllChecks++ : null;
-            if ($item->getCorrectly() === $data["answer_{$item->getId()}"]) {
+            $data[ "answer_{$item->getId()}" ] ? $countAllChecks++ : null;
+            if ($item->getCorrectly() === $data[ "answer_{$item->getId()}" ]) {
                 $sumAllCorrect++;
                 if ($item->getCorrectly())
                     $sumCorrectChecks++;
@@ -55,8 +55,8 @@ 
             $maxCountAnswers = $countAllTrueAnswers;
         }
 
-        if ($question->getAllIncorrect() || $data['answer_all_incorrect']) {
-            if ($question->getAllIncorrect() === $data['answer_all_incorrect'] && $question->getAllIncorrect() === true &&
+        if ($question->getAllIncorrect() || $data[ 'answer_all_incorrect' ]) {
+            if ($question->getAllIncorrect() === $data[ 'answer_all_incorrect' ] && $question->getAllIncorrect() === true &&
                 $sumAllCorrect == $countOriginalAnswers
             )
                 return $result = 1;
@@ -68,7 +68,7 @@ 
         if ($sumAllCorrect && $sumCorrectChecks && $countAllChecks <= $maxCountAnswers) {
             // second type question
             if ($countAllTrueAnswers == 1) {
-                $result = (1 / $maxCountAnswers) * ($sumCorrectChecks + ($sumFalseAnswers > 0 ? 0: 1));
+                $result = (1 / $maxCountAnswers) * ($sumCorrectChecks + ($sumFalseAnswers > 0 ? 0 : 1));
             }
             // third type question
             elseif ($countAllTrueAnswers > 1) {

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: device
- * Date: 04.03.16
- * Time: 15:50
- */
+     * Created by PhpStorm.
+     * User: device
+     * Date: 04.03.16
+     * Time: 15:50
+     */
 
 namespace AppBundle\Services;
 

Braces +6 added lines, -4 removed lines

@@ -40,8 +40,9 @@ 
             $data["answer_{$item->getId()}"] ? $countAllChecks++ : null;
             if ($item->getCorrectly() === $data["answer_{$item->getId()}"]) {
                 $sumAllCorrect++;
-                if ($item->getCorrectly())
-                    $sumCorrectChecks++;
+                if ($item->getCorrectly()) {
+                                    $sumCorrectChecks++;
+                }
             } else {
                 if ($item->getCorrectly() === false) {
                     $sumFalseAnswers++;
@@ -58,8 +59,9 @@ 
         if ($question->getAllIncorrect() || $data['answer_all_incorrect']) {
             if ($question->getAllIncorrect() === $data['answer_all_incorrect'] && $question->getAllIncorrect() === true &&
                 $sumAllCorrect == $countOriginalAnswers
-            )
-                return 1;
+            ) {
+                            return 1;
+            }
 
             return 0;
         }

src/AppBundle/Services/CheckAnswerV0.php

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: device
- * Date: 04.03.16
- * Time: 15:50
- */
+     * Created by PhpStorm.
+     * User: device
+     * Date: 04.03.16
+     * Time: 15:50
+     */
 
 namespace AppBundle\Services;
 

Spacing +5 added lines, -5 removed lines

@@ -24,7 +24,7 @@ 
     {
         $em = $this->doctrine->getManager();
         $question = $em->getRepository('AppBundle:Question')
-            ->find($data['idQuestion']);
+            ->find($data[ 'idQuestion' ]);
 
         $originalAnswers = $question->getAnswers();
         $countOriginalAnswers = count($originalAnswers);
@@ -37,7 +37,7 @@ 
 
         foreach ($originalAnswers as $item) {
             $item->getCorrectly() ? $countAllTrueAnswers++ : $countAllFalseAnswers++;
-            if ($item->getCorrectly() === $data["answer_{$item->getId()}"]) {
+            if ($item->getCorrectly() === $data[ "answer_{$item->getId()}" ]) {
                 if ($item->getCorrectly() === true) {
                     $sumTrueCorrect++;
                 }
@@ -49,8 +49,8 @@ 
             }
         }
         //first type question
-        if ($question->getAllIncorrect() || $data['answer_all_incorrect']) {
-            if ($question->getAllIncorrect() === $data['answer_all_incorrect'] && $question->getAllIncorrect() === true && $sumTrueCorrect == 0) {
+        if ($question->getAllIncorrect() || $data[ 'answer_all_incorrect' ]) {
+            if ($question->getAllIncorrect() === $data[ 'answer_all_incorrect' ] && $question->getAllIncorrect() === true && $sumTrueCorrect == 0) {
 
                 return $result = 1;
             }
@@ -74,7 +74,7 @@ 
                 //   $result = $sumTrueCorrect != 0 ? ((1 / $countAllTrueAnswers) * $sumTrueCorrect) - ((1 / $countAllFalseAnswers) * $countFalseAnswers) : 0;
                 $result = $sumAllCorrect != 0 ? ((1 / $countOriginalAnswers) * $sumAllCorrect) : 0;
             } else {
-                $result =  0;
+                $result = 0;
             }
         }
 

Braces +1 added lines, -2 removed lines

@@ -64,8 +64,7 @@
                 $result = $sumTrueCorrect != 0 ? 1 / $sumTrueCorrect / 2 : 0;
             } elseif ($countFalseAnswers > 1) {
                 $result = 0;
-            }
-            else {
+            } else {
                 $result = $sumTrueCorrect != 0 ? 1 / $sumTrueCorrect : 0;
             }
             //third type question

src/AppBundle/Services/CheckCountAnswers.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
         if ($countTrueAnswers > 3) {
             $this->session->getFlashBag()->add('notice',
-                'You have to add not more than 3 true answers for question '.$question->getTextQuestion());
+                'You have to add not more than 3 true answers for question ' . $question->getTextQuestion());
 
             return false;
         }

src/AppBundle/Services/DeactivationPassModule.php

Indentation +5 added lines, -5 removed lines

@@ -1,10 +1,10 @@
 <?php
 /**
- * Created by PhpStorm.
- * User: device
- * Date: 09.03.16
- * Time: 19:01
- */
+     * Created by PhpStorm.
+     * User: device
+     * Date: 09.03.16
+     * Time: 19:01
+     */
 
 namespace AppBundle\Services;
 

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
         if ($passModule->getPercentResult() >= $module->getPersentSuccess()) {
             $moduleUser->setStatus(ModuleUser::STATUS_SUCCESS);
             $moduleUser->setRating($passModule->getRating());
-        } else if ($moduleUser->getCountPassModules() >= $module->getAttempts()){
+        } else if ($moduleUser->getCountPassModules() >= $module->getAttempts()) {
                 $moduleUser->setStatus(ModuleUser::STATUS_FAILED);
                 //$moduleUser->setRating($passModule->getRating());
         }

src/AppBundle/Services/PassControl.php

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
     {
         $rating = $this->checkAnswers->checkAnswers($data);
         $passModule = $this->doctrine->getRepository('AppBundle:PassModule')
-            ->findOneById($data['idPassModule']);
+            ->findOneById($data[ 'idPassModule' ]);
 
         $passModule->addAnsweredQuestionId($passModule->getCurrentQuestion()->getId());
 
@@ -43,18 +43,18 @@ 
         $passModule->addRating($rating);
 
 
-        if($nextQuestionForPass === null) {
+        if ($nextQuestionForPass === null) {
           //  $passModule->setIsActive(false);
           //  $passModule->setTimeFinish(new \DateTime());
          //   $this->doctrine->getEntityManager()->flush();
             $timeFinish = new \DateTime();
             $this->deactivation->deactivation($passModule, $timeFinish);
-            return $this->generateOutput('redirect_to_result', 301, $data['idPassModule']);
+            return $this->generateOutput('redirect_to_result', 301, $data[ 'idPassModule' ]);
         }
 
         $passModule->setCurrentQuestion($nextQuestionForPass);
         $this->doctrine->getEntityManager()->flush();
 
-        return $this->generateOutput('redirect_to_pass', 301, $data['idPassModule']);
+        return $this->generateOutput('redirect_to_pass', 301, $data[ 'idPassModule' ]);
     }
 }

src/AppBundle/Traits/GenerateOutput.php

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php
 namespace AppBundle\Traits;
 
-trait GenerateOutput{
+trait GenerateOutput {
 
     private function generateOutput($status, $code, $message)
     {

src/AppBundle/Tests/TestBaseWeb.php

Spacing +7 added lines, -7 removed lines

@@ -17,24 +17,24 @@
     public function setUp()
     {
         $this->client = static::createClient();
-        $this->runCommand(['command' => 'doctrine:database:create']);
-        $this->runCommand(['command' => 'doctrine:schema:update', '--force' => true]);
-        $this->runCommand(['command' => 'doctrine:fixtures:load', '--no-interaction' => true]);
+        $this->runCommand([ 'command' => 'doctrine:database:create' ]);
+        $this->runCommand([ 'command' => 'doctrine:schema:update', '--force' => true ]);
+        $this->runCommand([ 'command' => 'doctrine:fixtures:load', '--no-interaction' => true ]);
 
     }
 
     public function tearDown()
     {
-        $this->runCommand(['command' => 'doctrine:database:drop', '--force' => true]);
+        $this->runCommand([ 'command' => 'doctrine:database:drop', '--force' => true ]);
         $this->client = null;
     }
 
-    protected function runCommand(array $arguments = [])
+    protected function runCommand(array $arguments = [ ])
     {
         $application = new Application($this->client->getKernel());
         $application->setAutoExit(false);
-        $arguments['--quiet'] = true;
-        $arguments['-e'] = 'test';
+        $arguments[ '--quiet' ] = true;
+        $arguments[ '-e' ] = 'test';
         $input = new ArrayInput($arguments);
         $application->run($input, new ConsoleOutput());
     }