ModuleController::removeModuleAction() - Code Metrics - Inspection of "Develop" - Wolframcheg/symfotest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#45)

by Pavel

created 2016-03-31 10:50 UTC

ModuleController::removeModuleAction() A

↳ Parent: ModuleController

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2.0023

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
ccs	11
cts	12
cp	0.9167
rs	9.4285
cc	2
eloc	11
nc	2
nop	1
crap	2.0023

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\Module;
use AppBundle\Form\ModuleType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request;

class ModuleController extends Controller
{
    /**
     * @Route("/admin/module/new", name="create_module")
     * @Template("@App/admin/module/createModule.html.twig")
     */
    public function createModuleAction(Request $request)

    {
        $em = $this->getDoctrine()->getManager();

        $module = new Module();
        $form = $this->createForm(ModuleType::class, $module);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $em->persist($module);
            $em->flush();

            return $this->redirectToRoute('create_question', array('idModule' => $module->getId()));

        }

        return ['form' => $form->createView()];
    }

    /**
     * @Route("/admin/module/edit/{id}", name="edit_module")
     * @Template("@App/admin/module/editModule.html.twig")
     */
    public function editModuleAction(Request $request, $id)

    {
        $em = $this->getDoctrine()->getManager();

        $module = $em->getRepository('AppBundle:Module')
            ->find($id);
        $form = $this->createForm(ModuleType::class, $module);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $em->flush();

            return $this->redirectToRoute('show_module');
        }

        return ['module' => $module,
                'form' => $form->createView()];
    }

    /**
     * @Route("/admin/module/remove/{id}", name="remove_module")
     * @Method("DELETE")
     */
    public function removeModuleAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $module = $em->getRepository('AppBundle:Module')
            ->find($id);
        $users = $em->getRepository('AppBundle:User')
            ->findChoiceModules($module->getId());
        foreach ($users as $item) {
                $item->removeChosenModule($module->getId());
        }

        $em->remove($module);
        $em->flush();

        return $this->redirectToRoute('show_module');

    }

    /**
     * @Route("/admin/module", name="show_module")
     * @Template("@App/admin/module/showmodule.html.twig")
     */
    public function showModuleAction()

    {
        $em = $this->getDoctrine()->getManager();

        $sql = $em->getRepository('AppBundle:Module')

            ->findAllModules();
        $paginator = $this->get('knp_paginator');
        $module = $paginator->paginate(
            $sql,
            $this->get('request')->query->get('page', 1),
            $this->container->getParameter('knp_paginator.page_range')
        );

        $form_delete = [];

        foreach ($module as $item) {
            $form_delete[$item->getId()] = $this->createFormDelete($item->getId())->createView();
        }

        return [
            'modules' => $module,
            'form_remove' => $form_delete
        ];

    }

    /**
     * @return \Symfony\Component\Form\Form
     */
    private function createFormDelete($id)

    {
        return $this->createFormBuilder()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setAction($this->generateUrl('remove_module', ['id' => $id]))
            ->setMethod('DELETE')
            ->add('submit', SubmitType::class, [
                'label' => ' ',
                'attr' => [
                    'class' => 'glyphicon glyphicon-remove btn-link',
                    'onclick' => 'return confirm("Are you sure?")'
                ]
            ])
            ->getForm();
    }
}


1			<?php
2
3			namespace AppBundle\Controller\Admin;
4
5			use AppBundle\Entity\Module;
6			use AppBundle\Form\ModuleType;
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
8			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
9			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
10			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
11			use Symfony\Component\Form\Extension\Core\Type\SubmitType;
12			use Symfony\Component\HttpFoundation\Request;
13
14			class ModuleController extends Controller
15			{
16			/**
17			* @Route("/admin/module/new", name="create_module")
18			* @Template("@App/admin/module/createModule.html.twig")
19			*/
20	1	View Code Duplication	public function createModuleAction(Request $request)
			0 ignored issues – show Duplication introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21			{
22	1		$em = $this->getDoctrine()->getManager();
23
24	1		$module = new Module();
25	1		$form = $this->createForm(ModuleType::class, $module);
26
27	1		$form->handleRequest($request);
28
29	1		if ($form->isValid()) {
30			$em->persist($module);
31			$em->flush();
32
33			return $this->redirectToRoute('create_question', array('idModule' => $module->getId()));
34
35			}
36
37	1		return ['form' => $form->createView()];
38			}
39
40			/**
41			* @Route("/admin/module/edit/{id}", name="edit_module")
42			* @Template("@App/admin/module/editModule.html.twig")
43			*/
44	1	View Code Duplication	public function editModuleAction(Request $request, $id)
			0 ignored issues – show Duplication introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46	1		$em = $this->getDoctrine()->getManager();
47
48	1		$module = $em->getRepository('AppBundle:Module')
49	1		->find($id);
50	1		$form = $this->createForm(ModuleType::class, $module);
51
52	1		$form->handleRequest($request);
53
54	1		if ($form->isValid()) {
55			$em->flush();
56
57			return $this->redirectToRoute('show_module');
58			}
59
60	1		return ['module' => $module,
61	1		'form' => $form->createView()];
62			}
63
64			/**
65			* @Route("/admin/module/remove/{id}", name="remove_module")
66			* @Method("DELETE")
67			*/
68	1		public function removeModuleAction($id)
69			{
70	1		$em = $this->getDoctrine()->getManager();
71
72	1		$module = $em->getRepository('AppBundle:Module')
73	1		->find($id);
74	1		$users = $em->getRepository('AppBundle:User')
75	1		->findChoiceModules($module->getId());
76	1		foreach ($users as $item) {
77			$item->removeChosenModule($module->getId());
78	1		}
79
80	1		$em->remove($module);
81	1		$em->flush();
82
83	1		return $this->redirectToRoute('show_module');
84
85			}
86
87			/**
88			* @Route("/admin/module", name="show_module")
89			* @Template("@App/admin/module/showmodule.html.twig")
90			*/
91	1	View Code Duplication	public function showModuleAction()
			0 ignored issues – show Duplication introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92			{
93	1		$em = $this->getDoctrine()->getManager();
94
95	1		$sql = $em->getRepository('AppBundle:Module')
			0 ignored issues – show Bug introduced 2016-03-31 10:53 UTC by Report Bug Copy Issue Report The method `findAllModules()` does not exist on `Doctrine\Common\Persistence\ObjectRepository`. Did you maybe mean `findAll()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
96	1		->findAllModules();
97	1		$paginator = $this->get('knp_paginator');
98	1		$module = $paginator->paginate(
99	1		$sql,
100	1		$this->get('request')->query->get('page', 1),
101	1		$this->container->getParameter('knp_paginator.page_range')
102	1		);
103
104	1		$form_delete = [];
105
106	1		foreach ($module as $item) {
107	1		$form_delete[$item->getId()] = $this->createFormDelete($item->getId())->createView();
108	1		}
109
110	1		return [
111	1		'modules' => $module,
112			'form_remove' => $form_delete
113	1		];
114
115			}
116
117			/**
118			* @return \Symfony\Component\Form\Form
119			*/
120	1	View Code Duplication	private function createFormDelete($id)
			0 ignored issues – show Duplication introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121			{
122	1		return $this->createFormBuilder()
			0 ignored issues – show Bug introduced 2016-03-18 21:20 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Form\FormConfigBuilder` as the method `add()` does only exist in the following sub-classes of `Symfony\Component\Form\FormConfigBuilder`: `Symfony\Component\Form\FormBuilder`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
123	1		->setAction($this->generateUrl('remove_module', ['id' => $id]))
124	1		->setMethod('DELETE')
125	1		->add('submit', SubmitType::class, [
126	1		'label' => ' ',
127			'attr' => [
128	1		'class' => 'glyphicon glyphicon-remove btn-link',
129			'onclick' => 'return confirm("Are you sure?")'
130	1		]
131	1		])
132	1		->getForm();
133			}
134			}
135

Wolframcheg / symfotest

Pull Request — master (#45)

ModuleController::removeModuleAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like