ModuleRepository::getFreeModulesForUserQuery() - Code Metrics - Inspection of "Merge pull request #45 from Wolframcheg/develop" - Wolframcheg/symfotest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 858bee...ca95b0 )

by Pavel

created 2016-03-31 10:58 UTC

ModuleRepository::getFreeModulesForUserQuery() A

↳ Parent: ModuleRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	6
cts	6
cp	1
rs	9.4285
cc	1
eloc	6
nc	1
nop	1
crap	1

<?php
/**
 * Created by PhpStorm.
 * User: device
 * Date: 23.02.16
 * Time: 9:27
 */

namespace AppBundle\Repository;


use Doctrine\ORM\EntityRepository;
use Symfony\Component\Security\Core\User\UserInterface;

class ModuleRepository extends EntityRepository
{

    public function getFreeModulesForUserQuery(UserInterface $user)
    {
        return $this->createQueryBuilder('module')
            ->leftJoin('module.modulesUser mu WITH mu.user = :userId', false)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->where('mu IS NULL')
            ->setParameter('userId', $user->getId())
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->orderBy('module.title', 'ASC');
    }

    public function getFreeModulesForUser(UserInterface $user)
    {
        return $this->getFreeModulesForUserQuery($user)
            ->getQuery()
            ->getResult();
    }

    public function findCountModules()
    {
        return $this->createQueryBuilder('module')
            ->select('COUNT(module.id) as count_m')
            ->getQuery()
            ->getOneOrNullResult();
    }

    public function findAllModules()
    {
        return $this->createQueryBuilder('m')
            ->select('m')
            ->orderBy('m.createdAt', 'DESC')
            ->getQuery();
    }

}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: device
5		* Date: 23.02.16
6		* Time: 9:27
7		*/
8
9		namespace AppBundle\Repository;
10
11
12		use Doctrine\ORM\EntityRepository;
13		use Symfony\Component\Security\Core\User\UserInterface;
14
15		class ModuleRepository extends EntityRepository
16		{
17
18	1	public function getFreeModulesForUserQuery(UserInterface $user)
19		{
20	1	return $this->createQueryBuilder('module')
21	1	->leftJoin('module.modulesUser mu WITH mu.user = :userId', false)
		0 ignored issues – show Documentation introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
22	1	->where('mu IS NULL')
23	1	->setParameter('userId', $user->getId())
		0 ignored issues – show Bug introduced 2016-03-18 21:25 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Security\Core\User\UserInterface` as the method `getId()` does only exist in the following implementations of said interface: `AppBundle\Entity\User`, `HWI\Bundle\OAuthBundle\Tests\Fixtures\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24	1	->orderBy('module.title', 'ASC');
25		}
26
27		public function getFreeModulesForUser(UserInterface $user)
28		{
29		return $this->getFreeModulesForUserQuery($user)
30		->getQuery()
31		->getResult();
32		}
33
34	1	public function findCountModules()
35		{
36	1	return $this->createQueryBuilder('module')
37	1	->select('COUNT(module.id) as count_m')
38	1	->getQuery()
39	1	->getOneOrNullResult();
40		}
41
42	1	public function findAllModules()
43		{
44	1	return $this->createQueryBuilder('m')
45	1	->select('m')
46	1	->orderBy('m.createdAt', 'DESC')
47	1	->getQuery();
48		}
49
50		}

Wolframcheg / symfotest

Push — master ( 858bee...ca95b0 )

ModuleRepository::getFreeModulesForUserQuery() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like