AppBundle\Controller\Admin\ModuleController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	121
Duplicated Lines	63.64 %

Coupling/Cohesion

Components	1
Dependencies	9

Test Coverage

Coverage

90%

Importance

Changes	8
Bugs	0	Features	7

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createModuleAction()	19	19	2
A	editModuleAction()	19	19	2
A	removeModuleAction()	0	18	2
B	showModuleAction()	25	25	2
A	createFormDelete()	14	14	1

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\Module;
use AppBundle\Form\ModuleType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request;

class ModuleController extends Controller
{
    /**
     * @Route("/admin/module/new", name="create_module")
     * @Template("@App/admin/module/createModule.html.twig")
     */
    public function createModuleAction(Request $request)

This method seems to be duplicated in your project.

    {
        $em = $this->getDoctrine()->getManager();

        $module = new Module();
        $form = $this->createForm(ModuleType::class, $module);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $em->persist($module);
            $em->flush();

            return $this->redirectToRoute('create_question', array('idModule' => $module->getId()));

        }

        return ['form' => $form->createView()];
    }

    /**
     * @Route("/admin/module/edit/{id}", name="edit_module")
     * @Template("@App/admin/module/editModule.html.twig")
     */
    public function editModuleAction(Request $request, $id)

This method seems to be duplicated in your project.

    {
        $em = $this->getDoctrine()->getManager();

        $module = $em->getRepository('AppBundle:Module')
            ->find($id);
        $form = $this->createForm(ModuleType::class, $module);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $em->flush();

            return $this->redirectToRoute('show_module');
        }

        return ['module' => $module,
                'form' => $form->createView()];
    }

    /**
     * @Route("/admin/module/remove/{id}", name="remove_module")
     * @Method("DELETE")
     */
    public function removeModuleAction($id)
    {
        $em = $this->getDoctrine()->getManager();

        $module = $em->getRepository('AppBundle:Module')
            ->find($id);
        $users = $em->getRepository('AppBundle:User')
            ->findChoiceModules($module->getId());
        foreach ($users as $item) {
                $item->removeChosenModule($module->getId());
        }

        $em->remove($module);
        $em->flush();

        return $this->redirectToRoute('show_module');

    }

    /**
     * @Route("/admin/module", name="show_module")
     * @Template("@App/admin/module/showmodule.html.twig")
     */
    public function showModuleAction()

This method seems to be duplicated in your project.

    {
        $em = $this->getDoctrine()->getManager();

        $sql = $em->getRepository('AppBundle:Module')

The method findAllModules() does not exist on Doctrine\Common\Persistence\ObjectRepository. Did you maybe mean findAll()?

            ->findAllModules();
        $paginator = $this->get('knp_paginator');
        $module = $paginator->paginate(
            $sql,
            $this->get('request')->query->get('page', 1),
            $this->container->getParameter('knp_paginator.page_range')
        );

        $form_delete = [];

        foreach ($module as $item) {
            $form_delete[$item->getId()] = $this->createFormDelete($item->getId())->createView();
        }

        return [
            'modules' => $module,
            'form_remove' => $form_delete
        ];

    }

    /**
     * @return \Symfony\Component\Form\Form
     */
    private function createFormDelete($id)

This method seems to be duplicated in your project.

    {
        return $this->createFormBuilder()

It seems like you code against a specific sub-type and not the parent class Symfony\Component\Form\FormConfigBuilder as the method add() does only exist in the following sub-classes of Symfony\Component\Form\FormConfigBuilder: Symfony\Component\Form\FormBuilder. Maybe you want to instanceof check for one of these explicitly?

            ->setAction($this->generateUrl('remove_module', ['id' => $id]))
            ->setMethod('DELETE')
            ->add('submit', SubmitType::class, [
                'label' => ' ',
                'attr' => [
                    'class' => 'glyphicon glyphicon-remove btn-link',
                    'onclick' => 'return confirm("Are you sure?")'
                ]
            ])
            ->getForm();
    }
}