AppBundle\Controller\Admin\MassActionController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
B	massAction()	0	38	4

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\ModuleUser;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class MassActionController extends Controller
{
    /**
     * @Route("/admin/mass-action", name="mass_action")
     * @Template("@App/admin/massAction/massAction.html.twig")
     */
    public function massAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $modules = $em->getRepository('AppBundle:Module')
            ->findAll();

        if ($module = $request->get('module')) {
            $users = $em->getRepository('AppBundle:User')
                ->findChoiceModules($module);

            return new Response(json_encode(['users' => $users]));
        }

        if ($choice = $request->get('users_choice')) {
            $hiddenModule = $request->get('moduleHidden');
            $moduleHidden = $em->getRepository('AppBundle:Module')
                ->find($hiddenModule);

            for ($i = 0; $i < count($choice); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $moduleUser = new ModuleUser();
                $moduleUser->setModule($moduleHidden);
                $user = $em->getRepository('AppBundle:User')
                    ->find($choice[$i]);
                $moduleUser->setUser($user);
                $user->removeChosenModule($hiddenModule);
                $em->persist($moduleUser);
            }

            $em->flush();

            return $this->redirectToRoute('mass_action');
        }

        return [
            'modules' => $modules
        ];
    }
}