RecordingDispatcherTest::testDispatch() - Code Metrics - Werkspot/statsd-bundle - Measure and Improve Code Quality continuously with Scrutinizer

RecordingDispatcherTest::testDispatch() A
last analyzed 2015-12-30 14:44 UTC

↳ Parent: RecordingDispatcherTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	12
rs	9.4286
cc	1
eloc	6
nc	1
nop	0

<?php

namespace Werkspot\Bundle\StatsdBundle\Tests\Event;

use Mockery;
use Mockery\MockInterface;
use Symfony\Component\EventDispatcher\Event;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Werkspot\Bundle\StatsdBundle\Client\StatsdClientInterface;
use Werkspot\Bundle\StatsdBundle\Event\RecordingDispatcher;

class RecordingDispatcherTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var EventDispatcherInterface|MockInterface
     */
    private $mockOriginalDispatcher;

    /**
     * @var StatsdClientInterface|MockInterface
     */
    private $mockStatsdClient;

    /**
     * @var RecordingDispatcher
     */
    private $dispatcher;

    protected function setUp()
    {
        $this->mockOriginalDispatcher = Mockery::mock(EventDispatcherInterface::class);
        $this->mockStatsdClient = Mockery::mock(StatsdClientInterface::class);

        $this->dispatcher = new RecordingDispatcher($this->mockOriginalDispatcher, $this->mockStatsdClient);
    }

    public function testDispatch()
    {
        $mockEventName = 'a.b-c.d-e';
        $mockEvent = Mockery::mock(Event::class);

        $this->mockOriginalDispatcher->shouldReceive('dispatch')->with($mockEventName, $mockEvent);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->mockStatsdClient->shouldReceive('increment')->with('a-b-c-d-e');

        $this->dispatcher->dispatch($mockEventName, $mockEvent);


    }

}


1			<?php
2
3			namespace Werkspot\Bundle\StatsdBundle\Tests\Event;
4
5			use Mockery;
6			use Mockery\MockInterface;
7			use Symfony\Component\EventDispatcher\Event;
8			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
9			use Werkspot\Bundle\StatsdBundle\Client\StatsdClientInterface;
10			use Werkspot\Bundle\StatsdBundle\Event\RecordingDispatcher;
11
12			class RecordingDispatcherTest extends \PHPUnit_Framework_TestCase
13			{
14			/**
15			* @var EventDispatcherInterface\|MockInterface
16			*/
17			private $mockOriginalDispatcher;
18
19			/**
20			* @var StatsdClientInterface\|MockInterface
21			*/
22			private $mockStatsdClient;
23
24			/**
25			* @var RecordingDispatcher
26			*/
27			private $dispatcher;
28
29			protected function setUp()
30			{
31			$this->mockOriginalDispatcher = Mockery::mock(EventDispatcherInterface::class);
32			$this->mockStatsdClient = Mockery::mock(StatsdClientInterface::class);
33
34			$this->dispatcher = new RecordingDispatcher($this->mockOriginalDispatcher, $this->mockStatsdClient);
35			}
36
37			public function testDispatch()
38			{
39			$mockEventName = 'a.b-c.d-e';
40			$mockEvent = Mockery::mock(Event::class);
41
42			$this->mockOriginalDispatcher->shouldReceive('dispatch')->with($mockEventName, $mockEvent);
			0 ignored issues – show Bug introduced 2015-12-30 14:36 UTC by Report Bug Copy Issue Report The method `shouldReceive` does only exist in `Mockery\MockInterface`, but not in `Symfony\Component\EventD...ventDispatcherInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43			$this->mockStatsdClient->shouldReceive('increment')->with('a-b-c-d-e');
44
45			$this->dispatcher->dispatch($mockEventName, $mockEvent);
46
47
48			}
49
50			}
51

Werkspot / statsd-bundle

RecordingDispatcherTest::testDispatch() A last analyzed 2015-12-30 14:44 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

RecordingDispatcherTest::testDispatch() A
last analyzed 2015-12-30 14:44 UTC