TradeNames::__construct() - Code Metrics - Inspection of "Refactor namespace" - Werkspot/kvk-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Laurens

created 2018-02-19 09:35 UTC

TradeNames::__construct() A

↳ Parent: TradeNames

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	4
crap	1

<?php

declare(strict_types=1);

namespace Werkspot\KvkApi\Client\Profile\Company;

final class TradeNames
{
    private $businessName;
    private $shortBusinessName;
    private $currentTradeNames;
    private $currentStatutoryNames;

    public function __construct(
        ?string $businessName,
        ?string $shortBusinessName,
        ?array $currentTradeNames,
        ?array $currentStatutoryNames
    ) {
        $this->businessName = $businessName;
        $this->shortBusinessName = $shortBusinessName;
        $this->currentTradeNames = $currentTradeNames;
        $this->currentStatutoryNames = $currentStatutoryNames;
    }

    public function getBusinessName(): ?string
    {
        return $this->businessName;
    }

    public function getShortBusinessName(): ?string
    {
        return $this->shortBusinessName;
    }

    public function getCurrentTradeNames()
    {
        return $this->currentTradeNames;
    }

    public function getCurrentStatutoryNames()
    {
        return $this->currentStatutoryNames;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Werkspot\KvkApi\Client\Profile\Company;
6
7		final class TradeNames
8		{
9		private $businessName;
10		private $shortBusinessName;
11		private $currentTradeNames;
12		private $currentStatutoryNames;
13
14	20	public function __construct(
15		?string $businessName,
16		?string $shortBusinessName,
17		?array $currentTradeNames,
18		?array $currentStatutoryNames
19		) {
20	20	$this->businessName = $businessName;
21	20	$this->shortBusinessName = $shortBusinessName;
22	20	$this->currentTradeNames = $currentTradeNames;
23	20	$this->currentStatutoryNames = $currentStatutoryNames;
24	20	}
25
26	2	public function getBusinessName(): ?string
27		{
28	2	return $this->businessName;
29		}
30
31	2	public function getShortBusinessName(): ?string
32		{
33	2	return $this->shortBusinessName;
34		}
35
36	2	public function getCurrentTradeNames()
37		{
38	2	return $this->currentTradeNames;
39		}
40
41	2	public function getCurrentStatutoryNames()
42		{
43	2	return $this->currentStatutoryNames;
44		}
45		}
46

Werkspot / kvk-api

Pull Request — master (#8)

TradeNames::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like