KvkPaginatorFactory::fromProfileData() - Code Metrics - Inspection of "Refactor namespace" - Werkspot/kvk-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Laurens

created 2018-02-19 09:35 UTC

KvkPaginatorFactory::fromProfileData() A

↳ Parent: KvkPaginatorFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	11
c	0
b	0
f	0
ccs	8
cts	8
cp	1
rs	9.4285
cc	1
eloc	8
nc	1
nop	1
crap	1

<?php

declare(strict_types=1);

namespace Werkspot\KvkApi\Client\Factory;

use Werkspot\KvkApi\Client\Factory\Profile\CompanyFactoryInterface;
use Werkspot\KvkApi\Client\KvkPaginator;
use Werkspot\KvkApi\Client\KvkPaginatorInterface;
use Werkspot\KvkApi\Client\Profile\Company;

final class KvkPaginatorFactory extends AbstractFactory implements KvkPaginatorFactoryInterface
{
    /**
     * @var CompanyFactoryInterface
     */
    private $companyFactory;

    public function __construct(CompanyFactoryInterface $companyFactory)
    {
        $this->companyFactory = $companyFactory;
    }

    public function fromProfileData(array $data): KvkPaginatorInterface
    {
        return new KvkPaginator(
            $this->extractIntegerOrNull('itemsPerPage', $data),
            $this->extractIntegerOrNull('startPage', $data),
            $this->extractIntegerOrNull('totalItems', $data),
            $this->extractCompanies($data['items']),
            $this->extractStringOrNull('nextLink', $data),
            $this->extractStringOrNull('previousLink', $data)
        );
    }

    /**
     * @return Company[]
     */
    private function extractCompanies(array $data): array
    {
        $companies = [];

        foreach ($data  as $company) {
            $companies[] = $this->companyFactory->fromArray($company);
        }

        return $companies;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Werkspot\KvkApi\Client\Factory;
6
7		use Werkspot\KvkApi\Client\Factory\Profile\CompanyFactoryInterface;
8		use Werkspot\KvkApi\Client\KvkPaginator;
9		use Werkspot\KvkApi\Client\KvkPaginatorInterface;
10		use Werkspot\KvkApi\Client\Profile\Company;
11
12		final class KvkPaginatorFactory extends AbstractFactory implements KvkPaginatorFactoryInterface
13		{
14		/**
15		* @var CompanyFactoryInterface
16		*/
17		private $companyFactory;
18
19	19	public function __construct(CompanyFactoryInterface $companyFactory)
20		{
21	19	$this->companyFactory = $companyFactory;
22	19	}
23
24	17	public function fromProfileData(array $data): KvkPaginatorInterface
25		{
26	17	return new KvkPaginator(
27	17	$this->extractIntegerOrNull('itemsPerPage', $data),
28	17	$this->extractIntegerOrNull('startPage', $data),
29	17	$this->extractIntegerOrNull('totalItems', $data),
30	17	$this->extractCompanies($data['items']),
31	17	$this->extractStringOrNull('nextLink', $data),
32	17	$this->extractStringOrNull('previousLink', $data)
33		);
34		}
35
36		/**
37		* @return Company[]
38		*/
39	17	private function extractCompanies(array $data): array
40		{
41	17	$companies = [];
42
43	17	foreach ($data as $company) {
44	17	$companies[] = $this->companyFactory->fromArray($company);
45		}
46
47	17	return $companies;
48		}
49		}
50

Werkspot / kvk-api

Pull Request — master (#8)

KvkPaginatorFactory::fromProfileData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like