Issues in AbstractEnumTest.php - Failed Issues - Inspection of "Add magic methods to enums" - Werkspot/Enum - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#5)

by Laurens

created 2017-12-07 21:41 UTC

tests/AbstractEnumTest.php (4 issues)

Labels

Documentation 4

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

namespace Werkspot\Enum\Tests;

use PHPUnit\Framework\TestCase;

final class AbstractEnumTest extends TestCase
{
    /**
     * @test
     */
    public function enum(): void
    {
        $a = TestEnum::get(TestEnum::A);
        $b = TestEnum::get(TestEnum::B);

        self::assertSame(TestEnum::A, $a->getValue());
        self::assertSame(TestEnum::B, $b->getValue());
        self::assertSame(TestEnum::A, (string) $a);
        self::assertSame(TestEnum::B, (string) $b);
    }

    /**
     * @test
     */
    public function null(): void
    {
        $nullEnum = TestEnum::get(null);
        self::assertNull($nullEnum->getValue());
        self::assertSame('', (string) $nullEnum);
    }

    /**
     * @test
     */
    public function integer(): void
    {
        $integerEnum = TestEnum::get(3);
        self::assertSame(3, $integerEnum->getValue());
        self::assertSame('3', (string) $integerEnum);
    }

    /**
     * @test
     */
    public function equalsShouldReturnTrueWhenComparingObjectsWithTheSameTypeAndValue(): void
    {
        $a = TestEnum::get(TestEnum::A);

        self::assertTrue($a->equals(TestEnum::get(TestEnum::A)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     */
    public function equalsShouldReturnFalseWhenComparingObjectsWithTheSameTypeButDifferentValue(): void
    {
        $a = TestEnum::get(TestEnum::A);

        self::assertFalse($a->equals(TestEnum::get(TestEnum::B)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     */
    public function equalsShouldReturnFalseWhenComparingObjectsWithTheSameValueButDifferentType(): void
    {
        $a = TestEnum::get(TestEnum::A);

        self::assertFalse($a->equals(Test2Enum::get(Test2Enum::A)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     */
    public function equalsShouldReturnTrueWhenComparingObjectsWithDifferentTypeAndValue(): void
    {
        $a = TestEnum::get(TestEnum::A);

        self::assertFalse($a->equals(Test2Enum::get(Test2Enum::C)));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @test
     *
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Value [anything] is not matching any valid value of class "TestEnum". Valid values are ['A', 'BEE', 1, 3, NULL, true].
     */
    public function exceptionMessage(): void
    {
        TestEnum::get('anything');
    }

    /**
     * @test
     *
     * @dataProvider getInvertedCaseOptions
     * @expectedException \InvalidArgumentException
     *
     * @param mixed $option
     */
    public function getWithInvertedCaseIsIncorrect($option): void
    {
        TestEnum::get($option);
    }

    public function getInvertedCaseOptions()
    {
        return [
            [strtolower(TestEnum::A)],
            [strtolower(TestEnum::B)],
        ];
    }

    /**
     * @test
     *
     * @expectedException \InvalidArgumentException
     */
    public function getWithStrictEqualMatchThrowsException(): void
    {
        TestEnum::get('1');
    }


    /**
     * @test
     */
    public function isShouldAllowToCallMethodsBasedOnConstantNames(): void
    {
        $enum = TestEnum::nameWithUnderscore();

        self::assertInstanceOf(TestEnum::class, $enum);
        self::assertSame(TestEnum::NAME_WITH_UNDERSCORE, $enum->getValue());
    }

    /**
     * @expectedException \BadMethodCallException
     * @expectedExceptionMessage Werkspot\Instapro\Common\Test\Unit\Enum\TestEnum::isDoesNotExist() does not exist
     */
    public function isShouldThrowAnExceptionWhenWhenCallingAnInvalidMethod(): void
    {
        TestEnum::isDoesNotExist();
    }

    /**
     * @test
     */
    public function getValidOptions(): void
    {
        self::assertSame(
            [
                TestEnum::A,
                TestEnum::B,
                TestEnum::A1,
                TestEnum::A3,
                TestEnum::ANULL,
                TestEnum::NAME_WITH_UNDERSCORE,
            ],
            TestEnum::getValidOptions()
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Werkspot\Enum\Tests;
6
7			use PHPUnit\Framework\TestCase;
8
9			final class AbstractEnumTest extends TestCase
10			{
11			/**
12			* @test
13			*/
14			public function enum(): void
15			{
16			$a = TestEnum::get(TestEnum::A);
17			$b = TestEnum::get(TestEnum::B);
18
19			self::assertSame(TestEnum::A, $a->getValue());
20			self::assertSame(TestEnum::B, $b->getValue());
21			self::assertSame(TestEnum::A, (string) $a);
22			self::assertSame(TestEnum::B, (string) $b);
23			}
24
25			/**
26			* @test
27			*/
28			public function null(): void
29			{
30			$nullEnum = TestEnum::get(null);
31			self::assertNull($nullEnum->getValue());
32			self::assertSame('', (string) $nullEnum);
33			}
34
35			/**
36			* @test
37			*/
38			public function integer(): void
39			{
40			$integerEnum = TestEnum::get(3);
41			self::assertSame(3, $integerEnum->getValue());
42			self::assertSame('3', (string) $integerEnum);
43			}
44
45			/**
46			* @test
47			*/
48			public function equalsShouldReturnTrueWhenComparingObjectsWithTheSameTypeAndValue(): void
49			{
50			$a = TestEnum::get(TestEnum::A);
51
52			self::assertTrue($a->equals(TestEnum::get(TestEnum::A)));
			1 ignored issue – show Documentation introduced 2017-12-07 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Werkspot\Enum\Tests\Tes...Enum\Tests\TestEnum::A)` is of type `object<Werkspot\Enum\Tests\TestEnum>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
53			}
54
55			/**
56			* @test
57			*/
58			public function equalsShouldReturnFalseWhenComparingObjectsWithTheSameTypeButDifferentValue(): void
59			{
60			$a = TestEnum::get(TestEnum::A);
61
62			self::assertFalse($a->equals(TestEnum::get(TestEnum::B)));
			1 ignored issue – show Documentation introduced 2017-12-07 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Werkspot\Enum\Tests\Tes...Enum\Tests\TestEnum::B)` is of type `object<Werkspot\Enum\Tests\TestEnum>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63			}
64
65			/**
66			* @test
67			*/
68			public function equalsShouldReturnFalseWhenComparingObjectsWithTheSameValueButDifferentType(): void
69			{
70			$a = TestEnum::get(TestEnum::A);
71
72			self::assertFalse($a->equals(Test2Enum::get(Test2Enum::A)));
			1 ignored issue – show Documentation introduced 2017-12-07 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Werkspot\Enum\Tests\Tes...num\Tests\Test2Enum::A)` is of type `object<Werkspot\Enum\Tests\Test2Enum>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73			}
74
75			/**
76			* @test
77			*/
78			public function equalsShouldReturnTrueWhenComparingObjectsWithDifferentTypeAndValue(): void
79			{
80			$a = TestEnum::get(TestEnum::A);
81
82			self::assertFalse($a->equals(Test2Enum::get(Test2Enum::C)));
			1 ignored issue – show Documentation introduced 2017-12-07 21:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Werkspot\Enum\Tests\Tes...num\Tests\Test2Enum::C)` is of type `object<Werkspot\Enum\Tests\Test2Enum>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
83			}
84
85			/**
86			* @test
87			*
88			* @expectedException \InvalidArgumentException
89			* @expectedExceptionMessage Value [anything] is not matching any valid value of class "TestEnum". Valid values are ['A', 'BEE', 1, 3, NULL, true].
90			*/
91			public function exceptionMessage(): void
92			{
93			TestEnum::get('anything');
94			}
95
96			/**
97			* @test
98			*
99			* @dataProvider getInvertedCaseOptions
100			* @expectedException \InvalidArgumentException
101			*
102			* @param mixed $option
103			*/
104			public function getWithInvertedCaseIsIncorrect($option): void
105			{
106			TestEnum::get($option);
107			}
108
109			public function getInvertedCaseOptions()
110			{
111			return [
112			[strtolower(TestEnum::A)],
113			[strtolower(TestEnum::B)],
114			];
115			}
116
117			/**
118			* @test
119			*
120			* @expectedException \InvalidArgumentException
121			*/
122			public function getWithStrictEqualMatchThrowsException(): void
123			{
124			TestEnum::get('1');
125			}
126
127
128			/**
129			* @test
130			*/
131			public function isShouldAllowToCallMethodsBasedOnConstantNames(): void
132			{
133			$enum = TestEnum::nameWithUnderscore();
134
135			self::assertInstanceOf(TestEnum::class, $enum);
136			self::assertSame(TestEnum::NAME_WITH_UNDERSCORE, $enum->getValue());
137			}
138
139			/**
140			* @expectedException \BadMethodCallException
141			* @expectedExceptionMessage Werkspot\Instapro\Common\Test\Unit\Enum\TestEnum::isDoesNotExist() does not exist
142			*/
143			public function isShouldThrowAnExceptionWhenWhenCallingAnInvalidMethod(): void
144			{
145			TestEnum::isDoesNotExist();
146			}
147
148			/**
149			* @test
150			*/
151			public function getValidOptions(): void
152			{
153			self::assertSame(
154			[
155			TestEnum::A,
156			TestEnum::B,
157			TestEnum::A1,
158			TestEnum::A3,
159			TestEnum::ANULL,
160			TestEnum::NAME_WITH_UNDERSCORE,
161			],
162			TestEnum::getValidOptions()
163			);
164			}
165			}
166

Werkspot / Enum

Pull Request — master (#5)

tests/AbstractEnumTest.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like