File::download() - Code Metrics - Inspection of "Tests" - Werkspot/BingAdsApiBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Laurens

created 2016-03-07 09:11 UTC

File::download() A

↳ Parent: File

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	2

<?php
namespace Werkspot\BingAdsApiBundle\Api\Helper;

use Exception;
use GuzzleHttp\ClientInterface;
use Symfony\Component\Filesystem\Filesystem;
use Werkspot\BingAdsApiBundle\Guzzle\Exceptions\CurlException;
use Werkspot\BingAdsApiBundle\Guzzle\Exceptions\HttpStatusCodeException;
use ZipArchive;

class File
{
    /**
     * @var ClientInterface
     */
    private $guzzleClient;

    /**
     * @var Filesystem
     */
    private $filesystem;

    public function __construct(ClientInterface $guzzleClient = null)
    {
        $this->guzzleClient = $guzzleClient;
        $this->filesystem = new Filesystem();
    }

    /**
     * @param $source
     * @param null|string $destination
     *
     * @throws \Exception
     *
     * @return bool|string
     */
    public function getFile($source, $destination = null)
    {
        if (preg_match('/^((https?)\:\/\/)?([a-z0-9-.]*)\.([a-z]{2,255})(\:[0-9]{2,5})?(\/([a-z0-9+$_-]\.?)+)*\/?(\?[a-z+&$_.-][a-z0-9;:@&%=+\/$_.-]*)?(#[a-z_.-][a-z0-9+$_.-]*)?$/', $source)) {
            if (!$destination) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                throw new \Exception('No file destination given.');
            }
            $destination = $this->download($source, $destination);
        } else {
            if ($destination) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $this->filesystem->copy($source, $destination);
            } else {
                $destination = $source;
            }
        }

        if (!$this->filesystem->exists($destination)) {
            return false;
        }

        return $destination;
    }

    /**
     * @param string $url
     * @param string $destination
     *
     * @throws CurlException
     * @throws HttpStatusCodeException
     * @throws \Exception
     *
     * @return string
     */
    public function download($url, $destination)
    {
        $this->guzzleClient->request('GET', $url, ['sink' => $destination]);

        return $destination;
    }

    /**
     * @param string $file zipFile we want to open
     * @param null|string $extractTo
     * @param true|bool $delete
     *
     * @throws Exception
     *
     * @return array
     */
    public function unZip($file, $extractTo = null, $delete = true)
    {
        $zipDir = ($extractTo) ? $extractTo : dirname($file);
        $zip = new ZipArchive();
        if ($zip->open($file) !== true) {
            throw new Exception("Could not open file {$file}");
        }
        $files = [];
        for ($i = 0; $i < $zip->numFiles; ++$i) {
            $stat = $zip->statIndex($i);
            $files[] = "{$zipDir}/{$stat['name']}";
        }
        $zip->extractTo($zipDir);
        $zip->close();
        if ($delete) {
            $this->filesystem->remove($file);
        }

        return $files;
    }
}


1			<?php
2			namespace Werkspot\BingAdsApiBundle\Api\Helper;
3
4			use Exception;
5			use GuzzleHttp\ClientInterface;
6			use Symfony\Component\Filesystem\Filesystem;
7			use Werkspot\BingAdsApiBundle\Guzzle\Exceptions\CurlException;
8			use Werkspot\BingAdsApiBundle\Guzzle\Exceptions\HttpStatusCodeException;
9			use ZipArchive;
10
11			class File
12			{
13			/**
14			* @var ClientInterface
15			*/
16			private $guzzleClient;
17
18			/**
19			* @var Filesystem
20			*/
21			private $filesystem;
22
23			public function __construct(ClientInterface $guzzleClient = null)
24			{
25			$this->guzzleClient = $guzzleClient;
26			$this->filesystem = new Filesystem();
27			}
28
29			/**
30			* @param $source
31			* @param null\|string $destination
32			*
33			* @throws \Exception
34			*
35			* @return bool\|string
36			*/
37			public function getFile($source, $destination = null)
38			{
39			if (preg_match('/^((https?)\:\/\/)?([a-z0-9-.])\.([a-z]{2,255})(\:[0-9]{2,5})?(\/([a-z0-9+$_-]\.?)+)\/?(\?[a-z+&$_.-][a-z0-9;:@&%=+\/$_.-])?(#[a-z_.-][a-z0-9+$_.-])?$/', $source)) {
40			if (!$destination) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-04 15:16 UTC by Report Bug Copy Issue Report The expression `$destination` of type `null\|string` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
41			throw new \Exception('No file destination given.');
42			}
43			$destination = $this->download($source, $destination);
44			} else {
45			if ($destination) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-04 15:16 UTC by Report Bug Copy Issue Report The expression `$destination` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
46			$this->filesystem->copy($source, $destination);
47			} else {
48			$destination = $source;
49			}
50			}
51
52			if (!$this->filesystem->exists($destination)) {
53			return false;
54			}
55
56			return $destination;
57			}
58
59			/**
60			* @param string $url
61			* @param string $destination
62			*
63			* @throws CurlException
64			* @throws HttpStatusCodeException
65			* @throws \Exception
66			*
67			* @return string
68			*/
69			public function download($url, $destination)
70			{
71			$this->guzzleClient->request('GET', $url, ['sink' => $destination]);
72
73			return $destination;
74			}
75
76			/**
77			* @param string $file zipFile we want to open
78			* @param null\|string $extractTo
79			* @param true\|bool $delete
80			*
81			* @throws Exception
82			*
83			* @return array
84			*/
85			public function unZip($file, $extractTo = null, $delete = true)
86			{
87			$zipDir = ($extractTo) ? $extractTo : dirname($file);
88			$zip = new ZipArchive();
89			if ($zip->open($file) !== true) {
90			throw new Exception("Could not open file {$file}");
91			}
92			$files = [];
93			for ($i = 0; $i < $zip->numFiles; ++$i) {
94			$stat = $zip->statIndex($i);
95			$files[] = "{$zipDir}/{$stat['name']}";
96			}
97			$zip->extractTo($zipDir);
98			$zip->close();
99			if ($delete) {
100			$this->filesystem->remove($file);
101			}
102
103			return $files;
104			}
105			}
106

Werkspot / BingAdsApiBundle

Pull Request — master (#4)

File::download() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like