Completed
Pull Request — master (#6)
by Laurens
03:01
created
Api/Client.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -210,7 +210,7 @@
 block discarded – undo
210 210
      * to request the report identifier. The identifier is used to check report generation status
211 211
      * before downloading the report.
212 212
      *
213
-     * @param mixed  $report
213
+     * @param ReportRequest  $report
214 214
      * @param string $name
215 215
      *
216 216
      * @return string ReportRequestId
Please login to merge, or discard this patch.
Tests/Api/Report/GeoLocationPerformanceReportTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -279,7 +279,7 @@
 block discarded – undo
279 279
     }
280 280
 
281 281
     /**
282
-     * @param $code
282
+     * @param integer $code
283 283
      * @return SoapFault
284 284
      */
285 285
     private function generateSoapFault($code)
Please login to merge, or discard this patch.
Api/Report/ReportInterface.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,21 +5,24 @@
 block discarded – undo
5 5
 {
6 6
     /**
7 7
      * @param string $format (See BingAds SDK documentation)
8
+     * @return void
8 9
      */
9 10
     public function setFormat($format);
10 11
 
11 12
     /**
12 13
      * @param bool $returnOnlyCompleteData
14
+    * @return void
13 15
     */
14 16
     public function setReturnOnlyCompleteData($returnOnlyCompleteData);
15 17
 
16 18
     /**
17 19
     * @param string $language (See BingAds SDK documentation)
20
+    * @return void
18 21
     */
19 22
     public function setReportLanguage($language);
20 23
 
21 24
     /**
22
-     * @return mixed
25
+     * @return \BingAds\Reporting\ReportRequest
23 26
      */
24 27
     public function getRequest();
25 28
 }
Please login to merge, or discard this patch.
Tests/Api/ClientTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -112,6 +112,8 @@  discard block
 block discarded – undo
112 112
      * @var int $code
113 113
      * @var null|string $type
114 114
      *
115
+     * @param integer $code
116
+     * @param string $type
115 117
      * @return MockInterface
116 118
      */
117 119
     private function runClientSoapException($code, $type = null)
@@ -172,6 +174,10 @@  discard block
 block discarded – undo
172 174
         return $apiClient;
173 175
     }
174 176
 
177
+    /**
178
+     * @param integer $code
179
+     * @param string $type
180
+     */
175 181
     private function generateSoapFault($code, $type = null)
176 182
     {
177 183
         $message = "an error message {$code}";
Please login to merge, or discard this patch.