Configuration - Code Metrics - WellCommerce/WellCommerce - Measure and Improve Code Quality continuously with Scrutinizer

Configuration A
last analyzed 2017-07-29 22:12 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	3
dl	0
loc	31
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfigTreeBuilder()	0	8	1
A	processConfiguration()	0	17	1

<?php

/*
 * This file is part of the Ivory Lucene Search package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace WellCommerce\Bundle\CatalogBundle\DependencyInjection;

use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\ConfigurationInterface;

/**
 * Class Configuration
 *
 * @author  Adam Piotrowski <[email protected]>
 */
class Configuration implements ConfigurationInterface
{
    public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder();
        $rootNode    = $treeBuilder->root('well_commerce_catalog');
        $this->processConfiguration($rootNode);

        return $treeBuilder;
    }

    //@formatter:off
    protected function processConfiguration(ArrayNodeDefinition $node)
    {
        $node
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->children()
                ->arrayNode('filters')
                    ->useAttributeAsKey('name')
                    ->prototype('array')
                        ->children()
                            ->scalarNode('type')->isRequired()->end()
                            ->scalarNode('condition')->isRequired()->end()
                            ->booleanNode('enabled')->isRequired()->end()
                            ->scalarNode('column')->isRequired()->end()
                        ->end()
                    ->end()
                ->end()
            ->end();
    }
    //@formatter:on
}


1			<?php
2
3			/*
4			* This file is part of the Ivory Lucene Search package.
5			*
6			* (c) Eric GELOEN <[email protected]>
7			*
8			* For the full copyright and license information, please read the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace WellCommerce\Bundle\CatalogBundle\DependencyInjection;
13
14			use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
15			use Symfony\Component\Config\Definition\Builder\TreeBuilder;
16			use Symfony\Component\Config\Definition\ConfigurationInterface;
17
18			/**
19			* Class Configuration
20			*
21			* @author Adam Piotrowski <[email protected]>
22			*/
23			class Configuration implements ConfigurationInterface
24			{
25			public function getConfigTreeBuilder()
26			{
27			$treeBuilder = new TreeBuilder();
28			$rootNode = $treeBuilder->root('well_commerce_catalog');
29			$this->processConfiguration($rootNode);
30
31			return $treeBuilder;
32			}
33
34			//@formatter:off
35			protected function processConfiguration(ArrayNodeDefinition $node)
36			{
37			$node
			0 ignored issues – show Bug introduced 2017-02-05 11:35 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Config...\Builder\NodeDefinition` as the method `children()` does only exist in the following sub-classes of `Symfony\Component\Config...\Builder\NodeDefinition`: `Symfony\Component\Config...der\ArrayNodeDefinition`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
38			->children()
39			->arrayNode('filters')
40			->useAttributeAsKey('name')
41			->prototype('array')
42			->children()
43			->scalarNode('type')->isRequired()->end()
44			->scalarNode('condition')->isRequired()->end()
45			->booleanNode('enabled')->isRequired()->end()
46			->scalarNode('column')->isRequired()->end()
47			->end()
48			->end()
49			->end()
50			->end();
51			}
52			//@formatter:on
53			}
54

WellCommerce / WellCommerce

Configuration A last analyzed 2017-07-29 22:12 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

Configuration A
last analyzed 2017-07-29 22:12 UTC