Total Complexity | 12 |
Total Lines | 91 |
Duplicated Lines | 28.57 % |
Changes | 0 |
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
21 | class ProgressBar implements IProgressBar |
||
22 | { |
||
23 | use Console; |
||
24 | |||
25 | /** |
||
26 | * @var bool |
||
27 | */ |
||
28 | protected $disabled; |
||
29 | |||
30 | /** |
||
31 | * @var CliProgressBar |
||
32 | */ |
||
33 | protected $progressBar; |
||
34 | |||
35 | /**s |
||
36 | * @var int |
||
37 | */ |
||
38 | protected $total; |
||
39 | |||
40 | /** |
||
41 | * {@inheritdoc} |
||
42 | */ |
||
43 | public function isDisabled():bool |
||
44 | { |
||
45 | if (isset($this->disabled)) { |
||
46 | return $this->disabled; |
||
47 | } |
||
48 | |||
49 | $isQuiet = $this->output->isQuiet(); |
||
50 | $noProgress = $this->input->getOption('no-progress'); |
||
51 | $noAnsi = $this->input->getOption('no-ansi'); |
||
52 | |||
53 | if ($isQuiet || $noProgress || $noAnsi) { |
||
54 | $this->disabled = true; |
||
55 | |||
56 | return true; |
||
57 | } |
||
58 | |||
59 | $this->disabled = false; |
||
60 | |||
61 | return false; |
||
62 | } |
||
63 | |||
64 | /** |
||
65 | * {@inheritdoc} |
||
66 | */ |
||
67 | public function start(int $total):IProgressBar |
||
77 | } |
||
78 | |||
79 | /** |
||
80 | * {@inheritdoc} |
||
81 | */ |
||
82 | View Code Duplication | public function progress(int $current = 0):IProgressBar |
|
1 ignored issue
–
show
|
|||
83 | { |
||
84 | if ($this->isDisabled()) { |
||
85 | return $this; |
||
86 | } |
||
87 | |||
88 | if ($current) { |
||
89 | $this->progressBar->progress($current); |
||
90 | |||
91 | return $this; |
||
92 | } |
||
93 | |||
94 | $this->progressBar->progress(); |
||
95 | |||
96 | return $this; |
||
97 | } |
||
98 | |||
99 | /** |
||
100 | * {@inheritdoc} |
||
101 | */ |
||
102 | View Code Duplication | public function end():IProgressBar |
|
112 | } |
||
113 | } |
||
114 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.