Completed
Push — trunk ( 0cdb75...7dd985 )
by Justin
13:23 queued 07:40
created
includes/CMB2_Field.php 1 patch
Spacing   +77 added lines, -77 removed lines patch added patch discarded remove patch
@@ -86,21 +86,21 @@  discard block
 block discarded – undo
86 86
 	 */
87 87
 	public function __construct( $args ) {
88 88
 
89
-		if ( ! empty( $args['group_field'] ) ) {
90
-			$this->group       = $args['group_field'];
89
+		if ( ! empty( $args[ 'group_field' ] ) ) {
90
+			$this->group       = $args[ 'group_field' ];
91 91
 			$this->object_id   = $this->group->object_id;
92 92
 			$this->object_type = $this->group->object_type;
93 93
 			$this->cmb_id      = $this->group->cmb_id;
94 94
 		} else {
95
-			$this->object_id   = isset( $args['object_id'] ) && '_' !== $args['object_id'] ? $args['object_id'] : 0;
96
-			$this->object_type = isset( $args['object_type'] ) ? $args['object_type'] : 'post';
95
+			$this->object_id   = isset( $args[ 'object_id' ] ) && '_' !== $args[ 'object_id' ] ? $args[ 'object_id' ] : 0;
96
+			$this->object_type = isset( $args[ 'object_type' ] ) ? $args[ 'object_type' ] : 'post';
97 97
 
98
-			if ( isset( $args['cmb_id'] ) ) {
99
-				$this->cmb_id = $args['cmb_id'];
98
+			if ( isset( $args[ 'cmb_id' ] ) ) {
99
+				$this->cmb_id = $args[ 'cmb_id' ];
100 100
 			}
101 101
 		}
102 102
 
103
-		$this->args = $this->_set_field_defaults( $args['field_args'], $args );
103
+		$this->args = $this->_set_field_defaults( $args[ 'field_args' ], $args );
104 104
 
105 105
 		if ( $this->object_id ) {
106 106
 			$this->value = $this->get_data();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 	 * @return mixed             Value of field argument
116 116
 	 */
117 117
 	public function __call( $name, $arguments ) {
118
-		$key = isset( $arguments[0] ) ? $arguments[0] : false;
118
+		$key = isset( $arguments[ 0 ] ) ? $arguments[ 0 ] : false;
119 119
 		return $this->args( $name, $key );
120 120
 	}
121 121
 
@@ -186,9 +186,9 @@  discard block
 block discarded – undo
186 186
 	 */
187 187
 	public function get_data( $field_id = '', $args = array() ) {
188 188
 		if ( $field_id ) {
189
-			$args['field_id'] = $field_id;
189
+			$args[ 'field_id' ] = $field_id;
190 190
 		} else if ( $this->group ) {
191
-			$args['field_id'] = $this->group->id();
191
+			$args[ 'field_id' ] = $this->group->id();
192 192
 		}
193 193
 
194 194
 		$a = $this->data_args( $args );
@@ -229,13 +229,13 @@  discard block
 block discarded – undo
229 229
 		 *
230 230
 		 * @since 2.0.0
231 231
 		 */
232
-		$data = apply_filters( "cmb2_override_{$a['field_id']}_meta_value", $data, $this->object_id, $a, $this );
232
+		$data = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_value", $data, $this->object_id, $a, $this );
233 233
 
234 234
 		// If no override, get value normally
235 235
 		if ( 'cmb2_field_no_override_val' === $data ) {
236
-			$data = 'options-page' === $a['type']
237
-				? cmb2_options( $a['id'] )->get( $a['field_id'] )
238
-				: get_metadata( $a['type'], $a['id'], $a['field_id'], ( $a['single'] || $a['repeat'] ) );
236
+			$data = 'options-page' === $a[ 'type' ]
237
+				? cmb2_options( $a[ 'id' ] )->get( $a[ 'field_id' ] )
238
+				: get_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], ( $a[ 'single' ] || $a[ 'repeat' ] ) );
239 239
 		}
240 240
 
241 241
 		if ( $this->group ) {
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 	public function update_data( $new_value, $single = true ) {
258 258
 		$a = $this->data_args( array( 'single' => $single ) );
259 259
 
260
-		$a['value'] = $a['repeat'] ? array_values( $new_value ) : $new_value;
260
+		$a[ 'value' ] = $a[ 'repeat' ] ? array_values( $new_value ) : $new_value;
261 261
 
262 262
 		/**
263 263
 		 * Filter whether to override saving of meta value.
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 		 *
294 294
 		 * @since 2.0.0
295 295
 		 */
296
-		$override = apply_filters( "cmb2_override_{$a['field_id']}_meta_save", $override, $a, $this->args(), $this );
296
+		$override = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_save", $override, $a, $this->args(), $this );
297 297
 
298 298
 		// If override, return that
299 299
 		if ( null !== $override ) {
@@ -301,22 +301,22 @@  discard block
 block discarded – undo
301 301
 		}
302 302
 
303 303
 		// Options page handling (or temp data store)
304
-		if ( 'options-page' === $a['type'] || empty( $a['id'] ) ) {
305
-			return cmb2_options( $a['id'] )->update( $a['field_id'], $a['value'], false, $a['single'] );
304
+		if ( 'options-page' === $a[ 'type' ] || empty( $a[ 'id' ] ) ) {
305
+			return cmb2_options( $a[ 'id' ] )->update( $a[ 'field_id' ], $a[ 'value' ], false, $a[ 'single' ] );
306 306
 		}
307 307
 
308 308
 		// Add metadata if not single
309
-		if ( ! $a['single'] ) {
310
-			return add_metadata( $a['type'], $a['id'], $a['field_id'], $a['value'], false );
309
+		if ( ! $a[ 'single' ] ) {
310
+			return add_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $a[ 'value' ], false );
311 311
 		}
312 312
 
313 313
 		// Delete meta if we have an empty array
314
-		if ( is_array( $a['value'] ) && empty( $a['value'] ) ) {
315
-			return delete_metadata( $a['type'], $a['id'], $a['field_id'], $this->value );
314
+		if ( is_array( $a[ 'value' ] ) && empty( $a[ 'value' ] ) ) {
315
+			return delete_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $this->value );
316 316
 		}
317 317
 
318 318
 		// Update metadata
319
-		return update_metadata( $a['type'], $a['id'], $a['field_id'], $a['value'] );
319
+		return update_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $a[ 'value' ] );
320 320
 	}
321 321
 
322 322
 	/**
@@ -366,19 +366,19 @@  discard block
 block discarded – undo
366 366
 		 * @param array $field_args All field arguments
367 367
 		 * @param CMB2_Field object $field This field object
368 368
 		 */
369
-		$override = apply_filters( "cmb2_override_{$a['field_id']}_meta_remove", $override, $a, $this->args(), $this );
369
+		$override = apply_filters( "cmb2_override_{$a[ 'field_id' ]}_meta_remove", $override, $a, $this->args(), $this );
370 370
 
371 371
 		// If no override, remove as usual
372 372
 		if ( null !== $override ) {
373 373
 			return $override;
374 374
 		}
375 375
 		// Option page handling
376
-		elseif ( 'options-page' === $a['type'] || empty( $a['id'] ) ) {
377
-			return cmb2_options( $a['id'] )->remove( $a['field_id'] );
376
+		elseif ( 'options-page' === $a[ 'type' ] || empty( $a[ 'id' ] ) ) {
377
+			return cmb2_options( $a[ 'id' ] )->remove( $a[ 'field_id' ] );
378 378
 		}
379 379
 
380 380
 		// Remove metadata
381
-		return delete_metadata( $a['type'], $a['id'], $a['field_id'], $old );
381
+		return delete_metadata( $a[ 'type' ], $a[ 'id' ], $a[ 'field_id' ], $old );
382 382
 	}
383 383
 
384 384
 	/**
@@ -829,7 +829,7 @@  discard block
 block discarded – undo
829 829
 
830 830
 		foreach ( $conditional_classes as $class => $condition ) {
831 831
 			if ( $condition ) {
832
-				$classes[] = $class;
832
+				$classes[ ] = $class;
833 833
 			}
834 834
 		}
835 835
 
@@ -841,7 +841,7 @@  discard block
 block discarded – undo
841 841
 
842 842
 
843 843
 		if ( $added_classes ) {
844
-			$classes[] = esc_attr( $added_classes );
844
+			$classes[ ] = esc_attr( $added_classes );
845 845
 		}
846 846
 
847 847
 		/**
@@ -941,10 +941,10 @@  discard block
 block discarded – undo
941 941
 	public function string( $text_key, $fallback ) {
942 942
 		// If null, populate with our field strings values.
943 943
 		if ( null === $this->strings ) {
944
-			$this->strings = (array) $this->args['text'];
944
+			$this->strings = (array) $this->args[ 'text' ];
945 945
 
946
-			if ( is_callable( $this->args['text_cb'] ) ) {
947
-				$strings = call_user_func( $this->args['text_cb'], $this );
946
+			if ( is_callable( $this->args[ 'text_cb' ] ) ) {
947
+				$strings = call_user_func( $this->args[ 'text_cb' ], $this );
948 948
 
949 949
 				if ( $strings && is_array( $strings ) ) {
950 950
 					$this->strings += $strings;
@@ -978,10 +978,10 @@  discard block
 block discarded – undo
978 978
 			return $this->field_options;
979 979
 		}
980 980
 
981
-		$this->field_options = (array) $this->args['options'];
981
+		$this->field_options = (array) $this->args[ 'options' ];
982 982
 
983
-		if ( is_callable( $this->args['options_cb'] ) ) {
984
-			$options = call_user_func( $this->args['options_cb'], $this );
983
+		if ( is_callable( $this->args[ 'options_cb' ] ) ) {
984
+			$options = call_user_func( $this->args[ 'options_cb' ], $this );
985 985
 
986 986
 			if ( $options && is_array( $options ) ) {
987 987
 				$this->field_options = $options + $this->field_options;
@@ -1003,17 +1003,17 @@  discard block
 block discarded – undo
1003 1003
 	 * @return mixed  Default field value
1004 1004
 	 */
1005 1005
 	public function get_default() {
1006
-		if ( null !== $this->args['default'] ) {
1007
-			return $this->args['default'];
1006
+		if ( null !== $this->args[ 'default' ] ) {
1007
+			return $this->args[ 'default' ];
1008 1008
 		}
1009 1009
 
1010
-		$param = is_callable( $this->args['default_cb'] ) ? 'default_cb' : 'default';
1010
+		$param = is_callable( $this->args[ 'default_cb' ] ) ? 'default_cb' : 'default';
1011 1011
 		$default = $this->get_param_callback_result( $param );
1012 1012
 
1013 1013
 		// Allow a filter override of the default value
1014
-		$this->args['default'] = apply_filters( 'cmb2_default_filter', $default, $this );
1014
+		$this->args[ 'default' ] = apply_filters( 'cmb2_default_filter', $default, $this );
1015 1015
 
1016
-		return $this->args['default'];
1016
+		return $this->args[ 'default' ];
1017 1017
 	}
1018 1018
 
1019 1019
 	/**
@@ -1051,18 +1051,18 @@  discard block
 block discarded – undo
1051 1051
 			'classes_cb'        => '',
1052 1052
 			'select_all_button' => true,
1053 1053
 			'multiple'          => false,
1054
-			'repeatable'        => isset( $args['type'] ) && 'group' == $args['type'],
1054
+			'repeatable'        => isset( $args[ 'type' ] ) && 'group' == $args[ 'type' ],
1055 1055
 			'inline'            => false,
1056 1056
 			'on_front'          => true,
1057 1057
 			'show_names'        => true,
1058 1058
 			'save_field'        => true, // Will not save if false
1059 1059
 			'date_format'       => 'm\/d\/Y',
1060 1060
 			'time_format'       => 'h:i A',
1061
-			'description'       => isset( $args['desc'] ) ? $args['desc'] : '',
1062
-			'preview_size'      => 'file' == $args['type'] ? array( 350, 350 ) : array( 50, 50 ),
1061
+			'description'       => isset( $args[ 'desc' ] ) ? $args[ 'desc' ] : '',
1062
+			'preview_size'      => 'file' == $args[ 'type' ] ? array( 350, 350 ) : array( 50, 50 ),
1063 1063
 			'render_row_cb'     => array( $this, 'render_field_callback' ),
1064 1064
 			'display_cb'        => array( $this, 'display_value_callback' ),
1065
-			'label_cb'          => 'title' != $args['type'] ? array( $this, 'label' ) : '',
1065
+			'label_cb'          => 'title' != $args[ 'type' ] ? array( $this, 'label' ) : '',
1066 1066
 			'column'            => false,
1067 1067
 		) );
1068 1068
 
@@ -1070,73 +1070,73 @@  discard block
 block discarded – undo
1070 1070
 		 * Deprecated usage.
1071 1071
 		 */
1072 1072
 
1073
-		if ( isset( $args['row_classes'] ) ) {
1073
+		if ( isset( $args[ 'row_classes' ] ) ) {
1074 1074
 
1075 1075
 			// row_classes param could be a callback
1076
-			if ( is_callable( $args['row_classes'] ) ) {
1077
-				$args['classes_cb'] = $args['row_classes'];
1078
-				$args['classes'] = null;
1076
+			if ( is_callable( $args[ 'row_classes' ] ) ) {
1077
+				$args[ 'classes_cb' ] = $args[ 'row_classes' ];
1078
+				$args[ 'classes' ] = null;
1079 1079
 			} else {
1080
-				$args['classes'] = $args['row_classes'];
1080
+				$args[ 'classes' ] = $args[ 'row_classes' ];
1081 1081
 			}
1082 1082
 
1083
-			unset( $args['row_classes'] );
1083
+			unset( $args[ 'row_classes' ] );
1084 1084
 		}
1085 1085
 
1086 1086
 		// default param can be passed a callback as well
1087
-		if ( is_callable( $args['default'] ) ) {
1088
-			$args['default_cb'] = $args['default'];
1089
-			$args['default'] = null;
1087
+		if ( is_callable( $args[ 'default' ] ) ) {
1088
+			$args[ 'default_cb' ] = $args[ 'default' ];
1089
+			$args[ 'default' ] = null;
1090 1090
 		}
1091 1091
 
1092 1092
 		/*
1093 1093
 		 * END deprecated usage.
1094 1094
 		 */
1095 1095
 
1096
-		$args['repeatable'] = $args['repeatable'] && ! $this->repeatable_exception( $args['type'] );
1097
-		$args['inline']     = $args['inline'] || false !== stripos( $args['type'], '_inline' );
1096
+		$args[ 'repeatable' ] = $args[ 'repeatable' ] && ! $this->repeatable_exception( $args[ 'type' ] );
1097
+		$args[ 'inline' ]     = $args[ 'inline' ] || false !== stripos( $args[ 'type' ], '_inline' );
1098 1098
 
1099 1099
 		// options param can be passed a callback as well
1100
-		if ( is_callable( $args['options'] ) ) {
1101
-			$args['options_cb'] = $args['options'];
1102
-			$args['options'] = array();
1100
+		if ( is_callable( $args[ 'options' ] ) ) {
1101
+			$args[ 'options_cb' ] = $args[ 'options' ];
1102
+			$args[ 'options' ] = array();
1103 1103
 		}
1104 1104
 
1105
-		$args['options']    = 'group' == $args['type'] ? wp_parse_args( $args['options'], array(
1105
+		$args[ 'options' ] = 'group' == $args[ 'type' ] ? wp_parse_args( $args[ 'options' ], array(
1106 1106
 			'add_button'    => __( 'Add Group', 'cmb2' ),
1107 1107
 			'remove_button' => __( 'Remove Group', 'cmb2' ),
1108
-		) ) : $args['options'];
1108
+		) ) : $args[ 'options' ];
1109 1109
 
1110
-		$args['_id']        = $args['id'];
1111
-		$args['_name']      = $args['id'];
1110
+		$args[ '_id' ]        = $args[ 'id' ];
1111
+		$args[ '_name' ]      = $args[ 'id' ];
1112 1112
 
1113 1113
 		if ( $this->group ) {
1114 1114
 
1115
-			$args['id']    = $this->group->args( 'id' ) . '_' . $this->group->index . '_' . $args['id'];
1116
-			$args['_name'] = $this->group->args( 'id' ) . '[' . $this->group->index . '][' . $args['_name'] . ']';
1115
+			$args[ 'id' ]    = $this->group->args( 'id' ) . '_' . $this->group->index . '_' . $args[ 'id' ];
1116
+			$args[ '_name' ] = $this->group->args( 'id' ) . '[' . $this->group->index . '][' . $args[ '_name' ] . ']';
1117 1117
 		}
1118 1118
 
1119
-		if ( 'wysiwyg' == $args['type'] ) {
1120
-			$args['id'] = strtolower( str_ireplace( '-', '_', $args['id'] ) );
1121
-			$args['options']['textarea_name'] = $args['_name'];
1119
+		if ( 'wysiwyg' == $args[ 'type' ] ) {
1120
+			$args[ 'id' ] = strtolower( str_ireplace( '-', '_', $args[ 'id' ] ) );
1121
+			$args[ 'options' ][ 'textarea_name' ] = $args[ '_name' ];
1122 1122
 		}
1123 1123
 
1124 1124
 		$option_types = apply_filters( 'cmb2_all_or_nothing_types', array( 'select', 'radio', 'radio_inline', 'taxonomy_select', 'taxonomy_radio', 'taxonomy_radio_inline' ), $this );
1125 1125
 
1126
-		if ( in_array( $args['type'], $option_types, true ) ) {
1126
+		if ( in_array( $args[ 'type' ], $option_types, true ) ) {
1127 1127
 
1128
-			$args['show_option_none'] = isset( $args['show_option_none'] ) ? $args['show_option_none'] : null;
1129
-			$args['show_option_none'] = true === $args['show_option_none'] ? __( 'None', 'cmb2' ) : $args['show_option_none'];
1128
+			$args[ 'show_option_none' ] = isset( $args[ 'show_option_none' ] ) ? $args[ 'show_option_none' ] : null;
1129
+			$args[ 'show_option_none' ] = true === $args[ 'show_option_none' ] ? __( 'None', 'cmb2' ) : $args[ 'show_option_none' ];
1130 1130
 
1131
-			if ( null === $args['show_option_none'] ) {
1132
-				$off_by_default = in_array( $args['type'], array( 'select', 'radio', 'radio_inline' ), true );
1133
-				$args['show_option_none'] = $off_by_default ? false : __( 'None', 'cmb2' );
1131
+			if ( null === $args[ 'show_option_none' ] ) {
1132
+				$off_by_default = in_array( $args[ 'type' ], array( 'select', 'radio', 'radio_inline' ), true );
1133
+				$args[ 'show_option_none' ] = $off_by_default ? false : __( 'None', 'cmb2' );
1134 1134
 			}
1135 1135
 
1136 1136
 		}
1137 1137
 
1138
-		$args['has_supporting_data'] = in_array(
1139
-			$args['type'],
1138
+		$args[ 'has_supporting_data' ] = in_array(
1139
+			$args[ 'type' ],
1140 1140
 			array(
1141 1141
 				// CMB2_Sanitize::_save_file_id_value()/CMB2_Sanitize::_get_group_file_value_array()
1142 1142
 				'file',
@@ -1159,10 +1159,10 @@  discard block
 block discarded – undo
1159 1159
 	protected function get_default_args( $field_args, $field_group = null ) {
1160 1160
 		$args = parent::get_default_args( array(), $this->group );
1161 1161
 
1162
-		if ( isset( $field_args['field_args'] ) ) {
1162
+		if ( isset( $field_args[ 'field_args' ] ) ) {
1163 1163
 			$args = wp_parse_args( $field_args, $args );
1164 1164
 		} else {
1165
-			$args['field_args'] = wp_parse_args( $field_args, $this->args );
1165
+			$args[ 'field_args' ] = wp_parse_args( $field_args, $this->args );
1166 1166
 		}
1167 1167
 
1168 1168
 		return $args;
Please login to merge, or discard this patch.
includes/CMB2_Types.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -170,11 +170,11 @@  discard block
 block discarded – undo
170 170
 
171 171
 		$message = array( sprintf( __( 'Custom field types require a Type object instantiation to use this method. This method was called by the \'%s\' field type.' ), $this->field->type() ) );
172 172
 
173
-		$message[] = is_object( $this->type )
173
+		$message[ ] = is_object( $this->type )
174 174
 			? __( 'That field type may not work as expected.', 'cmb2' )
175 175
 			: __( 'That field type will not work as expected.', 'cmb2' );
176 176
 
177
-		$message[] = __( 'See: https://github.com/mustardBees/cmb-field-select2/pull/34w for more information about this change.', 'cmb2' );
177
+		$message[ ] = __( 'See: https://github.com/mustardBees/cmb-field-select2/pull/34w for more information about this change.', 'cmb2' );
178 178
 
179 179
 		_doing_it_wrong( __CLASS__ . '::' . $method, implode( ' ', $message ), '2.2.2' );
180 180
 	}
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
 	 * @return string               String of attributes for form element
219 219
 	 */
220 220
 	public function concat_attrs( $attrs, $attr_exclude = array() ) {
221
-		$attr_exclude[] = 'rendered';
221
+		$attr_exclude[ ] = 'rendered';
222 222
 		$attributes = '';
223 223
 		foreach ( $attrs as $attr => $val ) {
224 224
 			$excluded = in_array( $attr, (array) $attr_exclude, true );
@@ -405,8 +405,8 @@  discard block
 block discarded – undo
405 405
 			'class' => 'cmb2-hidden',
406 406
 		);
407 407
 		if ( $this->field->group ) {
408
-			$args['data-groupid'] = $this->field->group->id();
409
-			$args['data-iterator'] = $this->iterator;
408
+			$args[ 'data-groupid' ] = $this->field->group->id();
409
+			$args[ 'data-iterator' ] = $this->iterator;
410 410
 		}
411 411
 		return $this->input( $args );
412 412
 	}
Please login to merge, or discard this patch.
includes/CMB2.php 1 patch
Spacing   +67 added lines, -67 removed lines patch added patch discarded remove patch
@@ -104,19 +104,19 @@  discard block
 block discarded – undo
104 104
 	 */
105 105
 	public function __construct( $config, $object_id = 0 ) {
106 106
 
107
-		if ( empty( $config['id'] ) ) {
107
+		if ( empty( $config[ 'id' ] ) ) {
108 108
 			wp_die( __( 'Metabox configuration is required to have an ID parameter', 'cmb2' ) );
109 109
 		}
110 110
 
111 111
 		$this->meta_box = wp_parse_args( $config, $this->mb_defaults );
112
-		$this->meta_box['fields'] = array();
112
+		$this->meta_box[ 'fields' ] = array();
113 113
 
114 114
 		$this->object_id( $object_id );
115 115
 		$this->mb_object_type();
116
-		$this->cmb_id = $config['id'];
116
+		$this->cmb_id = $config[ 'id' ];
117 117
 
118
-		if ( ! empty( $config['fields'] ) && is_array( $config['fields'] ) ) {
119
-			$this->add_fields( $config['fields'] );
118
+		if ( ! empty( $config[ 'fields' ] ) && is_array( $config[ 'fields' ] ) ) {
119
+			$this->add_fields( $config[ 'fields' ] );
120 120
 		}
121 121
 
122 122
 		CMB2_Boxes::add( $this );
@@ -285,22 +285,22 @@  discard block
 block discarded – undo
285 285
 	 * @return mixed CMB2_Field object if successful.
286 286
 	 */
287 287
 	public function render_field( $field_args ) {
288
-		$field_args['context'] = $this->prop( 'context' );
288
+		$field_args[ 'context' ] = $this->prop( 'context' );
289 289
 
290
-		if ( 'group' == $field_args['type'] ) {
290
+		if ( 'group' == $field_args[ 'type' ] ) {
291 291
 
292
-			if ( ! isset( $field_args['show_names'] ) ) {
293
-				$field_args['show_names'] = $this->prop( 'show_names' );
292
+			if ( ! isset( $field_args[ 'show_names' ] ) ) {
293
+				$field_args[ 'show_names' ] = $this->prop( 'show_names' );
294 294
 			}
295 295
 			$field = $this->render_group( $field_args );
296 296
 
297
-		} elseif ( 'hidden' == $field_args['type'] && $this->get_field( $field_args )->should_show() ) {
297
+		} elseif ( 'hidden' == $field_args[ 'type' ] && $this->get_field( $field_args )->should_show() ) {
298 298
 			// Save rendering for after the metabox
299 299
 			$field = $this->add_hidden_field( $field_args );
300 300
 
301 301
 		} else {
302 302
 
303
-			$field_args['show_names'] = $this->prop( 'show_names' );
303
+			$field_args[ 'show_names' ] = $this->prop( 'show_names' );
304 304
 
305 305
 			// Render default fields
306 306
 			$field = $this->get_field( $field_args )->render_field();
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 	 */
317 317
 	public function render_group( $args ) {
318 318
 
319
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
319
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
320 320
 			return;
321 321
 		}
322 322
 
@@ -398,15 +398,15 @@  discard block
 block discarded – undo
398 398
 			<div class="inside cmb-td cmb-nested cmb-field-list">';
399 399
 				// Loop and render repeatable group fields
400 400
 				foreach ( array_values( $field_group->args( 'fields' ) ) as $field_args ) {
401
-					if ( 'hidden' == $field_args['type'] ) {
401
+					if ( 'hidden' == $field_args[ 'type' ] ) {
402 402
 
403 403
 						// Save rendering for after the metabox
404 404
 						$this->add_hidden_field( $field_args, $field_group );
405 405
 
406 406
 					} else {
407 407
 
408
-						$field_args['show_names'] = $field_group->args( 'show_names' );
409
-						$field_args['context']    = $field_group->args( 'context' );
408
+						$field_args[ 'show_names' ] = $field_group->args( 'show_names' );
409
+						$field_args[ 'context' ]    = $field_group->args( 'context' );
410 410
 
411 411
 						$field = $this->get_field( $field_args, $field_group )->render_field();
412 412
 					}
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
 	 * @param array  $field_args Array of field arguments to be passed to CMB2_Field
435 435
 	 */
436 436
 	public function add_hidden_field( $field_args, $field_group = null ) {
437
-		if ( isset( $field_args['field_args'] ) ) {
437
+		if ( isset( $field_args[ 'field_args' ] ) ) {
438 438
 			// For back-compatibility.
439 439
 			$field = new CMB2_Field( $field_args );
440 440
 		} else {
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
 			$type->iterator = $field_group->index;
448 448
 		}
449 449
 
450
-		$this->hidden_fields[] = $type;
450
+		$this->hidden_fields[ ] = $type;
451 451
 
452 452
 		return $field;
453 453
 	}
@@ -544,11 +544,11 @@  discard block
 block discarded – undo
544 544
 	 */
545 545
 	public function process_field( $field_args ) {
546 546
 
547
-		switch ( $field_args['type'] ) {
547
+		switch ( $field_args[ 'type' ] ) {
548 548
 
549 549
 			case 'group':
550 550
 				if ( $this->save_group( $field_args ) ) {
551
-					$this->updated[] = $field_args['id'];
551
+					$this->updated[ ] = $field_args[ 'id' ];
552 552
 				}
553 553
 
554 554
 				break;
@@ -562,7 +562,7 @@  discard block
 block discarded – undo
562 562
 				$field = $this->get_new_field( $field_args );
563 563
 
564 564
 				if ( $field->save_field_from_data( $this->data_to_save ) ) {
565
-					$this->updated[] = $field->id();
565
+					$this->updated[ ] = $field->id();
566 566
 				}
567 567
 
568 568
 				break;
@@ -629,7 +629,7 @@  discard block
 block discarded – undo
629 629
 	 * @return mixed        Return of CMB2_Field::update_data()
630 630
 	 */
631 631
 	public function save_group( $args ) {
632
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
632
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
633 633
 			return;
634 634
 		}
635 635
 
@@ -677,16 +677,16 @@  discard block
 block discarded – undo
677 677
 						$_new_val = array();
678 678
 						foreach ( $new_val as $group_index => $grouped_data ) {
679 679
 							// Add the supporting data to the $saved array stack
680
-							$saved[ $field_group->index ][ $grouped_data['supporting_field_id'] ][] = $grouped_data['supporting_field_value'];
680
+							$saved[ $field_group->index ][ $grouped_data[ 'supporting_field_id' ] ][ ] = $grouped_data[ 'supporting_field_value' ];
681 681
 							// Reset var to the actual value
682
-							$_new_val[ $group_index ] = $grouped_data['value'];
682
+							$_new_val[ $group_index ] = $grouped_data[ 'value' ];
683 683
 						}
684 684
 						$new_val = $_new_val;
685 685
 					} else {
686 686
 						// Add the supporting data to the $saved array stack
687
-						$saved[ $field_group->index ][ $new_val['supporting_field_id'] ] = $new_val['supporting_field_value'];
687
+						$saved[ $field_group->index ][ $new_val[ 'supporting_field_id' ] ] = $new_val[ 'supporting_field_value' ];
688 688
 						// Reset var to the actual value
689
-						$new_val = $new_val['value'];
689
+						$new_val = $new_val[ 'value' ];
690 690
 					}
691 691
 				}
692 692
 
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
 
701 701
 				// Compare values and add to `$updated` array
702 702
 				if ( $is_updated || $is_removed ) {
703
-					$this->updated[] = $base_id . '::' . $field_group->index . '::' . $sub_id;
703
+					$this->updated[ ] = $base_id . '::' . $field_group->index . '::' . $sub_id;
704 704
 				}
705 705
 
706 706
 				// Add to `$saved` array
@@ -737,22 +737,22 @@  discard block
 block discarded – undo
737 737
 		// Try to get our object ID from the global space
738 738
 		switch ( $this->object_type() ) {
739 739
 			case 'user':
740
-				$object_id = isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id;
741
-				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS['user_ID'] ) ? $GLOBALS['user_ID'] : $object_id;
740
+				$object_id = isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id;
741
+				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS[ 'user_ID' ] ) ? $GLOBALS[ 'user_ID' ] : $object_id;
742 742
 				break;
743 743
 
744 744
 			case 'comment':
745
-				$object_id = isset( $_REQUEST['c'] ) ? $_REQUEST['c'] : $object_id;
746
-				$object_id = ! $object_id && isset( $GLOBALS['comments']->comment_ID ) ? $GLOBALS['comments']->comment_ID : $object_id;
745
+				$object_id = isset( $_REQUEST[ 'c' ] ) ? $_REQUEST[ 'c' ] : $object_id;
746
+				$object_id = ! $object_id && isset( $GLOBALS[ 'comments' ]->comment_ID ) ? $GLOBALS[ 'comments' ]->comment_ID : $object_id;
747 747
 				break;
748 748
 
749 749
 			case 'term':
750
-				$object_id = isset( $_REQUEST['tag_ID'] ) ? $_REQUEST['tag_ID'] : $object_id;
750
+				$object_id = isset( $_REQUEST[ 'tag_ID' ] ) ? $_REQUEST[ 'tag_ID' ] : $object_id;
751 751
 				break;
752 752
 
753 753
 			default:
754
-				$object_id = isset( $GLOBALS['post']->ID ) ? $GLOBALS['post']->ID : $object_id;
755
-				$object_id = isset( $_REQUEST['post'] ) ? $_REQUEST['post'] : $object_id;
754
+				$object_id = isset( $GLOBALS[ 'post' ]->ID ) ? $GLOBALS[ 'post' ]->ID : $object_id;
755
+				$object_id = isset( $_REQUEST[ 'post' ] ) ? $_REQUEST[ 'post' ] : $object_id;
756 756
 				break;
757 757
 		}
758 758
 
@@ -828,7 +828,7 @@  discard block
 block discarded – undo
828 828
 	 * @return boolean True/False
829 829
 	 */
830 830
 	public function is_options_page_mb() {
831
-		return ( isset( $this->meta_box['show_on']['key'] ) && 'options-page' === $this->meta_box['show_on']['key'] || array_key_exists( 'options-page', $this->meta_box['show_on'] ) );
831
+		return ( isset( $this->meta_box[ 'show_on' ][ 'key' ] ) && 'options-page' === $this->meta_box[ 'show_on' ][ 'key' ] || array_key_exists( 'options-page', $this->meta_box[ 'show_on' ] ) );
832 832
 	}
833 833
 
834 834
 	/**
@@ -915,7 +915,7 @@  discard block
 block discarded – undo
915 915
 			return $field;
916 916
 		}
917 917
 
918
-		$field_id = is_string( $field ) ? $field : $field['id'];
918
+		$field_id = is_string( $field ) ? $field : $field[ 'id' ];
919 919
 
920 920
 		$parent_field_id = ! empty( $field_group ) ? $field_group->id() : '';
921 921
 		$ids = $this->get_field_ids( $field_id, $parent_field_id, true );
@@ -951,16 +951,16 @@  discard block
 block discarded – undo
951 951
 		if ( $field_group && ( $sub_field_id || 0 === $sub_field_id ) ) {
952 952
 
953 953
 			// Update the fields array w/ any modified properties inherited from the group field
954
-			$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] = $field_args;
954
+			$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] = $field_args;
955 955
 
956 956
 			return $this->get_default_args( $field_args, $field_group );
957 957
 		}
958 958
 
959 959
 		if ( is_array( $field_args ) ) {
960
-			$this->meta_box['fields'][ $field_id ] = array_merge( $field_args, $this->meta_box['fields'][ $field_id ] );
960
+			$this->meta_box[ 'fields' ][ $field_id ] = array_merge( $field_args, $this->meta_box[ 'fields' ][ $field_id ] );
961 961
 		}
962 962
 
963
-		return $this->get_default_args( $this->meta_box['fields'][ $field_id ] );
963
+		return $this->get_default_args( $this->meta_box[ 'fields' ][ $field_id ] );
964 964
 	}
965 965
 
966 966
 	/**
@@ -1010,8 +1010,8 @@  discard block
 block discarded – undo
1010 1010
 
1011 1011
 			$sub_fields = false;
1012 1012
 			if ( array_key_exists( 'fields', $field ) ) {
1013
-				$sub_fields = $field['fields'];
1014
-				unset( $field['fields'] );
1013
+				$sub_fields = $field[ 'fields' ];
1014
+				unset( $field[ 'fields' ] );
1015 1015
 			}
1016 1016
 
1017 1017
 			$field_id = $parent_field_id
@@ -1036,29 +1036,29 @@  discard block
 block discarded – undo
1036 1036
 			return false;
1037 1037
 		}
1038 1038
 
1039
-		if ( 'oembed' === $field['type'] ) {
1039
+		if ( 'oembed' === $field[ 'type' ] ) {
1040 1040
 			// Initiate oembed Ajax hooks
1041 1041
 			cmb2_ajax();
1042 1042
 		}
1043 1043
 
1044
-		if ( isset( $field['column'] ) && false !== $field['column'] ) {
1044
+		if ( isset( $field[ 'column' ] ) && false !== $field[ 'column' ] ) {
1045 1045
 			$this->has_columns = true;
1046 1046
 
1047
-			$column = is_array( $field['column'] ) ? $field['column'] : array();
1047
+			$column = is_array( $field[ 'column' ] ) ? $field[ 'column' ] : array();
1048 1048
 
1049
-			$field['column'] = wp_parse_args( $column, array(
1050
-				'name'     => isset( $field['name'] ) ? $field['name'] : '',
1049
+			$field[ 'column' ] = wp_parse_args( $column, array(
1050
+				'name'     => isset( $field[ 'name' ] ) ? $field[ 'name' ] : '',
1051 1051
 				'position' => false,
1052 1052
 			) );
1053 1053
 		}
1054 1054
 
1055 1055
 		$this->_add_field_to_array(
1056 1056
 			$field,
1057
-			$this->meta_box['fields'],
1057
+			$this->meta_box[ 'fields' ],
1058 1058
 			$position
1059 1059
 		);
1060 1060
 
1061
-		return $field['id'];
1061
+		return $field[ 'id' ];
1062 1062
 	}
1063 1063
 
1064 1064
 	/**
@@ -1070,27 +1070,27 @@  discard block
 block discarded – undo
1070 1070
 	 * @return mixed                   Array of parent/field ids or false
1071 1071
 	 */
1072 1072
 	public function add_group_field( $parent_field_id, array $field, $position = 0 ) {
1073
-		if ( ! array_key_exists( $parent_field_id, $this->meta_box['fields'] ) ) {
1073
+		if ( ! array_key_exists( $parent_field_id, $this->meta_box[ 'fields' ] ) ) {
1074 1074
 			return false;
1075 1075
 		}
1076 1076
 
1077
-		$parent_field = $this->meta_box['fields'][ $parent_field_id ];
1077
+		$parent_field = $this->meta_box[ 'fields' ][ $parent_field_id ];
1078 1078
 
1079
-		if ( 'group' !== $parent_field['type'] ) {
1079
+		if ( 'group' !== $parent_field[ 'type' ] ) {
1080 1080
 			return false;
1081 1081
 		}
1082 1082
 
1083
-		if ( ! isset( $parent_field['fields'] ) ) {
1084
-			$this->meta_box['fields'][ $parent_field_id ]['fields'] = array();
1083
+		if ( ! isset( $parent_field[ 'fields' ] ) ) {
1084
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ] = array();
1085 1085
 		}
1086 1086
 
1087 1087
 		$this->_add_field_to_array(
1088 1088
 			$field,
1089
-			$this->meta_box['fields'][ $parent_field_id ]['fields'],
1089
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ],
1090 1090
 			$position
1091 1091
 		);
1092 1092
 
1093
-		return array( $parent_field_id, $field['id'] );
1093
+		return array( $parent_field_id, $field[ 'id' ] );
1094 1094
 	}
1095 1095
 
1096 1096
 	/**
@@ -1102,9 +1102,9 @@  discard block
 block discarded – undo
1102 1102
 	 */
1103 1103
 	protected function _add_field_to_array( $field, &$fields, $position = 0 ) {
1104 1104
 		if ( $position ) {
1105
-			cmb2_utils()->array_insert( $fields, array( $field['id'] => $field ), $position );
1105
+			cmb2_utils()->array_insert( $fields, array( $field[ 'id' ] => $field ), $position );
1106 1106
 		} else {
1107
-			$fields[ $field['id'] ] = $field;
1107
+			$fields[ $field[ 'id' ] ] = $field;
1108 1108
 		}
1109 1109
 	}
1110 1110
 
@@ -1127,15 +1127,15 @@  discard block
 block discarded – undo
1127 1127
 		unset( $this->fields[ implode( '', $ids ) ] );
1128 1128
 
1129 1129
 		if ( ! $sub_field_id ) {
1130
-			unset( $this->meta_box['fields'][ $field_id ] );
1130
+			unset( $this->meta_box[ 'fields' ][ $field_id ] );
1131 1131
 			return true;
1132 1132
 		}
1133 1133
 
1134
-		if ( isset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ) ) {
1135
-			unset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] );
1134
+		if ( isset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ) ) {
1135
+			unset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] );
1136 1136
 		}
1137
-		if ( isset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ) ) {
1138
-			unset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] );
1137
+		if ( isset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ) ) {
1138
+			unset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] );
1139 1139
 		}
1140 1140
 		return true;
1141 1141
 	}
@@ -1159,11 +1159,11 @@  discard block
 block discarded – undo
1159 1159
 		list( $field_id, $sub_field_id ) = $ids;
1160 1160
 
1161 1161
 		if ( ! $sub_field_id ) {
1162
-			$this->meta_box['fields'][ $field_id ][ $property ] = $value;
1162
+			$this->meta_box[ 'fields' ][ $field_id ][ $property ] = $value;
1163 1163
 			return $field_id;
1164 1164
 		}
1165 1165
 
1166
-		$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ][ $property ] = $value;
1166
+		$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ][ $property ] = $value;
1167 1167
 		return $field_id;
1168 1168
 	}
1169 1169
 
@@ -1177,7 +1177,7 @@  discard block
 block discarded – undo
1177 1177
 	public function get_field_ids( $field_id, $parent_field_id = '' ) {
1178 1178
 		$sub_field_id = $parent_field_id ? $field_id : '';
1179 1179
 		$field_id     = $parent_field_id ? $parent_field_id : $field_id;
1180
-		$fields       =& $this->meta_box['fields'];
1180
+		$fields       = & $this->meta_box[ 'fields' ];
1181 1181
 
1182 1182
 		if ( ! array_key_exists( $field_id, $fields ) ) {
1183 1183
 			$field_id = $this->search_old_school_array( $field_id, $fields );
@@ -1191,12 +1191,12 @@  discard block
 block discarded – undo
1191 1191
 			return array( $field_id, $sub_field_id );
1192 1192
 		}
1193 1193
 
1194
-		if ( 'group' !== $fields[ $field_id ]['type'] ) {
1194
+		if ( 'group' !== $fields[ $field_id ][ 'type' ] ) {
1195 1195
 			return false;
1196 1196
 		}
1197 1197
 
1198
-		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ]['fields'] ) ) {
1199
-			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ]['fields'] );
1198
+		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ][ 'fields' ] ) ) {
1199
+			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ][ 'fields' ] );
1200 1200
 		}
1201 1201
 
1202 1202
 		return false === $sub_field_id ? false : array( $field_id, $sub_field_id );
Please login to merge, or discard this patch.