Complex classes like CMB2_Utils often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CMB2_Utils, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class CMB2_Utils { |
||
|
|
|||
| 14 | |||
| 15 | /** |
||
| 16 | * The url which is used to load local resources. |
||
| 17 | * @var string |
||
| 18 | * @since 2.0.0 |
||
| 19 | */ |
||
| 20 | protected $url = ''; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * Utility method that attempts to get an attachment's ID by it's url |
||
| 24 | * @since 1.0.0 |
||
| 25 | * @param string $img_url Attachment url |
||
| 26 | * @return int|false Attachment ID or false |
||
| 27 | */ |
||
| 28 | 1 | public function image_id_from_url( $img_url ) { |
|
| 29 | 1 | $attachment_id = 0; |
|
| 30 | 1 | $dir = wp_upload_dir(); |
|
| 31 | |||
| 32 | // Is URL in uploads directory? |
||
| 33 | 1 | if ( false === strpos( $img_url, $dir['baseurl'] . '/' ) ) { |
|
| 34 | return false; |
||
| 35 | } |
||
| 36 | |||
| 37 | 1 | $file = basename( $img_url ); |
|
| 38 | |||
| 39 | $query_args = array( |
||
| 40 | 1 | 'post_type' => 'attachment', |
|
| 41 | 1 | 'post_status' => 'inherit', |
|
| 42 | 1 | 'fields' => 'ids', |
|
| 43 | 'meta_query' => array( |
||
| 44 | array( |
||
| 45 | 1 | 'value' => $file, |
|
| 46 | 1 | 'compare' => 'LIKE', |
|
| 47 | 1 | 'key' => '_wp_attachment_metadata', |
|
| 48 | 1 | ), |
|
| 49 | ) |
||
| 50 | 1 | ); |
|
| 51 | |||
| 52 | 1 | $query = new WP_Query( $query_args ); |
|
| 53 | |||
| 54 | 1 | if ( $query->have_posts() ) { |
|
| 55 | |||
| 56 | 1 | foreach ( $query->posts as $post_id ) { |
|
| 57 | 1 | $meta = wp_get_attachment_metadata( $post_id ); |
|
| 58 | 1 | $original_file = basename( $meta['file'] ); |
|
| 59 | 1 | $cropped_image_files = isset( $meta['sizes'] ) ? wp_list_pluck( $meta['sizes'], 'file' ) : array(); |
|
| 60 | 1 | if ( $original_file === $file || in_array( $file, $cropped_image_files ) ) { |
|
| 61 | 1 | $attachment_id = $post_id; |
|
| 62 | 1 | break; |
|
| 63 | } |
||
| 64 | 1 | } |
|
| 65 | |||
| 66 | 1 | } |
|
| 67 | |||
| 68 | 1 | return 0 === $attachment_id ? false : $attachment_id; |
|
| 69 | } |
||
| 70 | |||
| 71 | /** |
||
| 72 | * Utility method that returns time string offset by timezone |
||
| 73 | * @since 1.0.0 |
||
| 74 | * @param string $tzstring Time string |
||
| 75 | * @return string Offset time string |
||
| 76 | */ |
||
| 77 | 2 | public function timezone_offset( $tzstring ) { |
|
| 78 | 2 | $tz_offset = 0; |
|
| 79 | |||
| 80 | 2 | if ( ! empty( $tzstring ) && is_string( $tzstring ) ) { |
|
| 81 | 2 | if ( 'UTC' === substr( $tzstring, 0, 3 ) ) { |
|
| 82 | 1 | $tzstring = str_replace( array( ':15', ':30', ':45' ), array( '.25', '.5', '.75' ), $tzstring ); |
|
| 83 | 1 | return intval( floatval( substr( $tzstring, 3 ) ) * HOUR_IN_SECONDS ); |
|
| 84 | } |
||
| 85 | |||
| 86 | try { |
||
| 87 | 1 | $date_time_zone_selected = new DateTimeZone( $tzstring ); |
|
| 88 | 1 | $tz_offset = timezone_offset_get( $date_time_zone_selected, date_create() ); |
|
| 89 | 1 | } catch ( Exception $e ) { |
|
| 90 | $this->log_if_debug( __METHOD__, __LINE__, $e->getMessage() ); |
||
| 91 | } |
||
| 92 | |||
| 93 | 1 | } |
|
| 94 | |||
| 95 | 1 | return $tz_offset; |
|
| 96 | } |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Utility method that returns a timezone string representing the default timezone for the site. |
||
| 100 | * |
||
| 101 | * Roughly copied from WordPress, as get_option('timezone_string') will return |
||
| 102 | * an empty string if no value has been set on the options page. |
||
| 103 | * A timezone string is required by the wp_timezone_choice() used by the |
||
| 104 | * select_timezone field. |
||
| 105 | * |
||
| 106 | * @since 1.0.0 |
||
| 107 | * @return string Timezone string |
||
| 108 | */ |
||
| 109 | 2 | public function timezone_string() { |
|
| 125 | |||
| 126 | /** |
||
| 127 | * Returns a timestamp, first checking if value already is a timestamp. |
||
| 128 | * @since 2.0.0 |
||
| 129 | * @param string|int $string Possible timestamp string |
||
| 130 | * @return int Time stamp |
||
| 131 | */ |
||
| 132 | 5 | public function make_valid_time_stamp( $string ) { |
|
| 133 | 5 | if ( ! $string ) { |
|
| 134 | return 0; |
||
| 135 | } |
||
| 136 | |||
| 137 | 5 | return $this->is_valid_time_stamp( $string ) |
|
| 138 | 5 | ? (int) $string : |
|
| 139 | 5 | strtotime( (string) $string ); |
|
| 140 | } |
||
| 141 | |||
| 142 | /** |
||
| 143 | * Determine if a value is a valid timestamp |
||
| 144 | * @since 2.0.0 |
||
| 145 | * @param mixed $timestamp Value to check |
||
| 146 | * @return boolean Whether value is a valid timestamp |
||
| 147 | */ |
||
| 148 | 5 | public function is_valid_time_stamp( $timestamp ) { |
|
| 149 | 5 | return (string) (int) $timestamp === (string) $timestamp |
|
| 150 | 5 | && $timestamp <= PHP_INT_MAX |
|
| 151 | 5 | && $timestamp >= ~PHP_INT_MAX; |
|
| 152 | } |
||
| 153 | |||
| 154 | /** |
||
| 155 | * Checks if a value is 'empty'. Still accepts 0. |
||
| 156 | * @since 2.0.0 |
||
| 157 | * @param mixed $value Value to check |
||
| 158 | * @return bool True or false |
||
| 159 | */ |
||
| 160 | 51 | public function isempty( $value ) { |
|
| 163 | |||
| 164 | /** |
||
| 165 | * Insert a single array item inside another array at a set position |
||
| 166 | * @since 2.0.2 |
||
| 167 | * @param array &$array Array to modify. Is passed by reference, and no return is needed. |
||
| 168 | * @param array $new New array to insert |
||
| 169 | * @param int $position Position in the main array to insert the new array |
||
| 170 | */ |
||
| 171 | 2 | public function array_insert( &$array, $new, $position ) { |
|
| 172 | 2 | $before = array_slice( $array, 0, $position - 1 ); |
|
| 173 | 2 | $after = array_diff_key( $array, $before ); |
|
| 174 | 2 | $array = array_merge( $before, $new, $after ); |
|
| 175 | 2 | } |
|
| 176 | |||
| 177 | /** |
||
| 178 | * Defines the url which is used to load local resources. |
||
| 179 | * This may need to be filtered for local Window installations. |
||
| 180 | * If resources do not load, please check the wiki for details. |
||
| 181 | * @since 1.0.1 |
||
| 182 | * @return string URL to CMB2 resources |
||
| 183 | */ |
||
| 184 | 2 | public function url( $path = '' ) { |
|
| 185 | 2 | if ( $this->url ) { |
|
| 186 | 1 | return $this->url . $path; |
|
| 187 | } |
||
| 188 | |||
| 189 | 1 | if ( 'WIN' === strtoupper( substr( PHP_OS, 0, 3 ) ) ) { |
|
| 190 | // Windows |
||
| 191 | $content_dir = str_replace( '/', DIRECTORY_SEPARATOR, WP_CONTENT_DIR ); |
||
| 192 | $content_url = str_replace( $content_dir, WP_CONTENT_URL, cmb2_dir() ); |
||
| 193 | $cmb2_url = str_replace( DIRECTORY_SEPARATOR, '/', $content_url ); |
||
| 194 | |||
| 195 | } else { |
||
| 196 | 1 | $cmb2_url = str_replace( |
|
| 197 | 1 | array( WP_CONTENT_DIR, WP_PLUGIN_DIR ), |
|
| 198 | 1 | array( WP_CONTENT_URL, WP_PLUGIN_URL ), |
|
| 199 | 1 | cmb2_dir() |
|
| 200 | 1 | ); |
|
| 201 | } |
||
| 202 | |||
| 203 | /** |
||
| 204 | * Filter the CMB location url |
||
| 205 | * |
||
| 206 | * @param string $cmb2_url Currently registered url |
||
| 207 | */ |
||
| 208 | 1 | $this->url = trailingslashit( apply_filters( 'cmb2_meta_box_url', set_url_scheme( $cmb2_url ), CMB2_VERSION ) ); |
|
| 209 | |||
| 210 | 1 | return $this->url . $path; |
|
| 211 | } |
||
| 212 | |||
| 213 | /** |
||
| 214 | * Get timestamp from text date |
||
| 215 | * @since 2.2.0 |
||
| 216 | * @param string $value Date value |
||
| 217 | * @param string $date_format Expected date format |
||
| 218 | * @return mixed Unix timestamp representing the date. |
||
| 219 | */ |
||
| 220 | public function get_timestamp_from_value( $value, $date_format ) { |
||
| 224 | |||
| 225 | /** |
||
| 226 | * Takes a php date() format string and returns a string formatted to suit for the date/time pickers |
||
| 227 | * It will work with only with the following subset ot date() options: |
||
| 228 | * |
||
| 229 | * d, j, z, m, n, y, and Y. |
||
| 230 | * |
||
| 231 | * A slight effort is made to deal with escaped characters. |
||
| 232 | * |
||
| 233 | * Other options are ignored, because they would either bring compatibility problems between PHP and JS, or |
||
| 234 | * bring even more translation troubles. |
||
| 235 | * |
||
| 236 | * @since 2.2.0 |
||
| 237 | * @param string $format php date format |
||
| 238 | * @return string reformatted string |
||
| 239 | */ |
||
| 240 | 5 | public function php_to_js_dateformat( $format ) { |
|
| 241 | |||
| 242 | // order is relevant here, since the replacement will be done sequentially. |
||
| 243 | $supported_options = array( |
||
| 244 | 5 | 'd' => 'dd', // Day, leading 0 |
|
| 245 | 5 | 'j' => 'd', // Day, no 0 |
|
| 246 | 5 | 'z' => 'o', // Day of the year, no leading zeroes, |
|
| 247 | // 'D' => 'D', // Day name short, not sure how it'll work with translations |
||
| 248 | // 'l' => 'DD', // Day name full, idem before |
||
| 249 | 5 | 'm' => 'mm', // Month of the year, leading 0 |
|
| 250 | 5 | 'n' => 'm', // Month of the year, no leading 0 |
|
| 251 | // 'M' => 'M', // Month, Short name |
||
| 252 | // 'F' => 'MM', // Month, full name, |
||
| 253 | 5 | 'y' => 'y', // Year, two digit |
|
| 254 | 5 | 'Y' => 'yy', // Year, full |
|
| 255 | 5 | 'H' => 'HH', // Hour with leading 0 (24 hour) |
|
| 256 | 5 | 'G' => 'H', // Hour with no leading 0 (24 hour) |
|
| 257 | 5 | 'h' => 'hh', // Hour with leading 0 (12 hour) |
|
| 258 | 5 | 'g' => 'h', // Hour with no leading 0 (12 hour), |
|
| 259 | 5 | 'i' => 'mm', // Minute with leading 0, |
|
| 260 | 5 | 's' => 'ss', // Second with leading 0, |
|
| 261 | 5 | 'a' => 'tt', // am/pm |
|
| 262 | 'A' => 'TT' // AM/PM |
||
| 263 | 5 | ); |
|
| 264 | |||
| 265 | 5 | foreach ( $supported_options as $php => $js ) { |
|
| 266 | // replaces every instance of a supported option, but skips escaped characters |
||
| 267 | 5 | $format = preg_replace( "~(?<!\\\\)$php~", $js, $format ); |
|
| 268 | 5 | } |
|
| 269 | |||
| 270 | 5 | $format = preg_replace_callback( '~(?:\\\.)+~', array( $this, 'wrap_escaped_chars' ), $format ); |
|
| 271 | |||
| 272 | 5 | return $format; |
|
| 273 | } |
||
| 274 | |||
| 275 | /** |
||
| 276 | * Helper function for CMB_Utils->php_to_js_dateformat, because php 5.2 was retarded. |
||
| 277 | * @since 2.2.0 |
||
| 278 | * @param $value Value to wrap/escape |
||
| 279 | * @return string Modified value |
||
| 280 | */ |
||
| 281 | 4 | public function wrap_escaped_chars( $value ) { |
|
| 284 | |||
| 285 | /** |
||
| 286 | * Send to debug.log if WP_DEBUG is defined and true |
||
| 287 | * |
||
| 288 | * @since 2.2.0 |
||
| 289 | * |
||
| 290 | * @param string $function Function name |
||
| 291 | * @param int $line Line number |
||
| 292 | * @param mixed $msg Message to output |
||
| 293 | * @param mixed $debug Variable to print_r |
||
| 294 | */ |
||
| 295 | public function log_if_debug( $function, $line, $msg, $debug = null ) { |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Determine a file's extension |
||
| 303 | * @since 1.0.0 |
||
| 304 | * @param string $file File url |
||
| 305 | * @return string|false File extension or false |
||
| 306 | */ |
||
| 307 | 4 | public function get_file_ext( $file ) { |
|
| 311 | |||
| 312 | /** |
||
| 313 | * Get the file name from a url |
||
| 314 | * @since 2.0.0 |
||
| 315 | * @param string $value File url or path |
||
| 316 | * @return string File name |
||
| 317 | */ |
||
| 318 | 3 | public function get_file_name_from_path( $value ) { |
|
| 322 | } |
||
| 323 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.