Complex classes like CMB2_Utils often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CMB2_Utils, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class CMB2_Utils { |
||
|
|
|||
| 14 | |||
| 15 | /** |
||
| 16 | * The url which is used to load local resources. |
||
| 17 | * @var string |
||
| 18 | * @since 2.0.0 |
||
| 19 | */ |
||
| 20 | protected $url = ''; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * Utility method that attempts to get an attachment's ID by it's url |
||
| 24 | * @since 1.0.0 |
||
| 25 | * @param string $img_url Attachment url |
||
| 26 | * @return int|false Attachment ID or false |
||
| 27 | */ |
||
| 28 | 1 | public function image_id_from_url( $img_url ) { |
|
| 70 | |||
| 71 | /** |
||
| 72 | * Utility method that returns time string offset by timezone |
||
| 73 | * @since 1.0.0 |
||
| 74 | * @param string $tzstring Time string |
||
| 75 | * @return string Offset time string |
||
| 76 | */ |
||
| 77 | 1 | public function timezone_offset( $tzstring ) { |
|
| 97 | |||
| 98 | /** |
||
| 99 | * Utility method that returns a timezone string representing the default timezone for the site. |
||
| 100 | * |
||
| 101 | * Roughly copied from WordPress, as get_option('timezone_string') will return |
||
| 102 | * an empty string if no value has been set on the options page. |
||
| 103 | * A timezone string is required by the wp_timezone_choice() used by the |
||
| 104 | * select_timezone field. |
||
| 105 | * |
||
| 106 | * @since 1.0.0 |
||
| 107 | * @return string Timezone string |
||
| 108 | */ |
||
| 109 | 1 | public function timezone_string() { |
|
| 130 | |||
| 131 | /** |
||
| 132 | * Returns a timestamp, first checking if value already is a timestamp. |
||
| 133 | * @since 2.0.0 |
||
| 134 | * @param string|int $string Possible timestamp string |
||
| 135 | * @return int Time stamp |
||
| 136 | */ |
||
| 137 | 5 | public function make_valid_time_stamp( $string ) { |
|
| 146 | |||
| 147 | /** |
||
| 148 | * Determine if a value is a valid timestamp |
||
| 149 | * @since 2.0.0 |
||
| 150 | * @param mixed $timestamp Value to check |
||
| 151 | * @return boolean Whether value is a valid timestamp |
||
| 152 | */ |
||
| 153 | 5 | public function is_valid_time_stamp( $timestamp ) { |
|
| 158 | |||
| 159 | /** |
||
| 160 | * Checks if a value is 'empty'. Still accepts 0. |
||
| 161 | * @since 2.0.0 |
||
| 162 | * @param mixed $value Value to check |
||
| 163 | * @return bool True or false |
||
| 164 | */ |
||
| 165 | 54 | public function isempty( $value ) { |
|
| 168 | |||
| 169 | /** |
||
| 170 | * Checks if a value is not 'empty'. 0 doesn't count as empty. |
||
| 171 | * @since 2.2.2 |
||
| 172 | * @param mixed $value Value to check |
||
| 173 | * @return bool True or false |
||
| 174 | */ |
||
| 175 | 3 | public function notempty( $value ){ |
|
| 178 | |||
| 179 | /** |
||
| 180 | * Filters out empty values (not including 0). |
||
| 181 | * @since 2.2.2 |
||
| 182 | * @param mixed $value Value to check |
||
| 183 | * @return bool True or false |
||
| 184 | */ |
||
| 185 | 2 | function filter_empty( $value ) { |
|
| 188 | |||
| 189 | /** |
||
| 190 | * Insert a single array item inside another array at a set position |
||
| 191 | * @since 2.0.2 |
||
| 192 | * @param array &$array Array to modify. Is passed by reference, and no return is needed. |
||
| 193 | * @param array $new New array to insert |
||
| 194 | * @param int $position Position in the main array to insert the new array |
||
| 195 | */ |
||
| 196 | 2 | public function array_insert( &$array, $new, $position ) { |
|
| 201 | |||
| 202 | /** |
||
| 203 | * Defines the url which is used to load local resources. |
||
| 204 | * This may need to be filtered for local Window installations. |
||
| 205 | * If resources do not load, please check the wiki for details. |
||
| 206 | * @since 1.0.1 |
||
| 207 | * @return string URL to CMB2 resources |
||
| 208 | */ |
||
| 209 | 2 | public function url( $path = '' ) { |
|
| 225 | |||
| 226 | /** |
||
| 227 | * Converts a system path to a URL |
||
| 228 | * @since 2.2.2 |
||
| 229 | * @param string $dir Directory path to convert. |
||
| 230 | * @return string Converted URL. |
||
| 231 | */ |
||
| 232 | 2 | public static function get_url_from_dir( $dir ) { |
|
| 265 | |||
| 266 | /** |
||
| 267 | * `wp_normalize_path` wrapper for back-compat. Normalize a filesystem path. |
||
| 268 | * |
||
| 269 | * On windows systems, replaces backslashes with forward slashes |
||
| 270 | * and forces upper-case drive letters. |
||
| 271 | * Allows for two leading slashes for Windows network shares, but |
||
| 272 | * ensures that all other duplicate slashes are reduced to a single. |
||
| 273 | * |
||
| 274 | * @since 2.2.0 |
||
| 275 | * |
||
| 276 | * @param string $path Path to normalize. |
||
| 277 | * @return string Normalized path. |
||
| 278 | */ |
||
| 279 | 2 | protected static function normalize_path( $path ) { |
|
| 293 | |||
| 294 | /** |
||
| 295 | * Get timestamp from text date |
||
| 296 | * @since 2.2.0 |
||
| 297 | * @param string $value Date value |
||
| 298 | * @param string $date_format Expected date format |
||
| 299 | * @return mixed Unix timestamp representing the date. |
||
| 300 | */ |
||
| 301 | public function get_timestamp_from_value( $value, $date_format ) { |
||
| 305 | |||
| 306 | /** |
||
| 307 | * Takes a php date() format string and returns a string formatted to suit for the date/time pickers |
||
| 308 | * It will work with only with the following subset ot date() options: |
||
| 309 | * |
||
| 310 | * d, j, z, m, n, y, and Y. |
||
| 311 | * |
||
| 312 | * A slight effort is made to deal with escaped characters. |
||
| 313 | * |
||
| 314 | * Other options are ignored, because they would either bring compatibility problems between PHP and JS, or |
||
| 315 | * bring even more translation troubles. |
||
| 316 | * |
||
| 317 | * @since 2.2.0 |
||
| 318 | * @param string $format php date format |
||
| 319 | * @return string reformatted string |
||
| 320 | */ |
||
| 321 | 5 | public function php_to_js_dateformat( $format ) { |
|
| 355 | |||
| 356 | /** |
||
| 357 | * Helper function for CMB_Utils->php_to_js_dateformat, because php 5.2 was retarded. |
||
| 358 | * @since 2.2.0 |
||
| 359 | * @param $value Value to wrap/escape |
||
| 360 | * @return string Modified value |
||
| 361 | */ |
||
| 362 | 4 | public function wrap_escaped_chars( $value ) { |
|
| 365 | |||
| 366 | /** |
||
| 367 | * Send to debug.log if WP_DEBUG is defined and true |
||
| 368 | * |
||
| 369 | * @since 2.2.0 |
||
| 370 | * |
||
| 371 | * @param string $function Function name |
||
| 372 | * @param int $line Line number |
||
| 373 | * @param mixed $msg Message to output |
||
| 374 | * @param mixed $debug Variable to print_r |
||
| 375 | */ |
||
| 376 | public function log_if_debug( $function, $line, $msg, $debug = null ) { |
||
| 381 | |||
| 382 | /** |
||
| 383 | * Determine a file's extension |
||
| 384 | * @since 1.0.0 |
||
| 385 | * @param string $file File url |
||
| 386 | * @return string|false File extension or false |
||
| 387 | */ |
||
| 388 | 4 | public function get_file_ext( $file ) { |
|
| 392 | |||
| 393 | /** |
||
| 394 | * Get the file name from a url |
||
| 395 | * @since 2.0.0 |
||
| 396 | * @param string $value File url or path |
||
| 397 | * @return string File name |
||
| 398 | */ |
||
| 399 | 3 | public function get_file_name_from_path( $value ) { |
|
| 403 | } |
||
| 404 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.