Completed
Pull Request — trunk (#602)
by Juliette
71:35 queued 56:37
created
includes/helper-functions.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
 		$cmb = CMB2_Boxes::get( $meta_box );
179 179
 	} else {
180 180
 		// See if we already have an instance of this metabox
181
-		$cmb = CMB2_Boxes::get( $meta_box['id'] );
181
+		$cmb = CMB2_Boxes::get( $meta_box[ 'id' ] );
182 182
 		// If not, we'll initate a new metabox
183 183
 		$cmb = $cmb ? $cmb : new CMB2( $meta_box, $object_id );
184 184
 	}
@@ -254,7 +254,7 @@  discard block
 block discarded – undo
254 254
 	) );
255 255
 
256 256
 	// Set object type explicitly (rather than trying to guess from context)
257
-	$cmb->object_type( $args['object_type'] );
257
+	$cmb->object_type( $args[ 'object_type' ] );
258 258
 
259 259
 	// Save the metabox if it's been submitted
260 260
 	// check permissions
@@ -262,32 +262,32 @@  discard block
 block discarded – undo
262 262
 	if (
263 263
 		$cmb->prop( 'save_fields' )
264 264
 		// check nonce
265
-		&& isset( $_POST['submit-cmb'], $_POST['object_id'], $_POST[ $cmb->nonce() ] )
265
+		&& isset( $_POST[ 'submit-cmb' ], $_POST[ 'object_id' ], $_POST[ $cmb->nonce() ] )
266 266
 		&& wp_verify_nonce( $_POST[ $cmb->nonce() ], $cmb->nonce() )
267
-		&& $object_id && $_POST['object_id'] == $object_id
267
+		&& $object_id && $_POST[ 'object_id' ] == $object_id
268 268
 	) {
269 269
 		$cmb->save_fields( $object_id, $cmb->object_type(), $_POST );
270 270
 	}
271 271
 
272 272
 	// Enqueue JS/CSS
273
-	if ( $args['cmb_styles'] ) {
273
+	if ( $args[ 'cmb_styles' ] ) {
274 274
 		CMB2_hookup::enqueue_cmb_css();
275 275
 	}
276 276
 
277
-	if ( $args['enqueue_js'] ) {
277
+	if ( $args[ 'enqueue_js' ] ) {
278 278
 		CMB2_hookup::enqueue_cmb_js();
279 279
 	}
280 280
 
281
-	$form_format = apply_filters( 'cmb2_get_metabox_form_format', $args['form_format'], $object_id, $cmb );
281
+	$form_format = apply_filters( 'cmb2_get_metabox_form_format', $args[ 'form_format' ], $object_id, $cmb );
282 282
 
283 283
 	$format_parts = explode( '%3$s', $form_format );
284 284
 
285 285
 	// Show cmb form
286
-	printf( $format_parts[0], $cmb->cmb_id, $object_id );
286
+	printf( $format_parts[ 0 ], $cmb->cmb_id, $object_id );
287 287
 	$cmb->show_form();
288 288
 
289
-	if ( isset( $format_parts[1] ) && $format_parts[1] ) {
290
-		printf( str_ireplace( '%4$s', '%1$s', $format_parts[1] ), $args['save_button'] );
289
+	if ( isset( $format_parts[ 1 ] ) && $format_parts[ 1 ] ) {
290
+		printf( str_ireplace( '%4$s', '%1$s', $format_parts[ 1 ] ), $args[ 'save_button' ] );
291 291
 	}
292 292
 
293 293
 }
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
  * @param  array   $args      Optional arguments array
301 301
  */
302 302
 function cmb2_metabox_form( $meta_box, $object_id = 0, $args = array() ) {
303
-	if ( ! isset( $args['echo'] ) || $args['echo'] ) {
303
+	if ( ! isset( $args[ 'echo' ] ) || $args[ 'echo' ] ) {
304 304
 		cmb2_print_metabox_form( $meta_box, $object_id, $args );
305 305
 	} else {
306 306
 		return cmb2_get_metabox_form( $meta_box, $object_id, $args );
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
 
323 323
 		$schedule_format = str_replace(
324 324
 			array( 'M', 'Y', 'm', 'd', 'H', 'i', 'a' ),
325
-			array('%b', '%Y', '%m', '%d', '%H', '%M', '%p' ),
325
+			array( '%b', '%Y', '%m', '%d', '%H', '%M', '%p' ),
326 326
 			$date_format
327 327
 		);
328 328
 
@@ -339,14 +339,14 @@  discard block
 block discarded – undo
339 339
 			 * 4 or 2 characters, as needed
340 340
 			 */
341 341
 			'%04d-%02d-%02d %02d:%02d:%02d',
342
-			$parsed_time['tm_year'] + 1900,  // This will be "111", so we need to add 1900.
343
-			$parsed_time['tm_mon'] + 1,      // This will be the month minus one, so we add one.
344
-			$parsed_time['tm_mday'],
345
-			$parsed_time['tm_hour'],
346
-			$parsed_time['tm_min'],
347
-			$parsed_time['tm_sec']
342
+			$parsed_time[ 'tm_year' ] + 1900, // This will be "111", so we need to add 1900.
343
+			$parsed_time[ 'tm_mon' ] + 1, // This will be the month minus one, so we add one.
344
+			$parsed_time[ 'tm_mday' ],
345
+			$parsed_time[ 'tm_hour' ],
346
+			$parsed_time[ 'tm_min' ],
347
+			$parsed_time[ 'tm_sec' ]
348 348
 		);
349 349
 
350
-		return new DateTime($ymd);
350
+		return new DateTime( $ymd );
351 351
 	}
352 352
 }
Please login to merge, or discard this patch.
includes/CMB2_Ajax.php 2 patches
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -53,12 +53,12 @@  discard block
 block discarded – undo
53 53
 	public function oembed_handler() {
54 54
 
55 55
 		// Verify our nonce
56
-		if ( ! ( isset( $_REQUEST['cmb2_ajax_nonce'], $_REQUEST['oembed_url'] ) && wp_verify_nonce( $_REQUEST['cmb2_ajax_nonce'], 'ajax_nonce' ) ) ) {
56
+		if ( ! ( isset( $_REQUEST[ 'cmb2_ajax_nonce' ], $_REQUEST[ 'oembed_url' ] ) && wp_verify_nonce( $_REQUEST[ 'cmb2_ajax_nonce' ], 'ajax_nonce' ) ) ) {
57 57
 			die();
58 58
 		}
59 59
 
60 60
 		// Sanitize our search string
61
-		$oembed_string = sanitize_text_field( $_REQUEST['oembed_url'] );
61
+		$oembed_string = sanitize_text_field( $_REQUEST[ 'oembed_url' ] );
62 62
 
63 63
 		// Send back error if empty
64 64
 		if ( empty( $oembed_string ) ) {
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 		}
67 67
 
68 68
 		// Set width of embed
69
-		$embed_width = isset( $_REQUEST['oembed_width'] ) && intval( $_REQUEST['oembed_width'] ) < 640 ? intval( $_REQUEST['oembed_width'] ) : '640';
69
+		$embed_width = isset( $_REQUEST[ 'oembed_width' ] ) && intval( $_REQUEST[ 'oembed_width' ] ) < 640 ? intval( $_REQUEST[ 'oembed_width' ] ) : '640';
70 70
 
71 71
 		// Set url
72 72
 		$oembed_url = esc_url( $oembed_string );
@@ -79,10 +79,10 @@  discard block
 block discarded – undo
79 79
 		// Get embed code (or fallback link)
80 80
 		$html = $this->get_oembed( array(
81 81
 			'url'         => $oembed_url,
82
-			'object_id'   => $_REQUEST['object_id'],
83
-			'object_type' => isset( $_REQUEST['object_type'] ) ? $_REQUEST['object_type'] : 'post',
82
+			'object_id'   => $_REQUEST[ 'object_id' ],
83
+			'object_type' => isset( $_REQUEST[ 'object_type' ] ) ? $_REQUEST[ 'object_type' ] : 'post',
84 84
 			'oembed_args' => $embed_args,
85
-			'field_id'    => $_REQUEST['field_id'],
85
+			'field_id'    => $_REQUEST[ 'field_id' ],
86 86
 		) );
87 87
 
88 88
 		wp_send_json_success( $html );
@@ -98,10 +98,10 @@  discard block
 block discarded – undo
98 98
 
99 99
 		global $wp_embed;
100 100
 
101
-		$oembed_url = esc_url( $args['url'] );
101
+		$oembed_url = esc_url( $args[ 'url' ] );
102 102
 
103 103
 		// Sanitize object_id
104
-		$this->object_id = is_numeric( $args['object_id'] ) ? absint( $args['object_id'] ) : sanitize_text_field( $args['object_id'] );
104
+		$this->object_id = is_numeric( $args[ 'object_id' ] ) ? absint( $args[ 'object_id' ] ) : sanitize_text_field( $args[ 'object_id' ] );
105 105
 
106 106
 		$args = wp_parse_args( $args, array(
107 107
 			'object_type' => 'post',
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 			'field_id'    => false,
110 110
 		) );
111 111
 
112
-		$this->embed_args =& $args;
112
+		$this->embed_args = & $args;
113 113
 
114 114
 		/**
115 115
 		 * Set the post_ID so oEmbed won't fail
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
 		$wp_embed->post_ID = $this->object_id;
119 119
 
120 120
 		// Special scenario if NOT a post object
121
-		if ( isset( $args['object_type'] ) && 'post' != $args['object_type'] ) {
121
+		if ( isset( $args[ 'object_type' ] ) && 'post' != $args[ 'object_type' ] ) {
122 122
 
123
-			if ( 'options-page' == $args['object_type'] ) {
123
+			if ( 'options-page' == $args[ 'object_type' ] ) {
124 124
 
125 125
 				// Bogus id to pass some numeric checks. Issue with a VERY large WP install?
126 126
 				$wp_embed->post_ID = 1987645321;
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
 			// Ok, we need to hijack the oembed cache system
130 130
 			$this->hijack = true;
131
-			$this->object_type = $args['object_type'];
131
+			$this->object_type = $args[ 'object_type' ];
132 132
 
133 133
 			// Gets ombed cache from our object's meta (vs postmeta)
134 134
 			add_filter( 'get_post_metadata', array( $this, 'hijack_oembed_cache_get' ), 10, 3 );
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
 		$embed_args = '';
142 142
 
143
-		foreach ( $args['oembed_args'] as $key => $val ) {
143
+		foreach ( $args[ 'oembed_args' ] as $key => $val ) {
144 144
 			$embed_args .= " $key=\"$val\"";
145 145
 		}
146 146
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 
153 153
 		// Send back our embed
154 154
 		if ( $check_embed && $check_embed != $fallback ) {
155
-			return '<div class="embed-status">' . $check_embed . '<p class="cmb2-remove-wrapper"><a href="#" class="cmb2-remove-file-button" rel="' . $args['field_id'] . '">' . __( 'Remove Embed', 'cmb2' ) . '</a></p></div>';
155
+			return '<div class="embed-status">' . $check_embed . '<p class="cmb2-remove-wrapper"><a href="#" class="cmb2-remove-file-button" rel="' . $args[ 'field_id' ] . '">' . __( 'Remove Embed', 'cmb2' ) . '</a></p></div>';
156 156
 		}
157 157
 
158 158
 		// Otherwise, send back error info that no oEmbeds were found
@@ -219,15 +219,15 @@  discard block
 block discarded – undo
219 219
 	 */
220 220
 	protected function cache_action( $meta_key ) {
221 221
 		$func_args = func_get_args();
222
-		$action    = isset( $func_args[1] ) ? 'update' : 'get';
222
+		$action    = isset( $func_args[ 1 ] ) ? 'update' : 'get';
223 223
 
224 224
 		if ( 'options-page' === $this->object_type ) {
225 225
 
226 226
 			$args = array( $meta_key );
227 227
 
228 228
 			if ( 'update' === $action ) {
229
-				$args[] = $func_args[1];
230
-				$args[] = true;
229
+				$args[ ] = $func_args[ 1 ];
230
+				$args[ ] = true;
231 231
 			}
232 232
 
233 233
 			// Cache the result to our options
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 		} else {
236 236
 
237 237
 			$args = array( $this->object_type, $this->object_id, $meta_key );
238
-			$args[] = 'update' === $action ? $func_args : true;
238
+			$args[ ] = 'update' === $action ? $func_args : true;
239 239
 
240 240
 			// Cache the result to our metadata
241 241
 			$status = call_user_func_array( $action . '_metadata', $args );
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 	/**
31 31
 	 * Get the singleton instance of this class
32 32
 	 * @since 2.2.2
33
-	 * @return object
33
+	 * @return CMB2_Ajax
34 34
 	 */
35 35
 	public static function get_instance() {
36 36
 		if ( ! ( self::$instance instanceof self ) ) {
@@ -221,7 +221,6 @@  discard block
 block discarded – undo
221 221
 	 *
222 222
 	 * @since  1.3.0
223 223
 	 * @param  string  $meta_key   Postmeta's key
224
-	 * @param  mixed   $meta_value (Optional) value of the postmeta to be saved
225 224
 	 */
226 225
 	protected function cache_action( $meta_key ) {
227 226
 		$func_args = func_get_args();
Please login to merge, or discard this patch.