WebDevStudios / CMB2

includes/types/CMB2_Type_Title.php

Spacing +3 added lines, -3 removed lines

@@ -28,10 +28,10 @@
 		return $this->rendered(
 			sprintf(
 				'<%1$s %2$s>%3$s</%1$s>%4$s',
-				$a['tag'],
+				$a[ 'tag' ],
 				$this->concat_attrs( $a, array( 'tag', 'name', 'desc' ) ),
-				$a['name'],
-				$a['desc']
+				$a[ 'name' ],
+				$a[ 'desc' ]
 			)
 		);
 	}

includes/CMB2_Utils.php

Spacing +21 added lines, -22 removed lines

@@ -37,7 +37,7 @@ 
 		$dir = wp_upload_dir();
 
 		// Is URL in uploads directory?
-		if ( false === strpos( $img_url, $dir['baseurl'] . '/' ) ) {
+		if ( false === strpos( $img_url, $dir[ 'baseurl' ] . '/' ) ) {
 			return false;
 		}
 
@@ -62,8 +62,8 @@ 
 
 			foreach ( $query->posts as $post_id ) {
 				$meta = wp_get_attachment_metadata( $post_id );
-				$original_file       = basename( $meta['file'] );
-				$cropped_image_files = isset( $meta['sizes'] ) ? wp_list_pluck( $meta['sizes'], 'file' ) : array();
+				$original_file       = basename( $meta[ 'file' ] );
+				$cropped_image_files = isset( $meta[ 'sizes' ] ) ? wp_list_pluck( $meta[ 'sizes' ], 'file' ) : array();
 				if ( $original_file === $file || in_array( $file, $cropped_image_files ) ) {
 					$attachment_id = $post_id;
 					break;
@@ -147,8 +147,7 @@ 
 		}
 
 		return self::is_valid_time_stamp( $string )
-			? (int) $string :
-			strtotime( (string) $string );
+			? (int) $string : strtotime( (string) $string );
 	}
 
 	/**
@@ -179,7 +178,7 @@ 
 	 * @param  mixed $value Value to check
 	 * @return bool         True or false
 	 */
-	public static function notempty( $value ){
+	public static function notempty( $value ) {
 		return null !== $value && '' !== $value && false !== $value;
 	}
 
@@ -337,24 +336,24 @@ 
 
 		// order is relevant here, since the replacement will be done sequentially.
 		$supported_options = array(
-			'd' => 'dd',  // Day, leading 0
-			'j' => 'd',   // Day, no 0
-			'z' => 'o',   // Day of the year, no leading zeroes,
+			'd' => 'dd', // Day, leading 0
+			'j' => 'd', // Day, no 0
+			'z' => 'o', // Day of the year, no leading zeroes,
 			// 'D' => 'D',   // Day name short, not sure how it'll work with translations
 			// 'l' => 'DD',  // Day name full, idem before
-			'm' => 'mm',  // Month of the year, leading 0
-			'n' => 'm',   // Month of the year, no leading 0
+			'm' => 'mm', // Month of the year, leading 0
+			'n' => 'm', // Month of the year, no leading 0
 			// 'M' => 'M',   // Month, Short name
 			// 'F' => 'MM',  // Month, full name,
-			'y' => 'y',   // Year, two digit
-			'Y' => 'yy',  // Year, full
-			'H' => 'HH',  // Hour with leading 0 (24 hour)
-			'G' => 'H',   // Hour with no leading 0 (24 hour)
-			'h' => 'hh',  // Hour with leading 0 (12 hour)
-			'g' => 'h',   // Hour with no leading 0 (12 hour),
-			'i' => 'mm',  // Minute with leading 0,
-			's' => 'ss',  // Second with leading 0,
-			'a' => 'tt',  // am/pm
+			'y' => 'y', // Year, two digit
+			'Y' => 'yy', // Year, full
+			'H' => 'HH', // Hour with leading 0 (24 hour)
+			'G' => 'H', // Hour with no leading 0 (24 hour)
+			'h' => 'hh', // Hour with leading 0 (12 hour)
+			'g' => 'h', // Hour with no leading 0 (12 hour),
+			'i' => 'mm', // Minute with leading 0,
+			's' => 'ss', // Second with leading 0,
+			'a' => 'tt', // am/pm
 			'A' => 'TT'   // AM/PM
 		);
 
@@ -375,7 +374,7 @@ 
 	 * @return string Modified value
 	 */
 	public static function wrap_escaped_chars( $value ) {
-		return "'" . str_replace( '\\', '', $value[0] ) . "'";
+		return "'" . str_replace( '\\', '', $value[ 0 ] ) . "'";
 	}
 
 	/**
@@ -435,7 +434,7 @@ 
 	 * @return string               String of attributes for form element.
 	 */
 	public static function concat_attrs( $attrs, $attr_exclude = array() ) {
-		$attr_exclude[] = 'rendered';
+		$attr_exclude[ ] = 'rendered';
 		$attributes = '';
 		foreach ( $attrs as $attr => $val ) {
 			$excluded = in_array( $attr, (array) $attr_exclude, true );

Braces +3 added lines, -2 removed lines

@@ -122,7 +122,8 @@ 
 			$tzstring = '';
 		}
 
-		if ( empty( $tzstring ) ) { // Create a UTC+- zone if no timezone string exists
+		if ( empty( $tzstring ) ) {
+// Create a UTC+- zone if no timezone string exists
 			if ( 0 == $current_offset ) {
 				$tzstring = 'UTC+0';
 			} elseif ( $current_offset < 0 ) {
@@ -179,7 +180,7 @@ 
 	 * @param  mixed $value Value to check
 	 * @return bool         True or false
 	 */
-	public static function notempty( $value ){
+	public static function notempty( $value ) {
 		return null !== $value && '' !== $value && false !== $value;
 	}
 

includes/types/CMB2_Type_File_Base.php

Spacing +9 added lines, -9 removed lines

@@ -55,11 +55,11 @@ 
 	 */
 	public function img_status_output( $args ) {
 		return sprintf( '<%1$s class="img-status">%2$s<p class="cmb2-remove-wrapper"><a href="#" class="cmb2-remove-file-button"%3$s>%4$s</a></p>%5$s</%1$s>',
-			$args['tag'],
-			$args['image'],
-			isset( $args['cached_id'] ) ? ' rel="' . $args['cached_id'] . '"' : '',
+			$args[ 'tag' ],
+			$args[ 'image' ],
+			isset( $args[ 'cached_id' ] ) ? ' rel="' . $args[ 'cached_id' ] . '"' : '',
 			esc_html( $this->_text( 'remove_image_text', esc_html__( 'Remove Image', 'cmb2' ) ) ),
-			isset( $args['id_input'] ) ? $args['id_input'] : ''
+			isset( $args[ 'id_input' ] ) ? $args[ 'id_input' ] : ''
 		);
 	}
 
@@ -71,14 +71,14 @@ 
 	 */
 	public function file_status_output( $args ) {
 		return sprintf( '<%1$s class="file-status"><span>%2$s <strong>%3$s</strong></span>&nbsp;&nbsp; (<a href="%4$s" target="_blank" rel="external">%5$s</a> / <a href="#" class="cmb2-remove-file-button"%6$s>%7$s</a>)%8$s</%1$s>',
-			$args['tag'],
+			$args[ 'tag' ],
 			esc_html( $this->_text( 'file_text', esc_html__( 'File:', 'cmb2' ) ) ),
-			CMB2_Utils::get_file_name_from_path( $args['value'] ),
-			$args['value'],
+			CMB2_Utils::get_file_name_from_path( $args[ 'value' ] ),
+			$args[ 'value' ],
 			esc_html( $this->_text( 'file_download_text', esc_html__( 'Download', 'cmb2' ) ) ),
-			isset( $args['cached_id'] ) ? ' rel="' . $args['cached_id'] . '"' : '',
+			isset( $args[ 'cached_id' ] ) ? ' rel="' . $args[ 'cached_id' ] . '"' : '',
 			esc_html( $this->_text( 'remove_text', esc_html__( 'Remove', 'cmb2' ) ) ),
-			isset( $args['id_input'] ) ? $args['id_input'] : ''
+			isset( $args[ 'id_input' ] ) ? $args[ 'id_input' ] : ''
 		);
 	}
 

includes/CMB2_Base.php

Braces +2 added lines, -4 removed lines

@@ -370,15 +370,13 @@
 			if ( function_exists( '__' ) ) {
 				if ( ! is_null( $message ) ) {
 					trigger_error( sprintf( __( '%1$s was called with a parameter that is <strong>deprecated</strong> since version %2$s! %3$s', 'cmb2' ), $function, $version, $message ) );
-				}
-				else {
+				} else {
 					trigger_error( sprintf( __( '%1$s was called with a parameter that is <strong>deprecated</strong> since version %2$s with no alternative available.', 'cmb2' ), $function, $version ) );
 				}
 			} else {
 				if ( ! is_null( $message ) ) {
 					trigger_error( sprintf( '%1$s was called with a parameter that is <strong>deprecated</strong> since version %2$s! %3$s', $function, $version, $message ) );
-				}
-				else {
+				} else {
 					trigger_error( sprintf( '%1$s was called with a parameter that is <strong>deprecated</strong> since version %2$s with no alternative available.', $function, $version ) );
 				}
 			}

Doc Comments -1 removed lines

@@ -413,7 +413,6 @@
 	 * Allows overloading the object with methods... Whooaaa oooh it's magic, y'knoooow.
 	 * @since 1.0.0
 	 * @param string $method Non-existent method.
-	 * @param array  $arguments All arguments passed to the method
 	 */
 	public function __call( $method, $args ) {
 		$object_class = strtolower( get_class( $this ) );

Spacing +3 added lines, -3 removed lines

@@ -335,11 +335,11 @@ 
 			switch ( $message ) {
 
 				case self::DEPRECATED_PARAM:
-					$message = sprintf( __( 'The "%s" field parameter has been deprecated in favor of the "%s" parameter.', 'cmb2' ), $args[3], $args[4] );
+					$message = sprintf( __( 'The "%s" field parameter has been deprecated in favor of the "%s" parameter.', 'cmb2' ), $args[ 3 ], $args[ 4 ] );
 					break;
 
 				case self::DEPRECATED_CB_PARAM:
-					$message = sprintf( __( 'Using the "%s" field parameter as a callback has been deprecated in favor of the "%s" parameter.', 'cmb2' ), $args[3], $args[4] );
+					$message = sprintf( __( 'Using the "%s" field parameter as a callback has been deprecated in favor of the "%s" parameter.', 'cmb2' ), $args[ 3 ], $args[ 4 ] );
 					break;
 
 				default:
@@ -418,7 +418,7 @@ 
 	public function __call( $method, $args ) {
 		$object_class = strtolower( get_class( $this ) );
 
-		if ( ! has_filter(  "{$object_class}_inherit_{$method}" ) ) {
+		if ( ! has_filter( "{$object_class}_inherit_{$method}" ) ) {
 			throw new Exception( 'Invalid ' . get_class( $this ) . ' method: ' . $method );
 		}
 

includes/shim/WP_REST_Controller.php

Spacing +37 added lines, -37 removed lines

@@ -166,7 +166,7 @@ 
 		}
 
 		if ( ! empty( $links ) ) {
-			$data['_links'] = $links;
+			$data[ '_links' ] = $links;
 		}
 
 		return $data;
@@ -183,21 +183,21 @@ 
 
 		$schema = $this->get_item_schema();
 		foreach ( $data as $key => $value ) {
-			if ( empty( $schema['properties'][ $key ] ) || empty( $schema['properties'][ $key ]['context'] ) ) {
+			if ( empty( $schema[ 'properties' ][ $key ] ) || empty( $schema[ 'properties' ][ $key ][ 'context' ] ) ) {
 				continue;
 			}
 
-			if ( ! in_array( $context, $schema['properties'][ $key ]['context'] ) ) {
+			if ( ! in_array( $context, $schema[ 'properties' ][ $key ][ 'context' ] ) ) {
 				unset( $data[ $key ] );
 				continue;
 			}
 
-			if ( 'object' === $schema['properties'][ $key ]['type'] && ! empty( $schema['properties'][ $key ]['properties'] ) ) {
-				foreach ( $schema['properties'][ $key ]['properties'] as $attribute => $details ) {
-					if ( empty( $details['context'] ) ) {
+			if ( 'object' === $schema[ 'properties' ][ $key ][ 'type' ] && ! empty( $schema[ 'properties' ][ $key ][ 'properties' ] ) ) {
+				foreach ( $schema[ 'properties' ][ $key ][ 'properties' ] as $attribute => $details ) {
+					if ( empty( $details[ 'context' ] ) ) {
 						continue;
 					}
-					if ( ! in_array( $context, $details['context'] ) ) {
+					if ( ! in_array( $context, $details[ 'context' ] ) ) {
 						if ( isset( $data[ $key ][ $attribute ] ) ) {
 							unset( $data[ $key ][ $attribute ] );
 						}
@@ -227,9 +227,9 @@ 
 
 		$schema = $this->get_item_schema();
 
-		foreach ( $schema['properties'] as &$property ) {
-			if ( isset( $property['arg_options'] ) ) {
-				unset( $property['arg_options'] );
+		foreach ( $schema[ 'properties' ] as &$property ) {
+			if ( isset( $property[ 'arg_options' ] ) ) {
+				unset( $property[ 'arg_options' ] );
 			}
 		}
 
@@ -286,18 +286,18 @@ 
 			'validate_callback'  => 'rest_validate_request_arg',
 		);
 		$schema = $this->get_item_schema();
-		if ( empty( $schema['properties'] ) ) {
+		if ( empty( $schema[ 'properties' ] ) ) {
 			return array_merge( $param_details, $args );
 		}
 		$contexts = array();
-		foreach ( $schema['properties'] as $attributes ) {
-			if ( ! empty( $attributes['context'] ) ) {
-				$contexts = array_merge( $contexts, $attributes['context'] );
+		foreach ( $schema[ 'properties' ] as $attributes ) {
+			if ( ! empty( $attributes[ 'context' ] ) ) {
+				$contexts = array_merge( $contexts, $attributes[ 'context' ] );
 			}
 		}
 		if ( ! empty( $contexts ) ) {
-			$param_details['enum'] = array_unique( $contexts );
-			rsort( $param_details['enum'] );
+			$param_details[ 'enum' ] = array_unique( $contexts );
+			rsort( $param_details[ 'enum' ] );
 		}
 		return array_merge( $param_details, $args );
 	}
@@ -315,11 +315,11 @@ 
 
 		foreach ( $additional_fields as $field_name => $field_options ) {
 
-			if ( ! $field_options['get_callback'] ) {
+			if ( ! $field_options[ 'get_callback' ] ) {
 				continue;
 			}
 
-			$object[ $field_name ] = call_user_func( $field_options['get_callback'], $object, $field_name, $request, $this->get_object_type() );
+			$object[ $field_name ] = call_user_func( $field_options[ 'get_callback' ], $object, $field_name, $request, $this->get_object_type() );
 		}
 
 		return $object;
@@ -337,7 +337,7 @@ 
 
 		foreach ( $additional_fields as $field_name => $field_options ) {
 
-			if ( ! $field_options['update_callback'] ) {
+			if ( ! $field_options[ 'update_callback' ] ) {
 				continue;
 			}
 
@@ -346,7 +346,7 @@ 
 				continue;
 			}
 
-			call_user_func( $field_options['update_callback'], $request[ $field_name ], $object, $field_name, $request, $this->get_object_type() );
+			call_user_func( $field_options[ 'update_callback' ], $request[ $field_name ], $object, $field_name, $request, $this->get_object_type() );
 		}
 	}
 
@@ -358,23 +358,23 @@ 
 	 * @param array $schema Schema array.
 	 */
 	protected function add_additional_fields_schema( $schema ) {
-		if ( empty( $schema['title'] ) ) {
+		if ( empty( $schema[ 'title' ] ) ) {
 			return $schema;
 		}
 
 		/**
 		 * Can't use $this->get_object_type otherwise we cause an inf loop.
 		 */
-		$object_type = $schema['title'];
+		$object_type = $schema[ 'title' ];
 
 		$additional_fields = $this->get_additional_fields( $object_type );
 
 		foreach ( $additional_fields as $field_name => $field_options ) {
-			if ( ! $field_options['schema'] ) {
+			if ( ! $field_options[ 'schema' ] ) {
 				continue;
 			}
 
-			$schema['properties'][ $field_name ] = $field_options['schema'];
+			$schema[ 'properties' ][ $field_name ] = $field_options[ 'schema' ];
 		}
 
 		return $schema;
@@ -413,11 +413,11 @@ 
 	protected function get_object_type() {
 		$schema = $this->get_item_schema();
 
-		if ( ! $schema || ! isset( $schema['title'] ) ) {
+		if ( ! $schema || ! isset( $schema[ 'title' ] ) ) {
 			return null;
 		}
 
-		return $schema['title'];
+		return $schema[ 'title' ];
 	}
 
 	/**
@@ -433,13 +433,13 @@ 
 	public function get_endpoint_args_for_item_schema( $method = WP_REST_Server::CREATABLE ) {
 
 		$schema                = $this->get_item_schema();
-		$schema_properties     = ! empty( $schema['properties'] ) ? $schema['properties'] : array();
+		$schema_properties     = ! empty( $schema[ 'properties' ] ) ? $schema[ 'properties' ] : array();
 		$endpoint_args = array();
 
 		foreach ( $schema_properties as $field_id => $params ) {
 
 			// Arguments specified as `readonly` are not allowed to be set.
-			if ( ! empty( $params['readonly'] ) ) {
+			if ( ! empty( $params[ 'readonly' ] ) ) {
 				continue;
 			}
 
@@ -448,16 +448,16 @@ 
 				'sanitize_callback' => 'rest_sanitize_request_arg',
 			);
 
-			if ( isset( $params['description'] ) ) {
-				$endpoint_args[ $field_id ]['description'] = $params['description'];
+			if ( isset( $params[ 'description' ] ) ) {
+				$endpoint_args[ $field_id ][ 'description' ] = $params[ 'description' ];
 			}
 
-			if ( WP_REST_Server::CREATABLE === $method && isset( $params['default'] ) ) {
-				$endpoint_args[ $field_id ]['default'] = $params['default'];
+			if ( WP_REST_Server::CREATABLE === $method && isset( $params[ 'default' ] ) ) {
+				$endpoint_args[ $field_id ][ 'default' ] = $params[ 'default' ];
 			}
 
-			if ( WP_REST_Server::CREATABLE === $method && ! empty( $params['required'] ) ) {
-				$endpoint_args[ $field_id ]['required'] = true;
+			if ( WP_REST_Server::CREATABLE === $method && ! empty( $params[ 'required' ] ) ) {
+				$endpoint_args[ $field_id ][ 'required' ] = true;
 			}
 
 			foreach ( array( 'type', 'format', 'enum' ) as $schema_prop ) {
@@ -467,14 +467,14 @@ 
 			}
 
 			// Merge in any options provided by the schema property.
-			if ( isset( $params['arg_options'] ) ) {
+			if ( isset( $params[ 'arg_options' ] ) ) {
 
 				// Only use required / default from arg_options on CREATABLE endpoints.
 				if ( WP_REST_Server::CREATABLE !== $method ) {
-					$params['arg_options'] = array_diff_key( $params['arg_options'], array( 'required' => '', 'default' => '' ) );
+					$params[ 'arg_options' ] = array_diff_key( $params[ 'arg_options' ], array( 'required' => '', 'default' => '' ) );
 				}
 
-				$endpoint_args[ $field_id ] = array_merge( $endpoint_args[ $field_id ], $params['arg_options'] );
+				$endpoint_args[ $field_id ] = array_merge( $endpoint_args[ $field_id ], $params[ 'arg_options' ] );
 			}
 		}
 

includes/CMB2_Hookup_Base.php

Spacing +3 added lines, -3 removed lines

@@ -52,9 +52,9 @@
 
 		// Get object hash.. This bypasses issues with serializing closures.
 		if ( is_object( $hook ) ) {
-			$args[1] = spl_object_hash( $args[1] );
-		} elseif ( is_array( $hook ) && is_object( $hook[0] ) ) {
-			$args[1][0] = spl_object_hash( $hook[0] );
+			$args[ 1 ] = spl_object_hash( $args[ 1 ] );
+		} elseif ( is_array( $hook ) && is_object( $hook[ 0 ] ) ) {
+			$args[ 1 ][ 0 ] = spl_object_hash( $hook[ 0 ] );
 		}
 
 		$key = md5( serialize( $args ) );

includes/CMB2_Types.php

Spacing +2 added lines, -2 removed lines

@@ -385,8 +385,8 @@
 			'class' => 'cmb2-hidden',
 		);
 		if ( $this->field->group ) {
-			$args['data-groupid'] = $this->field->group->id();
-			$args['data-iterator'] = $this->iterator;
+			$args[ 'data-groupid' ] = $this->field->group->id();
+			$args[ 'data-iterator' ] = $this->iterator;
 		}
 		return $this->input( $args );
 	}

includes/rest-api/CMB2_REST.php

Doc Comments +7 added lines, -6 removed lines

@@ -197,6 +197,7 @@ 
 	 * @param string|array $object_types Object(s) the field is being registered
 	 *                                   to, "post"|"term"|"comment" etc.
 	 * @param string $object_types       Canonical object type for callbacks.
+	 * @param string $object_type
 	 *
 	 * @return void
 	 */
@@ -391,7 +392,7 @@ 
 	 *
 	 * @since  2.2.4
 	 *
-	 * @param  mixed           $value       The value of the field
+	 * @param  mixed           $values       The value of the field
 	 * @param  object          $object      The object from the response
 	 * @param  string          $field_name  Name of field
 	 * @param  WP_REST_Request $request     Current request
@@ -410,7 +411,7 @@ 
 	 *
 	 * @since  2.2.4
 	 *
-	 * @param  mixed           $value       The value of the field
+	 * @param  mixed           $values       The value of the field
 	 * @param  object          $object      The object from the response
 	 * @param  string          $field_name  Name of field
 	 * @param  WP_REST_Request $request     Current request
@@ -429,7 +430,7 @@ 
 	 *
 	 * @since  2.2.4
 	 *
-	 * @param  mixed           $value       The value of the field
+	 * @param  mixed           $values       The value of the field
 	 * @param  object          $object      The object from the response
 	 * @param  string          $field_name  Name of field
 	 * @param  WP_REST_Request $request     Current request
@@ -448,7 +449,7 @@ 
 	 *
 	 * @since  2.2.4
 	 *
-	 * @param  mixed           $value       The value of the field
+	 * @param  mixed           $values       The value of the field
 	 * @param  object          $object      The object from the response
 	 * @param  string          $field_name  Name of field
 	 * @param  WP_REST_Request $request     Current request
@@ -467,7 +468,7 @@ 
 	 *
 	 * @since  2.2.4
 	 *
-	 * @param  mixed           $value            The value of the field
+	 * @param  mixed           $values            The value of the field
 	 * @param  object          $object           The object from the response
 	 * @param  WP_REST_Request $request          Current request
 	 * @param  string          $object_type      The request object type
@@ -665,7 +666,7 @@ 
 	 * Retrieve all CMB2_REST instances from the registry.
 	 *
 	 * @since  2.2.4
-	 * @return CMB2[] Array of all registered CMB2_REST instances.
+	 * @return CMB2_REST[] Array of all registered CMB2_REST instances.
 	 */
 	public static function get_all() {
 		return self::$boxes;

Spacing +21 added lines, -21 removed lines

@@ -143,30 +143,30 @@ 
 		foreach ( self::$boxes as $cmb_id => $rest_box ) {
 			$types = array_flip( $rest_box->cmb->box_types() );
 
-			if ( isset( $types['user'] ) ) {
-				unset( $types['user'] );
-				self::$type_boxes['user'][ $cmb_id ] = $cmb_id;
+			if ( isset( $types[ 'user' ] ) ) {
+				unset( $types[ 'user' ] );
+				self::$type_boxes[ 'user' ][ $cmb_id ] = $cmb_id;
 			}
 
-			if ( isset( $types['comment'] ) ) {
-				unset( $types['comment'] );
-				self::$type_boxes['comment'][ $cmb_id ] = $cmb_id;
+			if ( isset( $types[ 'comment' ] ) ) {
+				unset( $types[ 'comment' ] );
+				self::$type_boxes[ 'comment' ][ $cmb_id ] = $cmb_id;
 			}
 
-			if ( isset( $types['term'] ) ) {
-				unset( $types['term'] );
+			if ( isset( $types[ 'term' ] ) ) {
+				unset( $types[ 'term' ] );
 
 				$taxonomies = array_merge(
 					$taxonomies,
 					CMB2_Utils::ensure_array( $rest_box->cmb->prop( 'taxonomies' ) )
 				);
 
-				self::$type_boxes['term'][ $cmb_id ] = $cmb_id;
+				self::$type_boxes[ 'term' ][ $cmb_id ] = $cmb_id;
 			}
 
 			if ( ! empty( $types ) ) {
 				$alltypes = array_merge( $alltypes, array_flip( $types ) );
-				self::$type_boxes['post'][ $cmb_id ] = $cmb_id;
+				self::$type_boxes[ 'post' ][ $cmb_id ] = $cmb_id;
 			}
 		}
 
@@ -176,15 +176,15 @@ 
 			self::register_rest_field( $alltypes, 'post' );
 		}
 
-		if ( ! empty( self::$type_boxes['user'] ) ) {
+		if ( ! empty( self::$type_boxes[ 'user' ] ) ) {
 			self::register_rest_field( 'user', 'user' );
 		}
 
-		if ( ! empty( self::$type_boxes['comment'] ) ) {
+		if ( ! empty( self::$type_boxes[ 'comment' ] ) ) {
 			self::register_rest_field( 'comment', 'comment' );
 		}
 
-		if ( ! empty( self::$type_boxes['term'] ) ) {
+		if ( ! empty( self::$type_boxes[ 'term' ] ) ) {
 			self::register_rest_field( $taxonomies, 'term' );
 		}
 	}
@@ -217,18 +217,18 @@ 
 	 */
 	protected function declare_read_edit_fields() {
 		foreach ( $this->cmb->prop( 'fields' ) as $field ) {
-			$show_in_rest = isset( $field['show_in_rest'] ) ? $field['show_in_rest'] : null;
+			$show_in_rest = isset( $field[ 'show_in_rest' ] ) ? $field[ 'show_in_rest' ] : null;
 
 			if ( false === $show_in_rest ) {
 				continue;
 			}
 
 			if ( $this->can_read( $show_in_rest ) ) {
-				$this->read_fields[] = $field['id'];
+				$this->read_fields[ ] = $field[ 'id' ];
 			}
 
 			if ( $this->can_edit( $show_in_rest ) ) {
-				$this->edit_fields[] = $field['id'];
+				$this->edit_fields[ ] = $field[ 'id' ];
 			}
 
 		}
@@ -359,7 +359,7 @@ 
 	 * @return mixed
 	 */
 	protected static function get_rest_values( $object, $request, $object_type, $main_object_type = 'post' ) {
-		if ( ! isset( $object['id'] ) ) {
+		if ( ! isset( $object[ 'id' ] ) ) {
 			return;
 		}
 
@@ -370,12 +370,12 @@ 
 				$rest_box = self::$boxes[ $cmb_id ];
 
 				foreach ( $rest_box->read_fields as $field_id ) {
-					$rest_box->cmb->object_id( $object['id'] );
+					$rest_box->cmb->object_id( $object[ 'id' ] );
 					$rest_box->cmb->object_type( $main_object_type );
 
 					$field = $rest_box->cmb->get_field( $field_id );
 
-					$field->object_id( $object['id'] );
+					$field->object_id( $object[ 'id' ] );
 					$field->object_type( $main_object_type );
 
 					$values[ $cmb_id ][ $field->id( true ) ] = $field->get_data();
@@ -609,8 +609,8 @@ 
 					return intval( $object->comment_ID );
 				}
 			case 'term':
-				if ( is_array( $object ) && isset( $object['term_id'] ) ) {
-					return intval( $object['term_id'] );
+				if ( is_array( $object ) && isset( $object[ 'term_id' ] ) ) {
+					return intval( $object[ 'term_id' ] );
 				} elseif ( isset( $object->term_id ) ) {
 					return intval( $object->term_id );
 				}

includes/rest-api/CMB2_REST_Controller.php

Doc Comments +1 added lines, -3 removed lines

@@ -142,7 +142,6 @@ 
 	 *
 	 * @since 2.2.4
 	 *
-	 * @param  mixed $data
 	 * @return array $data
 	 */
 	public function prepare_item( $post ) {
@@ -155,7 +154,7 @@ 
 	 * @since  2.2.4
 	 *
 	 * @param  mixed $cb Callable function/method.
-	 * @return mixed     Results of output buffer after calling function/method.
+	 * @return string     Results of output buffer after calling function/method.
 	 */
 	public function get_cb_results( $cb ) {
 		$args = func_get_args();
@@ -171,7 +170,6 @@ 
 	 *
 	 * @since 2.2.4
 	 *
-	 * @param  mixed            $item     WordPress representation of the item.
 	 * @param  WP_REST_Request  $request  Request object.
 	 * @return WP_REST_Response $response
 	 */

Spacing +7 added lines, -7 removed lines

@@ -226,7 +226,7 @@ 
 	 * @return WP_REST_Response $response
 	 */
 	public function prepare_item_for_response( $data, $request = null ) {
-		$data = $this->filter_response_by_context( $data, $this->request['context'] );
+		$data = $this->filter_response_by_context( $data, $this->request[ 'context' ] );
 
 		/**
 		 * Filter the prepared CMB2 item response.
@@ -297,12 +297,12 @@ 
 
 		} else {
 
-			if ( isset( $this->request['object_id'] ) ) {
-				$this->rest_box->cmb->object_id( sanitize_text_field( $this->request['object_id'] ) );
+			if ( isset( $this->request[ 'object_id' ] ) ) {
+				$this->rest_box->cmb->object_id( sanitize_text_field( $this->request[ 'object_id' ] ) );
 			}
 
-			if ( isset( $this->request['object_type'] ) ) {
-				$this->rest_box->cmb->object_type( sanitize_text_field( $this->request['object_type'] ) );
+			if ( isset( $this->request[ 'object_type' ] ) ) {
+				$this->rest_box->cmb->object_type( sanitize_text_field( $this->request[ 'object_type' ] ) );
 			}
 		}
 	}
@@ -320,8 +320,8 @@ 
 	public function initiate_request( $request, $request_type ) {
 		$this->request = $request;
 
-		if ( ! isset( $this->request['context'] ) || empty( $this->request['context'] ) ) {
-			$this->request['context'] = 'view';
+		if ( ! isset( $this->request[ 'context' ] ) || empty( $this->request[ 'context' ] ) ) {
+			$this->request[ 'context' ] = 'view';
 		}
 
 		if ( ! self::$request_type ) {