WebDevStudios /
CMB2
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like CMB2_hookup often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CMB2_hookup, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 14 | class CMB2_hookup { |
||
|
|
|||
| 15 | |||
| 16 | /** |
||
| 17 | * Array of all hooks done (to be run once) |
||
| 18 | * @var array |
||
| 19 | * @since 2.0.0 |
||
| 20 | */ |
||
| 21 | protected static $hooks_completed = array(); |
||
| 22 | |||
| 23 | /** |
||
| 24 | * Only allow JS registration once |
||
| 25 | * @var bool |
||
| 26 | * @since 2.0.7 |
||
| 27 | */ |
||
| 28 | protected static $js_registration_done = false; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Only allow CSS registration once |
||
| 32 | * @var bool |
||
| 33 | * @since 2.0.7 |
||
| 34 | */ |
||
| 35 | protected static $css_registration_done = false; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @var CMB2 object |
||
| 39 | * @since 2.0.2 |
||
| 40 | */ |
||
| 41 | protected $cmb; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * CMB taxonomies array for term meta |
||
| 45 | * @var array |
||
| 46 | * @since 2.2.0 |
||
| 47 | */ |
||
| 48 | protected $taxonomies = array(); |
||
| 49 | |||
| 50 | /** |
||
| 51 | * Custom field columns. |
||
| 52 | * @var array |
||
| 53 | * @since 2.2.2 |
||
| 54 | */ |
||
| 55 | protected $columns = array(); |
||
| 56 | |||
| 57 | /** |
||
| 58 | * The object type we are performing the hookup for |
||
| 59 | * @var string |
||
| 60 | * @since 2.0.9 |
||
| 61 | */ |
||
| 62 | protected $object_type = 'post'; |
||
| 63 | |||
| 64 | public function __construct( CMB2 $cmb ) { |
||
| 85 | |||
| 86 | public function universal_hooks() { |
||
| 101 | |||
| 102 | public function post_hooks() { |
||
| 115 | |||
| 116 | public function comment_hooks() { |
||
| 125 | |||
| 126 | public function user_hooks() { |
||
| 142 | |||
| 143 | public function term_hooks() { |
||
| 182 | |||
| 183 | /** |
||
| 184 | * Registers styles for CMB2 |
||
| 185 | * @since 2.0.7 |
||
| 186 | */ |
||
| 187 | 1 | protected static function register_styles() { |
|
| 204 | |||
| 205 | /** |
||
| 206 | * Registers scripts for CMB2 |
||
| 207 | * @since 2.0.7 |
||
| 208 | */ |
||
| 209 | 1 | protected static function register_js() { |
|
| 219 | |||
| 220 | /** |
||
| 221 | * Registers scripts and styles for CMB2 |
||
| 222 | * @since 1.0.0 |
||
| 223 | */ |
||
| 224 | public static function register_scripts() { |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Enqueues scripts and styles for CMB2 in admin_head. |
||
| 231 | * @since 1.0.0 |
||
| 232 | */ |
||
| 233 | public function do_scripts( $hook ) { |
||
| 257 | |||
| 258 | /** |
||
| 259 | * Register the CMB2 field column headers. |
||
| 260 | * @since 2.2.2 |
||
| 261 | */ |
||
| 262 | public function register_column_headers( $columns ) { |
||
| 289 | |||
| 290 | /** |
||
| 291 | * The CMB2 field column display output. |
||
| 292 | * @since 2.2.2 |
||
| 293 | */ |
||
| 294 | public function column_display( $column_name, $object_id ) { |
||
| 306 | |||
| 307 | /** |
||
| 308 | * Returns the column display. |
||
| 309 | * @since 2.2.2 |
||
| 310 | */ |
||
| 311 | public function return_column_display( $empty, $custom_column, $object_id ) { |
||
| 318 | |||
| 319 | /** |
||
| 320 | * Add metaboxes (to 'post' or 'comment' object types) |
||
| 321 | * @since 1.0.0 |
||
| 322 | */ |
||
| 323 | public function add_metaboxes() { |
||
| 350 | |||
| 351 | /** |
||
| 352 | * Add 'closed' class to metabox |
||
| 353 | * @since 2.0.0 |
||
| 354 | * @param array $classes Array of classes |
||
| 355 | * @return array Modified array of classes |
||
| 356 | */ |
||
| 357 | public function close_metabox_class( $classes ) { |
||
| 361 | |||
| 362 | /** |
||
| 363 | * Display metaboxes for a post or comment object |
||
| 364 | * @since 1.0.0 |
||
| 365 | */ |
||
| 366 | public function metabox_callback() { |
||
| 370 | |||
| 371 | /** |
||
| 372 | * Display metaboxes for new user page |
||
| 373 | * @since 1.0.0 |
||
| 374 | */ |
||
| 375 | public function user_new_metabox( $section ) { |
||
| 382 | |||
| 383 | /** |
||
| 384 | * Display metaboxes for a user object |
||
| 385 | * @since 1.0.0 |
||
| 386 | */ |
||
| 387 | public function user_metabox() { |
||
| 390 | |||
| 391 | /** |
||
| 392 | * Display metaboxes for a taxonomy term object |
||
| 393 | * @since 2.2.0 |
||
| 394 | */ |
||
| 395 | public function term_metabox() { |
||
| 398 | |||
| 399 | /** |
||
| 400 | * Display metaboxes for an object type |
||
| 401 | * @since 2.2.0 |
||
| 402 | * @param string $type Object type |
||
| 403 | * @return void |
||
| 404 | */ |
||
| 405 | public function show_form_for_type( $type ) { |
||
| 423 | |||
| 424 | /** |
||
| 425 | * Determines if metabox should be shown in current context |
||
| 426 | * @since 2.0.0 |
||
| 427 | * @return bool Whether metabox should be added/shown |
||
| 428 | */ |
||
| 429 | public function show_on() { |
||
| 444 | |||
| 445 | /** |
||
| 446 | * Get the CMB priority property set to numeric hook priority. |
||
| 447 | * @since 2.2.0 |
||
| 448 | * @param integer $default Default display hook priority. |
||
| 449 | * @return integer Hook priority. |
||
| 450 | */ |
||
| 451 | public function get_priority( $default = 10 ) { |
||
| 473 | |||
| 474 | /** |
||
| 475 | * Save data from post metabox |
||
| 476 | * @since 1.0.0 |
||
| 477 | * @param int $post_id Post ID |
||
| 478 | * @param mixed $post Post object |
||
| 479 | * @return null |
||
| 480 | */ |
||
| 481 | public function save_post( $post_id, $post = false ) { |
||
| 500 | |||
| 501 | /** |
||
| 502 | * Save data from comment metabox |
||
| 503 | * @since 2.0.9 |
||
| 504 | * @param int $comment_id Comment ID |
||
| 505 | * @return null |
||
| 506 | */ |
||
| 507 | public function save_comment( $comment_id ) { |
||
| 515 | |||
| 516 | /** |
||
| 517 | * Save data from user fields |
||
| 518 | * @since 1.0.x |
||
| 519 | * @param int $user_id User ID |
||
| 520 | * @return null |
||
| 521 | */ |
||
| 522 | public function save_user( $user_id ) { |
||
| 528 | |||
| 529 | /** |
||
| 530 | * Save data from term fields |
||
| 531 | * @since 2.2.0 |
||
| 532 | * @param int $term_id Term ID |
||
| 533 | * @param int $tt_id Term Taxonomy ID |
||
| 534 | * @param string $taxonomy Taxonomy |
||
| 535 | * @return null |
||
| 536 | */ |
||
| 537 | public function save_term( $term_id, $tt_id, $taxonomy = '' ) { |
||
| 545 | |||
| 546 | /** |
||
| 547 | * Delete term meta when a term is deleted. |
||
| 548 | * @since 2.2.0 |
||
| 549 | * @param int $term_id Term ID |
||
| 550 | * @param int $tt_id Term Taxonomy ID |
||
| 551 | * @param string $taxonomy Taxonomy |
||
| 552 | * @return null |
||
| 553 | */ |
||
| 554 | public function delete_term( $term_id, $tt_id, $taxonomy = '' ) { |
||
| 564 | |||
| 565 | /** |
||
| 566 | * Determines if the current object is able to be saved |
||
| 567 | * @since 2.0.9 |
||
| 568 | * @param string $type Current post_type or comment_type |
||
| 569 | * @return bool Whether object can be saved |
||
| 570 | */ |
||
| 571 | public function can_save( $type = '' ) { |
||
| 583 | |||
| 584 | /** |
||
| 585 | * Determine if taxonomy of term being modified is cmb2-editable. |
||
| 586 | * @since 2.2.0 |
||
| 587 | * @param string $taxonomy Taxonomy of term being modified. |
||
| 588 | * @return bool Whether taxonomy is editable. |
||
| 589 | */ |
||
| 590 | public function taxonomy_can_save( $taxonomy ) { |
||
| 603 | |||
| 604 | /** |
||
| 605 | * Ensures WordPress hook only gets fired once |
||
| 606 | * @since 2.0.0 |
||
| 607 | * @param string $action The name of the filter to hook the $hook callback to. |
||
| 608 | * @param callback $hook The callback to be run when the filter is applied. |
||
| 609 | * @param integer $priority Order the functions are executed |
||
| 610 | * @param int $accepted_args The number of arguments the function accepts. |
||
| 611 | */ |
||
| 612 | public function once( $action, $hook, $priority = 10, $accepted_args = 1 ) { |
||
| 622 | |||
| 623 | /** |
||
| 624 | * Includes CMB2 styles |
||
| 625 | * @since 2.0.0 |
||
| 626 | */ |
||
| 627 | 1 | public static function enqueue_cmb_css( $handle = 'cmb2-styles' ) { |
|
| 635 | |||
| 636 | /** |
||
| 637 | * Includes CMB2 JS |
||
| 638 | * @since 2.0.0 |
||
| 639 | */ |
||
| 640 | 1 | public static function enqueue_cmb_js() { |
|
| 648 | |||
| 649 | } |
||
| 650 |
Loading history...
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.