Complex classes like CMB2_Utils often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use CMB2_Utils, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | class CMB2_Utils { |
||
|
|||
14 | |||
15 | /** |
||
16 | * The url which is used to load local resources. |
||
17 | * @var string |
||
18 | * @since 2.0.0 |
||
19 | */ |
||
20 | protected $url = ''; |
||
21 | |||
22 | /** |
||
23 | * Utility method that attempts to get an attachment's ID by it's url |
||
24 | * @since 1.0.0 |
||
25 | * @param string $img_url Attachment url |
||
26 | * @return int|false Attachment ID or false |
||
27 | */ |
||
28 | 1 | public function image_id_from_url( $img_url ) { |
|
70 | |||
71 | /** |
||
72 | * Utility method that returns time string offset by timezone |
||
73 | * @since 1.0.0 |
||
74 | * @param string $tzstring Time string |
||
75 | * @return string Offset time string |
||
76 | */ |
||
77 | 1 | public function timezone_offset( $tzstring ) { |
|
97 | |||
98 | /** |
||
99 | * Utility method that returns a timezone string representing the default timezone for the site. |
||
100 | * |
||
101 | * Roughly copied from WordPress, as get_option('timezone_string') will return |
||
102 | * an empty string if no value has been set on the options page. |
||
103 | * A timezone string is required by the wp_timezone_choice() used by the |
||
104 | * select_timezone field. |
||
105 | * |
||
106 | * @since 1.0.0 |
||
107 | * @return string Timezone string |
||
108 | */ |
||
109 | 1 | public function timezone_string() { |
|
130 | |||
131 | /** |
||
132 | * Returns a timestamp, first checking if value already is a timestamp. |
||
133 | * @since 2.0.0 |
||
134 | * @param string|int $string Possible timestamp string |
||
135 | * @return int Time stamp |
||
136 | */ |
||
137 | 5 | public function make_valid_time_stamp( $string ) { |
|
146 | |||
147 | /** |
||
148 | * Determine if a value is a valid timestamp |
||
149 | * @since 2.0.0 |
||
150 | * @param mixed $timestamp Value to check |
||
151 | * @return boolean Whether value is a valid timestamp |
||
152 | */ |
||
153 | 5 | public function is_valid_time_stamp( $timestamp ) { |
|
158 | |||
159 | /** |
||
160 | * Checks if a value is 'empty'. Still accepts 0. |
||
161 | * @since 2.0.0 |
||
162 | * @param mixed $value Value to check |
||
163 | * @return bool True or false |
||
164 | */ |
||
165 | 51 | public function isempty( $value ) { |
|
168 | |||
169 | /** |
||
170 | * Insert a single array item inside another array at a set position |
||
171 | * @since 2.0.2 |
||
172 | * @param array &$array Array to modify. Is passed by reference, and no return is needed. |
||
173 | * @param array $new New array to insert |
||
174 | * @param int $position Position in the main array to insert the new array |
||
175 | */ |
||
176 | 2 | public function array_insert( &$array, $new, $position ) { |
|
181 | |||
182 | /** |
||
183 | * Defines the url which is used to load local resources. |
||
184 | * This may need to be filtered for local Window installations. |
||
185 | * If resources do not load, please check the wiki for details. |
||
186 | * @since 1.0.1 |
||
187 | * @return string URL to CMB2 resources |
||
188 | */ |
||
189 | 2 | public function url( $path = '' ) { |
|
205 | |||
206 | /** |
||
207 | * Converts a system path to a URL |
||
208 | * @since 2.2.2 |
||
209 | * @param string $dir Directory path to convert. |
||
210 | * @return string Converted URL. |
||
211 | */ |
||
212 | 1 | public static function get_url_from_dir( $dir ) { |
|
229 | |||
230 | /** |
||
231 | * Get timestamp from text date |
||
232 | * @since 2.2.0 |
||
233 | * @param string $value Date value |
||
234 | * @param string $date_format Expected date format |
||
235 | * @return mixed Unix timestamp representing the date. |
||
236 | */ |
||
237 | public function get_timestamp_from_value( $value, $date_format ) { |
||
241 | |||
242 | /** |
||
243 | * Takes a php date() format string and returns a string formatted to suit for the date/time pickers |
||
244 | * It will work with only with the following subset ot date() options: |
||
245 | * |
||
246 | * d, j, z, m, n, y, and Y. |
||
247 | * |
||
248 | * A slight effort is made to deal with escaped characters. |
||
249 | * |
||
250 | * Other options are ignored, because they would either bring compatibility problems between PHP and JS, or |
||
251 | * bring even more translation troubles. |
||
252 | * |
||
253 | * @since 2.2.0 |
||
254 | * @param string $format php date format |
||
255 | * @return string reformatted string |
||
256 | */ |
||
257 | 5 | public function php_to_js_dateformat( $format ) { |
|
291 | |||
292 | /** |
||
293 | * Helper function for CMB_Utils->php_to_js_dateformat, because php 5.2 was retarded. |
||
294 | * @since 2.2.0 |
||
295 | * @param $value Value to wrap/escape |
||
296 | * @return string Modified value |
||
297 | */ |
||
298 | 4 | public function wrap_escaped_chars( $value ) { |
|
301 | |||
302 | /** |
||
303 | * Send to debug.log if WP_DEBUG is defined and true |
||
304 | * |
||
305 | * @since 2.2.0 |
||
306 | * |
||
307 | * @param string $function Function name |
||
308 | * @param int $line Line number |
||
309 | * @param mixed $msg Message to output |
||
310 | * @param mixed $debug Variable to print_r |
||
311 | */ |
||
312 | public function log_if_debug( $function, $line, $msg, $debug = null ) { |
||
317 | |||
318 | /** |
||
319 | * Determine a file's extension |
||
320 | * @since 1.0.0 |
||
321 | * @param string $file File url |
||
322 | * @return string|false File extension or false |
||
323 | */ |
||
324 | 4 | public function get_file_ext( $file ) { |
|
328 | |||
329 | /** |
||
330 | * Get the file name from a url |
||
331 | * @since 2.0.0 |
||
332 | * @param string $value File url or path |
||
333 | * @return string File name |
||
334 | */ |
||
335 | 3 | public function get_file_name_from_path( $value ) { |
|
339 | } |
||
340 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.