Completed
Push — trunk ( 6ee722...c7df04 )
by Justin
20:09 queued 04:47
created
includes/CMB2.php 1 patch
Spacing   +69 added lines, -69 removed lines patch added patch discarded remove patch
@@ -111,19 +111,19 @@  discard block
 block discarded – undo
111 111
 	 */
112 112
 	public function __construct( $config, $object_id = 0 ) {
113 113
 
114
-		if ( empty( $config['id'] ) ) {
114
+		if ( empty( $config[ 'id' ] ) ) {
115 115
 			wp_die( __( 'Metabox configuration is required to have an ID parameter', 'cmb2' ) );
116 116
 		}
117 117
 
118 118
 		$this->meta_box = wp_parse_args( $config, $this->mb_defaults );
119
-		$this->meta_box['fields'] = array();
119
+		$this->meta_box[ 'fields' ] = array();
120 120
 
121 121
 		$this->object_id( $object_id );
122 122
 		$this->mb_object_type();
123
-		$this->cmb_id = $config['id'];
123
+		$this->cmb_id = $config[ 'id' ];
124 124
 
125
-		if ( ! empty( $config['fields'] ) && is_array( $config['fields'] ) ) {
126
-			$this->add_fields( $config['fields'] );
125
+		if ( ! empty( $config[ 'fields' ] ) && is_array( $config[ 'fields' ] ) ) {
126
+			$this->add_fields( $config[ 'fields' ] );
127 127
 		}
128 128
 
129 129
 		CMB2_Boxes::add( $this );
@@ -292,22 +292,22 @@  discard block
 block discarded – undo
292 292
 	 * @return mixed CMB2_Field object if successful.
293 293
 	 */
294 294
 	public function render_field( $field_args ) {
295
-		$field_args['context'] = $this->prop( 'context' );
295
+		$field_args[ 'context' ] = $this->prop( 'context' );
296 296
 
297
-		if ( 'group' == $field_args['type'] ) {
297
+		if ( 'group' == $field_args[ 'type' ] ) {
298 298
 
299
-			if ( ! isset( $field_args['show_names'] ) ) {
300
-				$field_args['show_names'] = $this->prop( 'show_names' );
299
+			if ( ! isset( $field_args[ 'show_names' ] ) ) {
300
+				$field_args[ 'show_names' ] = $this->prop( 'show_names' );
301 301
 			}
302 302
 			$field = $this->render_group( $field_args );
303 303
 
304
-		} elseif ( 'hidden' == $field_args['type'] && $this->get_field( $field_args )->should_show() ) {
304
+		} elseif ( 'hidden' == $field_args[ 'type' ] && $this->get_field( $field_args )->should_show() ) {
305 305
 			// Save rendering for after the metabox
306 306
 			$field = $this->add_hidden_field( $field_args );
307 307
 
308 308
 		} else {
309 309
 
310
-			$field_args['show_names'] = $this->prop( 'show_names' );
310
+			$field_args[ 'show_names' ] = $this->prop( 'show_names' );
311 311
 
312 312
 			// Render default fields
313 313
 			$field = $this->get_field( $field_args )->render_field();
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 	 */
324 324
 	public function render_group( $args ) {
325 325
 
326
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
326
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
327 327
 			return;
328 328
 		}
329 329
 
@@ -405,15 +405,15 @@  discard block
 block discarded – undo
405 405
 			<div class="inside cmb-td cmb-nested cmb-field-list">';
406 406
 				// Loop and render repeatable group fields
407 407
 				foreach ( array_values( $field_group->args( 'fields' ) ) as $field_args ) {
408
-					if ( 'hidden' == $field_args['type'] ) {
408
+					if ( 'hidden' == $field_args[ 'type' ] ) {
409 409
 
410 410
 						// Save rendering for after the metabox
411 411
 						$this->add_hidden_field( $field_args, $field_group );
412 412
 
413 413
 					} else {
414 414
 
415
-						$field_args['show_names'] = $field_group->args( 'show_names' );
416
-						$field_args['context']    = $field_group->args( 'context' );
415
+						$field_args[ 'show_names' ] = $field_group->args( 'show_names' );
416
+						$field_args[ 'context' ]    = $field_group->args( 'context' );
417 417
 
418 418
 						$field = $this->get_field( $field_args, $field_group )->render_field();
419 419
 					}
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
 	 * @param array  $field_args Array of field arguments to be passed to CMB2_Field
442 442
 	 */
443 443
 	public function add_hidden_field( $field_args, $field_group = null ) {
444
-		if ( isset( $field_args['field_args'] ) ) {
444
+		if ( isset( $field_args[ 'field_args' ] ) ) {
445 445
 			// For back-compatibility.
446 446
 			$field = new CMB2_Field( $field_args );
447 447
 		} else {
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
 			$type->iterator = $field_group->index;
455 455
 		}
456 456
 
457
-		$this->hidden_fields[] = $type;
457
+		$this->hidden_fields[ ] = $type;
458 458
 
459 459
 		return $field;
460 460
 	}
@@ -551,11 +551,11 @@  discard block
 block discarded – undo
551 551
 	 */
552 552
 	public function process_field( $field_args ) {
553 553
 
554
-		switch ( $field_args['type'] ) {
554
+		switch ( $field_args[ 'type' ] ) {
555 555
 
556 556
 			case 'group':
557 557
 				if ( $this->save_group( $field_args ) ) {
558
-					$this->updated[] = $field_args['id'];
558
+					$this->updated[ ] = $field_args[ 'id' ];
559 559
 				}
560 560
 
561 561
 				break;
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 				$field = $this->get_new_field( $field_args );
570 570
 
571 571
 				if ( $field->save_field_from_data( $this->data_to_save ) ) {
572
-					$this->updated[] = $field->id();
572
+					$this->updated[ ] = $field->id();
573 573
 				}
574 574
 
575 575
 				break;
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
636 636
 	 * @return mixed        Return of CMB2_Field::update_data()
637 637
 	 */
638 638
 	public function save_group( $args ) {
639
-		if ( ! isset( $args['id'], $args['fields'] ) || ! is_array( $args['fields'] ) ) {
639
+		if ( ! isset( $args[ 'id' ], $args[ 'fields' ] ) || ! is_array( $args[ 'fields' ] ) ) {
640 640
 			return;
641 641
 		}
642 642
 
@@ -684,16 +684,16 @@  discard block
 block discarded – undo
684 684
 						$_new_val = array();
685 685
 						foreach ( $new_val as $group_index => $grouped_data ) {
686 686
 							// Add the supporting data to the $saved array stack
687
-							$saved[ $field_group->index ][ $grouped_data['supporting_field_id'] ][] = $grouped_data['supporting_field_value'];
687
+							$saved[ $field_group->index ][ $grouped_data[ 'supporting_field_id' ] ][ ] = $grouped_data[ 'supporting_field_value' ];
688 688
 							// Reset var to the actual value
689
-							$_new_val[ $group_index ] = $grouped_data['value'];
689
+							$_new_val[ $group_index ] = $grouped_data[ 'value' ];
690 690
 						}
691 691
 						$new_val = $_new_val;
692 692
 					} else {
693 693
 						// Add the supporting data to the $saved array stack
694
-						$saved[ $field_group->index ][ $new_val['supporting_field_id'] ] = $new_val['supporting_field_value'];
694
+						$saved[ $field_group->index ][ $new_val[ 'supporting_field_id' ] ] = $new_val[ 'supporting_field_value' ];
695 695
 						// Reset var to the actual value
696
-						$new_val = $new_val['value'];
696
+						$new_val = $new_val[ 'value' ];
697 697
 					}
698 698
 				}
699 699
 
@@ -707,7 +707,7 @@  discard block
 block discarded – undo
707 707
 
708 708
 				// Compare values and add to `$updated` array
709 709
 				if ( $is_updated || $is_removed ) {
710
-					$this->updated[] = $base_id . '::' . $field_group->index . '::' . $sub_id;
710
+					$this->updated[ ] = $base_id . '::' . $field_group->index . '::' . $sub_id;
711 711
 				}
712 712
 
713 713
 				// Add to `$saved` array
@@ -744,22 +744,22 @@  discard block
 block discarded – undo
744 744
 		// Try to get our object ID from the global space
745 745
 		switch ( $this->object_type() ) {
746 746
 			case 'user':
747
-				$object_id = isset( $_REQUEST['user_id'] ) ? $_REQUEST['user_id'] : $object_id;
748
-				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS['user_ID'] ) ? $GLOBALS['user_ID'] : $object_id;
747
+				$object_id = isset( $_REQUEST[ 'user_id' ] ) ? $_REQUEST[ 'user_id' ] : $object_id;
748
+				$object_id = ! $object_id && 'user-new.php' != $pagenow && isset( $GLOBALS[ 'user_ID' ] ) ? $GLOBALS[ 'user_ID' ] : $object_id;
749 749
 				break;
750 750
 
751 751
 			case 'comment':
752
-				$object_id = isset( $_REQUEST['c'] ) ? $_REQUEST['c'] : $object_id;
753
-				$object_id = ! $object_id && isset( $GLOBALS['comments']->comment_ID ) ? $GLOBALS['comments']->comment_ID : $object_id;
752
+				$object_id = isset( $_REQUEST[ 'c' ] ) ? $_REQUEST[ 'c' ] : $object_id;
753
+				$object_id = ! $object_id && isset( $GLOBALS[ 'comments' ]->comment_ID ) ? $GLOBALS[ 'comments' ]->comment_ID : $object_id;
754 754
 				break;
755 755
 
756 756
 			case 'term':
757
-				$object_id = isset( $_REQUEST['tag_ID'] ) ? $_REQUEST['tag_ID'] : $object_id;
757
+				$object_id = isset( $_REQUEST[ 'tag_ID' ] ) ? $_REQUEST[ 'tag_ID' ] : $object_id;
758 758
 				break;
759 759
 
760 760
 			default:
761
-				$object_id = isset( $GLOBALS['post']->ID ) ? $GLOBALS['post']->ID : $object_id;
762
-				$object_id = isset( $_REQUEST['post'] ) ? $_REQUEST['post'] : $object_id;
761
+				$object_id = isset( $GLOBALS[ 'post' ]->ID ) ? $GLOBALS[ 'post' ]->ID : $object_id;
762
+				$object_id = isset( $_REQUEST[ 'post' ] ) ? $_REQUEST[ 'post' ] : $object_id;
763 763
 				break;
764 764
 		}
765 765
 
@@ -835,7 +835,7 @@  discard block
 block discarded – undo
835 835
 	 * @return boolean True/False
836 836
 	 */
837 837
 	public function is_options_page_mb() {
838
-		return ( isset( $this->meta_box['show_on']['key'] ) && 'options-page' === $this->meta_box['show_on']['key'] || array_key_exists( 'options-page', $this->meta_box['show_on'] ) );
838
+		return ( isset( $this->meta_box[ 'show_on' ][ 'key' ] ) && 'options-page' === $this->meta_box[ 'show_on' ][ 'key' ] || array_key_exists( 'options-page', $this->meta_box[ 'show_on' ] ) );
839 839
 	}
840 840
 
841 841
 	/**
@@ -922,7 +922,7 @@  discard block
 block discarded – undo
922 922
 			return $field;
923 923
 		}
924 924
 
925
-		$field_id = is_string( $field ) ? $field : $field['id'];
925
+		$field_id = is_string( $field ) ? $field : $field[ 'id' ];
926 926
 
927 927
 		$parent_field_id = ! empty( $field_group ) ? $field_group->id() : '';
928 928
 		$ids = $this->get_field_ids( $field_id, $parent_field_id, true );
@@ -958,16 +958,16 @@  discard block
 block discarded – undo
958 958
 		if ( $field_group && ( $sub_field_id || 0 === $sub_field_id ) ) {
959 959
 
960 960
 			// Update the fields array w/ any modified properties inherited from the group field
961
-			$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] = $field_args;
961
+			$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] = $field_args;
962 962
 
963 963
 			return $this->get_default_args( $field_args, $field_group );
964 964
 		}
965 965
 
966 966
 		if ( is_array( $field_args ) ) {
967
-			$this->meta_box['fields'][ $field_id ] = array_merge( $field_args, $this->meta_box['fields'][ $field_id ] );
967
+			$this->meta_box[ 'fields' ][ $field_id ] = array_merge( $field_args, $this->meta_box[ 'fields' ][ $field_id ] );
968 968
 		}
969 969
 
970
-		return $this->get_default_args( $this->meta_box['fields'][ $field_id ] );
970
+		return $this->get_default_args( $this->meta_box[ 'fields' ][ $field_id ] );
971 971
 	}
972 972
 
973 973
 	/**
@@ -1017,8 +1017,8 @@  discard block
 block discarded – undo
1017 1017
 
1018 1018
 			$sub_fields = false;
1019 1019
 			if ( array_key_exists( 'fields', $field ) ) {
1020
-				$sub_fields = $field['fields'];
1021
-				unset( $field['fields'] );
1020
+				$sub_fields = $field[ 'fields' ];
1021
+				unset( $field[ 'fields' ] );
1022 1022
 			}
1023 1023
 
1024 1024
 			$field_id = $parent_field_id
@@ -1043,26 +1043,26 @@  discard block
 block discarded – undo
1043 1043
 			return false;
1044 1044
 		}
1045 1045
 
1046
-		if ( 'oembed' === $field['type'] ) {
1046
+		if ( 'oembed' === $field[ 'type' ] ) {
1047 1047
 			// Initiate oembed Ajax hooks
1048 1048
 			cmb2_ajax();
1049 1049
 		}
1050 1050
 
1051
-		if ( isset( $field['column'] ) && false !== $field['column'] ) {
1051
+		if ( isset( $field[ 'column' ] ) && false !== $field[ 'column' ] ) {
1052 1052
 			$field = $this->define_field_column( $field );
1053 1053
 		}
1054 1054
 
1055
-		if ( isset( $field['taxonomy'] ) && ! empty( $field['remove_default'] ) ) {
1056
-			$this->tax_metaboxes_to_remove[ $field['taxonomy'] ] = $field['taxonomy'];
1055
+		if ( isset( $field[ 'taxonomy' ] ) && ! empty( $field[ 'remove_default' ] ) ) {
1056
+			$this->tax_metaboxes_to_remove[ $field[ 'taxonomy' ] ] = $field[ 'taxonomy' ];
1057 1057
 		}
1058 1058
 
1059 1059
 		$this->_add_field_to_array(
1060 1060
 			$field,
1061
-			$this->meta_box['fields'],
1061
+			$this->meta_box[ 'fields' ],
1062 1062
 			$position
1063 1063
 		);
1064 1064
 
1065
-		return $field['id'];
1065
+		return $field[ 'id' ];
1066 1066
 	}
1067 1067
 
1068 1068
 	/**
@@ -1074,10 +1074,10 @@  discard block
 block discarded – undo
1074 1074
 	protected function define_field_column( array $field ) {
1075 1075
 		$this->has_columns = true;
1076 1076
 
1077
-		$column = is_array( $field['column'] ) ? $field['column'] : array();
1077
+		$column = is_array( $field[ 'column' ] ) ? $field[ 'column' ] : array();
1078 1078
 
1079
-		$field['column'] = wp_parse_args( $column, array(
1080
-			'name'     => isset( $field['name'] ) ? $field['name'] : '',
1079
+		$field[ 'column' ] = wp_parse_args( $column, array(
1080
+			'name'     => isset( $field[ 'name' ] ) ? $field[ 'name' ] : '',
1081 1081
 			'position' => false,
1082 1082
 		) );
1083 1083
 
@@ -1093,27 +1093,27 @@  discard block
 block discarded – undo
1093 1093
 	 * @return mixed                   Array of parent/field ids or false
1094 1094
 	 */
1095 1095
 	public function add_group_field( $parent_field_id, array $field, $position = 0 ) {
1096
-		if ( ! array_key_exists( $parent_field_id, $this->meta_box['fields'] ) ) {
1096
+		if ( ! array_key_exists( $parent_field_id, $this->meta_box[ 'fields' ] ) ) {
1097 1097
 			return false;
1098 1098
 		}
1099 1099
 
1100
-		$parent_field = $this->meta_box['fields'][ $parent_field_id ];
1100
+		$parent_field = $this->meta_box[ 'fields' ][ $parent_field_id ];
1101 1101
 
1102
-		if ( 'group' !== $parent_field['type'] ) {
1102
+		if ( 'group' !== $parent_field[ 'type' ] ) {
1103 1103
 			return false;
1104 1104
 		}
1105 1105
 
1106
-		if ( ! isset( $parent_field['fields'] ) ) {
1107
-			$this->meta_box['fields'][ $parent_field_id ]['fields'] = array();
1106
+		if ( ! isset( $parent_field[ 'fields' ] ) ) {
1107
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ] = array();
1108 1108
 		}
1109 1109
 
1110 1110
 		$this->_add_field_to_array(
1111 1111
 			$field,
1112
-			$this->meta_box['fields'][ $parent_field_id ]['fields'],
1112
+			$this->meta_box[ 'fields' ][ $parent_field_id ][ 'fields' ],
1113 1113
 			$position
1114 1114
 		);
1115 1115
 
1116
-		return array( $parent_field_id, $field['id'] );
1116
+		return array( $parent_field_id, $field[ 'id' ] );
1117 1117
 	}
1118 1118
 
1119 1119
 	/**
@@ -1125,9 +1125,9 @@  discard block
 block discarded – undo
1125 1125
 	 */
1126 1126
 	protected function _add_field_to_array( $field, &$fields, $position = 0 ) {
1127 1127
 		if ( $position ) {
1128
-			cmb2_utils()->array_insert( $fields, array( $field['id'] => $field ), $position );
1128
+			cmb2_utils()->array_insert( $fields, array( $field[ 'id' ] => $field ), $position );
1129 1129
 		} else {
1130
-			$fields[ $field['id'] ] = $field;
1130
+			$fields[ $field[ 'id' ] ] = $field;
1131 1131
 		}
1132 1132
 	}
1133 1133
 
@@ -1150,15 +1150,15 @@  discard block
 block discarded – undo
1150 1150
 		unset( $this->fields[ implode( '', $ids ) ] );
1151 1151
 
1152 1152
 		if ( ! $sub_field_id ) {
1153
-			unset( $this->meta_box['fields'][ $field_id ] );
1153
+			unset( $this->meta_box[ 'fields' ][ $field_id ] );
1154 1154
 			return true;
1155 1155
 		}
1156 1156
 
1157
-		if ( isset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] ) ) {
1158
-			unset( $this->fields[ $field_id ]->args['fields'][ $sub_field_id ] );
1157
+		if ( isset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] ) ) {
1158
+			unset( $this->fields[ $field_id ]->args[ 'fields' ][ $sub_field_id ] );
1159 1159
 		}
1160
-		if ( isset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] ) ) {
1161
-			unset( $this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ] );
1160
+		if ( isset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] ) ) {
1161
+			unset( $this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ] );
1162 1162
 		}
1163 1163
 		return true;
1164 1164
 	}
@@ -1182,11 +1182,11 @@  discard block
 block discarded – undo
1182 1182
 		list( $field_id, $sub_field_id ) = $ids;
1183 1183
 
1184 1184
 		if ( ! $sub_field_id ) {
1185
-			$this->meta_box['fields'][ $field_id ][ $property ] = $value;
1185
+			$this->meta_box[ 'fields' ][ $field_id ][ $property ] = $value;
1186 1186
 			return $field_id;
1187 1187
 		}
1188 1188
 
1189
-		$this->meta_box['fields'][ $field_id ]['fields'][ $sub_field_id ][ $property ] = $value;
1189
+		$this->meta_box[ 'fields' ][ $field_id ][ 'fields' ][ $sub_field_id ][ $property ] = $value;
1190 1190
 		return $field_id;
1191 1191
 	}
1192 1192
 
@@ -1200,7 +1200,7 @@  discard block
 block discarded – undo
1200 1200
 	public function get_field_ids( $field_id, $parent_field_id = '' ) {
1201 1201
 		$sub_field_id = $parent_field_id ? $field_id : '';
1202 1202
 		$field_id     = $parent_field_id ? $parent_field_id : $field_id;
1203
-		$fields       =& $this->meta_box['fields'];
1203
+		$fields       = & $this->meta_box[ 'fields' ];
1204 1204
 
1205 1205
 		if ( ! array_key_exists( $field_id, $fields ) ) {
1206 1206
 			$field_id = $this->search_old_school_array( $field_id, $fields );
@@ -1214,12 +1214,12 @@  discard block
 block discarded – undo
1214 1214
 			return array( $field_id, $sub_field_id );
1215 1215
 		}
1216 1216
 
1217
-		if ( 'group' !== $fields[ $field_id ]['type'] ) {
1217
+		if ( 'group' !== $fields[ $field_id ][ 'type' ] ) {
1218 1218
 			return false;
1219 1219
 		}
1220 1220
 
1221
-		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ]['fields'] ) ) {
1222
-			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ]['fields'] );
1221
+		if ( ! array_key_exists( $sub_field_id, $fields[ $field_id ][ 'fields' ] ) ) {
1222
+			$sub_field_id = $this->search_old_school_array( $sub_field_id, $fields[ $field_id ][ 'fields' ] );
1223 1223
 		}
1224 1224
 
1225 1225
 		return false === $sub_field_id ? false : array( $field_id, $sub_field_id );
Please login to merge, or discard this patch.