Issues in bootstrap.php - All Issues - Inspection of "Stop using $wp_version global" - WebDevStudios/CMB2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — trunk (#731)

by Rami

created 2016-09-09 18:14 UTC

bootstrap.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Bootstraps the CMB2 process
 *
 * @category  WordPress_Plugin
 * @package   CMB2
 * @author    WebDevStudios
 * @license   GPL-2.0+
 * @link      http://webdevstudios.com
 */

/**
 * Function to encapsulate the CMB2 bootstrap process.
 * @since  2.2.0
 * @return void
 */
function cmb2_bootstrap() {

	if ( is_admin() ) {
		/**
		 * Fires on the admin side when CMB2 is included/loaded.
		 *
		 * In most cases, this should be used to add metaboxes. See example-functions.php
		 */
		do_action( 'cmb2_admin_init' );
	}

	/**
	 * Fires when CMB2 is included/loaded
	 *
	 * Can be used to add metaboxes if needed on the front-end or WP-API (or the front and backend).
	 */
	do_action( 'cmb2_init' );

	/**
	 * For back-compat. Does the dirty-work of instantiating all the
	 * CMB2 instances for the cmb2_meta_boxes filter
	 * @since  2.0.2
	 */
	$cmb_config_arrays = apply_filters( 'cmb2_meta_boxes', array() );
	foreach ( (array) $cmb_config_arrays as $cmb_config ) {
		new CMB2( $cmb_config );
	}

	/**
	 * Fires after all CMB2 instances are created
	 */
	do_action( 'cmb2_init_before_hookup' );

	/**
	 * Get all created metaboxes, and instantiate CMB2_hookup
	 * on metaboxes which require it.
	 * @since  2.0.2
	 */
	foreach ( CMB2_Boxes::get_all() as $cmb ) {
		if ( $cmb->prop( 'hookup' ) ) {
			$hookup = new CMB2_hookup( $cmb );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		}
	}

	/**
	 * Fires after CMB2 initiation process has been completed
	 */
	do_action( 'cmb2_after_init' );
}

// End. That's it, folks! //


1			<?php
2			/**
3			* Bootstraps the CMB2 process
4			*
5			* @category WordPress_Plugin
6			* @package CMB2
7			* @author WebDevStudios
8			* @license GPL-2.0+
9			* @link http://webdevstudios.com
10			*/
11
12			/**
13			* Function to encapsulate the CMB2 bootstrap process.
14			* @since 2.2.0
15			* @return void
16			*/
17			function cmb2_bootstrap() {
18
19			if ( is_admin() ) {
20			/**
21			* Fires on the admin side when CMB2 is included/loaded.
22			*
23			* In most cases, this should be used to add metaboxes. See example-functions.php
24			*/
25			do_action( 'cmb2_admin_init' );
26			}
27
28			/**
29			* Fires when CMB2 is included/loaded
30			*
31			* Can be used to add metaboxes if needed on the front-end or WP-API (or the front and backend).
32			*/
33			do_action( 'cmb2_init' );
34
35			/**
36			* For back-compat. Does the dirty-work of instantiating all the
37			* CMB2 instances for the cmb2_meta_boxes filter
38			* @since 2.0.2
39			*/
40			$cmb_config_arrays = apply_filters( 'cmb2_meta_boxes', array() );
41			foreach ( (array) $cmb_config_arrays as $cmb_config ) {
42			new CMB2( $cmb_config );
43			}
44
45			/**
46			* Fires after all CMB2 instances are created
47			*/
48			do_action( 'cmb2_init_before_hookup' );
49
50			/**
51			* Get all created metaboxes, and instantiate CMB2_hookup
52			* on metaboxes which require it.
53			* @since 2.0.2
54			*/
55			foreach ( CMB2_Boxes::get_all() as $cmb ) {
56			if ( $cmb->prop( 'hookup' ) ) {
57			$hookup = new CMB2_hookup( $cmb );
			0 ignored issues – show Unused Code introduced 2015-11-24 04:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$hookup` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
58			}
59			}
60
61			/**
62			* Fires after CMB2 initiation process has been completed
63			*/
64			do_action( 'cmb2_after_init' );
65			}
66
67			// End. That's it, folks! //
68

WebDevStudios / CMB2

Pull Request — trunk (#731)

bootstrap.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like