Issues in RunningBalanceServiceTest.php (master) - Issues in master - WeareJH/Flexitime - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Service/RunningBalanceServiceTest.php (31 issues)

Labels

Severity

Major 31

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JhFlexiTimeTest\Service;

use Doctrine\Common\Persistence\ObjectManager;
use JhFlexiTime\Entity\RunningBalance;
use JhFlexiTime\Entity\UserSettings;
use JhFlexiTime\Options\ModuleOptions;
use JhFlexiTime\Repository\BalanceRepositoryInterface;
use JhFlexiTime\Repository\BookingRepository;
use JhFlexiTime\Repository\UserSettingsRepositoryInterface;
use JhFlexiTime\Service\PeriodService;
use JhFlexiTime\Service\RunningBalanceService;
use JhUser\Entity\User;
use JhFlexiTime\DateTime\DateTime;
use JhUser\Repository\UserRepositoryInterface;
use ZfcUser\Entity\UserInterface;

/**
 * Class RunningBalanceServiceTest
 * @package JhFlexiTimeTest\Service
 * @author Aydin Hassan <[email protected]>
 */
class RunningBalanceServiceTest extends \PHPUnit_Framework_TestCase
{

    /**
     * @var UserRepositoryInterface
     */
    protected $userRepository;

    /**
     * @var UserSettingsRepositoryInterface
     */
    protected $userSettingsRepository;

    /**
     * @var RunningBalanceService
     */
    protected $runningBalanceService;

    /**
     * @var PeriodService
     */
    protected $periodService;

    /**
     * @var BookingRepository
     */
    protected $bookingRepository;

    /**
     * @var BalanceRepositoryInterface
     */
    protected $balanceRepository;

    /**
     * @var DateTime
     */
    protected $date;

    /**
     * @var ObjectManager
     */
    protected $objectManager;

    /**
     * @var \Zend\EventManager\EventManagerInterface
     */
    protected $evm;

    public function setUp()
    {
        $this->userRepository           = $this->getMock('JhUser\Repository\UserRepositoryInterface');
        $this->userSettingsRepository   = $this->getMock('JhFlexiTime\Repository\UserSettingsRepositoryInterface');
        $this->balanceRepository        = $this->getMock('JhFlexiTime\Repository\BalanceRepositoryInterface');
        $this->periodService            = new PeriodService(new ModuleOptions());
        $this->bookingRepository        = $this->getMock('JhFlexiTime\Repository\BookingRepositoryInterface');
        $this->objectManager            = $this->getMock('Doctrine\Common\Persistence\ObjectManager');
        $this->date                     = new DateTime("2 May 2014");
        $this->evm                      = $this->getMock('Zend\EventManager\EventManagerInterface');

        $this->runningBalanceService = new RunningBalanceService(
            $this->userRepository,
            $this->userSettingsRepository,
            $this->bookingRepository,
            $this->balanceRepository,
            $this->periodService,
            $this->objectManager,
            $this->date
        );

        $this->runningBalanceService->setEventManager($this->evm);
    }

    public function testCalculatePreviousMonthBalanceWithNoBookedHours()
    {
        list($user1, $userSettings1) = $this->getUser(new DateTime("10 April 2014"));
        list($user2, $userSettings2) = $this->getUser(new DateTime("1 January 2014"));

        $runningBalance1 = new RunningBalance;
        $runningBalance1->setBalance(20);

        $runningBalance2 = new RunningBalance;
        $runningBalance2->setBalance(-20);

        $this->userRepository

            ->expects($this->once())
            ->method('findAll')
            ->with(false)
            ->will($this->returnValue([$user1, $user2]));

        $this->balanceRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $runningBalance1),
                    array($user2, $runningBalance2),
                )
            ));

        $this->userSettingsRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $userSettings1),
                    array($user2, $userSettings2),
                )
            ));

        $invokeCount = $this->evmExpects([new DateTime("30 April 2014 23:59:59")], $runningBalance1, false, 0);
        $this->evmExpects([new DateTime("30 April 2014 23:59:59")], $runningBalance2, false, $invokeCount);

        $this->objectManager->expects($this->once())->method('flush');


        $this->runningBalanceService->indexPreviousMonthBalance();
        $this->assertEquals(-92.5, $runningBalance1->getBalance());
        $this->assertEquals(-185, $runningBalance2->getBalance());
    }

    public function testCalculatePreviousMonthBalanceWithBookedHours()
    {
        list($user1, $userSettings1) = $this->getUser(new DateTime("10 April 2014"));
        list($user2, $userSettings2) = $this->getUser(new DateTime("1 January 2014"));

        $runningBalance1 = new RunningBalance;
        $runningBalance1->setBalance(20);

        $runningBalance2 = new RunningBalance;
        $runningBalance2->setBalance(-20);

        $this->userRepository

            ->expects($this->once())
            ->method('findAll')
            ->with(false)
            ->will($this->returnValue([$user1, $user2]));

        $this->balanceRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $runningBalance1),
                    array($user2, $runningBalance2),
                )
            ));

        $this->userSettingsRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $userSettings1),
                    array($user2, $userSettings2),
                )
            ));

        $user1Dates = [
            [new DateTime("10 April 2014 00:00:00"), new DateTime("30 April 2014 23:59:59"), 100],
        ];

        $user2Dates = [
            [new DateTime("1 April 2014 00:00:00"), new DateTime("30 April 2014 23:59:59"), 100],
        ];

        $invokeCount = $this->bookingRepositoryExpects($user1, $user1Dates);
        $invokeCount = $this->bookingRepositoryExpects($user2, $user2Dates, $invokeCount);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $invokeCount = $this->evmExpects([new DateTime("30 April 2014 23:59:59")], $runningBalance1, false, 0);
        $this->evmExpects([new DateTime("30 April 2014 23:59:59")], $runningBalance2, false, $invokeCount);

        $this->objectManager->expects($this->once())->method('flush');


        $this->runningBalanceService->indexPreviousMonthBalance();
        $this->assertEquals(7.5, $runningBalance1->getBalance());
        $this->assertEquals(-85, $runningBalance2->getBalance());
    }

    public function testCalculateRecalculateAllUsersRunningBalance()
    {
        $user1Start = new DateTime("10 April 2014");
        $user2Start = new DateTime("1 January 2014");
        list($user1, $userSettings1) = $this->getUser($user1Start);
        list($user2, $userSettings2) = $this->getUser($user2Start);

        $runningBalance1 = new RunningBalance;
        $runningBalance2 = new RunningBalance;

        $this->userRepository

            ->expects($this->once())
            ->method('findAll')
            ->with(false)
            ->will($this->returnValue([$user1, $user2]));

        $this->balanceRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $runningBalance1),
                    array($user2, $runningBalance2),
                )
            ));

        $this->userSettingsRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $userSettings1),
                    array($user2, $userSettings2),
                )
            ));

        $this->objectManager->expects($this->once())->method('flush');


        $user1Dates = [
            [$user1Start, new DateTime("30 April 2014 23:59:59"), 0],
        ];

        $user2Dates = [
            [$user2Start, new DateTime('31 January 2014 23:59:59'), 0],
            [new DateTime('1 February 2014 00:00:00'), new DateTime('28 February 2014 23:59:59'), 0],
            [new DateTime('1 March 2014 00:00:00'), new DateTime('31 March 2014 23:59:59'), 0],
            [new DateTime('1 April 2014 00:00:00'), new DateTime('30 April 2014 23:59:59'), 0],
        ];

        $invokeCount = $this->bookingRepositoryExpects($user1, $user1Dates);
        $invokeCount = $this->bookingRepositoryExpects($user2, $user2Dates, $invokeCount);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $invokeCount = $this->evmExpects(array_column($user1Dates, 1), $runningBalance1, true, 0);
        $invokeCount = $this->evmExpects(array_column($user2Dates, 1), $runningBalance2, true, $invokeCount);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->runningBalanceService->reIndexAllUsersRunningBalance();
        $this->assertEquals(-112.5, $runningBalance1->getBalance());
        $this->assertEquals(-645, $runningBalance2->getBalance());
    }

    public function testCalculateRecalculateAllUsersRunningBalanceWithBookedHours()
    {
        $user1Start = new DateTime("10 April 2014");
        $user2Start = new DateTime("1 January 2014");
        list($user1, $userSettings1) = $this->getUser($user1Start);
        list($user2, $userSettings2) = $this->getUser($user2Start);

        $runningBalance1 = new RunningBalance;
        $runningBalance2 = new RunningBalance;

        $this->userRepository

            ->expects($this->once())
            ->method('findAll')
            ->with(false)
            ->will($this->returnValue([$user1, $user2]));

        $this->balanceRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $runningBalance1),
                    array($user2, $runningBalance2),
                )
            ));

        $this->userSettingsRepository

            ->expects($this->exactly(2))
            ->method('findOneByUser')
            ->will($this->returnValueMap(
                array(
                    array($user1, $userSettings1),
                    array($user2, $userSettings2),
                )
            ));

        $this->objectManager->expects($this->once())->method('flush');


        $user1Dates = [
            [$user1Start, new DateTime("30 April 2014 23:59:59"), 100],
        ];

        $user2Dates = [
            [$user2Start, new DateTime('31 January 2014 23:59:59'), 50],
            [new DateTime('1 February 2014 00:00:00'), new DateTime('28 February 2014 23:59:59'), 50],
            [new DateTime('1 March 2014 00:00:00'), new DateTime('31 March 2014 23:59:59'), 50],
            [new DateTime('1 April 2014 00:00:00'), new DateTime('30 April 2014 23:59:59'), 50],
        ];

        $invokeCount = $this->bookingRepositoryExpects($user1, $user1Dates);
        $invokeCount = $this->bookingRepositoryExpects($user2, $user2Dates, $invokeCount);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $invokeCount = $this->evmExpects(array_column($user1Dates, 1), $runningBalance1, true, 0);
        $invokeCount = $this->evmExpects(array_column($user2Dates, 1), $runningBalance2, true, $invokeCount);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->runningBalanceService->reIndexAllUsersRunningBalance();
        $this->assertEquals(-12.5, $runningBalance1->getBalance());
        $this->assertEquals(-445, $runningBalance2->getBalance());
    }

    /**
     * @param float $startBalance
     * @param DateTime $startDate
     * @param float $expectedBalance
     * @param float $bookedHours
     * @dataProvider singleUserStartDateProvider
     */
    public function testRecalculateSingleUserRunningBalanceConsidersUsersStartDate(
        $startBalance,
        DateTime $startDate,
        $expectedBalance,
        $bookedHours
    ) {
        $user = new User;
        $runningBalance = new RunningBalance;
        $userSettings = new UserSettings;
        $userSettings->setFlexStartDate($startDate);
        $userSettings->setStartingBalance($startBalance);

        $this->balanceRepository

            ->expects($this->once())
            ->method('findOneByUser')
            ->with($user)
            ->will($this->returnValue($runningBalance));

        $this->userSettingsRepository

            ->expects($this->once())
            ->method('findOneByUser')
            ->With($user)
            ->will($this->returnValue($userSettings));

        $this->objectManager->expects($this->once())->method('flush');


        $dates = [
            [$startDate, new DateTime("31 March 2014 23:59:59"), $bookedHours],
            [new DateTime("01 April 2014 00:00:00"), new DateTime("30 April 2014 23:59:59"), $bookedHours],
        ];

        $this->bookingRepositoryExpects($user, $dates);
        $this->evmExpects(array_column($dates, 1), $runningBalance, true, 0);

        $this->runningBalanceService->reIndexIndividualUserRunningBalance($user);
        $this->assertEquals($expectedBalance, $runningBalance->getBalance());
    }

    /**
     * @return array
     */
    public function singleUserStartDateProvider()
    {
        return [
            [
                'startingBalance'   => 0,
                'startDate'         => new DateTime("12-03-2014"),
                'expectedBalance'   => -270,
                'bookedHours'       => 0
            ],
            [
                'startingBalance'   => 10,
                'startDate'         => new DateTime("12-03-2014"),
                'expectedBalance'   => -260,
                'bookedHours'       => 0
            ],
        ];
    }

    public function testSetUserBalance()
    {
        $user = new User;
        $balance = 10;

        $userSettings = new UserSettings;
        $this->userSettingsRepository

            ->expects($this->once())
            ->method('findOneByUser')
            ->with($user)
            ->will($this->returnValue($userSettings));

        $this->objectManager->expects($this->once())->method('flush');

        $this->runningBalanceService->setUserStartingBalance($user, $balance);
        $this->assertEquals(10, $userSettings->getStartingBalance());
    }

    /**
     * @param DateTime $userStartDate
     * @return array
     */
    private function getUser(DateTime $userStartDate)
    {
        $user = new User;
        $userSettings = new UserSettings;
        $userSettings->setFlexStartDate($userStartDate);
        return [$user, $userSettings];
    }

    /**
     * @param array $dates
     * @param RunningBalance $runningBalance
     * @param bool $addReindexPreAndPostEvents
     * @param int $invocationCount
     * @return int
     */
    private function evmExpects(
        array $dates,
        RunningBalance $runningBalance,
        $addReindexPreAndPostEvents = false,
        $invocationCount = 0
    ) {

        if ($addReindexPreAndPostEvents) {
            $this->evm

                ->expects($this->at($invocationCount++))
                ->method('trigger')
                ->with(
                    'reIndexUserRunningBalance.pre',
                    null,
                    ['runningBalance' => $runningBalance]
                );
        }

        foreach ($dates as $date) {
            $this->evm

                ->expects($this->at($invocationCount++))
                ->method('trigger')
                ->with(
                    'addMonthBalance.pre',
                    null,
                    ['runningBalance' => $runningBalance, 'month' => $date]
                );

            $this->evm

                ->expects($this->at($invocationCount++))
                ->method('trigger')
                ->with(
                    'addMonthBalance.post',
                    null,
                    ['runningBalance' => $runningBalance, 'month' => $date]
                );
        }

        if ($addReindexPreAndPostEvents) {
            $this->evm

                ->expects($this->at($invocationCount++))
                ->method('trigger')
                ->with(
                    'reIndexUserRunningBalance.post',
                    null,
                    ['runningBalance' => $runningBalance]
                );
        }

        return $invocationCount;
    }

    /**
     * @param UserInterface $user
     * @param array $months
     * @param int $invocationCount
     * @return int
     */
    private function bookingRepositoryExpects(UserInterface $user, array $months, $invocationCount = 0)
    {
        foreach ($months as $month) {
            list($start, $end, $bookedHours) = $month;

            $this->bookingRepository

                ->expects($this->at($invocationCount++))
                ->method('getTotalBookedBetweenByUser')
                ->with(
                    $user,
                    $this->equalTo($start),
                    $this->equalTo($end)
                )
                ->will($this->returnValue($bookedHours));
        }

        return $invocationCount;
    }
}


1			<?php
2
3			namespace JhFlexiTimeTest\Service;
4
5			use Doctrine\Common\Persistence\ObjectManager;
6			use JhFlexiTime\Entity\RunningBalance;
7			use JhFlexiTime\Entity\UserSettings;
8			use JhFlexiTime\Options\ModuleOptions;
9			use JhFlexiTime\Repository\BalanceRepositoryInterface;
10			use JhFlexiTime\Repository\BookingRepository;
11			use JhFlexiTime\Repository\UserSettingsRepositoryInterface;
12			use JhFlexiTime\Service\PeriodService;
13			use JhFlexiTime\Service\RunningBalanceService;
14			use JhUser\Entity\User;
15			use JhFlexiTime\DateTime\DateTime;
16			use JhUser\Repository\UserRepositoryInterface;
17			use ZfcUser\Entity\UserInterface;
18
19			/**
20			* Class RunningBalanceServiceTest
21			* @package JhFlexiTimeTest\Service
22			* @author Aydin Hassan <[email protected]>
23			*/
24			class RunningBalanceServiceTest extends \PHPUnit_Framework_TestCase
25			{
26
27			/**
28			* @var UserRepositoryInterface
29			*/
30			protected $userRepository;
31
32			/**
33			* @var UserSettingsRepositoryInterface
34			*/
35			protected $userSettingsRepository;
36
37			/**
38			* @var RunningBalanceService
39			*/
40			protected $runningBalanceService;

WeareJH / Flexitime

Issues (164)

Security Analysis not enabled

Service/RunningBalanceServiceTest.php (31 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like