Issues in BookingController.php (master) - Issues in master - WeareJH/Flexitime - Measure and Improve Code Quality continuously with Scrutinizer

Issues (164)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/JhFlexiTime/Controller/BookingController.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace JhFlexiTime\Controller;

use JhFlexiTime\Repository\UserSettingsRepositoryInterface;
use JhFlexiTime\Service\BookingService;
use JhFlexiTime\Service\TimeCalculatorService;
use JhFlexiTime\Validator\UniqueBooking;
use Zend\Form\FormInterface;
use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\Validator\Date as DateValidator;

/**
 * Class BookingController
 * @package JhFlexiTime\Controller
 * @author Aydin Hassan <[email protected]>s
 */
class BookingController extends AbstractActionController
{
    use GetSetDateTrait;

    /**
     * @var \JhFlexiTime\Form\BookingForm
     */
    protected $bookingForm;

    /**
     * @var \JhFlexiTime\Service\BookingService
     */
    protected $bookingService;

    /**
     * @var \JhFlexiTime\Service\TimeCalculatorService
     */
    protected $timeCalculatorService;

    /**
     * @var UserSettingsRepositoryInterface
     */
    protected $userSettingsRepository;

    /**
     * @param BookingService $bookingService
     * @param TimeCalculatorService $timeCalculatorService
     * @param FormInterface $bookingForm
     */
    public function __construct(
        BookingService $bookingService,
        TimeCalculatorService $timeCalculatorService,
        FormInterface $bookingForm,
        UserSettingsRepositoryInterface $userSettingsRepository
    ) {
        $this->bookingService           = $bookingService;
        $this->bookingForm              = $bookingForm;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->timeCalculatorService    = $timeCalculatorService;
        $this->userSettingsRepository   = $userSettingsRepository;
    }

    /**
     * @return ViewModel
     */
    public function listAction()
    {

        $month  = (string) $this->params()->fromQuery('m');
        $year   = (string) $this->params()->fromQuery('y');
        $period = $this->getDate($month, $year);

        $user           = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $userSettings   = $this->userSettingsRepository->findOneByUser($user);
        $records        = $this->bookingService->getUserBookingsForMonth($user, $period);
        $pagination     = $this->bookingService->getPagination($period);
        $totals         = $this->timeCalculatorService->getTotals($user, $userSettings->getFlexStartDate(), $period);

        return new ViewModel([
            'bookings' => [
                'records'       => $records,
                'totals'        => $totals,
                'user'          => $user,
            ],
            'pagination' => $pagination,
            'date'       => $period,
            'today'      => new \DateTime("today"),
            'form'       => $this->bookingForm,
        ]);
    }
}


1			<?php
2
3			namespace JhFlexiTime\Controller;
4
5			use JhFlexiTime\Repository\UserSettingsRepositoryInterface;
6			use JhFlexiTime\Service\BookingService;
7			use JhFlexiTime\Service\TimeCalculatorService;
8			use JhFlexiTime\Validator\UniqueBooking;
9			use Zend\Form\FormInterface;
10			use Zend\Mvc\Controller\AbstractActionController;
11			use Zend\View\Model\ViewModel;
12			use Zend\Validator\Date as DateValidator;
13
14			/**
15			* Class BookingController
16			* @package JhFlexiTime\Controller
17			* @author Aydin Hassan <[email protected]>s
18			*/
19			class BookingController extends AbstractActionController
20			{
21			use GetSetDateTrait;
22
23			/**
24			* @var \JhFlexiTime\Form\BookingForm
25			*/
26			protected $bookingForm;
27
28			/**
29			* @var \JhFlexiTime\Service\BookingService
30			*/
31			protected $bookingService;
32
33			/**
34			* @var \JhFlexiTime\Service\TimeCalculatorService
35			*/
36			protected $timeCalculatorService;
37
38			/**
39			* @var UserSettingsRepositoryInterface
40			*/
41			protected $userSettingsRepository;
42
43			/**
44			* @param BookingService $bookingService
45			* @param TimeCalculatorService $timeCalculatorService
46			* @param FormInterface $bookingForm
47			*/
48			public function __construct(
49			BookingService $bookingService,
50			TimeCalculatorService $timeCalculatorService,
51			FormInterface $bookingForm,
52			UserSettingsRepositoryInterface $userSettingsRepository
53			) {
54			$this->bookingService = $bookingService;
55			$this->bookingForm = $bookingForm;
			0 ignored issues – show Documentation Bug introduced 2016-12-14 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$bookingForm` is of type `object<Zend\Form\FormInterface>`, but the property `$bookingForm` was declared to be of type `object<JhFlexiTime\Form\BookingForm>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
56			$this->timeCalculatorService = $timeCalculatorService;
57			$this->userSettingsRepository = $userSettingsRepository;
58			}
59
60			/**
61			* @return ViewModel
62			*/
63			public function listAction()
64			{
65
66			$month = (string) $this->params()->fromQuery('m');
67			$year = (string) $this->params()->fromQuery('y');
68			$period = $this->getDate($month, $year);
69
70			$user = $this->zfcUserAuthentication()->getIdentity();
			0 ignored issues – show Documentation Bug introduced 2016-12-14 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `zfcUserAuthentication` does not exist on `object<JhFlexiTime\Controller\BookingController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
71			$userSettings = $this->userSettingsRepository->findOneByUser($user);
72			$records = $this->bookingService->getUserBookingsForMonth($user, $period);
73			$pagination = $this->bookingService->getPagination($period);
74			$totals = $this->timeCalculatorService->getTotals($user, $userSettings->getFlexStartDate(), $period);
75
76			return new ViewModel([
77			'bookings' => [
78			'records' => $records,
79			'totals' => $totals,
80			'user' => $user,
81			],
82			'pagination' => $pagination,
83			'date' => $period,
84			'today' => new \DateTime("today"),
85			'form' => $this->bookingForm,
86			]);
87			}
88			}
89

WeareJH / Flexitime

Issues (164)

Security Analysis not enabled

src/JhFlexiTime/Controller/BookingController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like