PeriodServiceFactory::createService()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 6
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
c 0
b 0
f 0
dl 0
loc 6
rs 9.4285
cc 1
eloc 3
nc 1
nop 1
1
<?php
2
3
namespace JhFlexiTime\Service\Factory;
4
5
use JhFlexiTime\Service\PeriodService;
6
use Zend\ServiceManager\FactoryInterface;
7
use Zend\ServiceManager\ServiceLocatorInterface;
8
9
/**
10
 * Class PeriodServiceFactory
11
 * @package JhFlexiTime\Service\Factory
12
 * @author Aydin Hassan <[email protected]>
13
 */
14
class PeriodServiceFactory implements FactoryInterface
15
{
16
    /**
17
     * @param ServiceLocatorInterface $serviceLocator
18
     * @return PeriodService
19
     */
20
    public function createService(ServiceLocatorInterface $serviceLocator)
21
    {
22
        return new PeriodService(
23
            $serviceLocator->get('FlexiOptions')
0 ignored issues
show
Documentation introduced by
$serviceLocator->get('FlexiOptions') is of type object|array, but the function expects a object<JhFlexiTime\Options\ModuleOptions>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
24
        );
25
    }
26
}
27