BookingRestController - Code Metrics - WeareJH/Flexitime - Measure and Improve Code Quality continuously with Scrutinizer

BookingRestController A
last analyzed 2016-12-14 12:13 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	188
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

Metric	Value
wmc	13
c	0
b	0
f	0
lcom	1
cbo	10
dl	0
loc	188
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	11	1
B	getList()	36	4
A	get()	7	1
A	create()	22	2
A	update()	23	2
A	delete()	21	2
A	parseIdCriteria()	7	1

<?php

namespace JhFlexiTime\Controller;

use JhFlexiTime\Repository\UserSettingsRepositoryInterface;
use JhUser\Repository\UserRepositoryInterface;
use Zend\Mvc\Controller\AbstractRestfulController;
use Zend\Validator\Date as DateValidator;
use Zend\View\Model\JsonModel;
use JhFlexiTime\Service\TimeCalculatorService;
use JhFlexiTime\Service\BookingService;

/**
 * Class BookingRestController
 * @package JhFlexiTime\Controller
 * @author Aydin Hassan <[email protected]>
 */
class BookingRestController extends AbstractRestfulController
{
    use GetSetDateTrait;

    /**
     * @var \JhFlexiTime\Service\BookingService
     */
    protected $bookingService;

    /**
     * @var \JhFlexiTime\Service\TimeCalculatorService
     */
    protected $timeCalculatorService;

    /**
     * @var UserRepositoryInterface
     */
    protected $userRepository;

    /**
     * @var UserSettingsRepositoryInterface
     */
    protected $userSettingsRepository;

    /**
     * @param BookingService $bookingService
     * @param TimeCalculatorService $timeCalculatorService
     * @param UserRepositoryInterface $userRepository
     * @param UserSettingsRepositoryInterface $userSettingsRepository
     */
    public function __construct(
        BookingService $bookingService,
        TimeCalculatorService $timeCalculatorService,
        UserRepositoryInterface $userRepository,
        UserSettingsRepositoryInterface $userSettingsRepository
    ) {
        $this->bookingService           = $bookingService;
        $this->timeCalculatorService    = $timeCalculatorService;
        $this->userRepository           = $userRepository;
        $this->userSettingsRepository   = $userSettingsRepository;
    }

    /**
     * @return JsonModel
     */
    public function getList()
    {
        $month  = $this->params()->fromQuery('m', false);
        $year   = $this->params()->fromQuery('y', false);
        $userId = $this->params()->fromQuery('user', false);
        $period = $this->getDate($month, $year);

        if ($userId && $this->isGranted('flexi-time.readOthers')) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

            $user = $this->userRepository->find($userId);
            if (!$user) {
                return new JsonModel([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                    'success' => false,
                    'message' => 'User does not exist',
                ]);
            }
        } else {
            $user = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }

        $userSettings   = $this->userSettingsRepository->findOneByUser($user);
        $records        = $this->bookingService->getUserBookingsForMonth($user, $period);
        $pagination     = $this->bookingService->getPagination($period);
        $totals         = $this->timeCalculatorService->getTotals($user, $userSettings->getFlexStartDate(), $period);

        return new JsonModel([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'bookings' => [
                'records'   => $records,
                'totals'    => $totals,
                'user'      => $user,
            ],
            'pagination' => $pagination,
            'date'       => $period,
            'today'      => new \DateTime("today"),
        ]);
    }

    /**
     * @param int $id
     * @return JsonModel
     */
    public function get($id)
    {
        $id   = $this->parseIdCriteria($id);
        return new JsonModel([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'booking' => $this->bookingService->getBookingByUserAndDate($id['user'], $id['date']),
        ]);
    }

    /**
     * @param array $data
     * @return JsonModel
     */
    public function create($data)
    {
        $booking = $this->bookingService->create($data);

        if (is_array($booking)) {
            $booking['success'] = false;
            return new JsonModel($booking);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $userSettings = $this->userSettingsRepository->findOneByUser($booking->getUser());
        $monthTotals  = $this->timeCalculatorService->getTotals(
            $booking->getUser(),
            $userSettings->getFlexStartDate(),
            $booking->getDate()
        );
        return new JsonModel([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'success'       => true,
            'booking'       => $booking,
            'monthTotals'   => $monthTotals,
            'weekTotals'    => $this->timeCalculatorService->getWeekTotals($booking->getUser(), $booking->getDate())
        ]);
    }

    /**
     * @param int $id
     * @param array $data
     * @return JsonModel
     */
    public function update($id, $data)
    {
        $id         = $this->parseIdCriteria($id);
        $booking    = $this->bookingService->update($id['user'], $id['date'], $data);

        if (is_array($booking)) {
            $booking['success'] = false;
            return new JsonModel($booking);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $userSettings = $this->userSettingsRepository->findOneByUser($booking->getUser());
        $monthTotals  = $this->timeCalculatorService->getTotals(
            $booking->getUser(),
            $userSettings->getFlexStartDate(),
            $booking->getDate()
        );
        return new JsonModel([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'success'       => true,
            'booking'       => $booking,
            'monthTotals'   => $monthTotals,
            'weekTotals'    => $this->timeCalculatorService->getWeekTotals($booking->getUser(), $booking->getDate())
        ]);
    }

    /**
     * @param int $id
     * @return JsonModel
     */
    public function delete($id)
    {
        $id         = $this->parseIdCriteria($id);
        $booking    = $this->bookingService->delete($id['user'], $id['date']);
        if (is_array($booking)) {
            $booking['success'] = false;
            return new JsonModel($booking);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $userSettings = $this->userSettingsRepository->findOneByUser($booking->getUser());
        $monthTotals  = $this->timeCalculatorService->getTotals(
            $booking->getUser(),
            $userSettings->getFlexStartDate(),
            $booking->getDate()
        );
        return new JsonModel([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'success'       => true,
            'monthTotals'   => $monthTotals,
            'weekTotals'    => $this->timeCalculatorService->getWeekTotals($booking->getUser(), $booking->getDate())
        ]);
    }

    /**
     * @param $id
     * @return array
     */
    public function parseIdCriteria($id)
    {
        $idParts    = explode("-", $id);
        $date       = new \JhFlexiTime\DateTime\DateTime();
        $date->setTimestamp($idParts[0]);
        return ['date' => $date,'user' => $idParts[1]];
    }
}


1			<?php
2
3			namespace JhFlexiTime\Controller;
4
5			use JhFlexiTime\Repository\UserSettingsRepositoryInterface;
6			use JhUser\Repository\UserRepositoryInterface;
7			use Zend\Mvc\Controller\AbstractRestfulController;
8			use Zend\Validator\Date as DateValidator;
9			use Zend\View\Model\JsonModel;
10			use JhFlexiTime\Service\TimeCalculatorService;
11			use JhFlexiTime\Service\BookingService;
12
13			/**
14			* Class BookingRestController
15			* @package JhFlexiTime\Controller
16			* @author Aydin Hassan <[email protected]>
17			*/
18			class BookingRestController extends AbstractRestfulController
19			{
20			use GetSetDateTrait;
21
22			/**
23			* @var \JhFlexiTime\Service\BookingService
24			*/
25			protected $bookingService;
26
27			/**
28			* @var \JhFlexiTime\Service\TimeCalculatorService
29			*/
30			protected $timeCalculatorService;
31
32			/**
33			* @var UserRepositoryInterface
34			*/
35			protected $userRepository;
36
37			/**
38			* @var UserSettingsRepositoryInterface
39			*/
40			protected $userSettingsRepository;

WeareJH / Flexitime

BookingRestController A last analyzed 2016-12-14 12:13 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like

BookingRestController A
last analyzed 2016-12-14 12:13 UTC