NotValidator::assert() - Code Metrics - Inspection of "fix HHVM Array List" - Wandu/Framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5df011...747e00 )

by Changwan

created 2016-12-10 16:12 UTC

NotValidator::assert() B

↳ Parent: NotValidator

Complexity

Conditions	5
Paths	6

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	5

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	5
eloc	11
nc	6
nop	1
dl	0
loc	15
ccs	10
cts	10
cp	1
crap	5
rs	8.8571
c	1
b	0
f	1

<?php
namespace Wandu\Validator\Rules;

use Wandu\Validator\Contracts\ValidatorInterface;
use Wandu\Validator\Exception\InvalidValueException;

class NotValidator extends ValidatorAbstract
{
    const ERROR_TYPE = 'not';

    /** @var \Wandu\Validator\Contracts\ValidatorInterface */
    protected $next;

    /**
     * @param \Wandu\Validator\Contracts\ValidatorInterface $next
     */
    public function __construct(ValidatorInterface $next)
    {
        $this->next = $next;
    }

    /**
     * {@inheritdoc}
     */
    function test($item)

    {
        // nothing
    }

    /**
     * {@inheritdoc}
     */
    public function assert($item)
    {
        if (!isset($item)) return;
        try {
            $this->next->assert($item);
        } catch (InvalidValueException $exception) {
            return;
        }
        $errorType = ValidatorAbstract::ERROR_TYPE;
        if ($this->next instanceof ValidatorAbstract) {
            $errorType = $this->next->getErrorType();
        }
        $suffix = isset($this->name) ? '@' . $this->name : '';
class MyClass { }

$x = new MyClass();
$x->foo = true;
        throw new InvalidValueException('not.' . $errorType . $suffix);
    }

    /**
     * {@inheritdoc}
     */
    public function validate($item)
    {
        if (!isset($item)) return true;
        return !$this->next->validate($item);
    }
}


1		<?php
2		namespace Wandu\Validator\Rules;
3
4		use Wandu\Validator\Contracts\ValidatorInterface;
5		use Wandu\Validator\Exception\InvalidValueException;
6
7		class NotValidator extends ValidatorAbstract
8		{
9		const ERROR_TYPE = 'not';
10
11		/** @var \Wandu\Validator\Contracts\ValidatorInterface */
12		protected $next;
13
14		/**
15		* @param \Wandu\Validator\Contracts\ValidatorInterface $next
16		*/
17	4	public function __construct(ValidatorInterface $next)
18		{
19	4	$this->next = $next;
20	4	}
21
22		/**
23		* {@inheritdoc}
24		*/
25		function test($item)
		0 ignored issues – show Best Practice introduced 2016-10-25 17:40 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
26		{
27		// nothing
28		}
29
30		/**
31		* {@inheritdoc}
32		*/
33	2	public function assert($item)
34		{
35	2	if (!isset($item)) return;
36		try {
37	2	$this->next->assert($item);
38	2	} catch (InvalidValueException $exception) {
39	2	return;
40		}
41	2	$errorType = ValidatorAbstract::ERROR_TYPE;
42	2	if ($this->next instanceof ValidatorAbstract) {
43	2	$errorType = $this->next->getErrorType();
44		}
45	2	$suffix = isset($this->name) ? '@' . $this->name : '';
		0 ignored issues – show Bug introduced 2016-10-25 17:40 UTC by Report Bug Copy Issue Report The property `name` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46	2	throw new InvalidValueException('not.' . $errorType . $suffix);
47		}
48
49		/**
50		* {@inheritdoc}
51		*/
52	1	public function validate($item)
53		{
54	1	if (!isset($item)) return true;
55	1	return !$this->next->validate($item);
56		}
57		}
58

Wandu / Framework

Push — master ( 5df011...747e00 )

NotValidator::assert() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like