Wandu\Config\Config

Complexity

Total Complexity

31

Size/Duplication

Total Lines	165
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

93.94%

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	pushLoader()	0	4	1
A	load()	0	10	3
A	merge()	0	4	1
B	recursiveMerge()	0	17	7
A	toArray()	0	4	1
B	has()	0	16	5
B	get()	0	16	5
A	subset()	0	8	2
A	offsetExists()	0	4	1
A	offsetGet()	0	8	2
A	offsetSet()	0	4	1
A	offsetUnset()	0	4	1

<?php
namespace Wandu\Config;

use InvalidArgumentException;
use Wandu\Config\Contracts\Config as ConfigContract;
use Wandu\Config\Contracts\Loader;
use Wandu\Config\Exception\CannotLoadException;
use Wandu\Config\Exception\NotAllowedMethodException;

class Config implements ConfigContract
{
    /** @var array */
    protected $items;
    
    /** @var \Wandu\Config\Contracts\Loader[] */
    protected $loaders = [];

    /**
     * @param array $items
     */
    public function __construct(array $items = [])
    {
        $this->items = $items;
    }

    /**
     * @param \Wandu\Config\Contracts\Loader $loader
     */
    public function pushLoader(Loader $loader)
    {
        $this->loaders[] = $loader;
    }

    /**
     * @param string $path
     */
    public function load(string $path)
    {
        foreach ($this->loaders as $loader) {
            if ($loader->test($path)) {
                $this->merge($loader->load($path));

It seems like $loader->load($path) targeting Wandu\Config\Contracts\Loader::load() can also be of type null; however, Wandu\Config\Config::merge() does only seem to accept array, maybe add an additional type check?

                return;
            }
        }
        throw new CannotLoadException($path);
    }

    /**
     * @param array $appender
     */
    public function merge(array $appender)
    {
        $this->items = $this->recursiveMerge($this->items, $appender);

It seems like $this->recursiveMerge($this->items, $appender) of type * is incompatible with the declared type array of property $items.

    }

    /**
     * @param mixed $origin
     * @param mixed $appender
     * @return mixed
     */
    private function recursiveMerge($origin, $appender)
    {
        if (is_array($origin)
            && array_values($origin) !== $origin
            && is_array($appender)
            && array_values($appender) !== $appender) {
            foreach ($appender as $key => $value) {
                if (isset($origin[$key])) {
                    $origin[$key] = $this->recursiveMerge($origin[$key], $value);
                } else {
                    $origin[$key] = $value;
                }
            }
            return $origin;
        }
        return $appender;
    }

    /**
     * {@inheritdoc}
     */
    public function toArray(): array
    {
        return $this->items ?? [];
    }

    /**
     * {@inheritdoc}
     */
    public function has($name): bool
    {
        if ($name === '') {
            return true;
        }
        $names = explode('.', $name);
        $dataToReturn = $this->items;
        while (count($names)) {
            $name = array_shift($names);
            if (!is_array($dataToReturn) || !array_key_exists($name, $dataToReturn)) {
                return false;
            }
            $dataToReturn = $dataToReturn[$name];
        }
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function get($name, $default = null)
    {
        if ($name === '') {
            return $this->items;
        }
        $names = explode('.', $name);
        $dataToReturn = $this->items;
        while (count($names)) {
            $name = array_shift($names);
            if (!is_array($dataToReturn) || !array_key_exists($name, $dataToReturn)) {
                return $default;
            }
            $dataToReturn = $dataToReturn[$name];
        }
        return $dataToReturn;
    }

    /**
     * {@inheritdoc}
     */
    public function subset($name): ConfigContract
    {
        $subset = $this->get($name);
        if (!is_array($subset)) {
            throw new InvalidArgumentException('subset must be an array.');
        }
        return new static($subset);
    }

    /**
     * {@inheritdoc}
     */
    public function offsetExists($offset)
    {
        return $this->has($offset);
    }

    /**
     * {@inheritdoc}
     */
    public function offsetGet($offset)
    {
        if (strpos($offset, '||') !== false) {
            list($offset, $default) = explode('||', $offset);
            return $this->get($offset, $default);
        }
        return $this->get($offset);
    }

    /**
     * {@inheritdoc}
     */
    public function offsetSet($offset, $value)
    {
        throw new NotAllowedMethodException(__FUNCTION__, __CLASS__);
    }

    /**
     * {@inheritdoc}
     */
    public function offsetUnset($offset)
    {
        throw new NotAllowedMethodException(__FUNCTION__, __CLASS__);
    }
}