WagnerMontanini / apinfefasa

src/ApiNfeFasa.php

<?php

namespace WagnerMontanini\ApiNfeFasa;

/**
 * Class ApiNfeFasa
 * @package WagnerMontanini\ApiNfeFasa
 */
abstract class ApiNfeFasa
{
    /** @var string */
    private $apiUrl;

    /** @var array */
    private $headers;

    /** @var array */
    private $fields;

    /** @var string */
    private $endpoint;

    /** @var string */
    private $method;

    /** @var object */
    protected $response;

    /**
     * ApiNfeFasa constructor.
     * @param string $apiUrl
     */
    public function __construct(string $apiUrl,?string $token = null)
    {
        $this->apiUrl = $apiUrl;
        $headers = empty($token)?null:array("Authorization"=>"Bearer {$token}");
        $this->headers($headers);

    }

    /**
     * @param string $method
     * @param string $endpoint
     * @param array|null $fields
     * @param array|null $headers
     */
    protected function request(string $method, string $endpoint, array $fields = null, array $headers = null): void
    {
        $this->method = $method;
        $this->endpoint = $endpoint;
        $this->fields = $fields;
        $this->headers($headers);

        $this->dispatch();
    }

    /**
     * @return object|null
     */
    public function response()
    {
        return $this->response;
    }

    /**
     * @return object|null
     */
    public function error()
    {
        if (!empty($this->response->errors)) {
            return $this->response->errors;
        }

        return null;
    }

    /**
     * @param array|null $headers
     */
    private function headers(?array $headers): void
    {
        if (!$headers) {

The expression $headers of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return;
        }

        foreach ($headers as $key => $header) {
            $this->headers[] = "{$key}: {$header}";
        }
    }

    /**
     *
     */
    private function dispatch(): void
    {
        $curl = curl_init();
        
        if (empty($this->fields["files"])) {
            $this->fields = (!empty($this->fields) ? http_build_query($this->fields) : null);

It seems like ! empty($this->fields) ? http_build_query($this->fields) : null can also be of type string. However, the property $fields is declared as type array. Maybe add an additional type check?

        }

        curl_setopt_array($curl, array(
            CURLOPT_URL => "{$this->apiUrl}{$this->endpoint}",
            CURLOPT_RETURNTRANSFER => true,
            CURLOPT_ENCODING => '',
            CURLOPT_MAXREDIRS => 10,
            CURLOPT_TIMEOUT => 30,
            CURLOPT_FOLLOWLOCATION => true,
            CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
            CURLOPT_CUSTOMREQUEST => $this->method,
            CURLOPT_POSTFIELDS => $this->fields,
            CURLOPT_HTTPHEADER => $this->headers,
        ));

        $this->response = json_decode(curl_exec($curl));

It seems like curl_exec($curl) can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        curl_close($curl);
    }
}