Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | class ZohoDatabaseSyncZoho |
||
20 | { |
||
21 | |||
22 | /** |
||
23 | * @var Connection |
||
24 | */ |
||
25 | private $connection; |
||
26 | |||
27 | /** |
||
28 | * @var LoggerInterface |
||
29 | */ |
||
30 | private $logger; |
||
31 | |||
32 | /** |
||
33 | * |
||
34 | * @var string |
||
35 | */ |
||
36 | private $prefix; |
||
37 | |||
38 | /** |
||
39 | * @param Connection $connection |
||
40 | * @param string $prefix |
||
41 | * @param LoggerInterface $logger |
||
42 | */ |
||
43 | public function __construct(Connection $connection, $prefix = 'zoho_', LoggerInterface $logger = null) |
||
53 | |||
54 | /** |
||
55 | * |
||
56 | * @param AbstractZohoDao $zohoDao |
||
57 | * @return array |
||
58 | */ |
||
59 | private function findMethodValues(AbstractZohoDao $zohoDao){ |
||
71 | |||
72 | /** |
||
73 | * Insert or Update rows. |
||
74 | * @param AbstractZohoDao $zohoDao |
||
75 | * @param string $localTable |
||
76 | */ |
||
77 | public function pushDataToZoho(AbstractZohoDao $zohoDao, $localTable, $update = false){ |
||
136 | |||
137 | /** |
||
138 | * Find the row to delete and remove to Zoho. |
||
139 | * @param AbstractZohoDao $zohoDao |
||
140 | * @param string $localTable |
||
141 | */ |
||
142 | public function deleteDataToZoho(AbstractZohoDao $zohoDao, $localTable){ |
||
157 | |||
158 | /** |
||
159 | * Run inserted rows to Zoho : local_insert. |
||
160 | * @param AbstractZohoDao $zohoDao |
||
161 | */ |
||
162 | public function pushInsertedRows(AbstractZohoDao $zohoDao){ |
||
165 | |||
166 | /** |
||
167 | * Run updated rows to Zoho : local_update. |
||
168 | * @param AbstractZohoDao $zohoDao |
||
169 | */ |
||
170 | public function pushUpdatedRows(AbstractZohoDao $zohoDao){ |
||
173 | |||
174 | /** |
||
175 | * Run deleted rows to Zoho : local_delete. |
||
176 | * @param AbstractZohoDao $zohoDao |
||
177 | */ |
||
178 | public function pushDeletedRows(AbstractZohoDao $zohoDao){ |
||
181 | |||
182 | /** |
||
183 | * Computes the name of the table based on the DAO plural module name. |
||
184 | * |
||
185 | * @param AbstractZohoDao $dao |
||
186 | * |
||
187 | * @return string |
||
188 | */ |
||
189 | View Code Duplication | private function getTableName(AbstractZohoDao $dao) |
|
196 | |||
197 | |||
198 | /** |
||
199 | * @param LoggerInterface $logger |
||
200 | */ |
||
201 | public function setLogger(LoggerInterface $logger) |
||
205 | |||
206 | |||
207 | } |
This check looks for access to methods that are not accessible from the current context.
If you need to make a method accessible to another context you can raise its visibility level in the defining class.