ZohoUserService::__construct() - Code Metrics - Inspection of "[WIP] Switching uid to a real UUID level 1 instead..." - Wabel/zoho-crm-copy-db - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 2.0 (#18)

by David

created 2017-01-18 17:15 UTC

ZohoUserService::__construct() A

↳ Parent: ZohoUserService

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	4
rs	10
c	1
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php


namespace Wabel\Zoho\CRM\Copy;

use Wabel\Zoho\CRM\Request\Response;
use Wabel\Zoho\CRM\ZohoClient;

/**
 * This class acts as a cache for fetching users from Zoho.
 */
class ZohoUserService
{

    /**
     * @var ZohoClient
     */
    private $zohoClient;

    /**
     * @var Response
     */
    private $usersResponse;

    public function __construct(ZohoClient $zohoClient)
    {
        $this->zohoClient = $zohoClient;
    }

    /**
     * @return Response
     */
    public function getUsers()
    {
        if ($this->usersResponse !== null) {
            return $this->usersResponse();

        }

        $this->usersResponse = $this->zohoClient->getUsers();
        return $this->usersResponse;
    }
}


1			<?php
2
3
4			namespace Wabel\Zoho\CRM\Copy;
5
6			use Wabel\Zoho\CRM\Request\Response;
7			use Wabel\Zoho\CRM\ZohoClient;
8
9			/**
10			* This class acts as a cache for fetching users from Zoho.
11			*/
12			class ZohoUserService
13			{
14
15			/**
16			* @var ZohoClient
17			*/
18			private $zohoClient;
19
20			/**
21			* @var Response
22			*/
23			private $usersResponse;
24
25			public function __construct(ZohoClient $zohoClient)
26			{
27			$this->zohoClient = $zohoClient;
28			}
29
30			/**
31			* @return Response
32			*/
33			public function getUsers()
34			{
35			if ($this->usersResponse !== null) {
36			return $this->usersResponse();
			0 ignored issues – show Bug introduced 2017-01-18 16:44 UTC by Report Bug Copy Issue Report The method `usersResponse()` does not seem to exist on `object<Wabel\Zoho\CRM\Copy\ZohoUserService>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
37			}
38
39			$this->usersResponse = $this->zohoClient->getUsers();
40			return $this->usersResponse;
41			}
42			}
43

Wabel / zoho-crm-copy-db

Pull Request — 2.0 (#18)

ZohoUserService::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like