RegistrationCertain::getRegistrations() - Code Metrics - Inspection of "Update query for registraiton and profile" - Wabel/certain-api-wrapper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 104b8a...293390 )

by Raphaël

created 2016-03-07 10:36 UTC

RegistrationCertain::getRegistrations() A

↳ Parent: RegistrationCertain

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	9
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	9
loc	9
rs	9.6666
cc	2
eloc	6
nc	2
nop	0

<?php
namespace Wabel\CertainAPI\Ressources;

use Wabel\CertainAPI\Interfaces\CertainRessourceInterface;
use Wabel\CertainAPI\CertainRessourceAbstract;

/**
 * RegistrationCertain about the Registration entity
 *
 * @author rbergina
 */
class RegistrationCertain extends CertainRessourceAbstract implements CertainRessourceInterface
{
    public function getRessourceName(){
        return 'Registration';
    }
    public function getMandatoryFields()
    {
        return array('profile');
    }

    /**
     * Return with all the result from certain.
     * @return RegistrationCertain[]
     */
    public function getRegistrations()

    {
        $request=  $this->get();
        if($request->isSuccessFul()){
            $registrationCertainResults = $request->getResults();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            return $profileCertainResults;

        }
        return null;
    }
    
}

1		<?php
2		namespace Wabel\CertainAPI\Ressources;
3
4		use Wabel\CertainAPI\Interfaces\CertainRessourceInterface;
5		use Wabel\CertainAPI\CertainRessourceAbstract;
6
7		/**
8		* RegistrationCertain about the Registration entity
9		*
10		* @author rbergina
11		*/
12		class RegistrationCertain extends CertainRessourceAbstract implements CertainRessourceInterface
13		{
14		public function getRessourceName(){
15		return 'Registration';
16		}
17		public function getMandatoryFields()
18		{
19		return array('profile');
20		}
21
22		/**
23		* Return with all the result from certain.
24		* @return RegistrationCertain[]
25		*/
26	View Code Duplication	public function getRegistrations()
		0 ignored issues – show Duplication introduced 2016-03-07 10:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		{
28		$request= $this->get();
29		if($request->isSuccessFul()){
30		$registrationCertainResults = $request->getResults();
		0 ignored issues – show Unused Code introduced 2016-03-07 10:40 UTC by Report Bug Copy Issue Report `$registrationCertainResults` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31		return $profileCertainResults;
		0 ignored issues – show Bug introduced 2016-03-07 10:40 UTC by Report Bug Copy Issue Report The variable `$profileCertainResults` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
32		}
33		return null;
34		}
35
36		}

Wabel / certain-api-wrapper

Push — master ( 104b8a...293390 )

RegistrationCertain::getRegistrations() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like