Wabel / certain-api-wrapper

tests/Wabel/Services/DetectAppointmentsChangingsServiceTest.php

Spacing +28 added lines, -28 removed lines

@@ -29,7 +29,7 @@ 
      * Personal Object to test
      * @return array
      */
-    private function personalAppointment(){
+    private function personalAppointment() {
         return [
                     "appointmentId"=> 52,
                     "startDate"=> "2015-16-07 11:00:00",
@@ -68,23 +68,23 @@ 
 
     protected function setUp()
     {
-        $certainApiClient =  new CertainApiClient(null,getenv('username'),getenv('password'),getenv('accountCode'));
-        $this->certainApiService  = new CertainApiService($certainApiClient);
+        $certainApiClient = new CertainApiClient(null, getenv('username'), getenv('password'), getenv('accountCode'));
+        $this->certainApiService = new CertainApiService($certainApiClient);
         $this->appointmentsCertain = new AppointmentsCertain($this->certainApiService);
-        $this->certainAppointmentsList = $this->appointmentsCertain->get(getenv('eventCode'),['start_index'=>0,'max_results'=>10])->getResults()->appointments;
+        $this->certainAppointmentsList = $this->appointmentsCertain->get(getenv('eventCode'), ['start_index'=>0, 'max_results'=>10])->getResults()->appointments;
     }
 
-    public function testDetectChangings(){
+    public function testDetectChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $currentAppoiments = $oldAppointments;
         unset($currentAppoiments[0]);
         unset($currentAppoiments[1]);
-        $hasChanged = $detectService->hasChanged($oldAppointments,$currentAppoiments);
+        $hasChanged = $detectService->hasChanged($oldAppointments, $currentAppoiments);
         $this->assertTrue($hasChanged);
     }
 
-    public function testGetListChangings(){
+    public function testGetListChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $currentAppoiments = $oldAppointments;
@@ -94,14 +94,14 @@ 
         unset($currentAppoiments[0]);
         unset($currentAppoiments[1]);
         unset($currentAppoiments[4]);
-        $changings = $detectService->getListChangings($oldAppointments,$currentAppoiments);
-        $this->assertEquals(3,count($changings['updated_deleted']));
-        $this->assertContains($delete1,$changings['updated_deleted']);
-        $this->assertContains($delete2,$changings['updated_deleted']);
-        $this->assertContains($delete3,$changings['updated_deleted']);
+        $changings = $detectService->getListChangings($oldAppointments, $currentAppoiments);
+        $this->assertEquals(3, count($changings['updated_deleted']));
+        $this->assertContains($delete1, $changings['updated_deleted']);
+        $this->assertContains($delete2, $changings['updated_deleted']);
+        $this->assertContains($delete3, $changings['updated_deleted']);
     }
 
-    public function testDetectDeleteOrUpdated(){
+    public function testDetectDeleteOrUpdated() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $oldAppointments[10] = $this->personalAppointment();
@@ -113,19 +113,19 @@ 
         $update1 = $currentAppoiments[10];
         $currentAppoiments[10]["startDate"] = "2015-17-07 12:00:00";
         $currentAppoiments[10]["endDate"] = "2015-17-07 12:30:00";
-        $changings = $detectService->getListChangings($oldAppointments,$currentAppoiments);
-        $listDetected = $detectService->detectDeleteOrUpdated($currentAppoiments,$changings['updated_deleted']);
-        $this->assertEquals(3,count($changings['updated_deleted']));
-        $this->assertArrayHasKey('deleted',$listDetected);
-        $this->assertArrayHasKey('updated',$listDetected);
-        $this->assertEquals(2,count($listDetected['deleted']));
-        $this->assertEquals(1,count($listDetected['updated']));
-        $this->assertContains($delete1,$listDetected['deleted']);
-        $this->assertContains($delete2,$listDetected['deleted']);
-        $this->assertContains($update1,$listDetected['updated']);
+        $changings = $detectService->getListChangings($oldAppointments, $currentAppoiments);
+        $listDetected = $detectService->detectDeleteOrUpdated($currentAppoiments, $changings['updated_deleted']);
+        $this->assertEquals(3, count($changings['updated_deleted']));
+        $this->assertArrayHasKey('deleted', $listDetected);
+        $this->assertArrayHasKey('updated', $listDetected);
+        $this->assertEquals(2, count($listDetected['deleted']));
+        $this->assertEquals(1, count($listDetected['updated']));
+        $this->assertContains($delete1, $listDetected['deleted']);
+        $this->assertContains($delete2, $listDetected['deleted']);
+        $this->assertContains($update1, $listDetected['updated']);
     }
 
-    public function testDetectAppointmentsChangings(){
+    public function testDetectAppointmentsChangings() {
         $detectService = new DetectAppointmentsChangingsService($this->appointmentsCertain);
         $oldAppointments = $this->certainAppointmentsList;
         $oldAppointments[10] = $this->personalAppointment();
@@ -141,10 +141,10 @@ 
         $update1['dateDetectChanges'] = $time;
         $currentAppoiments[10]["startDate"] = "2015-17-07 12:00:00";
         $currentAppoiments[10]["endDate"] = "2015-17-07 12:30:00";
-        $listDetected = $detectService->detectAppointmentsChangings($oldAppointments,$currentAppoiments,$time);
-        $this->assertContains($delete1,$listDetected['deleted']);
-        $this->assertContains($delete2,$listDetected['deleted']);
-        $this->assertContains($update1,$listDetected['updated']);
+        $listDetected = $detectService->detectAppointmentsChangings($oldAppointments, $currentAppoiments, $time);
+        $this->assertContains($delete1, $listDetected['deleted']);
+        $this->assertContains($delete2, $listDetected['deleted']);
+        $this->assertContains($update1, $listDetected['updated']);
     }
 
 }
\ No newline at end of file

src/Services/DetectAppointmentsChangingsService.php

Doc Comments +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
     }
 
     /**
-     * @param $eventCode
+     * @param string $eventCode
      * @param null|int $start
      * @param null|int $maxResult
      * @return mixed
@@ -209,7 +209,7 @@ 
 
     /**
      * @param array $appointments
-     * @param $timestamp
+     * @param string $timestamp
      * @return array
      */
     public static function insertDateTimeChanges(array $appointments, $timestamp)

Spacing +7 added lines, -7 removed lines

@@ -101,7 +101,7 @@ 
     {
         if (is_object($object)) {
 
-            return (array)$object;
+            return (array) $object;
         }
         return $object;
     }
@@ -243,15 +243,15 @@ 
         }
         $codeCheckDirectory = FileChangesHelper::checkDirectory($this->dirPathHistoryAppointments);
         if ($codeCheckDirectory === 'no_directory') {
-            $this->logger->error('Path ' . $this->dirPathHistoryAppointments . ' doesn\'t exists.');
+            $this->logger->error('Path '.$this->dirPathHistoryAppointments.' doesn\'t exists.');
             return;
         }
         if ($codeCheckDirectory === 'not_readable') {
-            $this->logger->error('Path ' . $this->dirPathHistoryAppointments . ' is not readable.');
+            $this->logger->error('Path '.$this->dirPathHistoryAppointments.' is not readable.');
             return;
         }
         if ($codeCheckDirectory === 'not_writable') {
-            $this->logger->error('Path ' . $this->dirPathHistoryAppointments . ' is not writable.');
+            $this->logger->error('Path '.$this->dirPathHistoryAppointments.' is not writable.');
             return;
         }
         $this->lock->acquireLock();
@@ -265,7 +265,7 @@ 
         if (!$appointmentsOldHistoryFilePath) {
             //No files so it's the first time we attempt to synchronize.
             $appointmentsOld = [];
-        } else {
+        }else {
             //Get the last old appointments data.
             $appointmentsOldHistory = FileChangesHelper::getJsonContentFromFile($appointmentsOldHistoryFilePath);
             $appointmentsOld = self::recursiveArrayObjectToFullArray($appointmentsOldHistory);
@@ -276,9 +276,9 @@ 
         if (!$appointmentsOld || ((isset($listChangings['updated']) && !empty($listChangings['updated']))
                 || (isset($listChangings['deleted']) && !empty($listChangings['deleted'])))) {
             //Changes? So we save the new online appointments
-            FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments . '/appointments_' . $eventCode . '.json', json_encode($appointmentsNew));
+            FileChangesHelper::saveAppointmentsFileByHistory($this->dirPathHistoryAppointments.'/appointments_'.$eventCode.'.json', json_encode($appointmentsNew));
             $this->logger->info('Detect changes - Save Changes');
-        } else {
+        }else {
             $this->logger->info('Detect changes - No Changes');
         }
         foreach ($this->listeners as $listener) {

src/Helpers/FileChangesHelper.php

Spacing +17 added lines, -17 removed lines

@@ -10,8 +10,8 @@ 
      * @param $dirPath
      * @return bool
      */
-    public static function createDirectory($dirPath){
-        if(!file_exists($dirPath)){
+    public static function createDirectory($dirPath) {
+        if (!file_exists($dirPath)) {
             return mkdir($dirPath, 0775, true, null);
         }
         return false;
@@ -23,7 +23,7 @@ 
      * @param string $msg
      * @return void
      */
-    public static function writeFile($path,$msg){
+    public static function writeFile($path, $msg) {
         $f = fopen($path, "w+");
         fwrite($f, $msg);
         fclose($f);
@@ -42,15 +42,15 @@ 
      * @param string $contents
      * @return void
      */
-    public static function saveAppointmentsFileByHistory($filePath,$contents){
+    public static function saveAppointmentsFileByHistory($filePath, $contents) {
         $time = time();
         $file = pathinfo($filePath);
         $fileNamebase = $file['filename'];
         $filePath = $file['dirname'].'/'.$fileNamebase.'_'.$time.'.json';
-        if(!file_exists($filePath)){
-            self::writeFile($filePath,'');
+        if (!file_exists($filePath)) {
+            self::writeFile($filePath, '');
         }
-        self::writeFile($filePath,$contents);
+        self::writeFile($filePath, $contents);
     }
 
     /**
@@ -58,9 +58,9 @@ 
      * @param $path
      * @return string
      */
-    public static function getContentFile($path){
-        if(!file_exists($path)){
-            self::writeFile($path,'');
+    public static function getContentFile($path) {
+        if (!file_exists($path)) {
+            self::writeFile($path, '');
         }
         $handle = fopen($path, "rb");
         if (FALSE === $handle) {
@@ -79,7 +79,7 @@ 
      * @param string $path
      * @return mixed
      */
-    public static function getJsonContentFromFile($path){
+    public static function getJsonContentFromFile($path) {
         $contents = self::getContentFile($path);
         return json_decode($contents, true);
     }
@@ -90,7 +90,7 @@ 
      * @param string $pathDir
      * @return array
      */
-    public static function getFilesListHistoryAppointmentsByEventCode($eventCode,$pathDir){
+    public static function getFilesListHistoryAppointmentsByEventCode($eventCode, $pathDir) {
         $fileList = array();
         $files = glob($pathDir.'/appointments_'.$eventCode.'_*.json');
         foreach ($files as $file) {
@@ -107,8 +107,8 @@ 
      * @param string $pathDir
      * @return string
      */
-    public static function getTheLastAppointmentsSaved($eventCode,$pathDir){
-        $fileList = self::getFilesListHistoryAppointmentsByEventCode($eventCode,$pathDir);
+    public static function getTheLastAppointmentsSaved($eventCode, $pathDir) {
+        $fileList = self::getFilesListHistoryAppointmentsByEventCode($eventCode, $pathDir);
         return array_shift($fileList);
     }
 
@@ -128,20 +128,20 @@ 
 
     public static function commandIsLocked(string $pathDir): bool
     {
-        return file_exists($pathDir. '/command.lock');
+        return file_exists($pathDir.'/command.lock');
     }
 
     public static function lockCommand(string $pathDir): void
     {
         if (!self::commandIsLocked($pathDir)) {
-            self::writeFile($pathDir. '/command.lock','1');
+            self::writeFile($pathDir.'/command.lock', '1');
         }
     }
 
     public static function unlockCommand(string $pathDir): void
     {
         if (self::commandIsLocked($pathDir)) {
-            self::removeFile($pathDir. '/command.lock');
+            self::removeFile($pathDir.'/command.lock');
         }
     }
 }
\ No newline at end of file