EqualPrincipalPaymentScheduleCalculator::calculatePaymentInterest() - Code Metrics - Inspection of "Fixed Scrutinizer issues" - Vovke/loan-payments-calculator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3bb3f6...b96e37 )

by Vladimir

created 2017-09-07 08:41 UTC

calculatePaymentInterest() A

↳ Parent: EqualPrincipalPaymentScheduleCalculator

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	3
crap	1

<?php
/**
 * @author: Vova Lando <[email protected]>
 * @package: LoanPaymentsCalculator
 * @subpackage:
 * @created: 05/09/2017 16:56
 */

namespace cog\LoanPaymentsCalculator\PaymentSchedule;

use cog\LoanPaymentsCalculator\Payment\Payment;
use cog\LoanPaymentsCalculator\Period\Period;
use cog\LoanPaymentsCalculator\Schedule\Schedule;

/**
 * Class EqualPrincipalPaymentScheduleCalculator
 * @package cog\LoanPaymentsCalculator\PaymentSchedule
 */
class EqualPrincipalPaymentScheduleCalculator implements PaymentScheduleCalculator
{
    /**
     * @var Period[]
     */
    private $schedulePeriods;

    /**
     * @var float
     */
    private $principalAmount;

    /**
     * @var float
     */
    private $dailyInterestRate;

    /**
     * @var float
     */
    private $totalInterest;

    /**
     * PaymentSchedule constructor.
     * @param Period[] $schedulePeriods
     * @param float    $principalAmount
     * @param float    $dailyInterestRate
     */
    public function __construct(
        $schedulePeriods,
        $principalAmount,
        $dailyInterestRate
    ){

        $this->schedulePeriods = $schedulePeriods;
        $this->principalAmount = $principalAmount;
        $this->dailyInterestRate = $dailyInterestRate;
        $this->totalInterest = 0.0;
    }

    /**
     * @return float
     */
    public function getTotalInterest()
    {
        return $this->totalInterest;
    }

    /**
     * @param float $totalInterest
     */
    public function setTotalInterest($totalInterest)
    {
        $this->totalInterest = $totalInterest;
    }

    /**
     * @inheritdoc
     */
    public function calculateSchedule()
    {
        /**
         * @var Payment[] $payments
         */
        $payments = [];
        $numberOfPeriods = count($this->schedulePeriods);
        $paymentPrincipal = $this->principalAmount/$numberOfPeriods;
        $totalPrincipalToPay = $this->principalAmount;

        for ($i=0; $i<$numberOfPeriods ; $i++) {

            $payment = new Payment($this->schedulePeriods[$i]);
            // Payment principal
            $payment->setPrincipal($paymentPrincipal);
            // Payment interest
            $paymentInterest = $this->calculatePaymentInterest($totalPrincipalToPay, $this->dailyInterestRate, $payment->getPeriod()->daysLength);
            $payment->setInterest($paymentInterest);
            // Payment totals
            $totalPrincipalToPay-=$paymentPrincipal;
            $payment->setPrincipalBalanceLeft($totalPrincipalToPay);

            $payments[] = $payment;
            $this->totalInterest += $paymentInterest;
        }

        return $payments;
    }

    /**
     * @param float   $remainingPrincipalAmount
     * @param float   $dailyInterestRate
     * @param integer $periodInDays
     * @return float
     */
    private function calculatePaymentInterest($remainingPrincipalAmount, $dailyInterestRate, $periodInDays)
    {
        return $remainingPrincipalAmount*$dailyInterestRate*$periodInDays;
    }
}

1		<?php
2		/**
3		* @author: Vova Lando <[email protected]>
4		* @package: LoanPaymentsCalculator
5		* @subpackage:
6		* @created: 05/09/2017 16:56
7		*/
8
9		namespace cog\LoanPaymentsCalculator\PaymentSchedule;
10
11		use cog\LoanPaymentsCalculator\Payment\Payment;
12		use cog\LoanPaymentsCalculator\Period\Period;
13		use cog\LoanPaymentsCalculator\Schedule\Schedule;
14
15		/**
16		* Class EqualPrincipalPaymentScheduleCalculator
17		* @package cog\LoanPaymentsCalculator\PaymentSchedule
18		*/
19		class EqualPrincipalPaymentScheduleCalculator implements PaymentScheduleCalculator
20		{
21		/**
22		* @var Period[]
23		*/
24		private $schedulePeriods;
25
26		/**
27		* @var float
28		*/
29		private $principalAmount;
30
31		/**
32		* @var float
33		*/
34		private $dailyInterestRate;
35
36		/**
37		* @var float
38		*/
39		private $totalInterest;
40
41		/**
42		* PaymentSchedule constructor.
43		* @param Period[] $schedulePeriods
44		* @param float $principalAmount
45		* @param float $dailyInterestRate
46		*/
47	2	public function __construct(
48		$schedulePeriods,
49		$principalAmount,
50		$dailyInterestRate
51		){
		0 ignored issues – show Coding Style introduced 2017-09-07 08:43 UTC by Report Bug Copy Issue Report There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration; found 0 spaces Loading history...
52	2	$this->schedulePeriods = $schedulePeriods;
53	2	$this->principalAmount = $principalAmount;
54	2	$this->dailyInterestRate = $dailyInterestRate;
55	2	$this->totalInterest = 0.0;
56	2	}
57
58		/**
59		* @return float
60		*/
61	2	public function getTotalInterest()
62		{
63	2	return $this->totalInterest;
64		}
65
66		/**
67		* @param float $totalInterest
68		*/
69		public function setTotalInterest($totalInterest)
70		{
71		$this->totalInterest = $totalInterest;
72		}
73
74		/**
75		* @inheritdoc
76		*/
77	2	public function calculateSchedule()
78		{
79		/**
80		* @var Payment[] $payments
81		*/
82	2	$payments = [];
83	2	$numberOfPeriods = count($this->schedulePeriods);
84	2	$paymentPrincipal = $this->principalAmount/$numberOfPeriods;
85	2	$totalPrincipalToPay = $this->principalAmount;
86
87	2	for ($i=0; $i<$numberOfPeriods ; $i++) {
		0 ignored issues – show Coding Style introduced 2017-09-07 08:43 UTC by Report Bug Copy Issue Report Space found before second semicolon of FOR loop Loading history...
88	2	$payment = new Payment($this->schedulePeriods[$i]);
89		// Payment principal
90	2	$payment->setPrincipal($paymentPrincipal);
91		// Payment interest
92	2	$paymentInterest = $this->calculatePaymentInterest($totalPrincipalToPay, $this->dailyInterestRate, $payment->getPeriod()->daysLength);
93	2	$payment->setInterest($paymentInterest);
94		// Payment totals
95	2	$totalPrincipalToPay-=$paymentPrincipal;
96	2	$payment->setPrincipalBalanceLeft($totalPrincipalToPay);
97
98	2	$payments[] = $payment;
99	2	$this->totalInterest += $paymentInterest;
100		}
101
102	2	return $payments;
103		}
104
105		/**
106		* @param float $remainingPrincipalAmount
107		* @param float $dailyInterestRate
108		* @param integer $periodInDays
109		* @return float
110		*/
111	2	private function calculatePaymentInterest($remainingPrincipalAmount, $dailyInterestRate, $periodInDays)
112		{
113	2	return $remainingPrincipalAmount$dailyInterestRate$periodInDays;
114		}
115		}

Vovke / loan-payments-calculator

Push — master ( 3bb3f6...b96e37 )

calculatePaymentInterest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like