CommitCollectionFactory::getCollection() - Code Metrics - Inspection of "refactor: extract CommitCollection creation into a..." - Voral/vs-version-incrementor - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5168f4...b7b35d )

by Alexander

created 2025-04-15 07:48 UTC

CommitCollectionFactory::getCollection() A

↳ Parent: CommitCollectionFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	15
c	1
b	0
f	0
dl	0
loc	21
ccs	17
cts	17
cp	1
rs	9.7666
cc	3
nc	3
nop	1
crap	3

<?php

declare(strict_types=1);

namespace Vasoft\VersionIncrement\Commits;

use Vasoft\VersionIncrement\Config;

final class CommitCollectionFactory
{
    public function __construct(
        private readonly Config $config,
        private readonly array $majorTypes,
        private readonly array $minorTypes,
        private readonly string $defaultSection,
    ) {}

    /**
     * @param array $sortedSections Sorted sections array, where keys are section names and values are section
     *                              configurations and default section exists
     */
    public function getCollection(array $sortedSections): CommitCollection
    {
        $sections = [];
        $default = null;
        foreach ($sortedSections as $key => $section) {
            $section = new Section(
                $key,
                $section['title'],
                $section['hidden'],
                $this->config->getSectionRules($key),
                in_array($key, $this->majorTypes, true),
                in_array($key, $this->minorTypes, true),
                $this->config,
            );
            if ($this->defaultSection === $key) {
                $default = $section;
            }
            $sections[$key] = $section;
        }

        return new CommitCollection($sections, /* @scrutinizer ignore-type */ $default);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Vasoft\VersionIncrement\Commits;
6
7		use Vasoft\VersionIncrement\Config;
8
9		final class CommitCollectionFactory
10		{
11	24	public function __construct(
12		private readonly Config $config,
13		private readonly array $majorTypes,
14		private readonly array $minorTypes,
15		private readonly string $defaultSection,
16	24	) {}
17
18		/**
19		* @param array $sortedSections Sorted sections array, where keys are section names and values are section
20		* configurations and default section exists
21		*/
22	24	public function getCollection(array $sortedSections): CommitCollection
23		{
24	24	$sections = [];
25	24	$default = null;
26	24	foreach ($sortedSections as $key => $section) {
27	24	$section = new Section(
28	24	$key,
29	24	$section['title'],
30	24	$section['hidden'],
31	24	$this->config->getSectionRules($key),
32	24	in_array($key, $this->majorTypes, true),
33	24	in_array($key, $this->minorTypes, true),
34	24	$this->config,
35	24	);
36	24	if ($this->defaultSection === $key) {
37	24	$default = $section;
38		}
39	24	$sections[$key] = $section;
40		}
41
42	24	return new CommitCollection($sections, /* @scrutinizer ignore-type */ $default);
43		}
44		}
45

Voral / vs-version-incrementor

Push — master ( 5168f4...b7b35d )

CommitCollectionFactory::getCollection() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like