Vinelab\Api\Responder

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	9
Bugs	1	Features	3

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	respond()	0	12	3
A	getRequestFormat()	0	4	1

<?php

namespace Vinelab\Api;

/*
 * @author Mahmoud Zalt <mahmoud@vinelab.com>
 */

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Response;

class Responder
{
    /**
     * @param \Illuminate\Http\Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;

The property request does not exist. Did you maybe forget to declare it?

    }

    /**
     * @param $response
     * @param $status
     * @param $headers
     * @param $options
     *
     * @return $this|\Illuminate\Http\JsonResponse
     */
    public function respond($response, $status, $headers, $options)
    {
        switch ($this->getRequestFormat()) {
            case 'html' :

There must be no space before the colon in a CASE statement

            case 'text/html' :

There must be no space before the colon in a CASE statement

                return Response::make($response, $status, $headers, $options)
                    ->header('Content-Type', 'text/html');
            default :

There must be no space before the colon in a DEFAULT statement

                // whether 'Content-Type' is NULL or equal to anything such as 'application/json' response will be JSON
                return Response::json($response, $status, $headers, $options);
        }
    }

    /**
     * Get request format from the content type header property.
     *
     * @return string
     */
    public function getRequestFormat()
    {
        return $this->request->header('Content-Type');
    }
}