VinaiKopp\CurrencyInfo\Build\CurrencyInfoSourceTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testReturnsInstanceWithGivenJson()	0	14	1
A	testThrowsExceptionIfInputIsNotString()	0	6	1
A	testReturnsCurrencyInfoSourceInstanceFromGivenJsonString()	0	7	1
A	testReturnsCurrencyInfoInstanceBasedOnFileName()	0	13	1

<?php

namespace VinaiKopp\CurrencyInfo\Build;

use VinaiKopp\CurrencyInfo\StaticAccess\CurrencyInfo;

/**
 * @covers \VinaiKopp\CurrencyInfo\Build\CurrencyInfoSource
 */
class CurrencyInfoSourceTest extends \PHPUnit_Framework_TestCase
{
    public function testReturnsInstanceWithGivenJson()
    {
        $testSource = [
            'EUR' => [
                CurrencyInfo::SYMBOL          => 'EUR',
                CurrencyInfo::SYMBOL_NATIVE   => '€',
                CurrencyInfo::FRACTION_DIGITS => 2,
                CurrencyInfo::ROUNDING        => 0,
                CurrencyInfo::CODE            => 'EUR',
            ],
        ];
        $currencyInfoSource = new CurrencyInfoSource($testSource);
        $this->assertSame($testSource, $currencyInfoSource->get());
    }

    public function testThrowsExceptionIfInputIsNotString()
    {
        $this->expectException(\InvalidArgumentException::class);
        $this->expectExceptionMessage('Input has to be a JSON encoded currency info object');
        CurrencyInfoSource::fromJson('foo');
    }

    public function testReturnsCurrencyInfoSourceInstanceFromGivenJsonString()
    {
        $testSource = ['foo' => ['bar' => 'buz']];
        $currencyInfoSource = CurrencyInfoSource::fromJson(json_encode($testSource));
        $this->assertInstanceOf(CurrencyInfoSource::class, $currencyInfoSource);
        $this->assertSame($testSource, $currencyInfoSource->get());
    }

    public function testReturnsCurrencyInfoInstanceBasedOnFileName()
    {
        $testSource = ['foo' => ['bar' => 'buz']];
        $fileName = tempnam(sys_get_temp_dir(), 'test-');
        register_shutdown_function(function () use ($fileName) {
            @unlink($fileName);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        });
        file_put_contents($fileName, json_encode($testSource));

        $currencyInfoSource = CurrencyInfoSource::fromFile($fileName);
        $this->assertInstanceOf(CurrencyInfoSource::class, $currencyInfoSource);
        $this->assertSame($testSource, $currencyInfoSource->get());
    }
}