TagController::editRoleAction() - Code Metrics - VictorTkachenko81/SymfonyBlog - Measure and Improve Code Quality continuously with Scrutinizer

TagController::editRoleAction() B
last analyzed 2016-01-23 13:10 UTC

↳ Parent: TagController

Complexity

Conditions	3
Paths	3

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	32
ccs	0
cts	22
cp	0
rs	8.8571
cc	3
eloc	20
nc	3
nop	1
crap	12

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\Tag;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\HttpFoundation\Request;

/**
 * Class AdminController
 * @package AppBundle\Controller\Admin
 * @Route("/admin")
 */
class TagController extends Controller
{
    /**
     * @Method("GET")
     * @Route("/tags", name="tagsAdmin")
     * @Template("AppBundle:admin:tags.html.twig")
     *
     * @return Response
     */
    public function roleAction()
    {
        $em = $this->getDoctrine()->getManager();
        $tags = $em->getRepository('AppBundle:Tag')
            ->findAll();

        return [
            'tags'  => $tags,
        ];
    }

    /**
     * @param Request $request
     * @Route("/tag/new", name="tagNew")
     * @Method({"GET", "POST"})
     * @Template("AppBundle:admin/form:tag.html.twig")
     *
     * @return Response
     */
    public function editRoleAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();

        $tag = new Tag();
        $title = 'Create new tag';

        $form = $this->createFormBuilder($tag)
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->setAction($this->generateUrl('tagNew'))
            ->setMethod('POST')
            ->add('name', TextType::class, array(
                    'attr' => array('placeholder' => '* Tag name'),
                )
            )
            ->add('save', SubmitType::class, array('label' => 'Save'))
            ->getForm();

        if ($request->getMethod() == 'POST') {
            $form->handleRequest($request);
            if ($form->isValid()) {
                $em->persist($tag);
                $em->flush();

                return $this->redirectToRoute('tagsAdmin');
            }
        }

        return [
            'title' => $title,
            'form'  => $form->createView(),
        ];
    }
}


1		<?php
2
3		namespace AppBundle\Controller\Admin;
4
5		use AppBundle\Entity\Tag;
6		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
8		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
9		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10		use Symfony\Component\Form\Extension\Core\Type\SubmitType;
11		use Symfony\Component\Form\Extension\Core\Type\TextType;
12		use Symfony\Component\HttpFoundation\Request;
13
14		/**
15		* Class AdminController
16		* @package AppBundle\Controller\Admin
17		* @Route("/admin")
18		*/
19		class TagController extends Controller
20		{
21		/**
22		* @Method("GET")
23		* @Route("/tags", name="tagsAdmin")
24		* @Template("AppBundle:admin:tags.html.twig")
25		*
26		* @return Response
27		*/
28	1	public function roleAction()
29		{
30	1	$em = $this->getDoctrine()->getManager();
31	1	$tags = $em->getRepository('AppBundle:Tag')
32	1	->findAll();
33
34		return [
35	1	'tags' => $tags,
36	1	];
37		}
38
39		/**
40		* @param Request $request
41		* @Route("/tag/new", name="tagNew")
42		* @Method({"GET", "POST"})
43		* @Template("AppBundle:admin/form:tag.html.twig")
44		*
45		* @return Response
46		*/
47		public function editRoleAction(Request $request)
48		{
49		$em = $this->getDoctrine()->getManager();
50
51		$tag = new Tag();
52		$title = 'Create new tag';
53
54		$form = $this->createFormBuilder($tag)
		0 ignored issues – show Bug introduced 2016-01-17 18:08 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Symfony\Component\Form\FormConfigBuilder` as the method `add()` does only exist in the following sub-classes of `Symfony\Component\Form\FormConfigBuilder`: `Symfony\Component\Form\FormBuilder`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
55		->setAction($this->generateUrl('tagNew'))
56		->setMethod('POST')
57		->add('name', TextType::class, array(
58		'attr' => array('placeholder' => '* Tag name'),
59		)
60		)
61		->add('save', SubmitType::class, array('label' => 'Save'))
62		->getForm();
63
64		if ($request->getMethod() == 'POST') {
65		$form->handleRequest($request);
66		if ($form->isValid()) {
67		$em->persist($tag);
68		$em->flush();
69
70		return $this->redirectToRoute('tagsAdmin');
71		}
72		}
73
74		return [
75		'title' => $title,
76		'form' => $form->createView(),
77		];
78		}
79		}
80

VictorTkachenko81 / SymfonyBlog

TagController::editRoleAction() B last analyzed 2016-01-23 13:10 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

TagController::editRoleAction() B
last analyzed 2016-01-23 13:10 UTC