User - Code Metrics - VictorTkachenko81/SymfonyBlog - Measure and Improve Code Quality continuously with Scrutinizer

User B
last analyzed 2016-01-23 13:10 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	537
Duplicated Lines	6.33 %

Coupling/Cohesion

Components	3
Dependencies	2

Importance

Changes	10
Bugs	1	Features	1

Metric	Value
wmc	43
c	10
b	1
f	1
lcom	3
cbo	2
dl	34
loc	537
rs	8.3157

34 Methods

Rating	Name	Duplication	Size	Complexity
A	setName()	0	6	1
A	getName()	0	4	1
A	setSlug()	0	6	1
A	getSlug()	0	4	1
A	getEmail()	0	4	1
A	setCreatedAt()	0	6	1
A	getCreatedAt()	0	4	1
A	setUpdatedAt()	0	6	1
A	getUpdatedAt()	0	4	1
A	setDeletedAt()	0	6	1
A	getDeletedAt()	0	4	1
A	__construct()	0	5	1
A	addArticle()	0	6	1
A	removeArticle()	0	4	1
A	getArticles()	0	4	1
A	addComment()	0	6	1
A	removeComment()	0	4	1
A	getComments()	0	4	1
A	setRole()	0	6	1
A	getRole()	0	4	1
A	setPassword()	0	6	1
A	getPassword()	0	4	1
A	setPhoto()	0	6	1
A	getPhoto()	0	4	1
A	setFile()	10	10	2
A	getFile()	0	4	1
A	getAbsolutePath()	0	6	2
A	getWebPath()	0	6	2
A	getUploadRootDir()	0	4	1
A	getUploadDir()	0	4	1
A	preUpload()	7	7	2
A	upload()	17	17	3
A	removeUpload()	0	9	2
A	clearCache()	0	6	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like User often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use User, and based on these observations, apply Extract Interface, too.

<?php

namespace AppBundle\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Mapping as ORM;
use Gedmo\Mapping\Annotation as Gedmo;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Symfony\Component\Validator\Constraints as Assert;

/**
 * User
 *
 * @ORM\Table(name="user")
 * @ORM\Entity(repositoryClass="AppBundle\Repository\UserRepository")
 * @ORM\HasLifecycleCallbacks
 */
class User
{
    /**
     * @var int
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * @var string
     *
     * @ORM\Column(name="name", type="string", length=50, unique=true)
     *
     * @Assert\NotBlank()
     * @Assert\Length(max = 50)
     */
    private $name;

    /**
     * @var string
     *
     * @Gedmo\Slug(fields={"name"}, updatable=true, separator="_")
     * @ORM\Column(name="slug", type="string", length=50, unique=true)
     *
     * @Assert\Length(max = 50)
     */
    private $slug;

    /**
     * @var string
     *
     * @ORM\Column(name="photo", type="string", length=150, nullable=true)
     *
     * @Assert\Length(max = 150)
     */
    private $photo;

    /**
     * @Assert\File(maxSize="6000000",
     *     mimeTypes={
     *     "image/jpeg",
     *     "image/jpg",
     *     "image/png"})
     */
    private $file;

    private $temp;

    /**
     * @var string
     *
     * @ORM\Column(name="email", type="string", length=50)
     *
     * @Assert\NotBlank()
     * @Assert\Email()
     */
    private $email;

    /**
     * @var string
     *
     * @ORM\Column(name="password", type="string", length=100)
     *
     * @Assert\NotBlank()
     * @Assert\Length(max = 100)
     */
    private $password;

    /**
     * @ORM\OneToMany(targetEntity="Article", mappedBy="user")
     */
    private $articles;

    /**
     * @ORM\OneToMany(targetEntity="Comment", mappedBy="user")
     */
    private $comments;

    /**
     * @ORM\ManyToOne(targetEntity="Role", inversedBy="users")
     * @ORM\JoinColumn(name="role_id", referencedColumnName="id")
     */
    private $role;

    /**
     * @var \DateTime
     *
     * @Gedmo\Timestampable(on="create")
     * @ORM\Column(name="created_at", type="datetime")
     *
     * @Assert\DateTime()
     */
    private $createdAt;

    /**
     * @var \DateTime
     *
     * @Gedmo\Timestampable(on="change", field={"user", "role", "email", "password"})
     * @ORM\Column(name="updated_at", type="datetime", nullable=true)
     *
     * @Assert\DateTime()
     */
    private $updatedAt;

    /**
     * @var \DateTime
     *
     * @ORM\Column(name="deleted_at", type="datetime", nullable=true)
     *
     * @Assert\DateTime()
     */
    private $deletedAt;


    /**
     * Get id
     *
     * @return int
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * Set user
     *
     * @param string $name
     *
     * @return User
     */
    public function setName($name)
    {
        $this->name = $name;

        return $this;
    }

    /**
     * Get user
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Set slug
     *
     * @param string $slug
     *
     * @return User
     */
    public function setSlug($slug)
    {
        $this->slug = $slug;

        return $this;
    }

    /**
     * Get slug
     *
     * @return string
     */
    public function getSlug()
    {
        return $this->slug;
    }

    /**
     * Set email
     *
     * @param string $email
     *
     * @return User
     */
    public function setEmail($email)
    {
        $this->email = $email;

        return $this;
    }

    /**
     * Get email
     *
     * @return string
     */
    public function getEmail()
    {
        return $this->email;
    }

    /**
     * Set createdAt
     *
     * @param \DateTime $createdAt
     *
     * @return User
     */
    public function setCreatedAt($createdAt)
    {
        $this->createdAt = $createdAt;

        return $this;
    }

    /**
     * Get createdAt
     *
     * @return \DateTime
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * Set updatedAt
     *
     * @param \DateTime $updatedAt
     *
     * @return User
     */
    public function setUpdatedAt($updatedAt)
    {
        $this->updatedAt = $updatedAt;

        return $this;
    }

    /**
     * Get updatedAt
     *
     * @return \DateTime
     */
    public function getUpdatedAt()
    {
        return $this->updatedAt;
    }

    /**
     * Set deletedAt
     *
     * @param \DateTime $deletedAt
     *
     * @return User
     */
    public function setDeletedAt($deletedAt)
    {
        $this->deletedAt = $deletedAt;

        return $this;
    }

    /**
     * Get deletedAt
     *
     * @return \DateTime
     */
    public function getDeletedAt()
    {
        return $this->deletedAt;
    }
    /**
     * Constructor
     */
    public function __construct()
    {
        $this->articles = new ArrayCollection();
        $this->comments = new ArrayCollection();
    }

    /**
     * Add article
     *
     * @param \AppBundle\Entity\Article $article
     *
     * @return User
     */
    public function addArticle(Article $article)
    {
        $this->articles[] = $article;

        return $this;
    }

    /**
     * Remove article
     *
     * @param \AppBundle\Entity\Article $article
     */
    public function removeArticle(Article $article)
    {
        $this->articles->removeElement($article);
    }

    /**
     * Get articles
     *
     * @return \Doctrine\Common\Collections\Collection
     */
    public function getArticles()
    {
        return $this->articles;
    }

    /**
     * Add comment
     *
     * @param \AppBundle\Entity\Comment $comment
     *
     * @return User
     */
    public function addComment(Comment $comment)
    {
        $this->comments[] = $comment;

        return $this;
    }

    /**
     * Remove comment
     *
     * @param \AppBundle\Entity\Comment $comment
     */
    public function removeComment(Comment $comment)
    {
        $this->comments->removeElement($comment);
    }

    /**
     * Get comments
     *
     * @return \Doctrine\Common\Collections\Collection
     */
    public function getComments()
    {
        return $this->comments;
    }

    /**
     * Set role
     *
     * @param \AppBundle\Entity\Role $role
     *
     * @return User
     */
    public function setRole(Role $role = null)
    {
        $this->role = $role;

        return $this;
    }

    /**
     * Get role
     *
     * @return \AppBundle\Entity\Role
     */
    public function getRole()
    {
        return $this->role;
    }

    /**
     * Set password
     *
     * @param string $password
     *
     * @return User
     */
    public function setPassword($password)
    {
        $this->password = $password;

        return $this;
    }

    /**
     * Get password
     *
     * @return string
     */
    public function getPassword()
    {
        return $this->password;
    }

    /**
     * Set photo
     *
     * @param string $photo
     *
     * @return User
     */
    public function setPhoto($photo)
    {
        $this->photo = $photo;

        return $this;
    }

    /**
     * Get photo
     *
     * @return string
     */
    public function getPhoto()
    {
        return $this->photo;
    }


    /**
     * ***********************
     * Upload images start
     * ***********************
     */


    /**
     * Sets file.
     *
     * @param UploadedFile $file
     */
    public function setFile(UploadedFile $file = null)

    {
        $this->file = $file;
        if (isset($this->photo)) {
            $this->temp = $this->photo;
            $this->photo = null;
        } else {
            $this->photo = 'initial';
        }
    }

    /**
     * Get file.
     *
     * @return UploadedFile
     */
    public function getFile()
    {
        return $this->file;
    }

    public function getAbsolutePath()
    {
        return null === $this->photo
            ? null
            : $this->getUploadRootDir().'/'.$this->photo;
    }

    public function getWebPath()
    {
        return null === $this->photo
            ? null
            : $this->getUploadDir().'/'.$this->photo;
    }

    protected function getUploadRootDir()
    {
        return __DIR__.'/../../../web/'.$this->getUploadDir();
    }

    protected function getUploadDir()
    {
        return 'media/users';
    }

    /**
     * @ORM\PrePersist()
     * @ORM\PreUpdate()
     */
    public function preUpload()

    {
        if (null !== $this->getFile()) {
            $filename = sha1(uniqid(mt_rand(), true));
            $this->photo = $filename.'.'.$this->getFile()->guessExtension();
        }
    }

    /**
     * @ORM\PostPersist()
     * @ORM\PostUpdate()
     */
    public function upload()

    {
        if (null === $this->getFile()) {
            return;
        }

        $this->getFile()->move($this->getUploadRootDir(), $this->photo);

        if (isset($this->temp)) {
            unlink($this->getUploadRootDir().'/'.$this->temp);

            $this->clearCache($this->getUploadDir().'/'.$this->temp);

            $this->temp = null;
        }
        $this->file = null;
    }

    /**
     * @ORM\PostRemove()
     */
    public function removeUpload()
    {
        $file = $this->getAbsolutePath();
        if ($file) {
            unlink($file);

            $this->clearCache($this->getWebPath());
        }
    }

    public function clearCache($path)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $kernel = $GLOBALS['kernel'];
        $cacheManager = $kernel->getContainer()->get('liip_imagine.cache.manager');
        $cacheManager->remove($path);
    }

    /**
     * ***********************
     * Upload images end
     * ***********************
     */
}


1		<?php
2
3		namespace AppBundle\Entity;
4
5		use Doctrine\Common\Collections\ArrayCollection;
6		use Doctrine\ORM\Mapping as ORM;
7		use Gedmo\Mapping\Annotation as Gedmo;
8		use Symfony\Component\HttpFoundation\File\UploadedFile;
9		use Symfony\Component\Validator\Constraints as Assert;
10
11		/**
12		* User
13		*
14		* @ORM\Table(name="user")
15		* @ORM\Entity(repositoryClass="AppBundle\Repository\UserRepository")
16		* @ORM\HasLifecycleCallbacks
17		*/
18		class User
19		{
20		/**
21		* @var int
22		*
23		* @ORM\Column(name="id", type="integer")
24		* @ORM\Id
25		* @ORM\GeneratedValue(strategy="AUTO")
26		*/
27		private $id;
28
29		/**
30		* @var string
31		*
32		* @ORM\Column(name="name", type="string", length=50, unique=true)
33		*
34		* @Assert\NotBlank()
35		* @Assert\Length(max = 50)
36		*/
37		private $name;
38
39		/**
40		* @var string
41		*
42		* @Gedmo\Slug(fields={"name"}, updatable=true, separator="_")
43		* @ORM\Column(name="slug", type="string", length=50, unique=true)
44		*
45		* @Assert\Length(max = 50)
46		*/
47		private $slug;
48
49		/**
50		* @var string
51		*
52		* @ORM\Column(name="photo", type="string", length=150, nullable=true)
53		*
54		* @Assert\Length(max = 150)
55		*/
56		private $photo;
57
58		/**
59		* @Assert\File(maxSize="6000000",
60		* mimeTypes={
61		* "image/jpeg",
62		* "image/jpg",
63		* "image/png"})
64		*/
65		private $file;
66
67		private $temp;
68
69		/**
70		* @var string
71		*
72		* @ORM\Column(name="email", type="string", length=50)
73		*
74		* @Assert\NotBlank()
75		* @Assert\Email()
76		*/
77		private $email;
78
79		/**
80		* @var string
81		*
82		* @ORM\Column(name="password", type="string", length=100)
83		*
84		* @Assert\NotBlank()
85		* @Assert\Length(max = 100)
86		*/
87		private $password;
88
89		/**
90		* @ORM\OneToMany(targetEntity="Article", mappedBy="user")
91		*/
92		private $articles;
93
94		/**
95		* @ORM\OneToMany(targetEntity="Comment", mappedBy="user")
96		*/
97		private $comments;
98
99		/**
100		* @ORM\ManyToOne(targetEntity="Role", inversedBy="users")
101		* @ORM\JoinColumn(name="role_id", referencedColumnName="id")
102		*/
103		private $role;
104
105		/**
106		* @var \DateTime
107		*
108		* @Gedmo\Timestampable(on="create")
109		* @ORM\Column(name="created_at", type="datetime")
110		*
111		* @Assert\DateTime()
112		*/
113		private $createdAt;
114
115		/**
116		* @var \DateTime
117		*
118		* @Gedmo\Timestampable(on="change", field={"user", "role", "email", "password"})
119		* @ORM\Column(name="updated_at", type="datetime", nullable=true)
120		*
121		* @Assert\DateTime()
122		*/
123		private $updatedAt;
124
125		/**
126		* @var \DateTime
127		*
128		* @ORM\Column(name="deleted_at", type="datetime", nullable=true)
129		*
130		* @Assert\DateTime()
131		*/
132		private $deletedAt;
133
134
135		/**
136		* Get id
137		*
138		* @return int
139		*/
140		public function getId()
141		{
142		return $this->id;
143		}
144
145		/**
146		* Set user
147		*
148		* @param string $name
149		*
150		* @return User
151		*/
152		public function setName($name)
153		{
154		$this->name = $name;
155
156		return $this;
157		}
158
159		/**
160		* Get user
161		*
162		* @return string
163		*/
164		public function getName()
165		{
166		return $this->name;
167		}
168
169		/**
170		* Set slug
171		*
172		* @param string $slug
173		*
174		* @return User
175		*/
176		public function setSlug($slug)
177		{
178		$this->slug = $slug;
179
180		return $this;
181		}
182
183		/**
184		* Get slug
185		*
186		* @return string
187		*/
188		public function getSlug()
189		{
190		return $this->slug;
191		}
192
193		/**
194		* Set email
195		*
196		* @param string $email
197		*
198		* @return User
199		*/
200		public function setEmail($email)
201		{
202		$this->email = $email;
203
204		return $this;
205		}
206
207		/**
208		* Get email
209		*
210		* @return string
211		*/
212		public function getEmail()
213		{
214		return $this->email;
215		}
216
217		/**
218		* Set createdAt
219		*
220		* @param \DateTime $createdAt
221		*
222		* @return User
223		*/
224		public function setCreatedAt($createdAt)
225		{
226		$this->createdAt = $createdAt;
227
228		return $this;
229		}
230
231		/**
232		* Get createdAt
233		*
234		* @return \DateTime
235		*/
236		public function getCreatedAt()
237		{
238		return $this->createdAt;
239		}
240
241		/**
242		* Set updatedAt
243		*
244		* @param \DateTime $updatedAt
245		*
246		* @return User
247		*/
248		public function setUpdatedAt($updatedAt)
249		{
250		$this->updatedAt = $updatedAt;
251
252		return $this;
253		}
254
255		/**
256		* Get updatedAt
257		*
258		* @return \DateTime
259		*/
260		public function getUpdatedAt()
261		{
262		return $this->updatedAt;
263		}
264
265		/**
266		* Set deletedAt
267		*
268		* @param \DateTime $deletedAt
269		*
270		* @return User
271		*/
272		public function setDeletedAt($deletedAt)
273		{
274		$this->deletedAt = $deletedAt;
275
276		return $this;
277		}
278
279		/**
280		* Get deletedAt
281		*
282		* @return \DateTime
283		*/
284		public function getDeletedAt()
285		{
286		return $this->deletedAt;
287		}
288		/**
289		* Constructor
290		*/
291		public function __construct()
292		{
293		$this->articles = new ArrayCollection();
294		$this->comments = new ArrayCollection();
295		}
296
297		/**
298		* Add article
299		*
300		* @param \AppBundle\Entity\Article $article
301		*
302		* @return User
303		*/
304		public function addArticle(Article $article)
305		{
306		$this->articles[] = $article;
307
308		return $this;
309		}
310
311		/**
312		* Remove article
313		*
314		* @param \AppBundle\Entity\Article $article
315		*/
316		public function removeArticle(Article $article)
317		{
318		$this->articles->removeElement($article);
319		}
320
321		/**
322		* Get articles
323		*
324		* @return \Doctrine\Common\Collections\Collection
325		*/
326		public function getArticles()
327		{
328		return $this->articles;
329		}
330
331		/**
332		* Add comment
333		*
334		* @param \AppBundle\Entity\Comment $comment
335		*
336		* @return User
337		*/
338		public function addComment(Comment $comment)
339		{
340		$this->comments[] = $comment;
341
342		return $this;
343		}
344
345		/**
346		* Remove comment
347		*
348		* @param \AppBundle\Entity\Comment $comment
349		*/
350		public function removeComment(Comment $comment)
351		{
352		$this->comments->removeElement($comment);
353		}
354
355		/**
356		* Get comments
357		*
358		* @return \Doctrine\Common\Collections\Collection
359		*/
360		public function getComments()
361		{
362		return $this->comments;
363		}
364
365		/**
366		* Set role
367		*
368		* @param \AppBundle\Entity\Role $role
369		*
370		* @return User
371		*/
372		public function setRole(Role $role = null)
373		{
374		$this->role = $role;
375
376		return $this;
377		}
378
379		/**
380		* Get role
381		*
382		* @return \AppBundle\Entity\Role
383		*/
384		public function getRole()
385		{
386		return $this->role;
387		}
388
389		/**
390		* Set password
391		*
392		* @param string $password
393		*
394		* @return User
395		*/
396		public function setPassword($password)
397		{
398		$this->password = $password;
399
400		return $this;
401		}
402
403		/**
404		* Get password
405		*
406		* @return string
407		*/
408		public function getPassword()
409		{
410		return $this->password;
411		}
412
413		/**
414		* Set photo
415		*
416		* @param string $photo
417		*
418		* @return User
419		*/
420		public function setPhoto($photo)
421		{
422		$this->photo = $photo;
423
424		return $this;
425		}
426
427		/**
428		* Get photo
429		*
430		* @return string
431		*/
432		public function getPhoto()
433		{
434		return $this->photo;
435		}
436
437
438		/**
439		* ***********************
440		* Upload images start
441		* ***********************
442		*/
443
444
445		/**
446		* Sets file.
447		*
448		* @param UploadedFile $file
449		*/
450	View Code Duplication	public function setFile(UploadedFile $file = null)
		0 ignored issues – show Duplication introduced 2016-01-16 21:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
451		{
452		$this->file = $file;
453		if (isset($this->photo)) {
454		$this->temp = $this->photo;
455		$this->photo = null;
456		} else {
457		$this->photo = 'initial';
458		}
459		}
460
461		/**
462		* Get file.
463		*
464		* @return UploadedFile
465		*/
466		public function getFile()
467		{
468		return $this->file;
469		}
470
471		public function getAbsolutePath()
472		{
473		return null === $this->photo
474		? null
475		: $this->getUploadRootDir().'/'.$this->photo;
476		}
477
478		public function getWebPath()
479		{
480		return null === $this->photo
481		? null
482		: $this->getUploadDir().'/'.$this->photo;
483		}
484
485		protected function getUploadRootDir()
486		{
487		return __DIR__.'/../../../web/'.$this->getUploadDir();
488		}
489
490		protected function getUploadDir()
491		{
492		return 'media/users';
493		}
494
495		/**
496		* @ORM\PrePersist()
497		* @ORM\PreUpdate()
498		*/
499	View Code Duplication	public function preUpload()
		0 ignored issues – show Duplication introduced 2016-01-16 21:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
500		{
501		if (null !== $this->getFile()) {
502		$filename = sha1(uniqid(mt_rand(), true));
503		$this->photo = $filename.'.'.$this->getFile()->guessExtension();
504		}
505		}
506
507		/**
508		* @ORM\PostPersist()
509		* @ORM\PostUpdate()
510		*/
511	View Code Duplication	public function upload()
		0 ignored issues – show Duplication introduced 2016-01-16 21:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
512		{
513		if (null === $this->getFile()) {
514		return;
515		}
516
517		$this->getFile()->move($this->getUploadRootDir(), $this->photo);
518
519		if (isset($this->temp)) {
520		unlink($this->getUploadRootDir().'/'.$this->temp);
521
522		$this->clearCache($this->getUploadDir().'/'.$this->temp);
523
524		$this->temp = null;
525		}
526		$this->file = null;
527		}
528
529		/**
530		* @ORM\PostRemove()
531		*/
532		public function removeUpload()
533		{
534		$file = $this->getAbsolutePath();
535		if ($file) {
536		unlink($file);
537
538		$this->clearCache($this->getWebPath());
539		}
540		}
541
542		public function clearCache($path)
		0 ignored issues – show Coding Style introduced 2016-01-16 21:27 UTC by Report Bug Copy Issue Report `clearCache` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
543		{
544		$kernel = $GLOBALS['kernel'];
545		$cacheManager = $kernel->getContainer()->get('liip_imagine.cache.manager');
546		$cacheManager->remove($path);
547		}
548
549		/**
550		* ***********************
551		* Upload images end
552		* ***********************
553		*/
554		}
555

VictorTkachenko81 / SymfonyBlog

User B last analyzed 2016-01-23 13:10 UTC