Issues in PageController.php (master) - Issues in master - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1704)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Bundle/PageBundle/Controller/PageController.php (5 issues)

Labels

Severity

Major 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Victoire\Bundle\PageBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Victoire\Bundle\PageBundle\Entity\BasePage;
use Victoire\Bundle\PageBundle\Entity\Page;
use Victoire\Bundle\PageBundle\Form\PageSettingsType;
use Victoire\Bundle\PageBundle\Form\PageType;

/**
 * Page Controller.
 *
 * @Route("/victoire-dcms/page")
 **/
class PageController extends BasePageController
{
    /**
     * Display a form to create a new Page.
     *
     * @param Request $request
     * @param bool    $isHomepage Is the page a homepage
     *
     * @Route("/new", name="victoire_core_page_new", defaults={"isHomepage" : false})
     * @Route("/homepage/new", name="victoire_core_homepage_new", defaults={"isHomepage" : true})
     * @Method("GET")
     * @Template()
     *
     * @return JsonResponse
     */
    public function newAction(Request $request, $isHomepage = false)
    {
        return new JsonResponse(parent::newAction($request, $isHomepage));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Create a new Page.
     *
     * @param Request $request
     *
     * @Route("/new", name="victoire_core_page_new_post")
     * @Route("/homepage/new", name="victoire_core_homepage_new")
     * @Method("POST")
     * @Template()
     *
     * @return JsonResponse
     */
    public function newPostAction(Request $request)
    {
        return new JsonResponse(parent::newPostAction($request));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Display a form to edit Page settings.
     *
     * @param Request  $request
     * @param BasePage $page
     *
     * @Route("/{id}/settings", name="victoire_core_page_settings")
     * @Method("GET")
     * @Template()
     * @ParamConverter("page", class="VictoirePageBundle:BasePage")
     *
     * @return JsonResponse The settings
     */
    public function settingsAction(Request $request, BasePage $page)
    {
        return new JsonResponse(parent::settingsAction($request, $page));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Save Page settings.
     *
     * @param Request  $request
     * @param BasePage $page
     *
     * @Route("/{id}/settings", name="victoire_core_page_settings_post")
     * @Method("POST")
     * @Template()
     * @ParamConverter("page", class="VictoirePageBundle:BasePage")
     *
     * @return JsonResponse The settings
     */
    public function settingsPostAction(Request $request, BasePage $page)
    {
        return new JsonResponse(parent::settingsPostAction($request, $page));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Page delete.
     *
     * @param BasePage $page
     *
     * @return JsonResponse
     * @Route("/{id}/delete", name="victoire_core_page_delete")
     * @Template()
     * @ParamConverter("page", class="VictoirePageBundle:BasePage")
     */
    public function deleteAction(BasePage $page)
    {
        return new JsonResponse(parent::deleteAction($page));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * getNewPageType.
     *
     * @return string
     */
    protected function getNewPageType()
    {
        return PageType::class;
    }

    /**
     * getPageSettingsType.
     *
     * @return string
     */
    protected function getPageSettingsType()
    {
        return PageSettingsType::class;
    }

    /**
     * getBusinessPageType.
     *
     * @return string
     */
    protected function getBusinessPageType()
    {
        return PageSettingsType::class;
    }

    /**
     * getNewPage.
     *
     * @return \Victoire\Bundle\PageBundle\Entity\Page
     */
    protected function getNewPage()
    {
        return new Page();
    }

    /**
     * getBaseTemplatePath.
     *
     * @return string
     */
    protected function getBaseTemplatePath()
    {
        return 'VictoirePageBundle:Page';
    }
}


1			<?php
2
3			namespace Victoire\Bundle\PageBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
8			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
9			use Symfony\Component\HttpFoundation\JsonResponse;
10			use Symfony\Component\HttpFoundation\Request;
11			use Victoire\Bundle\PageBundle\Entity\BasePage;
12			use Victoire\Bundle\PageBundle\Entity\Page;
13			use Victoire\Bundle\PageBundle\Form\PageSettingsType;
14			use Victoire\Bundle\PageBundle\Form\PageType;
15
16			/**
17			* Page Controller.
18			*
19			* @Route("/victoire-dcms/page")
20			**/
21			class PageController extends BasePageController
22			{
23			/**
24			* Display a form to create a new Page.
25			*
26			* @param Request $request
27			* @param bool $isHomepage Is the page a homepage
28			*
29			* @Route("/new", name="victoire_core_page_new", defaults={"isHomepage" : false})
30			* @Route("/homepage/new", name="victoire_core_homepage_new", defaults={"isHomepage" : true})
31			* @Method("GET")
32			* @Template()
33			*
34			* @return JsonResponse
35			*/
36			public function newAction(Request $request, $isHomepage = false)
37			{
38			return new JsonResponse(parent::newAction($request, $isHomepage));
			0 ignored issues – show Bug Best Practice introduced 2016-05-27 15:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \Symfony\Comp...request, $isHomepage));` (`Symfony\Component\HttpFoundation\JsonResponse`) is incompatible with the return type of the parent method `Victoire\Bundle\PageBund...geController::newAction` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
39			}
40
41			/**
42			* Create a new Page.
43			*
44			* @param Request $request
45			*
46			* @Route("/new", name="victoire_core_page_new_post")
47			* @Route("/homepage/new", name="victoire_core_homepage_new")
48			* @Method("POST")
49			* @Template()
50			*
51			* @return JsonResponse
52			*/
53			public function newPostAction(Request $request)
54			{
55			return new JsonResponse(parent::newPostAction($request));
			0 ignored issues – show Bug Best Practice introduced 2017-03-08 09:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \Symfony\Comp...wPostAction($request));` (`Symfony\Component\HttpFoundation\JsonResponse`) is incompatible with the return type of the parent method `Victoire\Bundle\PageBund...ntroller::newPostAction` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
56			}
57
58			/**
59			* Display a form to edit Page settings.
60			*
61			* @param Request $request
62			* @param BasePage $page
63			*
64			* @Route("/{id}/settings", name="victoire_core_page_settings")
65			* @Method("GET")
66			* @Template()
67			* @ParamConverter("page", class="VictoirePageBundle:BasePage")
68			*
69			* @return JsonResponse The settings
70			*/
71			public function settingsAction(Request $request, BasePage $page)
72			{
73			return new JsonResponse(parent::settingsAction($request, $page));
			0 ignored issues – show Bug Best Practice introduced 2016-04-01 08:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \Symfony\Comp...tion($request, $page));` (`Symfony\Component\HttpFoundation\JsonResponse`) is incompatible with the return type of the parent method `Victoire\Bundle\PageBund...troller::settingsAction` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
74			}
75
76			/**
77			* Save Page settings.
78			*
79			* @param Request $request
80			* @param BasePage $page
81			*
82			* @Route("/{id}/settings", name="victoire_core_page_settings_post")
83			* @Method("POST")
84			* @Template()
85			* @ParamConverter("page", class="VictoirePageBundle:BasePage")
86			*
87			* @return JsonResponse The settings
88			*/
89			public function settingsPostAction(Request $request, BasePage $page)
90			{
91			return new JsonResponse(parent::settingsPostAction($request, $page));
			0 ignored issues – show Bug Best Practice introduced 2017-03-08 09:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \Symfony\Comp...tion($request, $page));` (`Symfony\Component\HttpFoundation\JsonResponse`) is incompatible with the return type of the parent method `Victoire\Bundle\PageBund...ler::settingsPostAction` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
92			}
93
94			/**
95			* Page delete.
96			*
97			* @param BasePage $page
98			*
99			* @return JsonResponse
100			* @Route("/{id}/delete", name="victoire_core_page_delete")
101			* @Template()
102			* @ParamConverter("page", class="VictoirePageBundle:BasePage")
103			*/
104			public function deleteAction(BasePage $page)
105			{
106			return new JsonResponse(parent::deleteAction($page));
			0 ignored issues – show Bug Best Practice introduced 2016-04-01 08:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \Symfony\Comp...::deleteAction($page));` (`Symfony\Component\HttpFoundation\JsonResponse`) is incompatible with the return type of the parent method `Victoire\Bundle\PageBund...ontroller::deleteAction` of type `array<string,boolean\|string>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
107			}
108
109			/**
110			* getNewPageType.
111			*
112			* @return string
113			*/
114			protected function getNewPageType()
115			{
116			return PageType::class;
117			}
118
119			/**
120			* getPageSettingsType.
121			*
122			* @return string
123			*/
124			protected function getPageSettingsType()
125			{
126			return PageSettingsType::class;
127			}
128
129			/**
130			* getBusinessPageType.
131			*
132			* @return string
133			*/
134			protected function getBusinessPageType()
135			{
136			return PageSettingsType::class;
137			}
138
139			/**
140			* getNewPage.
141			*
142			* @return \Victoire\Bundle\PageBundle\Entity\Page
143			*/
144			protected function getNewPage()
145			{
146			return new Page();
147			}
148
149			/**
150			* getBaseTemplatePath.
151			*
152			* @return string
153			*/
154			protected function getBaseTemplatePath()
155			{
156			return 'VictoirePageBundle:Page';
157			}
158			}
159

Victoire / victoire

Issues (1704)

Security Analysis not enabled

Bundle/PageBundle/Controller/PageController.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like