Issues in ORMBusinessEntityResolver.php (master) - Issues in master - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1704)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Resolver/ORMBusinessEntityResolver.php (7 issues)

Labels

Bug 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Victoire\Bundle\ORMBusinessEntityBundle\Resolver;

use Doctrine\ORM\EntityManager;
use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessProperty;
use Victoire\Bundle\BusinessEntityBundle\Resolver\BusinessEntityResolverInterface;
use Victoire\Bundle\CoreBundle\Entity\EntityProxy;
use Victoire\Bundle\ORMBusinessEntityBundle\Entity\ORMBusinessEntity;

/**
 * Class ORMBusinessEntityResolver.
 */
class ORMBusinessEntityResolver implements BusinessEntityResolverInterface
{
    protected $entityManager;

    public function __construct(EntityManager $entityManager)
function someFunction(ManagerRegistry $registry) {
    $em = $registry->getManager();
    $em->getConnection()->beginTransaction();
    try {
        // Do something.
        $em->getConnection()->commit();
    } catch (\Exception $ex) {
        $em->getConnection()->rollback();
        $em->close();

        throw $ex;
    }
}
    {
        $this->entityManager = $entityManager;
    }

    public function getBusinessEntity(EntityProxy $entityProxy)

    {
        return $this->entityManager->getRepository($entityProxy->getBusinessEntity()->getClass())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ->findOneById($entityProxy->getRessourceId());
    }

    public function getBusinessEntities(ORMBusinessEntity $businessEntity)

    {
        return $this->entityManager->getRepository($businessEntity->getClass())
            ->findAll();
    }

    /**

     * filter repo to get a list of entities.
     *
     * @param ORMBusinessEntity $businessEntity
     * @param array             $filter

     *
     * @return mixed
     */
    public function searchBusinessEntities(ORMBusinessEntity $businessEntity, BusinessProperty $businessProperty, $filter)
    {
        $alias = $businessEntity->getName();

        return $this->entityManager->getRepository($businessEntity->getClass())
            ->createQueryBuilder($alias)
            ->where($alias.'.'.$businessProperty->getName().'LIKE %:filter%')
            ->setParameter(':filter', $filter)
            ->getQuery()
            ->getResult();
    }
}


1			<?php
2
3			namespace Victoire\Bundle\ORMBusinessEntityBundle\Resolver;
4
5			use Doctrine\ORM\EntityManager;
6			use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessProperty;
7			use Victoire\Bundle\BusinessEntityBundle\Resolver\BusinessEntityResolverInterface;
8			use Victoire\Bundle\CoreBundle\Entity\EntityProxy;
9			use Victoire\Bundle\ORMBusinessEntityBundle\Entity\ORMBusinessEntity;
10
11			/**
12			* Class ORMBusinessEntityResolver.
13			*/
14			class ORMBusinessEntityResolver implements BusinessEntityResolverInterface
15			{
16			protected $entityManager;
17
18			public function __construct(EntityManager $entityManager)
			0 ignored issues – show Bug introduced 2017-03-08 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this You have injected the EntityManager via parameter `$entityManager`. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via `getManager()` each time you need it. The `EntityManager` might become unusable for example if a transaction is rolled back and it gets closed. Let’s assume that somewhere in your application, or in a third-party library, there is code such as the following: function someFunction(ManagerRegistry $registry) { $em = $registry->getManager(); $em->getConnection()->beginTransaction(); try { // Do something. $em->getConnection()->commit(); } catch (\Exception $ex) { $em->getConnection()->rollback(); $em->close(); throw $ex; } } If that code throws an exception and the `EntityManager` is closed. Any other code which depends on the same instance of the `EntityManager` during this request will fail. On the other hand, if you instead inject the `ManagerRegistry`, the `getManager()` method guarantees that you will always get a usable manager instance. Loading history... introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing function doc comment Loading history...
19			{
20			$this->entityManager = $entityManager;
21			}
22
23			public function getBusinessEntity(EntityProxy $entityProxy)
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing function doc comment Loading history...
24			{
25			return $this->entityManager->getRepository($entityProxy->getBusinessEntity()->getClass())
			0 ignored issues – show Bug introduced 2017-03-08 18:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a specific sub-type and not the parent class `Victoire\Bundle\Business...e\Entity\BusinessEntity` as the method `getClass()` does only exist in the following sub-classes of `Victoire\Bundle\Business...e\Entity\BusinessEntity`: `Victoire\Bundle\ORMBusin...ntity\ORMBusinessEntity`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
26			->findOneById($entityProxy->getRessourceId());
27			}
28
29			public function getBusinessEntities(ORMBusinessEntity $businessEntity)
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Missing function doc comment Loading history...
30			{
31			return $this->entityManager->getRepository($businessEntity->getClass())
32			->findAll();
33			}
34
35			/**
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Doc comment for parameter "$businessProperty" missing Loading history...
36			* filter repo to get a list of entities.
37			*
38			* @param ORMBusinessEntity $businessEntity
39			* @param array $filter
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Doc comment for parameter $filter does not match actual variable name $businessProperty Loading history...
40			*
41			* @return mixed
42			*/
43			public function searchBusinessEntities(ORMBusinessEntity $businessEntity, BusinessProperty $businessProperty, $filter)
44			{
45			$alias = $businessEntity->getName();
46
47			return $this->entityManager->getRepository($businessEntity->getClass())
48			->createQueryBuilder($alias)
49			->where($alias.'.'.$businessProperty->getName().'LIKE %:filter%')
50			->setParameter(':filter', $filter)
51			->getQuery()
52			->getResult();
53			}
54			}
55

Victoire / victoire

Issues (1704)

Security Analysis not enabled

Resolver/ORMBusinessEntityResolver.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like