Issues in BlogController.php (master) - Issues in master - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1704)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Bundle/BlogBundle/Controller/BlogController.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Victoire\Bundle\BlogBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Victoire\Bundle\BlogBundle\Entity\Blog;
use Victoire\Bundle\BlogBundle\Form\BlogCategoryType;
use Victoire\Bundle\BlogBundle\Form\BlogSettingsType;
use Victoire\Bundle\BlogBundle\Form\BlogType;
use Victoire\Bundle\BlogBundle\Form\ChooseBlogType;
use Victoire\Bundle\BlogBundle\Repository\BlogRepository;
use Victoire\Bundle\PageBundle\Controller\BasePageController;
use Victoire\Bundle\PageBundle\Entity\BasePage;

/**
 * Blog Controller.
 *
 * @Route("/victoire-dcms/blog")
 */
class BlogController extends BasePageController
{
    /**

     * List all Blogs.
     *
     * @Route("/index/{blogId}/{tab}", name="victoire_blog_index", defaults={"blogId" = null, "tab" = "articles"})
     *
     * @param Request $request
     *
     * @return JsonResponse
     */
    public function indexAction(Request $request, $blogId = null, $tab = 'articles')
    {
        $blog = $this->getBlog($request, $blogId);
        $template = $this->getBaseTemplatePath().':index.html.twig';
        $chooseBlogForm = $this->createForm(ChooseBlogType::class, null, [
            'blog'   => $blog,
            'locale' => $request->getLocale(),
        ]);

        $chooseBlogForm->handleRequest($request);
        if ($chooseBlogForm->isValid()) {
            $template = $this->getBaseTemplatePath().':_blogItem.html.twig';
        }

        return new JsonResponse(
            [
                'html' => $this->container->get('templating')->render(
                    $template,
                    [
                        'blog'               => $blog,
                        'currentTab'         => $tab,
                        'tabs'               => ['articles', 'settings', 'category'],
                        'chooseBlogForm'     => $chooseBlogForm->createView(),
                        'businessProperties' => $blog ? $this->getBusinessProperties($blog) : null,
                    ]
                ),
            ]
        );
    }

    /**

     * Display Blogs RSS feed.
     *
     * @Route("/feed/{id}.rss", name="victoire_blog_rss", defaults={"_format" = "rss"})
     *
     * @param Request $request
     * @Template("VictoireBlogBundle:Blog:feed.rss.twig")
     *
     * @return array
     */
    public function feedAction(Request $request, Blog $blog)

    {
        return [
            'blog' => $blog,
        ];
    }

    /**

     * Display a form to create a new Blog.
     *
     * @Route("/new", name="victoire_blog_new")
     * @Method("GET")
     * @Template()
     *
     * @return JsonResponse
     */
    public function newAction(Request $request, $isHomepage = false)
    {
        return new JsonResponse(parent::newAction($request));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**

     * Create a new Blog.
     *
     * @Route("/new", name="victoire_blog_new_post")
     * @Method("POST")
     * @Template()
     *
     * @return JsonResponse
     */
    public function newPostAction(Request $request)
    {
        return new JsonResponse(parent::newPostAction($request));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Display a form to edit Blog settings.
     *
     * @param Request  $request
     * @param BasePage $blog
     *
     * @Route("/{id}/settings", name="victoire_blog_settings")
     * @Method("GET")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     *
     * @return JsonResponse
     */
    public function settingsAction(Request $request, BasePage $blog)
    {
        $form = $this->createForm($this->getPageSettingsType(), $blog);

        $form->handleRequest($request);

        return new Response($this->container->get('templating')->render(
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            $this->getBaseTemplatePath().':Tabs/_settings.html.twig',
            [
                'blog'               => $blog,
                'form'               => $form->createView(),
                'businessProperties' => [],
            ]
        ));
    }

    /**
     * Save Blog settings.
     *
     * @Route("/{id}/settings", name="victoire_blog_settings_post")
     * @Method("POST")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     *
     * @return JsonResponse
     */
    protected function settingsPostAction(Request $request, BasePage $blog)
    {
        $entityManager = $this->getDoctrine()->getManager();
        $form = $this->createForm($this->getPageSettingsType(), $blog);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $entityManager->persist($blog);
            $entityManager->flush();

            return new JsonResponse($this->getViewReferenceRedirect($request, $blog));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        return new JsonResponse([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'success' => false,
            'message' => $this->get('victoire_form.error_helper')->getRecursiveReadableErrors($form),
            'html'    => $this->container->get('templating')->render(
                $this->getBaseTemplatePath().':Tabs/_settings.html.twig',
                [
                    'blog'               => $blog,
                    'form'               => $form->createView(),
                    'businessProperties' => [],
                ]
            ),
        ]);
    }

    /**
     * List Blog Categories.
     *
     * @param Request  $request
     * @param BasePage $blog
     *
     * @Route("/{id}/category", name="victoire_blog_category")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     *
     * @return Response
     */
    public function categoryAction(Request $request, BasePage $blog)

    {
        $entityManager = $this->getDoctrine()->getManager();
        $form = $this->createForm($this->getPageCategoryType(), $blog);
        $businessProperties = $this->getBusinessProperties($blog);

        $form->handleRequest($request);

        if ($form->isValid()) {
            $entityManager->persist($blog);
            $entityManager->flush();

            return new JsonResponse([
                'success' => true,
                'url'     => $this->generateUrl('victoire_core_page_show', ['_locale' => $blog->getCurrentLocale(), 'url' => $blog->getUrl()]), ]);

        }
        //we display the form
        $errors = $this->get('victoire_form.error_helper')->getRecursiveReadableErrors($form);
        if ($errors != '') {
            return new JsonResponse(['html' => $this->container->get('templating')->render(
                        $this->getBaseTemplatePath().':Tabs/_category.html.twig',
                            [
                                'blog'               => $blog,
                                'form'               => $form->createView(),
                                'businessProperties' => $businessProperties,
                            ]
                        ),
                        'message' => $errors,
                    ]
                );

        }

        return new Response($this->container->get('templating')->render(
                    $this->getBaseTemplatePath().':Tabs/_category.html.twig',
                    [
                        'blog'               => $blog,
                        'form'               => $form->createView(),
                        'businessProperties' => $businessProperties,
                    ]
                )
        );
    }

    /**
     * List Blog articles.
     *
     * @param Request  $request
     * @param BasePage $blog
     *
     * @Route("/{id}/articles", name="victoire_blog_articles")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     *
     * @return Response
     */
    public function articlesAction(Request $request, BasePage $blog)

    {
        return new Response($this->container->get('templating')->render(
            $this->getBaseTemplatePath().':Tabs/_articles.html.twig',
            [
                'blog' => $blog,
            ]
        ));
    }

    /**
     * Delete a Blog.
     *
     * @param BasePage $blog
     *
     * @Route("/{id}/delete", name="victoire_blog_delete")
     * @Template()
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     *
     * @return JsonResponse
     */
    public function deleteAction(BasePage $blog)
    {
        if (!$this->get('security.authorization_checker')->isGranted('ROLE_VICTOIRE', $blog)) {
            throw new AccessDeniedException("Nop ! you can't do such an action");
        }

        foreach ($blog->getArticles() as $_article) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $bep = $this->get('victoire_page.page_helper')->findPageByParameters(
                [
                    'templateId' => $_article->getTemplate()->getId(),
                    'entityId'   => $_article->getId(),
                ]
            );
            $this->get('victoire_blog.manager.article')->delete($_article, $bep);
        }

        return new JsonResponse(parent::deleteAction($blog));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return string
     */
    protected function getPageSettingsType()
    {
        return BlogSettingsType::class;
    }

    /**
     * @return string
     */
    protected function getPageCategoryType()
    {
        return BlogCategoryType::class;
    }

    /**
     * @return string
     */
    protected function getNewPageType()
    {
        return BlogType::class;
    }

    /**
     * @return \Victoire\Bundle\BlogBundle\Entity\Blog
     */
    protected function getNewPage()
    {
        return new Blog();
    }

    /**
     * @return string
     */
    protected function getBaseTemplatePath()
    {
        return 'VictoireBlogBundle:Blog';
    }

    /**
     * Get Blog from id if defined.
     * If not return the first Blog.
     *
     * @param Request $request
     * @param $blogId
     *
     * @return Blog|false
     */
    protected function getBlog(Request $request, $blogId)
    {
        /** @var BlogRepository $blogRepo */
        $blogRepo = $this->get('doctrine.orm.entity_manager')->getRepository('VictoireBlogBundle:Blog');

        if ($blogId) {
            $blog = $blogRepo->find($blogId);
        } else {
            $blogs = $blogRepo->joinTranslations($request->getLocale())->run();
            $blog = reset($blogs);
        }

        return $blog;
    }
}


Issues (1704)

Security Analysis not enabled

Bundle/BlogBundle/Controller/BlogController.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			namespace Victoire\Bundle\BlogBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
8			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
9			use Symfony\Component\HttpFoundation\JsonResponse;
10			use Symfony\Component\HttpFoundation\Request;
11			use Symfony\Component\HttpFoundation\Response;
12			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
13			use Victoire\Bundle\BlogBundle\Entity\Blog;
14			use Victoire\Bundle\BlogBundle\Form\BlogCategoryType;
15			use Victoire\Bundle\BlogBundle\Form\BlogSettingsType;
16			use Victoire\Bundle\BlogBundle\Form\BlogType;
17			use Victoire\Bundle\BlogBundle\Form\ChooseBlogType;
18			use Victoire\Bundle\BlogBundle\Repository\BlogRepository;
19			use Victoire\Bundle\PageBundle\Controller\BasePageController;
20			use Victoire\Bundle\PageBundle\Entity\BasePage;
21
22			/**
23			* Blog Controller.
24			*
25			* @Route("/victoire-dcms/blog")
26			*/
27			class BlogController extends BasePageController
28			{
29			/**
			0 ignored issues – show introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Doc comment for parameter "$blogId" missing Loading history... introduced 2017-03-21 09:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this Doc comment for parameter "$tab" missing Loading history...
30			* List all Blogs.
31			*
32			* @Route("/index/{blogId}/{tab}", name="victoire_blog_index", defaults={"blogId" = null, "tab" = "articles"})
33			*
34			* @param Request $request
35			*
36			* @return JsonResponse
37			*/
38			public function indexAction(Request $request, $blogId = null, $tab = 'articles')
39			{

Victoire / victoire

Issues (1704)

Security Analysis not enabled

Bundle/BlogBundle/Controller/BlogController.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like