BlogController::__construct() - Code Metrics - Inspection of "Upgrade/2.8 deprecations" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#343)

by Leny

created 2016-02-24 13:03 UTC

BlogController::__construct() A

↳ Parent: BlogController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php

namespace Victoire\Bundle\BlogBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Victoire\Bundle\BlogBundle\Entity\Blog;
use Victoire\Bundle\BlogBundle\Form\BlogCategoryType;
use Victoire\Bundle\BlogBundle\Form\BlogSettingsType;
use Victoire\Bundle\BlogBundle\Form\BlogType;
use Victoire\Bundle\BlogBundle\Form\ChooseBlogType;
use Victoire\Bundle\BlogBundle\Repository\BlogRepository;
use Victoire\Bundle\BusinessPageBundle\Entity\BusinessTemplate;
use Victoire\Bundle\PageBundle\Controller\BasePageController;
use Victoire\Bundle\PageBundle\Entity\BasePage;
use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;

/**
 * blog Controller.
 *
 * @Route("/victoire-dcms/blog")
 */
class BlogController extends BasePageController
{
    protected $routes;

    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->routes = [
            'new'       => 'victoire_blog_new',
            'show'      => 'victoire_core_page_show',
            'settings'  => 'victoire_blog_settings',
            'articles'  => 'victoire_blog_articles',
            'category'  => 'victoire_blog_category',
            'delete'    => 'victoire_blog_delete',
        ];
    }

    /**
     * New page.
     *
     * @Route("/index/{blogId}/{tab}", name="victoire_blog_index", defaults={"blogId" = null, "tab" = "articles"})
     *
     * @param Request $request
     *
     * @return JsonResponse
     */
    public function indexAction(Request $request, $blogId = null, $tab = 'articles')
    {
        /** @var BlogRepository $blogRepo */
        $blogRepo = $this->get('doctrine.orm.entity_manager')->getRepository('VictoireBlogBundle:Blog');
        $blogs = $blogRepo->getAll()->run();
        $blog = reset($blogs);
        if (is_numeric($blogId)) {
            $blog = $blogRepo->find($blogId);
        }
        $options['blog'] = $blog;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $template = $this->getBaseTemplatePath().':index.html.twig';
        $chooseBlogForm = $this->createForm(ChooseBlogType::class, null, $options);

        $chooseBlogForm->handleRequest($request);
        if ($chooseBlogForm->isValid()) {
            $blog = $chooseBlogForm->getData()['blog'];
            $template = $this->getBaseTemplatePath().':_blogItem.html.twig';
            $chooseBlogForm = $this->createForm(ChooseBlogType::class, null, ['blog' => $blog]);
        }
        $businessProperties = [];

        if ($blog instanceof BusinessTemplate) {
            //we can use the business entity properties on the seo
            $businessEntity = $this->get('victoire_core.helper.business_entity_helper')->findById($blog->getBusinessEntityId());
            $businessProperties = $businessEntity->getBusinessPropertiesByType('seoable');
        }

        return new JsonResponse(
            [
                'html' => $this->container->get('victoire_templating')->render(
                    $template,
                    [
                        'blog'               => $blog,
                        'currentTab'         => $tab,
                        'tabs'               => ['articles', 'settings', 'category'],
                        'chooseBlogForm'     => $chooseBlogForm->createView(),
                        'businessProperties' => $businessProperties,
                    ]
                ),
            ]
        );
    }

    /**
     * New page.
     *
     * @Route("/feed/{slug}.rss", name="victoire_blog_rss", defaults={"_format" = "rss"})
     *
     * @param Request $request
     * @Template("VictoireBlogBundle:Blog:feed.rss.twig")
     * 
     * @return JsonResponse
     */
    public function feedAction(Request $request, Blog $blog)

    {
        return [
                'blog' => $blog,
            ];
    }

    /**
     * New page.
     *
     * @Route("/new", name="victoire_blog_new")
     * @Template()
     *
     * @return JsonResponse
     */
    public function newAction($isHomepage = false)
    {
        return new JsonResponse(parent::newAction());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Blog settings.
     *
     * @param Request  $request
     * @param BasePage $blog
     *
     * @return JsonResponse
     * @Route("/{id}/settings", name="victoire_blog_settings")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     */
    public function settingsAction(Request $request, BasePage $blog)
    {
        $entityManager = $this->getDoctrine()->getManager();
        $form = $this->createForm($this->getPageSettingsType(), $blog);
        $businessProperties = [];

        $form->handleRequest($request);

        if ($form->isValid()) {
            $entityManager->persist($blog);
            $entityManager->flush();

            /** @var ViewReference $reference */
            $reference = $this->get('victoire_view_reference.repository')
            ->getOneReferenceByParameters(['viewId' => $blog->getId()]);

            return new JsonResponse([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                'success' => true,
                'url'     => $this->generateUrl(
                    'victoire_core_page_show', [
                        '_locale' => $blog->getLocale(), 'url' => $reference->getUrl(),
                ]),
            ]);
        }
        //we display the form
        $errors = $this->get('victoire_form.error_helper')->getRecursiveReadableErrors($form);
        if ($errors != '') {
            return new JsonResponse(['html' => $this->container->get('victoire_templating')->render(
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                        $this->getBaseTemplatePath().':Tabs/_settings.html.twig',
                            [
                                'blog'               => $blog,
                                'form'               => $form->createView(),
                                'businessProperties' => $businessProperties,
                            ]
                        ),
                        'message' => $errors,
                    ]
                );
        }

        return new Response($this->container->get('victoire_templating')->render(
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                    $this->getBaseTemplatePath().':Tabs/_settings.html.twig',
                    [
                        'blog'               => $blog,
                        'form'               => $form->createView(),
                        'businessProperties' => $businessProperties,
                    ]
                )
        );
    }

    /**
     * Blog settings.
     *
     * @param Request  $request
     * @param BasePage $blog
     *
     * @return Response
     * @Route("/{id}/category", name="victoire_blog_category")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     */
    public function categoryAction(Request $request, BasePage $blog)
    {
        $entityManager = $this->getDoctrine()->getManager();
        $form = $this->createForm($this->getPageCategoryType(), $blog);
        $businessProperties = [];

        //if the page is a business entity page
        if ($blog instanceof BusinessTemplate) {
            //we can use the business entity properties on the seo
            $businessEntity = $this->get('victoire_core.helper.business_entity_helper')->findById($blog->getBusinessEntityId());
            $businessProperties = $businessEntity->getBusinessPropertiesByType('seoable');
        }

        $form->handleRequest($request);

        if ($form->isValid()) {
            $entityManager->persist($blog);
            $entityManager->flush();

            return new JsonResponse([
                'success' => true,
                'url'     => $this->generateUrl('victoire_core_page_show', ['_locale' => $blog->getLocale(), 'url' => $blog->getUrl()]), ]);
        }
        //we display the form
        $errors = $this->get('victoire_form.error_helper')->getRecursiveReadableErrors($form);
        if ($errors != '') {
            return new JsonResponse(['html' => $this->container->get('victoire_templating')->render(
                        $this->getBaseTemplatePath().':Tabs/_category.html.twig',
                            [
                                'blog'               => $blog,
                                'form'               => $form->createView(),
                                'businessProperties' => $businessProperties,
                            ]
                        ),
                        'message' => $errors,
                    ]
                );
        }

        return new Response($this->container->get('victoire_templating')->render(
                    $this->getBaseTemplatePath().':Tabs/_category.html.twig',
                    [
                        'blog'               => $blog,
                        'form'               => $form->createView(),
                        'businessProperties' => $businessProperties,
                    ]
                )
        );
    }

    /**
     * Blog settings.
     *
     * @param Request  $request
     * @param BasePage $blog
     *
     * @return Response
     * @Route("/{id}/articles", name="victoire_blog_articles")
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     */
    public function articlesAction(Request $request, BasePage $blog)

    {
        return new Response($this->container->get('victoire_templating')->render(
                    $this->getBaseTemplatePath().':Tabs/_articles.html.twig',
                    [
                        'blog' => $blog,
                    ]
                )
        );
    }

    /**
     * Page delete.
     *
     * @param Blog $blog
     *
     * @return JsonResponse
     * @Route("/{id}/delete", name="victoire_blog_delete")
     * @Template()
     * @ParamConverter("blog", class="VictoirePageBundle:BasePage")
     */
    public function deleteAction(BasePage $blog)
    {
        if (!$this->get('security.authorization_checker')->isGranted('ROLE_VICTOIRE', $blog)) {
            throw new AccessDeniedException("Nop ! you can't do such an action");
        }

        foreach ($blog->getArticles() as $_article) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $bep = $this->get('victoire_page.page_helper')->findPageByParameters(
                [
                    'templateId' => $_article->getTemplate()->getId(),
                    'entityId'   => $_article->getId(),
                ]
            );
            $this->get('victoire_blog.manager.article')->delete($_article, $bep);
        }

        return new JsonResponse(parent::deleteAction($blog));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return string
     */
    protected function getPageSettingsType()
    {
        return BlogSettingsType::class;
    }

    /**
     * @return string
     */
    protected function getPageCategoryType()
    {
        return BlogCategoryType::class;
    }

    /**
     * @return string
     */
    protected function getNewPageType()
    {
        return BlogType::class;
    }

    /**
     * @return \Victoire\Bundle\BlogBundle\Entity\Blog
     */
    protected function getNewPage()
    {
        return new Blog();
    }

    /**
     * @return string
     */
    protected function getBaseTemplatePath()
    {
        return 'VictoireBlogBundle:Blog';
    }

    /**
     * @param unknown $action
     */
    protected function getRoutes($action)
    {
        return $this->routes[$action];
    }
}


1			<?php
2
3			namespace Victoire\Bundle\BlogBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
8			use Symfony\Component\HttpFoundation\JsonResponse;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\HttpFoundation\Response;
11			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
12			use Victoire\Bundle\BlogBundle\Entity\Blog;
13			use Victoire\Bundle\BlogBundle\Form\BlogCategoryType;
14			use Victoire\Bundle\BlogBundle\Form\BlogSettingsType;
15			use Victoire\Bundle\BlogBundle\Form\BlogType;
16			use Victoire\Bundle\BlogBundle\Form\ChooseBlogType;
17			use Victoire\Bundle\BlogBundle\Repository\BlogRepository;
18			use Victoire\Bundle\BusinessPageBundle\Entity\BusinessTemplate;
19			use Victoire\Bundle\PageBundle\Controller\BasePageController;
20			use Victoire\Bundle\PageBundle\Entity\BasePage;
21			use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;
22
23			/**
24			* blog Controller.
25			*
26			* @Route("/victoire-dcms/blog")
27			*/
28			class BlogController extends BasePageController
29			{
30			protected $routes;
31
32			/**
33			* Constructor.
34			*/
35			public function __construct()
36			{
37			$this->routes = [
38			'new' => 'victoire_blog_new',
39			'show' => 'victoire_core_page_show',
40			'settings' => 'victoire_blog_settings',

Victoire / victoire

Pull Request — master (#343)

BlogController::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like