Victoire\Bundle\WidgetBundle\Cache\WidgetCache

Complexity

Total Complexity

9

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	3
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	fetch()	0	4	1
A	save()	0	8	2
B	getHash()	0	18	5

<?php

namespace Victoire\Bundle\WidgetBundle\Cache;

use Predis\Client;
use Victoire\Bundle\WidgetBundle\Entity\Widget;

/**
 * This class handle the saving of Widgets.
 * Widgets are stored for a week, but are invalidated as soon as
 * the Widget's or BusinessEntity's updatedAt field is changed.
 */
class WidgetCache
{
    /**
     * @var Client
     */
    private $redis;

    public function __construct(Client $redis)
    {
        $this->redis = $redis;
    }

    /**
     * @param Widget $widget
     *
     * @return string
     */
    public function fetch(Widget $widget)
    {
        return $this->redis->get($this->getHash($widget));
    }

    /**
     * @param Widget $widget
     * @param        $content
     */
    public function save(Widget $widget, $content)
    {
        $hash = $this->getHash($widget);
        if ($hash) {

The expression $hash of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->redis->set($hash, $content);
            $this->redis->expire($hash, 7 * 24 * 60 * 1000); // cache for a week
        }
    }

    /**
     * @param Widget $widget
     *
     * @return string
     */
    protected function getHash(Widget $widget)
    {
        $hash = null;
        if ($widget->getMode() == Widget::MODE_BUSINESS_ENTITY
            && ($entity = $widget->getEntity())
            && method_exists($widget->getEntity(), 'getUpdatedAt')) {
            $hash = sprintf('%s-%s--%s-%s',
                $widget->getId(),
                $widget->getUpdatedAt()->getTimestamp(),
                $entity->getId(),

The method getId cannot be called on $entity (of type integer|double).

                $entity->getUpdatedAt()->getTimestamp()

The method getUpdatedAt cannot be called on $entity (of type integer|double).

            );
        } elseif ($widget->getMode() == Widget::MODE_STATIC) {
            $hash = sprintf('%s-%s', $widget->getId(), $widget->getUpdatedAt()->getTimestamp());
        }

        return $hash;
    }


}