Completed
Pull Request — 2.3 (#1133)
by Leny
39:02 queued 35:08
created
Bundle/MediaBundle/Helper/Menu/MenuItem.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
     /**
149 149
      * Set parent menu item.
150 150
      *
151
-     * @param MenuItem|null $parent
151
+     * @param null|\self $parent
152 152
      *
153 153
      * @return MenuItem
154 154
      */
Please login to merge, or discard this patch.
Bundle/MediaBundle/Twig/MenuTwigExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
     /**
28 28
      * Get Twig functions defined in this extension.
29 29
      *
30
-     * @return array
30
+     * @return \Twig_SimpleFunction[]
31 31
      */
32 32
     public function getFunctions()
33 33
     {
Please login to merge, or discard this patch.
Bundle/WidgetBundle/Builder/WidgetFormBuilder.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -128,9 +128,10 @@  discard block
 block discarded – undo
128 128
      *
129 129
      * @param string           $slot
130 130
      * @param View             $view
131
-     * @param Widget           $widget
131
+     * @param Widget           $widgets
132 132
      * @param BusinessEntity[] $classes
133 133
      * @param int              $position
134
+     * @param string $quantum
134 135
      *
135 136
      * @throws \Exception
136 137
      *
@@ -152,10 +153,9 @@  discard block
 block discarded – undo
152 153
     /**
153 154
      * Generates style forms for each quantum.
154 155
      *
155
-     * @param $viewReference
156
+     * @param string|null $viewReference
156 157
      * @param ArrayCollection|Widget[] $widgets
157 158
      * @param Widget                   $activeWidget
158
-     * @param null                     $quantum
159 159
      *
160 160
      * @return Form[]
161 161
      */
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
      *
313 313
      * @param Widget $widget
314 314
      * @param $viewReference
315
-     * @param $quantum
315
+     * @param string|null $quantum
316 316
      *
317 317
      * @throws \Throwable
318 318
      *
@@ -377,6 +377,7 @@  discard block
 block discarded – undo
377 377
      * @param string $namespace        the namespace
378 378
      * @param string $formMode         the form mode
379 379
      * @param int    $position
380
+     * @param string $slotId
380 381
      *
381 382
      * @throws \Exception
382 383
      *
Please login to merge, or discard this patch.
Bundle/WidgetBundle/Model/WidgetManager.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6 6
 use Doctrine\ORM\Mapping\ClassMetadataInfo;
7
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
8 7
 use Symfony\Bundle\FrameworkBundle\Templating\EngineInterface;
9 8
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
10 9
 use Symfony\Component\HttpFoundation\JsonResponse;
Please login to merge, or discard this patch.
Bundle/WidgetMapBundle/Entity/WidgetMap.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
     }
321 321
 
322 322
     /**
323
-     * @return WidgetMap[]
323
+     * @return Collection
324 324
      */
325 325
     public function getChildren()
326 326
     {
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
     }
353 353
 
354 354
     /**
355
-     * @return WidgetMap|null
355
+     * @return \self|null
356 356
      */
357 357
     public function getParent()
358 358
     {
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
     }
361 361
 
362 362
     /**
363
-     * @param null|WidgetMap $parent
363
+     * @param null|\self $parent
364 364
      */
365 365
     public function setParent(self $parent = null)
366 366
     {
Please login to merge, or discard this patch.
Bundle/WidgetMapBundle/Manager/WidgetMapManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -200,8 +200,8 @@
 block discarded – undo
200 200
      * @param View $view
201 201
      * @param $beforeChild
202 202
      * @param $afterChild
203
-     * @param $originalParent
204
-     * @param $originalPosition
203
+     * @param \self|null $originalParent
204
+     * @param string $originalPosition
205 205
      */
206 206
     public function moveChildren(View $view, $beforeChild, $afterChild, $originalParent, $originalPosition)
207 207
     {
Please login to merge, or discard this patch.
Tests/App/src/Acme/AppBundle/DataFixtures/Seeds/ORM/LoadFixtureData.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@
 block discarded – undo
141 141
             while ($file = readdir($openFolder)) {
142 142
                 if ($file != '.' && $file != '..') {
143 143
                     // Remove file
144
-                    $recursiveDelete = function ($str) use (&$recursiveDelete) {
144
+                    $recursiveDelete = function($str) use (&$recursiveDelete) {
145 145
                         if (is_file($str)) {
146 146
                             return @unlink($str);
147 147
                         } elseif (is_dir($str)) {
Please login to merge, or discard this patch.
Bundle/CoreBundle/Form/ViewType.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -53,18 +53,18 @@  discard block
 block discarded – undo
53 53
      */
54 54
     public function buildForm(FormBuilderInterface $builder, array $options)
55 55
     {
56
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
56
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event) {
57 57
             $view = $event->getData();
58 58
             $form = $event->getForm();
59 59
 
60 60
             $this->isNew = !$view || null === $view->getId();
61 61
 
62 62
             if ($this->isNew) {
63
-                $getAllTemplateWithoutMe = function (EntityRepository $tr) {
63
+                $getAllTemplateWithoutMe = function(EntityRepository $tr) {
64 64
                     return $tr->getAll()->getInstance();
65 65
                 };
66 66
             } else {
67
-                $getAllTemplateWithoutMe = function (EntityRepository $tr) use ($view) {
67
+                $getAllTemplateWithoutMe = function(EntityRepository $tr) use ($view) {
68 68
                     return $tr->getAll()
69 69
                         ->getInstance()
70 70
                         ->andWhere('template.id != :templateId')
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
             if (!$form->has('template')) {
75 75
                 $form->add('template', null, [
76 76
                     'label'        => 'form.view.type.template.label',
77
-                    'choice_label' => function ($view) {
77
+                    'choice_label' => function($view) {
78 78
                         return $view->getName();
79 79
                     },
80 80
                     'required'      => !$view instanceof Template || $view instanceof BusinessTemplate,
@@ -85,11 +85,11 @@  discard block
 block discarded – undo
85 85
             //If view is an Article BEP, we do not allow to choose parent because it will be set automatically
86 86
             if (!$view instanceof ArticleTemplate && ClassUtils::getClass($view) != 'Victoire\Bundle\TemplateBundle\Entity\Template') {
87 87
                 if (!$view || null === $view->getId()) {
88
-                    $getAllPageWithoutMe = function (EntityRepository $repo) {
88
+                    $getAllPageWithoutMe = function(EntityRepository $repo) {
89 89
                         return $repo->getAll()->getInstance();
90 90
                     };
91 91
                 } else {
92
-                    $getAllPageWithoutMe = function (EntityRepository $repo) use ($view) {
92
+                    $getAllPageWithoutMe = function(EntityRepository $repo) use ($view) {
93 93
                         return $repo->getAll()
94 94
                             ->getInstance()
95 95
                             ->andWhere('view.id != :pageId')
Please login to merge, or discard this patch.
Bundle/SitemapBundle/Domain/Export/SitemapExportHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         $ids = [$tree->getViewId()];
69 69
 
70
-        $getChildrenIds = function (ViewReference $tree) use (&$getChildrenIds, $ids) {
70
+        $getChildrenIds = function(ViewReference $tree) use (&$getChildrenIds, $ids) {
71 71
             foreach ($tree->getChildren() as $child) {
72 72
                 if (null !== $child->getViewId()) {
73 73
                     $ids[] = $child->getViewId();
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         $items = array_merge($pages, $this->getBusinessPages($tree));
95 95
         usort(
96 96
             $items,
97
-            function ($a, $b) {
97
+            function($a, $b) {
98 98
                 return strcmp($a->getUrl(), $b->getUrl());
99 99
             }
100 100
         );
Please login to merge, or discard this patch.