ParameterConverter::convertFromEntity() - Code Metrics - Inspection of "API mode" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#812)

by Paul

created 2017-03-13 11:19 UTC

ParameterConverter::convertFromEntity() A

↳ Parent: ParameterConverter

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	3

<?php

namespace Victoire\Bundle\BusinessEntityBundle\Converter;

use Symfony\Component\PropertyAccess\PropertyAccessor;
use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessProperty;

/**
 * Parameter Converter
 * ref: victoire_business_entity.converter.parameter_converter.
 */
class ParameterConverter
{
    /**
     * Replace the code string with the value of the entity attribute.
     *
     * @param string           $string
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param BusinessProperty $businessProperty
     * @param object           $entity
     *
     * @throws \Exception
     *
     * @return string The updated string
     */
    public function convertFromEntity($url, BusinessProperty $businessProperty, $entity)
    {
        //test parameters
        if ($entity === null) {
            throw new \Exception('The parameter entity can not be null');
        }
        //the attribute to set
        $entityProperty = $businessProperty->getName();

        //the value of the attribute
        $accessor = new PropertyAccessor();
        $attributeValue = $accessor->getValue($entity, $entityProperty);

        return $this->convert($url, 'item.'.$entityProperty, $attributeValue);
    }

    /**
     * Replace the code string with the value of the entity attribute.
     *
     * @param string $string
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $entityProperty
     * @param string $attributeValue
     *
     * @throws \Exception
     *
     * @return string The updated string
     */
    public function convert($url, $entityProperty, $attributeValue)
    {
        //the string to replace
        $stringToReplace = '{{'.$entityProperty.'}}';

        //we provide a default value
        if ($attributeValue === null) {
            $attributeValue = '';
        }

        //we replace the string
        return str_replace($stringToReplace, $attributeValue, $url);
    }
}


1			<?php
2
3			namespace Victoire\Bundle\BusinessEntityBundle\Converter;
4
5			use Symfony\Component\PropertyAccess\PropertyAccessor;
6			use Victoire\Bundle\BusinessEntityBundle\Entity\BusinessProperty;
7
8			/**
9			* Parameter Converter
10			* ref: victoire_business_entity.converter.parameter_converter.
11			*/
12			class ParameterConverter
13			{
14			/**
15			* Replace the code string with the value of the entity attribute.
16			*
17			* @param string $string
			0 ignored issues – show Bug introduced 2017-03-13 11:26 UTC by Report Bug Copy Issue Report There is no parameter named `$string`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
18			* @param BusinessProperty $businessProperty
19			* @param object $entity
20			*
21			* @throws \Exception
22			*
23			* @return string The updated string
24			*/
25			public function convertFromEntity($url, BusinessProperty $businessProperty, $entity)
26			{
27			//test parameters
28			if ($entity === null) {
29			throw new \Exception('The parameter entity can not be null');
30			}
31			//the attribute to set
32			$entityProperty = $businessProperty->getName();
33
34			//the value of the attribute
35			$accessor = new PropertyAccessor();
36			$attributeValue = $accessor->getValue($entity, $entityProperty);
37
38			return $this->convert($url, 'item.'.$entityProperty, $attributeValue);
39			}
40
41			/**
42			* Replace the code string with the value of the entity attribute.
43			*
44			* @param string $string
			0 ignored issues – show Bug introduced 2017-03-13 11:26 UTC by Report Bug Copy Issue Report There is no parameter named `$string`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
45			* @param string $entityProperty
46			* @param string $attributeValue
47			*
48			* @throws \Exception
49			*
50			* @return string The updated string
51			*/
52			public function convert($url, $entityProperty, $attributeValue)
53			{
54			//the string to replace
55			$stringToReplace = '{{'.$entityProperty.'}}';
56
57			//we provide a default value
58			if ($attributeValue === null) {
59			$attributeValue = '';
60			}
61
62			//we replace the string
63			return str_replace($stringToReplace, $attributeValue, $url);
64			}
65			}
66

Victoire / victoire

Pull Request — master (#812)

ParameterConverter::convertFromEntity() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like