SitemapController::xmlAction() - Code Metrics - Inspection of "Merge pull request #323 from lenybernard/master" - Victoire/victoire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cde4a2...ad2587 )

by Leny

created 2016-01-27 23:40 UTC

SitemapController::xmlAction() B

↳ Parent: SitemapController

Complexity

Conditions	5
Paths	1

Size

Total Lines	57
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	57
rs	8.7433
cc	5
eloc	35
nc	1
nop	1

How to fix Long Method

<?php

namespace Victoire\Bundle\SitemapBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
use Victoire\Bundle\PageBundle\Entity\BasePage;
use Victoire\Bundle\PageBundle\Helper\PageHelper;
use Victoire\Bundle\SeoBundle\Entity\PageSeo;
use Victoire\Bundle\ViewReferenceBundle\ViewReference\BusinessPageReference;
use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;

/**
 * Victoire sitemap controller.
 *
 * @Route("/sitemap")
 */
class SitemapController extends Controller
{
    /**
     * Get the whole list of published pages
     * #1 get the _locale related homepage
     * #2 parse recursively and extract every persisted pages ids
     * #3 load these pages with seo (if exists)
     * #4 parse recursively and extract every VirtualBusinessPages references
     * #5 prepare VirtualBusinessPages.
     *
     * @Route(".{_format}", name="victoire_sitemap_xml", Requirements={"_format" = "xml"})
     *
     * @return Response
     */
    public function xmlAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $homepage = $em->getRepository('VictoirePageBundle:BasePage')
            ->findOneByHomepage($request->getLocale());

        /** @var ViewReference $tree */
        $tree = $this->get('victoire_view_reference.repository')->getOneReferenceByParameters(
            ['viewId' => $homepage->getId()],
            true,
            true
        );

        $ids = [$tree->getViewId()];

        $getChildrenIds = function (ViewReference $tree) use (&$getChildrenIds, $ids) {
            foreach ($tree->getChildren() as $child) {
                $ids[] = $child->getViewId();
                $ids = array_merge($ids, $getChildrenIds($child));
$x = 1;
$callable = function() use ($x) {
    $x = 2; // Not visible in outer scope. If you would like this, how
            // about using a different variable name than $x?
};

$callable();
var_dump($x); // integer(1)
            }

            return $ids;
        };

        $pages = $em->getRepository('VictoirePageBundle:BasePage')
            ->getAll(true)
            ->joinSeo()
            ->filterByIds($getChildrenIds($tree))
            ->run();

        /** @var PageHelper $pageHelper */
        $pageHelper = $this->get('victoire_page.page_helper');
        $entityManager = $this->getDoctrine()->getManager();

        $getBusinessPages = function (ViewReference $tree) use (&$getBusinessPages, $pageHelper, $entityManager) {
            $businessPages = [];
            foreach ($tree->getChildren() as $child) {
                if ($child instanceof BusinessPageReference
                    && $child->getViewNamespace() == 'Victoire\Bundle\BusinessPageBundle\Entity\VirtualBusinessPage') {
                    $entity = $entityManager->getRepository($child->getEntityNamespace())->find($child->getEntityId());
                    /** @var WebViewInterface $businessPage */
                    $businessPage = $pageHelper->findPageByReference($child, $entity);
                    $businessPage->setReference($child);
                    $businessPages[] = $businessPage;
                }
                $businessPages = array_merge($businessPages, $getBusinessPages($child));
            }

            return $businessPages;
        };

        $pages = array_merge($pages, $getBusinessPages($tree));

        return $this->render('VictoireSitemapBundle:Sitemap:sitemap.xml.twig', [
            'pages' => $pages,
        ]);
    }

    /**
     * Show sitemap as tree and reorganize it by dnd.
     *
     * @Route("/reorganize", name="victoire_sitemap_reorganize", options={"expose"=true})
     * @Template()
     *
     * @return JsonResponse
     */
    public function reorganizeAction()
    {
        $em = $this->getDoctrine()->getManager();
        $pageRepo = $em->getRepository('VictoirePageBundle:BasePage');
        $response = [
            'success' => false,
        ];
        if ($this->get('request')->getMethod() === 'POST') {
            $sorted = $this->getRequest()->request->get('sorted');

            $depths = [];
            //reorder pages positions
            foreach ($sorted as $item) {
                $depths[$item['depth']][$item['item_id']] = 1;
                $page = $pageRepo->findOneById($item['item_id']);
                if ($page !== null) {
                    if ($item['parent_id'] !== '') {
                        $parent = $pageRepo->findOneById($item['parent_id']);
                        $page->setParent($parent);
                    } else {
                        $page->setParent(null);
                    }
                    $page->setPosition(count($depths[$item['depth']]));
                    $em->persist($page);
                }
            }
            $em->flush();

            $response = [
                'success' => true,
                'message' => $this->get('translator')->trans('sitemap.changed.success', [], 'victoire'),
            ];
        }

        $allPages = $em->getRepository('VictoirePageBundle:BasePage')->findAll();
        $forms = [];
        foreach ($allPages as $_page) {
            $forms[$_page->getId()] = $this->createSitemapPriorityType($_page)->createView();
        }

        $pages = $em->getRepository('VictoirePageBundle:BasePage')->findByParent(null, ['position' => 'ASC']);
        $response['html'] = $this->container->get('victoire_templating')->render(
            'VictoireSitemapBundle:Sitemap:reorganize.html.twig',
            [
                'pages' => $pages,
                'forms' => $forms,
            ]
        );

        return new JsonResponse($response);
    }

    /**
     * Change the sitemap priority for the given page.
     *
     * @Route("/changePriority/{id}", name="victoire_sitemap_changePriority", options={"expose"=true})
     *
     * @return JsonResponse
     */
    public function changePriorityAction(Request $request, BasePage $page)
    {
        $form = $this->createSitemapPriorityType($page);
        $form->handleRequest($request);
        $params = [
            'success' => $form->isValid(),
        ];
        if ($form->isValid()) {
            if (!$page->getSeo()) {
                $seo = new PageSeo();
                $page->setSeo($seo);
            }
            $this->get('doctrine.orm.entity_manager')->persist($page->getSeo());
            $this->get('doctrine.orm.entity_manager')->flush();

            // congratulate user, the action succeed
            $message = $this->get('translator')->trans(
                'sitemap.changedPriority.success',
                [
                    '%priority%' => $page->getSeo()->getSitemapPriority(),
                    '%pageName%' => $page->getName(),
                    ],
                'victoire'
            );
            $params['message'] = $message;
        }

        return new JsonResponse($params);
    }

    /**
     * Create a sitemap priority type.
     *
     * @return \Symfony\Component\Form\Form The form
     **/
    protected function createSitemapPriorityType(BasePage $page)
    {
        $form = $this->createForm(
            'victoire_sitemap_priority_pageseo_type',
            $page->getSeo(),
            [
                'action'     => $this->generateUrl('victoire_sitemap_changePriority', [
                        'id' => $page->getId(),
                    ]
                ),
                'method' => 'PUT',
                'attr'   => [
                    'class'       => 'sitemapPriorityForm form-inline',
                    'data-pageId' => $page->getId(),
                    'id'          => 'sitemap-priority-type-'.$page->getId(),
                    'style'       => 'display: inline;',
                ],
            ]
        );

        return $form;
    }
}


Push — master ( cde4a2...ad2587 )

SitemapController::xmlAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Change not visible in outer-scope

Change visible in outer-scope

1			<?php
2
3			namespace Victoire\Bundle\SitemapBundle\Controller;
4
5			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
6			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
7			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8			use Symfony\Component\HttpFoundation\JsonResponse;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\HttpFoundation\Response;
11			use Victoire\Bundle\CoreBundle\Entity\WebViewInterface;
12			use Victoire\Bundle\PageBundle\Entity\BasePage;
13			use Victoire\Bundle\PageBundle\Helper\PageHelper;
14			use Victoire\Bundle\SeoBundle\Entity\PageSeo;
15			use Victoire\Bundle\ViewReferenceBundle\ViewReference\BusinessPageReference;
16			use Victoire\Bundle\ViewReferenceBundle\ViewReference\ViewReference;
17
18			/**
19			* Victoire sitemap controller.
20			*
21			* @Route("/sitemap")
22			*/
23			class SitemapController extends Controller
24			{
25			/**
26			* Get the whole list of published pages
27			* #1 get the _locale related homepage
28			* #2 parse recursively and extract every persisted pages ids
29			* #3 load these pages with seo (if exists)
30			* #4 parse recursively and extract every VirtualBusinessPages references
31			* #5 prepare VirtualBusinessPages.
32			*
33			* @Route(".{_format}", name="victoire_sitemap_xml", Requirements={"_format" = "xml"})
34			*
35			* @return Response
36			*/
37			public function xmlAction(Request $request)
38			{
39			$em = $this->getDoctrine()->getManager();
40			$homepage = $em->getRepository('VictoirePageBundle:BasePage')
41			->findOneByHomepage($request->getLocale());
42
43			/** @var ViewReference $tree */
44			$tree = $this->get('victoire_view_reference.repository')->getOneReferenceByParameters(
45			['viewId' => $homepage->getId()],
46			true,
47			true
48			);
49
50			$ids = [$tree->getViewId()];
51
52			$getChildrenIds = function (ViewReference $tree) use (&$getChildrenIds, $ids) {
53			foreach ($tree->getChildren() as $child) {
54			$ids[] = $child->getViewId();
55			$ids = array_merge($ids, $getChildrenIds($child));
			0 ignored issues – show Bug introduced 2016-01-27 22:55 UTC by Report Bug Copy Issue Report Consider using a different name than the imported variable `$ids`, or did you forget to import by reference? It seems like you are assigning to a variable which was imported through a `use` statement which was not imported by reference. For clarity, we suggest to use a different name or import by reference depending on whether you would like to have the change visibile in outer-scope. Change not visible in outer-scope $x = 1; $callable = function() use ($x) { $x = 2; // Not visible in outer scope. If you would like this, how // about using a different variable name than $x? }; $callable(); var_dump($x); // integer(1) Change visible in outer-scope $x = 1; $callable = function() use (&$x) { $x = 2; }; $callable(); var_dump($x); // integer(2) Loading history...
56			}
57
58			return $ids;
59			};
60
61			$pages = $em->getRepository('VictoirePageBundle:BasePage')
62			->getAll(true)
63			->joinSeo()
64			->filterByIds($getChildrenIds($tree))
65			->run();
66
67			/** @var PageHelper $pageHelper */
68			$pageHelper = $this->get('victoire_page.page_helper');
69			$entityManager = $this->getDoctrine()->getManager();
70
71			$getBusinessPages = function (ViewReference $tree) use (&$getBusinessPages, $pageHelper, $entityManager) {
72			$businessPages = [];
73			foreach ($tree->getChildren() as $child) {
74			if ($child instanceof BusinessPageReference
75			&& $child->getViewNamespace() == 'Victoire\Bundle\BusinessPageBundle\Entity\VirtualBusinessPage') {
76			$entity = $entityManager->getRepository($child->getEntityNamespace())->find($child->getEntityId());
77			/** @var WebViewInterface $businessPage */
78			$businessPage = $pageHelper->findPageByReference($child, $entity);
79			$businessPage->setReference($child);
80			$businessPages[] = $businessPage;
81			}
82			$businessPages = array_merge($businessPages, $getBusinessPages($child));
83			}
84
85			return $businessPages;
86			};
87
88			$pages = array_merge($pages, $getBusinessPages($tree));
89
90			return $this->render('VictoireSitemapBundle:Sitemap:sitemap.xml.twig', [
91			'pages' => $pages,
92			]);
93			}
94
95			/**
96			* Show sitemap as tree and reorganize it by dnd.
97			*
98			* @Route("/reorganize", name="victoire_sitemap_reorganize", options={"expose"=true})
99			* @Template()
100			*
101			* @return JsonResponse
102			*/
103			public function reorganizeAction()
104			{
105			$em = $this->getDoctrine()->getManager();
106			$pageRepo = $em->getRepository('VictoirePageBundle:BasePage');
107			$response = [
108			'success' => false,
109			];
110			if ($this->get('request')->getMethod() === 'POST') {
111			$sorted = $this->getRequest()->request->get('sorted');
			0 ignored issues – show Deprecated Code introduced 2015-11-24 15:51 UTC by Report Bug Copy Issue Report The method `Symfony\Bundle\Framework...ontroller::getRequest()` has been deprecated with message: since version 2.4, to be removed in 3.0. Ask Symfony to inject the Request object into your controller method instead by type hinting it in the method's signature. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
112			$depths = [];
113			//reorder pages positions
114			foreach ($sorted as $item) {
115			$depths[$item['depth']][$item['item_id']] = 1;
116			$page = $pageRepo->findOneById($item['item_id']);
117			if ($page !== null) {
118			if ($item['parent_id'] !== '') {
119			$parent = $pageRepo->findOneById($item['parent_id']);
120			$page->setParent($parent);
121			} else {
122			$page->setParent(null);
123			}
124			$page->setPosition(count($depths[$item['depth']]));
125			$em->persist($page);
126			}
127			}
128			$em->flush();
129
130			$response = [
131			'success' => true,
132			'message' => $this->get('translator')->trans('sitemap.changed.success', [], 'victoire'),
133			];
134			}
135
136			$allPages = $em->getRepository('VictoirePageBundle:BasePage')->findAll();
137			$forms = [];
138			foreach ($allPages as $_page) {
139			$forms[$_page->getId()] = $this->createSitemapPriorityType($_page)->createView();
140			}
141
142			$pages = $em->getRepository('VictoirePageBundle:BasePage')->findByParent(null, ['position' => 'ASC']);
143			$response['html'] = $this->container->get('victoire_templating')->render(
144			'VictoireSitemapBundle:Sitemap:reorganize.html.twig',
145			[
146			'pages' => $pages,
147			'forms' => $forms,
148			]
149			);
150
151			return new JsonResponse($response);
152			}
153
154			/**
155			* Change the sitemap priority for the given page.
156			*
157			* @Route("/changePriority/{id}", name="victoire_sitemap_changePriority", options={"expose"=true})
158			*
159			* @return JsonResponse
160			*/
161			public function changePriorityAction(Request $request, BasePage $page)
162			{
163			$form = $this->createSitemapPriorityType($page);
164			$form->handleRequest($request);
165			$params = [
166			'success' => $form->isValid(),
167			];
168			if ($form->isValid()) {
169			if (!$page->getSeo()) {
170			$seo = new PageSeo();
171			$page->setSeo($seo);
172			}
173			$this->get('doctrine.orm.entity_manager')->persist($page->getSeo());
174			$this->get('doctrine.orm.entity_manager')->flush();
175
176			// congratulate user, the action succeed
177			$message = $this->get('translator')->trans(
178			'sitemap.changedPriority.success',
179			[
180			'%priority%' => $page->getSeo()->getSitemapPriority(),
181			'%pageName%' => $page->getName(),
182			],
183			'victoire'
184			);
185			$params['message'] = $message;
186			}
187
188			return new JsonResponse($params);
189			}
190
191			/**
192			* Create a sitemap priority type.
193			*
194			* @return \Symfony\Component\Form\Form The form
195			**/
196			protected function createSitemapPriorityType(BasePage $page)
197			{
198			$form = $this->createForm(
199			'victoire_sitemap_priority_pageseo_type',
200			$page->getSeo(),
201			[
202			'action' => $this->generateUrl('victoire_sitemap_changePriority', [
203			'id' => $page->getId(),
204			]
205			),
206			'method' => 'PUT',
207			'attr' => [
208			'class' => 'sitemapPriorityForm form-inline',
209			'data-pageId' => $page->getId(),
210			'id' => 'sitemap-priority-type-'.$page->getId(),
211			'style' => 'display: inline;',
212			],
213			]
214			);
215
216			return $form;
217			}
218			}
219

Victoire / victoire

Push — master ( cde4a2...ad2587 )

SitemapController::xmlAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Change not visible in outer-scope

Change visible in outer-scope

Duplication Side-by-Side

Filter issues like